[RESEND,v2,1/7] mfd: mt6358: Add missing registers for LDO voltage calibration

Message ID 20230721082903.2038975-2-wenst@chromium.org
State New
Headers
Series regulator: mt6358: Remove bogus regulators and improvements |

Commit Message

Chen-Yu Tsai July 21, 2023, 8:28 a.m. UTC
  Most of the LDOs, except the "VSRAM_*" ones, on the MT6358 and MT6366
PMICs support a finer output voltage calibration within the range of
+0 mV to +100 mV with 10 mV step. Some of the registers for this
function are missing from the register table.

Add the missing ones for MT6358.

Signed-off-by: Chen-Yu Tsai <wenst@chromium.org>
---
 include/linux/mfd/mt6358/registers.h | 6 ++++++
 1 file changed, 6 insertions(+)
  

Comments

AngeloGioacchino Del Regno July 21, 2023, 8:53 a.m. UTC | #1
Il 21/07/23 10:28, Chen-Yu Tsai ha scritto:
> Most of the LDOs, except the "VSRAM_*" ones, on the MT6358 and MT6366
> PMICs support a finer output voltage calibration within the range of
> +0 mV to +100 mV with 10 mV step. Some of the registers for this
> function are missing from the register table.
> 

Please mention that you're doing this addition *because* you're using
those new definitions right after, and in the regulator driver:

[...]
In preparation for adding support for improved output voltage selection
in mt6358-regulator, add the relevant missing registers for the same.
[...]

After which,

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>

> Add the missing ones for MT6358.
> 
> Signed-off-by: Chen-Yu Tsai <wenst@chromium.org>
> ---
>   include/linux/mfd/mt6358/registers.h | 6 ++++++
>   1 file changed, 6 insertions(+)
> 
> diff --git a/include/linux/mfd/mt6358/registers.h b/include/linux/mfd/mt6358/registers.h
> index 3d33517f178c..5ea2590be710 100644
> --- a/include/linux/mfd/mt6358/registers.h
> +++ b/include/linux/mfd/mt6358/registers.h
> @@ -262,6 +262,12 @@
>   #define MT6358_LDO_VBIF28_CON3                0x1db0
>   #define MT6358_VCAMA1_ANA_CON0                0x1e08
>   #define MT6358_VCAMA2_ANA_CON0                0x1e0c
> +#define MT6358_VFE28_ANA_CON0                 0x1e10
> +#define MT6358_VCN28_ANA_CON0                 0x1e14
> +#define MT6358_VBIF28_ANA_CON0                0x1e18
> +#define MT6358_VAUD28_ANA_CON0                0x1e1c
> +#define MT6358_VAUX18_ANA_CON0                0x1e20
> +#define MT6358_VXO22_ANA_CON0                 0x1e24
>   #define MT6358_VCN33_ANA_CON0                 0x1e28
>   #define MT6358_VSIM1_ANA_CON0                 0x1e2c
>   #define MT6358_VSIM2_ANA_CON0                 0x1e30
  

Patch

diff --git a/include/linux/mfd/mt6358/registers.h b/include/linux/mfd/mt6358/registers.h
index 3d33517f178c..5ea2590be710 100644
--- a/include/linux/mfd/mt6358/registers.h
+++ b/include/linux/mfd/mt6358/registers.h
@@ -262,6 +262,12 @@ 
 #define MT6358_LDO_VBIF28_CON3                0x1db0
 #define MT6358_VCAMA1_ANA_CON0                0x1e08
 #define MT6358_VCAMA2_ANA_CON0                0x1e0c
+#define MT6358_VFE28_ANA_CON0                 0x1e10
+#define MT6358_VCN28_ANA_CON0                 0x1e14
+#define MT6358_VBIF28_ANA_CON0                0x1e18
+#define MT6358_VAUD28_ANA_CON0                0x1e1c
+#define MT6358_VAUX18_ANA_CON0                0x1e20
+#define MT6358_VXO22_ANA_CON0                 0x1e24
 #define MT6358_VCN33_ANA_CON0                 0x1e28
 #define MT6358_VSIM1_ANA_CON0                 0x1e2c
 #define MT6358_VSIM2_ANA_CON0                 0x1e30