From patchwork Fri Jul 21 13:54:13 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Konrad Dybcio X-Patchwork-Id: 123890 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9010:0:b0:3e4:2afc:c1 with SMTP id l16csp232522vqg; Fri, 21 Jul 2023 07:10:41 -0700 (PDT) X-Google-Smtp-Source: APBJJlHL6xCMQ7jVXgbhx4lMtTxAOpv/iHkVHvqOWrcDFcsUeJkDk5ZRMhxjC9Hcsgyh3RuKEzYV X-Received: by 2002:a05:6a00:23cf:b0:654:4a24:d787 with SMTP id g15-20020a056a0023cf00b006544a24d787mr272923pfc.12.1689948641094; Fri, 21 Jul 2023 07:10:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689948641; cv=none; d=google.com; s=arc-20160816; b=sQzRCyu4R7zf9jw3ji/jJGgHUplJn8gkqX9SyvrGq50/N/pf1JysWA60YJEHUvuCIb wZP9ryEKfC/Vh6OQ0azmsZvznzFRcSSagTbC/bmAM85qknWmFfTgXftlXPkoIxQjy2Ii sqJhboE//hjMjsASBYugdpCoWX8XYnE4+CgJvqAFwhXQke6lCzIOAupjLTetsadAeOkO pD1KdJzun/ZniBq/OpaamyTOZJtI2221Ox//MUUTnu4iH4gxr6WIp/u6w4Uxzvrz7Lk/ YTTsvszCIh0uazq0xoSJR5QR0MU1d3nw7kezz0+oEOVQNObeh3ePGqmuD9Q8LVCvUe6C 7RSw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:message-id :content-transfer-encoding:mime-version:subject:date:from :dkim-signature; bh=dmfN4SKKWgK9SW4qxPnUm0MpTFrsYug3xDM0d387yPI=; fh=xQ4bPgBMp6pjfu5uXr9M5NsLBi3mTDsOQP6lWaQWMDw=; b=DTZb+1bbi1tFibbJlQ5TmbhWg/zT1IFqnqhKldsZbdAlN6kMp/mQIiFprVswZ4rubi 0DVmifmQmOsex8pWnKxihoExwnqULoBr2tQKh8TMImsJtAfVTh8/HkdKLbA8imBvaTNV ZA7E1NlSQnqDvPMyn0dOe1FMgNgnXz442LCXk1FygntwJDuKBLTzd3SmzWWThK7y35u+ laCMv2YWhOsYtiJNSbrZo1uQ81XMq6k9Krzj7u1IXtXniL53D9OebBOaZt7FMc1GDkai Cl69ag9TQn6UJWMgwYXZ4oDpYZI8AllKvC5OEJ8gkYeoFgOrAZqQsf0hczVC31u4R4G6 beHg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=F83EroK6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id c5-20020a6566c5000000b0053fb354c191si3045142pgw.861.2023.07.21.07.10.20; Fri, 21 Jul 2023 07:10:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=F83EroK6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231574AbjGUNye (ORCPT + 99 others); Fri, 21 Jul 2023 09:54:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50718 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231436AbjGUNy1 (ORCPT ); Fri, 21 Jul 2023 09:54:27 -0400 Received: from mail-lj1-x230.google.com (mail-lj1-x230.google.com [IPv6:2a00:1450:4864:20::230]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 652F91BE2 for ; Fri, 21 Jul 2023 06:54:25 -0700 (PDT) Received: by mail-lj1-x230.google.com with SMTP id 38308e7fff4ca-2b70bfc8db5so28550241fa.2 for ; Fri, 21 Jul 2023 06:54:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1689947663; x=1690552463; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=dmfN4SKKWgK9SW4qxPnUm0MpTFrsYug3xDM0d387yPI=; b=F83EroK6OBml0MUgVeu7s6BDBA2sDqis1LjO3BCG83C1QnRV576crNGuUGN8QEfEFs cA6gmQooMkR/UXjI4RrOksOoqgGlmFtx9+bZuByvnhqQ3Cow86wl3iRV2TYd5sgrsX7h 94zQlXi3ObNnpJ2F/wLn7Z+uiuzJKY8CTS2mKzjSz/WDYxH5SuutdHfMuuCW8D72kqqY iVnMnkxxMGiMFjp4Z8T0brtjFelyTgY9Ic0gzbs88sNHaPkENAoenI02XCztPEr3IoEi YaH1YjRFD9JATxXZ3xjDY4uzSPvYkvAvgTv0tHlcDlyDjPj3BHH7yFsIkrk5rqj3vlzm grNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689947663; x=1690552463; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dmfN4SKKWgK9SW4qxPnUm0MpTFrsYug3xDM0d387yPI=; b=Z5GEZd+p91Ub6P5/zT/yAQk4I9S+LfgAFSxE0My+FMNY8qbuO0Efi6d8JdxT3f/cGo OdIx9RnN6Q5f1Q/+UGgS1zEdScdA5rbA8IzkZGnN/P+11eGZltP7JW1JD1TgjlC/roTv r2g7Cu5VUoqxm6CrQHlRK6vkBkostMVqJQZLdg/kfvhBFH9pxoLZYTTXrfCYGsJ1BKjj jCRTmIZLIMumPaonHFCnwDxUVi1NHsOlFniY3Gu45JIYarTL6ba3HFZFHrijbXImCz0b p/i5SS0gxi8HRCnVrV/3kMmzaVe+IaKRgxHG7GPz9+NL9mzCDqVlAN4oaAQ0gE2qyJKt Ek5g== X-Gm-Message-State: ABy/qLbRMGt/D319WdGwjXs6Qx4lEyICb8yz7Vzr7sOu5//SJX0ltpSw 3aqdjFTqlOJGGF9eD4ClU79ThA== X-Received: by 2002:a2e:968e:0:b0:2b7:b9ca:3eda with SMTP id q14-20020a2e968e000000b002b7b9ca3edamr1808428lji.34.1689947663696; Fri, 21 Jul 2023 06:54:23 -0700 (PDT) Received: from [192.168.1.101] (abyj181.neoplus.adsl.tpnet.pl. [83.9.29.181]) by smtp.gmail.com with ESMTPSA id k21-20020a2e92d5000000b002b6ad323248sm953838ljh.10.2023.07.21.06.54.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Jul 2023 06:54:23 -0700 (PDT) From: Konrad Dybcio Date: Fri, 21 Jul 2023 15:54:13 +0200 Subject: [PATCH 3/7] dt-bindings: interconnect: qcom: Fix and separate out MSM8916 MIME-Version: 1.0 Message-Id: <20230721-topic-icc_bindings-v1-3-93e2bc728fb7@linaro.org> References: <20230721-topic-icc_bindings-v1-0-93e2bc728fb7@linaro.org> In-Reply-To: <20230721-topic-icc_bindings-v1-0-93e2bc728fb7@linaro.org> To: Andy Gross , Bjorn Andersson , Georgi Djakov , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo Cc: Marijn Suijten , Konrad Dybcio , linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Konrad Dybcio X-Mailer: b4 0.12.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1689947656; l=4542; i=konrad.dybcio@linaro.org; s=20230215; h=from:subject:message-id; bh=Rv/Btqa2ja+j05knCsIBBCAEjs5ZCyG116l9ptPC73c=; b=KBUDXhd297a2ySmSIc5WkgT3ReFiitE47DKx9LMZ3QeuCQelgVINMcJtrGsw1Sg7PhEC4BAZR kns54i10YIODIR5OxcZkKammUDkZnCk2ECDGcLLHVUOsULB8kJrAHEh X-Developer-Key: i=konrad.dybcio@linaro.org; a=ed25519; pk=iclgkYvtl2w05SSXO5EjjSYlhFKsJ+5OSZBjOkQuEms= X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1772039586109360394 X-GMAIL-MSGID: 1772039586109360394 Separate out MSM8916 icc bindings and fix the clocks description by removing the wrong internal RPM bus clock representation that we've been carrying for years. Replace the example in qcom,rpm.yaml with MSM8939 to keep it relevant to the file. Signed-off-by: Konrad Dybcio --- .../bindings/interconnect/qcom,msm8916.yaml | 52 ++++++++++++++++++++++ .../devicetree/bindings/interconnect/qcom,rpm.yaml | 24 +++++----- 2 files changed, 65 insertions(+), 11 deletions(-) diff --git a/Documentation/devicetree/bindings/interconnect/qcom,msm8916.yaml b/Documentation/devicetree/bindings/interconnect/qcom,msm8916.yaml new file mode 100644 index 000000000000..49baf808c087 --- /dev/null +++ b/Documentation/devicetree/bindings/interconnect/qcom,msm8916.yaml @@ -0,0 +1,52 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/interconnect/qcom,msm8916.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Qualcomm MSM8916 Network-On-Chip interconnect + +maintainers: + - Konrad Dybcio + +description: | + The Qualcomm MSM8916 interconnect providers support adjusting the + bandwidth requirements between the various NoC fabrics. + +allOf: + - $ref: qcom,rpm-common.yaml# + +properties: + compatible: + enum: + - qcom,msm8916-bimc + - qcom,msm8916-pcnoc + - qcom,msm8916-snoc + +required: + - compatible + - reg + +unevaluatedProperties: false + +examples: + - | + #include + + snoc: interconnect@580000 { + compatible = "qcom,msm8916-snoc"; + reg = <0x00580000 0x14000>; + #interconnect-cells = <1>; + }; + + pcnoc: interconnect@500000 { + compatible = "qcom,msm8916-pcnoc"; + reg = <0x00500000 0x11000>; + #interconnect-cells = <1>; + }; + + bimc: interconnect@400000 { + compatible = "qcom,msm8916-bimc"; + reg = <0x00400000 0x62000>; + #interconnect-cells = <1>; + }; diff --git a/Documentation/devicetree/bindings/interconnect/qcom,rpm.yaml b/Documentation/devicetree/bindings/interconnect/qcom,rpm.yaml index 4f95d512012a..788c5e88445a 100644 --- a/Documentation/devicetree/bindings/interconnect/qcom,rpm.yaml +++ b/Documentation/devicetree/bindings/interconnect/qcom,rpm.yaml @@ -20,9 +20,6 @@ properties: compatible: enum: - - qcom,msm8916-bimc - - qcom,msm8916-pcnoc - - qcom,msm8916-snoc - qcom,msm8939-bimc - qcom,msm8939-pcnoc - qcom,msm8939-snoc @@ -109,9 +106,6 @@ allOf: compatible: contains: enum: - - qcom,msm8916-bimc - - qcom,msm8916-pcnoc - - qcom,msm8916-snoc - qcom,msm8939-bimc - qcom,msm8939-pcnoc - qcom,msm8939-snoc @@ -254,7 +248,7 @@ examples: #include bimc: interconnect@400000 { - compatible = "qcom,msm8916-bimc"; + compatible = "qcom,msm8939-bimc"; reg = <0x00400000 0x62000>; #interconnect-cells = <1>; clock-names = "bus", "bus_a"; @@ -263,7 +257,7 @@ examples: }; pcnoc: interconnect@500000 { - compatible = "qcom,msm8916-pcnoc"; + compatible = "qcom,msm8939-pcnoc"; reg = <0x00500000 0x11000>; #interconnect-cells = <1>; clock-names = "bus", "bus_a"; @@ -272,10 +266,18 @@ examples: }; snoc: interconnect@580000 { - compatible = "qcom,msm8916-snoc"; - reg = <0x00580000 0x14000>; - #interconnect-cells = <1>; + compatible = "qcom,msm8939-snoc"; + reg = <0x00580000 0x14080>; clock-names = "bus", "bus_a"; clocks = <&rpmcc RPM_SMD_SNOC_CLK>, <&rpmcc RPM_SMD_SNOC_A_CLK>; + #interconnect-cells = <1>; + + snoc_mm: interconnect-snoc { + compatible = "qcom,msm8939-snoc-mm"; + clock-names = "bus", "bus_a"; + clocks = <&rpmcc RPM_SMD_SYSMMNOC_CLK>, + <&rpmcc RPM_SMD_SYSMMNOC_A_CLK>; + #interconnect-cells = <1>; + }; };