Message ID | 20230720115351.2039431-2-shikemeng@huaweicloud.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:c923:0:b0:3e4:2afc:c1 with SMTP id j3csp2891785vqt; Wed, 19 Jul 2023 22:11:48 -0700 (PDT) X-Google-Smtp-Source: APBJJlHFjTzA4D9ntC64wE0tOCRjvmLe8EuL5sIQSLc4SYU3yFNoWDKwZHtS7HOUeOQ5koUbZHu+ X-Received: by 2002:a17:906:311a:b0:973:fd02:a41f with SMTP id 26-20020a170906311a00b00973fd02a41fmr5114417ejx.40.1689829908663; Wed, 19 Jul 2023 22:11:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689829908; cv=none; d=google.com; s=arc-20160816; b=TJsbXia21uZhxTcclNgUCe340BTm6pJnO6P4wrFLw9YsGIVcMw2oMHdt6DIBEqewnG ExyrkVbPq3EQy+2Wr9dGAOF0+Xov4QUu4HIsUgBd1iDKUnd1eGvzGvSSBMf/1HBh2hKV cLpIM6P+rAS1qRR9TqIjfZ9S+nvVS1tP7byEdaTf7hTfR0Dj3UBXPQ/ZuXisCSxFMsnJ YNbVyQMUDDruM2JK2/hyQW1IRvpjxlnT316eK1NObxNqbi3Eb1IV4myeNrQQity4fwkj ughZ1GCbsenXlokIp1v8ESiiT2CaaQdra73QWoJl8FCchk4BvPgeVpQO7DY74AOKebrU u6rg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=2OaR1HEq5K6X+gQotTWPsxBi3ZkT+prDMGdYBql2c6M=; fh=Gzi1aFpH4bsuJxl33dRilzaRcjMW8JVkCVkQbG3Bsew=; b=mk76kvx6B50qiPj5TOnaBbTecFdraRduL8Zb4sQpsAxzwezslrm8eAsfco6gMYc0/o 1WK6hhH6ox5vG82/8ZVi7egAnJzQFDRxV5SUKJkXYqbqSCHcWKZuphPwVlvn9td6Y56q ApuXxYyOKq1V01Fz5JFAFPSYh4COSB4oBHfHTKOJHxm3gQFpQSMK/tBvI1ym+h3H4lJ6 7rtf/z7vpMIotAscHhwc8P3KTYwg7c7OCpsi+ddCxEKM7B9ZgqSsvaOQq2UqU6k7EURZ H/ittQjAbhH85jgmGtccGz8x2dXJYn2EAAXD1/QlSj1MUaIRWJqxl2RcUlrFfgVCRaF7 Ocrg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id c21-20020a170906925500b0098dfdc3f2d7si134960ejx.674.2023.07.19.22.11.25; Wed, 19 Jul 2023 22:11:48 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229938AbjGTDxb (ORCPT <rfc822;assdfgzxcv4@gmail.com> + 99 others); Wed, 19 Jul 2023 23:53:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50020 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229589AbjGTDxX (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Wed, 19 Jul 2023 23:53:23 -0400 Received: from dggsgout11.his.huawei.com (dggsgout11.his.huawei.com [45.249.212.51]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3BFA91FED for <linux-kernel@vger.kernel.org>; Wed, 19 Jul 2023 20:53:22 -0700 (PDT) Received: from mail02.huawei.com (unknown [172.30.67.143]) by dggsgout11.his.huawei.com (SkyGuard) with ESMTP id 4R5zLQ4zfbz4f3yyX for <linux-kernel@vger.kernel.org>; Thu, 20 Jul 2023 11:53:18 +0800 (CST) Received: from huaweicloud.com (unknown [10.175.124.27]) by APP2 (Coremail) with SMTP id Syh0CgC3q+mtr7hk4qk0OQ--.49914S3; Thu, 20 Jul 2023 11:53:19 +0800 (CST) From: Kemeng Shi <shikemeng@huaweicloud.com> To: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: shikemeng@huaweicloud.com Subject: [PATCH 1/2] mm/compaction: correct comment of candidate pfn in fast_isolate_freepages Date: Thu, 20 Jul 2023 19:53:49 +0800 Message-Id: <20230720115351.2039431-2-shikemeng@huaweicloud.com> X-Mailer: git-send-email 2.30.0 In-Reply-To: <20230720115351.2039431-1-shikemeng@huaweicloud.com> References: <20230720115351.2039431-1-shikemeng@huaweicloud.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CM-TRANSID: Syh0CgC3q+mtr7hk4qk0OQ--.49914S3 X-Coremail-Antispam: 1UD129KBjvdXoWruFyxZF4fAr1xWryruw4rKrg_yoW3Jwc_JF 12kr1Yy3WYvFyxZFnIka1Sya4UKa95Zr1Igw4rW3yjka9YqFs5WF1DZr1fXanIqa9FgFnx W3ykAF1qgF1akjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUb6AFF20E14v26r4j6ryUM7CY07I20VC2zVCF04k26cxKx2IYs7xG 6rWj6s0DM7CIcVAFz4kK6r1j6r18M280x2IEY4vEnII2IxkI6r1a6r45M28IrcIa0xkI8V A2jI8067AKxVWUGwA2048vs2IY020Ec7CjxVAFwI0_Jrv_JF4l8cAvFVAK0II2c7xJM28C jxkF64kEwVA0rcxSw2x7M28EF7xvwVC0I7IYx2IY67AKxVWDJVCq3wA2z4x0Y4vE2Ix0cI 8IcVCY1x0267AKxVW8Jr0_Cr1UM28EF7xvwVC2z280aVAFwI0_GcCE3s1l84ACjcxK6I8E 87Iv6xkF7I0E14v26rxl6s0DM2AIxVAIcxkEcVAq07x20xvEncxIr21l5I8CrVACY4xI64 kE6c02F40Ex7xfMcIj6xIIjxv20xvE14v26r1j6r18McIj6I8E87Iv67AKxVWUJVW8JwAm 72CE4IkC6x0Yz7v_Jr0_Gr1lF7xvr2IYc2Ij64vIr41lF7I21c0EjII2zVCS5cI20VAGYx C7MxAIw28IcxkI7VAKI48JMxC20s026xCaFVCjc4AY6r1j6r4UMI8I3I0E5I8CrVAFwI0_ Jr0_Jr4lx2IqxVCjr7xvwVAFwI0_JrI_JrWlx4CE17CEb7AF67AKxVWUAVWUtwCIc40Y0x 0EwIxGrwCI42IY6xIIjxv20xvE14v26r1j6r1xMIIF0xvE2Ix0cI8IcVCY1x0267AKxVWU JVW8JwCI42IY6xAIw20EY4v20xvaj40_Jr0_JF4lIxAIcVC2z280aVAFwI0_Jr0_Gr1lIx AIcVC2z280aVCY1x0267AKxVW8JVW8JrUvcSsGvfC2KfnxnUUI43ZEXa7sRiDGYDUUUUU= = X-CM-SenderInfo: 5vklyvpphqwq5kxd4v5lfo033gof0z/ X-CFilter-Loop: Reflected X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_00,DATE_IN_FUTURE_06_12, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1771911463256145810 X-GMAIL-MSGID: 1771915086275180362 |
Series |
[1/2] mm/compaction: correct comment of candidate pfn in fast_isolate_freepages
|
|
Commit Message
Kemeng Shi
July 20, 2023, 11:53 a.m. UTC
If no preferred one was not found, we will use candidate page with maximum
pfn > min_pfn which is saved in high_pfn. Correct "minimum" to "maximum
candidate" in comment.
Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com>
---
mm/compaction.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
Hi Baolin, I try to resend a new v2 patchset, the patch 1 is still missing. Here is the patch 1 in old version and I find it in lore archive of lore.kernel.org with link [1]. It's likely that patch 1 is denied by linux-mm.kvack.org but accepted by linux-kernel@vger.kernel.org. Is anyone know how to submit issue of linux-mm.kvack.org, please let know. Thanks! [1] https://lore.kernel.org/all/20230720115351.2039431-2-shikemeng@huaweicloud.com/ on 7/20/2023 7:53 PM, Kemeng Shi wrote: > If no preferred one was not found, we will use candidate page with maximum > pfn > min_pfn which is saved in high_pfn. Correct "minimum" to "maximum > candidate" in comment. > > Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com> > --- > mm/compaction.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/compaction.c b/mm/compaction.c > index eb1d3d9a422c..c0d8d08fc163 100644 > --- a/mm/compaction.c > +++ b/mm/compaction.c > @@ -1526,7 +1526,7 @@ static void fast_isolate_freepages(struct compact_control *cc) > break; > } > > - /* Use a minimum pfn if a preferred one was not found */ > + /* Use a maximum candidate pfn if a preferred one was not found */ > if (!page && high_pfn) { > page = pfn_to_page(high_pfn); > >
diff --git a/mm/compaction.c b/mm/compaction.c index eb1d3d9a422c..c0d8d08fc163 100644 --- a/mm/compaction.c +++ b/mm/compaction.c @@ -1526,7 +1526,7 @@ static void fast_isolate_freepages(struct compact_control *cc) break; } - /* Use a minimum pfn if a preferred one was not found */ + /* Use a maximum candidate pfn if a preferred one was not found */ if (!page && high_pfn) { page = pfn_to_page(high_pfn);