From patchwork Thu Jul 20 09:45:55 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chengming Zhou X-Patchwork-Id: 123170 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:c923:0:b0:3e4:2afc:c1 with SMTP id j3csp3022007vqt; Thu, 20 Jul 2023 03:35:29 -0700 (PDT) X-Google-Smtp-Source: APBJJlHg4xdY5FQUU4/X61bcb6nzrovddG68vJ9v2qT0y/LAOALzn+4pXj/neE0p9TTiPbb/sffF X-Received: by 2002:a17:906:151:b0:998:de72:4c89 with SMTP id 17-20020a170906015100b00998de724c89mr2135383ejh.50.1689849329627; Thu, 20 Jul 2023 03:35:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689849329; cv=none; d=google.com; s=arc-20160816; b=F+Xf+VMGlj8LDhsD2JIhXBFjnP+jsvy0J6O2cKM0UssxHT4p8AfCJgmX8oWROYMdHD erjvX+uyPX23uOprkVxg/G3JjP/kEYG5QZmUHmJ0qKi4MCLeRKv53i5UyeQ8Thty5B9N ez6ABxDP4JB02UBXPk7q6ITAmIZFZ3yASax3SCvU3n30f6YF9nFk4WaX5iktWGXOnQxK r5pjbMIVBbB151Ldbk4bha39B/tz5HjnjtdLxwGieSMydvWLiTJOPiAcW4xKjpEJn4Yk hqX0JDa7YR2+ZbSBwTyPfQADOsMLiOavlzyzZzkUqLstigsHX6AfxGoPcZ8HBrM+pDcz 8xLw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=iYyPqspkOuXVMavHO7B8mxFBAqzpe8Xduz/Ay3699EE=; fh=hjJkBnU2szufEu6iYNeHw5+ILtjbq+a6zNGIo+CbvPw=; b=Yztyb9bwBKuGvfNd67XiUoxtaWRpVijJ5Oa+JPB0iK2EsXFwHO2X30U1hGpwtyw2xz 6u7Pbm7rUC3+vklPb6DRU/YMVX2Mar60XtA3dxoTmT+VxEdEc7HxK+KMQeA9bF6KPd9j UYoAj2LOLewQzmZutkNq8NoJNPuG6iQhycswC0XpUsuSnhzfHuGkvmq2118JxvzqN9FG wBlKAqxz3QHZat7Cm9kTb466bjDLdVEY6J1hC3OdDELKAL/82iVUaJsRK0Su3sFOAqnB 4KLmNnMfI5DoZI1vrtm8XEWPuJgzJVcGXAB60gXZSRfpybt+IdNt/m58UVHeIFvejtGJ tk1g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=pw5sQb18; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id kk27-20020a170907767b00b00988839e5435si467419ejc.522.2023.07.20.03.35.05; Thu, 20 Jul 2023 03:35:29 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=pw5sQb18; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229763AbjGTJtx (ORCPT + 99 others); Thu, 20 Jul 2023 05:49:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47800 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229653AbjGTJt1 (ORCPT ); Thu, 20 Jul 2023 05:49:27 -0400 Received: from out-34.mta0.migadu.com (out-34.mta0.migadu.com [91.218.175.34]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C83E1189 for ; Thu, 20 Jul 2023 02:47:42 -0700 (PDT) X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1689846460; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=iYyPqspkOuXVMavHO7B8mxFBAqzpe8Xduz/Ay3699EE=; b=pw5sQb18kA//kymlNb+qvXIDo6jCV6+mmT0zU6VFQozPJNN8PoBdLacoMJrd/1FqdpJvcW VwuVolXq85zUUtFfX40ZQSiEGTsPAgEbohducF49YxBq9Q/Wf59Odv9Bl0BlUS6IqohIJQ /iml5vko4ls+yXcePH2pF7w/oW2Of3U= From: chengming.zhou@linux.dev To: axboe@kernel.dk, osandov@fb.com, ming.lei@redhat.com, kbusch@kernel.org, krisman@suse.de Cc: linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, zhouchengming@bytedance.com Subject: [PATCH 6/6] sbitmap: check ws_active before check waitqueues Date: Thu, 20 Jul 2023 17:45:55 +0800 Message-ID: <20230720094555.1397621-7-chengming.zhou@linux.dev> In-Reply-To: <20230720094555.1397621-1-chengming.zhou@linux.dev> References: <20230720094555.1397621-1-chengming.zhou@linux.dev> MIME-Version: 1.0 X-Migadu-Flow: FLOW_OUT X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1771935450582240987 X-GMAIL-MSGID: 1771935450582240987 From: Chengming Zhou When !ws_active, we don't need to check waitqueues at all. So add this check in sbitmap_queue_wake_all(), like we do in sbitmap_queue_wake_up(). Signed-off-by: Chengming Zhou --- lib/sbitmap.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/lib/sbitmap.c b/lib/sbitmap.c index 6778ab3fc6a5..38c265e4ef9d 100644 --- a/lib/sbitmap.c +++ b/lib/sbitmap.c @@ -672,6 +672,10 @@ void sbitmap_queue_wake_all(struct sbitmap_queue *sbq) * sbitmap_queue_wake_up(). */ smp_mb(); + + if (!atomic_read(&sbq->ws_active)) + return; + wake_index = READ_ONCE(sbq->wake_index); for (i = 0; i < SBQ_WAIT_QUEUES; i++) { struct sbq_wait_state *ws = &sbq->ws[wake_index];