From patchwork Mon Jul 24 10:49:22 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Konrad Dybcio X-Patchwork-Id: 124809 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9010:0:b0:3e4:2afc:c1 with SMTP id l16csp1723779vqg; Mon, 24 Jul 2023 04:12:46 -0700 (PDT) X-Google-Smtp-Source: APBJJlHS26qKp4cvvB1LkmnaurUIyJ1z96tuU4WSmexXbGIQgZKBSOAD6/jRGZFgdmwVF/TrlGRm X-Received: by 2002:a17:902:d34d:b0:1bb:a522:909a with SMTP id l13-20020a170902d34d00b001bba522909amr2698023plk.37.1690197166027; Mon, 24 Jul 2023 04:12:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690197166; cv=none; d=google.com; s=arc-20160816; b=yziWk4TbrbL/nuYypss896nhaqi4x7bGSgOYwLYNhZ4CE/OKa7bmhorYGK0JhNDUkv BYTdP6wbNNZgHno1jhq7zGYSmC0ft7nF9ApwIoRXYm5/YVJ5Nhb6SQRMKWS7WPwVlja8 IeG9ARmsj0hldA/aeWWQnrPOvllQKP0IWsOv623MiMecsK4HWM7VodiUOwYepQ0EJ31y qQNPeeVAbdy2gK/gB/x0pJs7a/ZqWoJj6VDw9+sW6NUA+vqMZhaPu/Abn0qwNvQ7LM+c 6YqOHO914pK1e1T5Ws/uQXyzVwbSnhU502hn6fY/bR2mdze2zvsu0QVRZ8QkXJ8ENAh+ ruow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:message-id :content-transfer-encoding:mime-version:subject:date:from :dkim-signature; bh=v8HKgJSSV07pp4d9brlO+h0JzIdiYnacUoJ+79PuEI4=; fh=6UEh9QsRZB+5SiKTsumfrAyaQ8JNOoFIZEeWUCZ7Tqk=; b=OdSj4iB1yKvIx2X5Jz/1aBfdsdbqohyxpDoREPObkkBJI0UCNJGknXcfCt2T+AHDnD d5tdZpjr6zoAQ5mj75BiYG3UOcImFqMltLRDDbjZUaKpU4aa0Z1EPmQCku1xoyhmQUgK qdG+4Skh7z+X9fRXZ/0M8btM2WOnhICZwAq/FLdp57y+IVYMxBId9SDYVp2+NdA/AzaQ pho/mjL82vJQCpej3OuaPVOqz7jdgAWpfeKmCsY8kZD2Upu71+8zwZ7fbndYp3EDY3m2 rhO/e5aDRV3qCDZGrshCqNTMXKDWRdeOJpO2dAfwkCyCiriVA2qPrw6ef3l0oSwdFql0 4+Ow== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=RQ+a0ZCw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id li13-20020a170903294d00b001b9fbcf2b8bsi8503563plb.511.2023.07.24.04.12.31; Mon, 24 Jul 2023 04:12:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=RQ+a0ZCw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232628AbjGXKtl (ORCPT + 99 others); Mon, 24 Jul 2023 06:49:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44786 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232479AbjGXKtc (ORCPT ); Mon, 24 Jul 2023 06:49:32 -0400 Received: from mail-lf1-x131.google.com (mail-lf1-x131.google.com [IPv6:2a00:1450:4864:20::131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 328C6FB for ; Mon, 24 Jul 2023 03:49:26 -0700 (PDT) Received: by mail-lf1-x131.google.com with SMTP id 2adb3069b0e04-4fb863edcb6so6198835e87.0 for ; Mon, 24 Jul 2023 03:49:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1690195764; x=1690800564; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=v8HKgJSSV07pp4d9brlO+h0JzIdiYnacUoJ+79PuEI4=; b=RQ+a0ZCwPXPESV3mIgCp8tm1prElKptpDZyaKjzC1uelhVuzifZNS0vm0tjagrC4F3 DQcZW4HqO9to/UuDYKcaJfw5gp7RlNb8rVlcYvBeQhY6QXRiioPm6iVYVWzFJfbEia/q xh2nMHfVzFpfY77jfpw++wB1iZCSedd0nWtjZazJNVVoxU1hXEml4I2b7ldB3DlMUwIf /IsXMYMP8Rvit3g5iTF3VYo7yTl33XsyqFOi0zHEM5ubB9zh9hDvSdBK/TFXpY2C5Idw Dxaa7tMp4VroJQxng1+H/Kq53kqbsKvlYDH6SxXlUhGRPjjEPsBteV7Am8TFLH0sfpbQ AR9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690195764; x=1690800564; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=v8HKgJSSV07pp4d9brlO+h0JzIdiYnacUoJ+79PuEI4=; b=Ox12J+P4TsZ1qILVGNHjW33HKx36IOcnzp5QL5hV5t6IaIVFxjlS0Znb1YCYe0DIIZ HQ1LvyBW5K9s46tPP05RA96+yvscUc0buNbJO+Dhrti52Sw43WEyABTneccpBHbz57Fk HA8uETUkL/VYQ5QZO3HoyecuKjx2SUlVpFRlXww0ifSbhC5ybYvWOAydC6amyo2ApCKr SESlGeQItkkjv33z/fYHhU8VgB8uceFAuLs4fsvQw3EIJDXkrDCNl15U1rFmBoj9sfZ1 aEDQ/i3HHxKbp7uo7dyiXg9BViBz9DD4q8loMQKmatYpZvoRJMCyqn5sV3z8QNBnAdVg p/Yg== X-Gm-Message-State: ABy/qLZaTAyfOF5Gt3i9t55/AJX2APo9VaoO2GiuRzcA5I8xOY8dPBwq GDy79Spvl3apawYWTpzdS71hew== X-Received: by 2002:a05:6512:ea0:b0:4f9:5718:70b3 with SMTP id bi32-20020a0565120ea000b004f9571870b3mr5338407lfb.31.1690195764496; Mon, 24 Jul 2023 03:49:24 -0700 (PDT) Received: from [192.168.1.101] (abyl203.neoplus.adsl.tpnet.pl. [83.9.31.203]) by smtp.gmail.com with ESMTPSA id o14-20020ac2494e000000b004fdc7ec5cbesm2164201lfi.300.2023.07.24.03.49.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Jul 2023 03:49:24 -0700 (PDT) From: Konrad Dybcio Date: Mon, 24 Jul 2023 12:49:22 +0200 Subject: [PATCH v2 2/2] interconnect: qcom: qcm2290: Enable sync state MIME-Version: 1.0 Message-Id: <20230720-topic-qcm2290_icc-v2-2-a2ceb9d3e713@linaro.org> References: <20230720-topic-qcm2290_icc-v2-0-a2ceb9d3e713@linaro.org> In-Reply-To: <20230720-topic-qcm2290_icc-v2-0-a2ceb9d3e713@linaro.org> To: Andy Gross , Bjorn Andersson , Georgi Djakov , Shawn Guo Cc: Marijn Suijten , linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Konrad Dybcio X-Mailer: b4 0.12.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1690195761; l=1022; i=konrad.dybcio@linaro.org; s=20230215; h=from:subject:message-id; bh=GplZxeOl64/ZE1tfvreBeiinURUbtJKYvGy7WRRT0bI=; b=O9MXnPhMxVQyCLJrL3jyqGMGBqfsvhiRg6ST9CmmM/h6dHwd8kFNhD6wYW8cmNWC/1c67k5+7 bzRBUL4EjjaCC6B+ki4drZ0UMURNFGXwB68yhuX+ukOGnhQZH3t61nf X-Developer-Key: i=konrad.dybcio@linaro.org; a=ed25519; pk=iclgkYvtl2w05SSXO5EjjSYlhFKsJ+5OSZBjOkQuEms= X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1772300183563491406 X-GMAIL-MSGID: 1772300183563491406 Enable the generic .sync_state callback to ensure there are no outstanding votes that would waste power. Generally one would need a bunch of interface clocks to access the QoS registers when trying to go over all possible nodes during sync_state, but QCM2290 surprisingly does not seem to require any such handling. Fixes: 1a14b1ac3935 ("interconnect: qcom: Add QCM2290 driver support") Signed-off-by: Konrad Dybcio --- drivers/interconnect/qcom/qcm2290.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/interconnect/qcom/qcm2290.c b/drivers/interconnect/qcom/qcm2290.c index c22354f3e667..5bc4b7516608 100644 --- a/drivers/interconnect/qcom/qcm2290.c +++ b/drivers/interconnect/qcom/qcm2290.c @@ -1364,6 +1364,7 @@ static struct platform_driver qcm2290_noc_driver = { .driver = { .name = "qnoc-qcm2290", .of_match_table = qcm2290_noc_of_match, + .sync_state = icc_sync_state, }, }; module_platform_driver(qcm2290_noc_driver);