Message ID | 20230719152147.355486-2-luca.ceresoli@bootlin.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:c923:0:b0:3e4:2afc:c1 with SMTP id j3csp2519906vqt; Wed, 19 Jul 2023 08:32:29 -0700 (PDT) X-Google-Smtp-Source: APBJJlH9IXAEybz3vWDO+u9DYPCR5S5PugqE5N/JatSkaQFt+pJm+2XeiO0nAQCS+cBuOYgmQG4B X-Received: by 2002:a17:902:ea82:b0:1ad:f138:b2f6 with SMTP id x2-20020a170902ea8200b001adf138b2f6mr16211084plb.16.1689780748935; Wed, 19 Jul 2023 08:32:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689780748; cv=none; d=google.com; s=arc-20160816; b=P9VLg1x2jJne+uWvKjO9dBNQmIp0wifr9uzCiCqZ1ALeRFu9hY99bAu0T5KG6f7qLT fgg/D8j4jpwp3XeIj8nFgn6NKwBKPSxTMIjyWWffeI/1wrt6MroJCtJUx1iPkY90uJ6I Uh/gIHIH5hGhRAsp/1CSUVYeVHfKofY+UPQzcd8yLGxruw11iDBFosW+eBXqfkhzGZFN joe8LpDC4NcXbMtIkL8TXXLAe8xA6VYSC7yWyZyEQ2qDvz48+5XSqcTgDTr1oDE7a+VI NWrfEGzRvYmietbKo3KxRzJa7RfSe935pWlW+dol5UclQVlJ26VEtdhfPS/X8u6a+q9/ AiMQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=99wH+vey50DngufvBEte5SfRinX7I5E5R5JRlIDEi1s=; fh=HcbfsntMiBBz8gizMGA0MXARb+41J9wGABY3u2xI0pA=; b=Y/biVCvHdFncgNz2yFSFcF0yD5Ub4p/Q9rk8GSmAdM+1x1fUXJOc+f3xqEnxpox6M0 MHqsd1kH5qqWcJNNmBZK3gTRH2hmPT7jPuTntgYTB2gUAwkxleCvtK9R6y1DBDnjow9X xUyfVjQsmSDAtlaSpTlJUYpN66JNiE8E2c/af7dqkO6iSPbIgJJjf9RLl1dv/k7booW7 nBHO8OARmIvGPxTLzIMK2u3bTg8cz2ljg+fIcs6zEIgGeN28seIffFl0LXufNW26Dn2w /uQjQlfR0wk0mG905FkJ1yrrncYdBT9PbP78olX9n/3dYtPBHZlF60FbiFQ6U3DYLEmI WwSw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@bootlin.com header.s=gm1 header.b=U9DkZbPD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=bootlin.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y8-20020a17090a86c800b0026370caa5c5si1526677pjv.75.2023.07.19.08.32.15; Wed, 19 Jul 2023 08:32:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@bootlin.com header.s=gm1 header.b=U9DkZbPD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=bootlin.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231670AbjGSPWG (ORCPT <rfc822;assdfgzxcv4@gmail.com> + 99 others); Wed, 19 Jul 2023 11:22:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59224 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231696AbjGSPWE (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Wed, 19 Jul 2023 11:22:04 -0400 Received: from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net [217.70.183.197]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6981CC1; Wed, 19 Jul 2023 08:22:02 -0700 (PDT) Received: by mail.gandi.net (Postfix) with ESMTPA id B481B1C0006; Wed, 19 Jul 2023 15:21:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1689780121; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=99wH+vey50DngufvBEte5SfRinX7I5E5R5JRlIDEi1s=; b=U9DkZbPDgqJw5yvQZnLPqRpyfLrpUQV3Tuckf19C7rBPjMvtD5TWzeSh7/y7a/BGEHYqrv qxVjrZV76FMvhtYwLMfxPTOsWPpTsPJyTQQAHyMZlCLZ+gqWk7NQO4iU6Hyzrn4qDLggTT Xx1USkh+ftS/34NfF8rztyErvPYrBZK2Bamk+w/gNOLZsednmEbIRY32MBfIsKojEBdbSS E0iuBzgcMSQF6PAzfZjCkJEClSB9wKACCZaqET40hFfIzvBYyyF8uymvoG5Ml874Urvx0z rX56v9HyN0G7sArJwwLYAlpc8YQF028V3uD+B8eDszArWgleLnw+uNR99fxcnA== From: Luca Ceresoli <luca.ceresoli@bootlin.com> To: Neil Armstrong <neil.armstrong@linaro.org>, Sam Ravnborg <sam@ravnborg.org>, David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org> Cc: Luca Ceresoli <luca.ceresoli@bootlin.com>, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Thomas Petazzoni <thomas.petazzoni@bootlin.com>, Paul Kocialkowski <paul.kocialkowski@bootlin.com> Subject: [PATCH 2/3] dt-bindings: display: panel: Add panels based on ILITEK ILI9806E Date: Wed, 19 Jul 2023 17:21:46 +0200 Message-Id: <20230719152147.355486-2-luca.ceresoli@bootlin.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230719152147.355486-1-luca.ceresoli@bootlin.com> References: <20230719152147.355486-1-luca.ceresoli@bootlin.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-GND-Sasl: luca.ceresoli@bootlin.com X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS, T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1771863538824037866 X-GMAIL-MSGID: 1771863538824037866 |
Series |
[1/3] dt-bindings: vendor-prefixes: add ShenZhen New Display Co.
|
|
Commit Message
Luca Ceresoli
July 19, 2023, 3:21 p.m. UTC
Add bindings for LCD panels based on the ILITEK ILI9806E RGB controller
connected over SPI and the "ShenZhen New Display Co NDS040480800-V3"
480x800 panel based on it.
Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
---
.../display/panel/ilitek,ili9806e.yaml | 69 +++++++++++++++++++
MAINTAINERS | 6 ++
2 files changed, 75 insertions(+)
create mode 100644 Documentation/devicetree/bindings/display/panel/ilitek,ili9806e.yaml
Comments
Hey Luca, On Wed, Jul 19, 2023 at 05:21:46PM +0200, Luca Ceresoli wrote: > Add bindings for LCD panels based on the ILITEK ILI9806E RGB controller > connected over SPI and the "ShenZhen New Display Co NDS040480800-V3" > 480x800 panel based on it. > > Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com> > --- > .../display/panel/ilitek,ili9806e.yaml | 69 +++++++++++++++++++ > MAINTAINERS | 6 ++ > 2 files changed, 75 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/panel/ilitek,ili9806e.yaml > > diff --git a/Documentation/devicetree/bindings/display/panel/ilitek,ili9806e.yaml b/Documentation/devicetree/bindings/display/panel/ilitek,ili9806e.yaml > new file mode 100644 > index 000000000000..42abc6923065 > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/panel/ilitek,ili9806e.yaml > @@ -0,0 +1,69 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/panel/ilitek,ili9806e.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Ilitek ILI9806E display panels > + > +maintainers: > + - Luca Ceresoli <luca.ceresoli@bootlin.com> > + > +description: > + This binding is for display panels using an Ilitek ILI9806E controller in > + SPI mode. I figure you explicitly mention SPI mode here because it also supports D{P,S}I? > + > +allOf: > + - $ref: panel-common.yaml# > + > +properties: > + compatible: > + items: > + - enum: > + # ShenZhen New Display Co 3.97" 480x800 RGB a-SI TFT LCD > + - newdisplay,nds040480800-v3 > + - const: ilitek,ili9806e > + > + reg: true > + spi-max-frequency: true > + reset-gpios: true > + backlight: true > + port: true > + > +required: > + - compatible > + - reg > + - port > + > +additionalProperties: false > + > +examples: > + - | > + #include <dt-bindings/gpio/gpio.h> > + > + backlight: backlight { > + compatible = "gpio-backlight"; > + gpios = <&gpio 22 GPIO_ACTIVE_HIGH>; > + }; > + spi { Just a nit, a blank line between properties please. Clearly no respinning needed for that... Otherwise, Reviewed-by: Conor Dooley <conor.dooley@microchip.com> Thanks, Conor. > + #address-cells = <1>; > + #size-cells = <0>; > + > + display@0 { > + compatible = "newdisplay,nds040480800-v3", "ilitek,ili9806e"; > + reg = <0>; > + spi-max-frequency = <1000000>; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_lcdgpios>; > + reset-gpios = <&gpio 26 GPIO_ACTIVE_LOW>; > + backlight = <&backlight>; > + > + port { > + ili9806e_in: endpoint { > + remote-endpoint = <&lcdif_out>; > + }; > + }; > + }; > + }; > + > +... > diff --git a/MAINTAINERS b/MAINTAINERS > index aee340630eca..3c38699ee821 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -6515,6 +6515,12 @@ T: git git://anongit.freedesktop.org/drm/drm-misc > F: Documentation/devicetree/bindings/display/ilitek,ili9486.yaml > F: drivers/gpu/drm/tiny/ili9486.c > > +DRM DRIVER FOR ILITEK ILI9806E PANELS > +M: Luca Ceresoli <luca.ceresoli@bootlin.com> > +S: Maintained > +T: git git://anongit.freedesktop.org/drm/drm-misc > +F: Documentation/devicetree/bindings/display/panel/ilitek,ili9806e.yaml > + > DRM DRIVER FOR JADARD JD9365DA-H3 MIPI-DSI LCD PANELS > M: Jagan Teki <jagan@edgeble.ai> > S: Maintained > -- > 2.34.1 >
On Wed, Jul 19, 2023 at 05:21:46PM +0200, Luca Ceresoli wrote: > Add bindings for LCD panels based on the ILITEK ILI9806E RGB controller > connected over SPI and the "ShenZhen New Display Co NDS040480800-V3" > 480x800 panel based on it. > > Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com> > --- > .../display/panel/ilitek,ili9806e.yaml | 69 +++++++++++++++++++ > MAINTAINERS | 6 ++ > 2 files changed, 75 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/panel/ilitek,ili9806e.yaml > > diff --git a/Documentation/devicetree/bindings/display/panel/ilitek,ili9806e.yaml b/Documentation/devicetree/bindings/display/panel/ilitek,ili9806e.yaml > new file mode 100644 > index 000000000000..42abc6923065 > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/panel/ilitek,ili9806e.yaml > @@ -0,0 +1,69 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/panel/ilitek,ili9806e.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Ilitek ILI9806E display panels > + > +maintainers: > + - Luca Ceresoli <luca.ceresoli@bootlin.com> > + > +description: > + This binding is for display panels using an Ilitek ILI9806E controller in > + SPI mode. > + > +allOf: > + - $ref: panel-common.yaml# A SPI device should reference spi-peripheral-props.yaml as well. > + > +properties: > + compatible: > + items: > + - enum: > + # ShenZhen New Display Co 3.97" 480x800 RGB a-SI TFT LCD > + - newdisplay,nds040480800-v3 > + - const: ilitek,ili9806e > + > + reg: true maxItems: 1 > + spi-max-frequency: true > + reset-gpios: true > + backlight: true > + port: true Drop all these and ... > + > +required: > + - compatible > + - reg > + - port > + > +additionalProperties: false ... use "unevaluatedProperties" instead. > + > +examples: > + - | > + #include <dt-bindings/gpio/gpio.h> > + > + backlight: backlight { > + compatible = "gpio-backlight"; > + gpios = <&gpio 22 GPIO_ACTIVE_HIGH>; > + }; The exact backlight is outside the scope of this binding and should be dropped from the example. > + spi { > + #address-cells = <1>; > + #size-cells = <0>; > + > + display@0 { > + compatible = "newdisplay,nds040480800-v3", "ilitek,ili9806e"; > + reg = <0>; > + spi-max-frequency = <1000000>; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_lcdgpios>; > + reset-gpios = <&gpio 26 GPIO_ACTIVE_LOW>; > + backlight = <&backlight>; > + > + port { > + ili9806e_in: endpoint { > + remote-endpoint = <&lcdif_out>; > + }; > + }; > + }; > + }; > + > +...
On 19/07/2023 17:21, Luca Ceresoli wrote: > Add bindings for LCD panels based on the ILITEK ILI9806E RGB controller > connected over SPI and the "ShenZhen New Display Co NDS040480800-V3" > 480x800 panel based on it. > diff --git a/MAINTAINERS b/MAINTAINERS > index aee340630eca..3c38699ee821 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -6515,6 +6515,12 @@ T: git git://anongit.freedesktop.org/drm/drm-misc > F: Documentation/devicetree/bindings/display/ilitek,ili9486.yaml > F: drivers/gpu/drm/tiny/ili9486.c > > +DRM DRIVER FOR ILITEK ILI9806E PANELS > +M: Luca Ceresoli <luca.ceresoli@bootlin.com> > +S: Maintained > +T: git git://anongit.freedesktop.org/drm/drm-misc Nope, same for recent one-driver-subsystem. It's like a second try... You do not have git tree for one driver. The git tree is for subsystem, not driver. Best regards, Krzysztof
Hello Conor, thanks for reviewing. On Wed, 19 Jul 2023 17:44:45 +0100 Conor Dooley <conor@kernel.org> wrote: > Hey Luca, > > On Wed, Jul 19, 2023 at 05:21:46PM +0200, Luca Ceresoli wrote: > > Add bindings for LCD panels based on the ILITEK ILI9806E RGB controller > > connected over SPI and the "ShenZhen New Display Co NDS040480800-V3" > > 480x800 panel based on it. > > > > Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com> > > --- > > .../display/panel/ilitek,ili9806e.yaml | 69 +++++++++++++++++++ > > MAINTAINERS | 6 ++ > > 2 files changed, 75 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/display/panel/ilitek,ili9806e.yaml > > > > diff --git a/Documentation/devicetree/bindings/display/panel/ilitek,ili9806e.yaml b/Documentation/devicetree/bindings/display/panel/ilitek,ili9806e.yaml > > new file mode 100644 > > index 000000000000..42abc6923065 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/display/panel/ilitek,ili9806e.yaml > > @@ -0,0 +1,69 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/display/panel/ilitek,ili9806e.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Ilitek ILI9806E display panels > > + > > +maintainers: > > + - Luca Ceresoli <luca.ceresoli@bootlin.com> > > + > > +description: > > + This binding is for display panels using an Ilitek ILI9806E controller in > > + SPI mode. > > I figure you explicitly mention SPI mode here because it also supports > D{P,S}I? Exactly, DSI is supported as well by the chip. > > +allOf: > > + - $ref: panel-common.yaml# > > + > > +properties: > > + compatible: > > + items: > > + - enum: > > + # ShenZhen New Display Co 3.97" 480x800 RGB a-SI TFT LCD > > + - newdisplay,nds040480800-v3 > > + - const: ilitek,ili9806e > > + > > + reg: true > > + spi-max-frequency: true > > + reset-gpios: true > > + backlight: true > > + port: true > > + > > +required: > > + - compatible > > + - reg > > + - port > > + > > +additionalProperties: false > > + > > +examples: > > + - | > > + #include <dt-bindings/gpio/gpio.h> > > + > > + backlight: backlight { > > + compatible = "gpio-backlight"; > > + gpios = <&gpio 22 GPIO_ACTIVE_HIGH>; > > + }; > > + spi { > > Just a nit, a blank line between properties please. Clearly no > respinning needed for that... I agree. This comes from copy-paste from another bindings file so I'm probably sending a separate series to fix it and avoid the same issue in the future. Luca
Hello Krzysztof, thanks for reviewing. On Wed, 19 Jul 2023 21:12:14 +0200 Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > On 19/07/2023 17:21, Luca Ceresoli wrote: > > Add bindings for LCD panels based on the ILITEK ILI9806E RGB controller > > connected over SPI and the "ShenZhen New Display Co NDS040480800-V3" > > 480x800 panel based on it. > > > > diff --git a/MAINTAINERS b/MAINTAINERS > > index aee340630eca..3c38699ee821 100644 > > --- a/MAINTAINERS > > +++ b/MAINTAINERS > > @@ -6515,6 +6515,12 @@ T: git git://anongit.freedesktop.org/drm/drm-misc > > F: Documentation/devicetree/bindings/display/ilitek,ili9486.yaml > > F: drivers/gpu/drm/tiny/ili9486.c > > > > +DRM DRIVER FOR ILITEK ILI9806E PANELS > > +M: Luca Ceresoli <luca.ceresoli@bootlin.com> > > +S: Maintained > > +T: git git://anongit.freedesktop.org/drm/drm-misc > > Nope, same for recent one-driver-subsystem. It's like a second try... > You do not have git tree for one driver. The git tree is for subsystem, > not driver. I see, no problem, I'm removing the T: line in v2. As this came from copy-pasting another panel driver, should the T: line be removed from every "DRM DRIVER FOR * PANELS" entry? I could send a patch to do that, if that makes sense. Luca
Hello Rob, thanks for reviewing. On Wed, 19 Jul 2023 13:02:54 -0600 Rob Herring <robh@kernel.org> wrote: > On Wed, Jul 19, 2023 at 05:21:46PM +0200, Luca Ceresoli wrote: > > Add bindings for LCD panels based on the ILITEK ILI9806E RGB controller > > connected over SPI and the "ShenZhen New Display Co NDS040480800-V3" > > 480x800 panel based on it. > > > > Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com> > > --- > > .../display/panel/ilitek,ili9806e.yaml | 69 +++++++++++++++++++ > > MAINTAINERS | 6 ++ > > 2 files changed, 75 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/display/panel/ilitek,ili9806e.yaml > > > > diff --git a/Documentation/devicetree/bindings/display/panel/ilitek,ili9806e.yaml b/Documentation/devicetree/bindings/display/panel/ilitek,ili9806e.yaml > > new file mode 100644 > > index 000000000000..42abc6923065 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/display/panel/ilitek,ili9806e.yaml > > @@ -0,0 +1,69 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/display/panel/ilitek,ili9806e.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Ilitek ILI9806E display panels > > + > > +maintainers: > > + - Luca Ceresoli <luca.ceresoli@bootlin.com> > > + > > +description: > > + This binding is for display panels using an Ilitek ILI9806E controller in > > + SPI mode. > > + > > +allOf: > > + - $ref: panel-common.yaml# > > A SPI device should reference spi-peripheral-props.yaml as well. > > > + > > +properties: > > + compatible: > > + items: > > + - enum: > > + # ShenZhen New Display Co 3.97" 480x800 RGB a-SI TFT LCD > > + - newdisplay,nds040480800-v3 > > + - const: ilitek,ili9806e > > + > > + reg: true > > maxItems: 1 > > > + spi-max-frequency: true > > + reset-gpios: true > > + backlight: true > > + port: true > > Drop all these and ... > > > + > > +required: > > + - compatible > > + - reg > > + - port > > + > > +additionalProperties: false > > ... use "unevaluatedProperties" instead. > > > + > > +examples: > > + - | > > + #include <dt-bindings/gpio/gpio.h> > > + > > + backlight: backlight { > > + compatible = "gpio-backlight"; > > + gpios = <&gpio 22 GPIO_ACTIVE_HIGH>; > > + }; > > The exact backlight is outside the scope of this binding and should be > dropped from the example. As this comes from copy-pasting from the bindings yaml for another panel, would it be useful if I send a patch to remove it? Requested changes queued for v2. Luca
On Thu, Jul 20, 2023 at 03:52:38PM +0200, Luca Ceresoli wrote: > Hello Rob, > > thanks for reviewing. > > On Wed, 19 Jul 2023 13:02:54 -0600 > Rob Herring <robh@kernel.org> wrote: > > > On Wed, Jul 19, 2023 at 05:21:46PM +0200, Luca Ceresoli wrote: > > > Add bindings for LCD panels based on the ILITEK ILI9806E RGB controller > > > connected over SPI and the "ShenZhen New Display Co NDS040480800-V3" > > > 480x800 panel based on it. > > > > > > Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com> > > > --- > > > .../display/panel/ilitek,ili9806e.yaml | 69 +++++++++++++++++++ > > > MAINTAINERS | 6 ++ > > > 2 files changed, 75 insertions(+) > > > create mode 100644 Documentation/devicetree/bindings/display/panel/ilitek,ili9806e.yaml > > > > > > diff --git a/Documentation/devicetree/bindings/display/panel/ilitek,ili9806e.yaml b/Documentation/devicetree/bindings/display/panel/ilitek,ili9806e.yaml > > > new file mode 100644 > > > index 000000000000..42abc6923065 > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/display/panel/ilitek,ili9806e.yaml > > > @@ -0,0 +1,69 @@ > > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > > +%YAML 1.2 > > > +--- > > > +$id: http://devicetree.org/schemas/display/panel/ilitek,ili9806e.yaml# > > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > > + > > > +title: Ilitek ILI9806E display panels > > > + > > > +maintainers: > > > + - Luca Ceresoli <luca.ceresoli@bootlin.com> > > > + > > > +description: > > > + This binding is for display panels using an Ilitek ILI9806E controller in > > > + SPI mode. > > > + > > > +allOf: > > > + - $ref: panel-common.yaml# > > > > A SPI device should reference spi-peripheral-props.yaml as well. > > > > > + > > > +properties: > > > + compatible: > > > + items: > > > + - enum: > > > + # ShenZhen New Display Co 3.97" 480x800 RGB a-SI TFT LCD > > > + - newdisplay,nds040480800-v3 > > > + - const: ilitek,ili9806e > > > + > > > + reg: true > > > > maxItems: 1 > > > > > + spi-max-frequency: true > > > + reset-gpios: true > > > + backlight: true > > > + port: true > > > > Drop all these and ... > > > > > + > > > +required: > > > + - compatible > > > + - reg > > > + - port > > > + > > > +additionalProperties: false > > > > ... use "unevaluatedProperties" instead. > > > > > + > > > +examples: > > > + - | > > > + #include <dt-bindings/gpio/gpio.h> > > > + > > > + backlight: backlight { > > > + compatible = "gpio-backlight"; > > > + gpios = <&gpio 22 GPIO_ACTIVE_HIGH>; > > > + }; > > > > The exact backlight is outside the scope of this binding and should be > > dropped from the example. > > As this comes from copy-pasting from the bindings yaml for another > panel, would it be useful if I send a patch to remove it? Yes. Rob
diff --git a/Documentation/devicetree/bindings/display/panel/ilitek,ili9806e.yaml b/Documentation/devicetree/bindings/display/panel/ilitek,ili9806e.yaml new file mode 100644 index 000000000000..42abc6923065 --- /dev/null +++ b/Documentation/devicetree/bindings/display/panel/ilitek,ili9806e.yaml @@ -0,0 +1,69 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/display/panel/ilitek,ili9806e.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Ilitek ILI9806E display panels + +maintainers: + - Luca Ceresoli <luca.ceresoli@bootlin.com> + +description: + This binding is for display panels using an Ilitek ILI9806E controller in + SPI mode. + +allOf: + - $ref: panel-common.yaml# + +properties: + compatible: + items: + - enum: + # ShenZhen New Display Co 3.97" 480x800 RGB a-SI TFT LCD + - newdisplay,nds040480800-v3 + - const: ilitek,ili9806e + + reg: true + spi-max-frequency: true + reset-gpios: true + backlight: true + port: true + +required: + - compatible + - reg + - port + +additionalProperties: false + +examples: + - | + #include <dt-bindings/gpio/gpio.h> + + backlight: backlight { + compatible = "gpio-backlight"; + gpios = <&gpio 22 GPIO_ACTIVE_HIGH>; + }; + spi { + #address-cells = <1>; + #size-cells = <0>; + + display@0 { + compatible = "newdisplay,nds040480800-v3", "ilitek,ili9806e"; + reg = <0>; + spi-max-frequency = <1000000>; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_lcdgpios>; + reset-gpios = <&gpio 26 GPIO_ACTIVE_LOW>; + backlight = <&backlight>; + + port { + ili9806e_in: endpoint { + remote-endpoint = <&lcdif_out>; + }; + }; + }; + }; + +... diff --git a/MAINTAINERS b/MAINTAINERS index aee340630eca..3c38699ee821 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -6515,6 +6515,12 @@ T: git git://anongit.freedesktop.org/drm/drm-misc F: Documentation/devicetree/bindings/display/ilitek,ili9486.yaml F: drivers/gpu/drm/tiny/ili9486.c +DRM DRIVER FOR ILITEK ILI9806E PANELS +M: Luca Ceresoli <luca.ceresoli@bootlin.com> +S: Maintained +T: git git://anongit.freedesktop.org/drm/drm-misc +F: Documentation/devicetree/bindings/display/panel/ilitek,ili9806e.yaml + DRM DRIVER FOR JADARD JD9365DA-H3 MIPI-DSI LCD PANELS M: Jagan Teki <jagan@edgeble.ai> S: Maintained