From patchwork Tue Jul 18 22:30:53 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 122283 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:c923:0:b0:3e4:2afc:c1 with SMTP id j3csp2055360vqt; Tue, 18 Jul 2023 15:46:32 -0700 (PDT) X-Google-Smtp-Source: APBJJlG9KSP32K/oq6FwP57fHfnyQ5VsGenp4qKSZ4+Z9CTNfVESYddhtMGwT878CBd4bNK67OHF X-Received: by 2002:a05:6358:c16:b0:134:e458:688d with SMTP id f22-20020a0563580c1600b00134e458688dmr974530rwj.15.1689720391800; Tue, 18 Jul 2023 15:46:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689720391; cv=none; d=google.com; s=arc-20160816; b=yt5YAJQEgZI3Zzd/mTy3rKm29wrEtPjFkMTrxmllU1KZYSBQSgF+XoF4WNMhJzEjP7 zMPEnpZdB+tqxgV9Y8h0Sf208sVq2tK6B6yKkoFg89iVp2rR1tY5TLJRN6TVqA4DHNa5 MocsFRvKilFS2ltd23wjdCJKU/DwYDYViDqtM709xZwNOwW+tyMxoNBoQ7EsuH1ffZGB WSJKA69lxAFVAXWFWrk/mEtD7WEU1YvzTCs06OV/KGL16duD1G3U9dGwnoP7z7Gt2Lt5 fjvwTZKofa8sCAUX4eyCzQAFDOYNXGAhFLrEcgrxFQiIUrh5eisCJhFX4Jn9c8SffJ4s aK0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=iVjmNNzs4rA4uCPXQvGEpmwTsekABYhMmzN4lt/EIkc=; fh=uwKSrd2+wgcT5Wk+7Sw7v62ZvHxsuHiESBbYGTU7eRQ=; b=cZbQgIWr5Mq6l7tTiHrVmmqYJhlzTQrp60Pd3e94U67U6spyTrl+iYlMAFeIwXi381 /zyd8qG4L7ovoOs8Z7gDxmmCLkBl7hDc13RVYwpDXPFWyzhtDmrJNroBXkKXH0DE0L4K gD/QNV4URU6QYN5Mf0BKyhdcij1Nj+mdxtHg70uZHXmXygOFIW/Ef/rfBXDp43n4P5sW +LliWyrpqnMVjR5zF9hhcvxcXBf86clKSLSlRlAyPUov1iqGCWyX9zPM4i5knHM6C8j0 Co+G9IIQ+UDkPnrW4USDTuZwaUqml9pgX2+Sl3X+PJwdnxKWRb/3s5+OtPPzUEKRnfPN sLlg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=fWhU4Huq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y38-20020a634966000000b0055b731aa9adsi2099159pgk.562.2023.07.18.15.46.18; Tue, 18 Jul 2023 15:46:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=fWhU4Huq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231366AbjGRWa6 (ORCPT + 99 others); Tue, 18 Jul 2023 18:30:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49036 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231184AbjGRWa4 (ORCPT ); Tue, 18 Jul 2023 18:30:56 -0400 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 41F5CBD; Tue, 18 Jul 2023 15:30:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1689719455; x=1721255455; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=mQ/XSuCjEEjkILhFj9nOT74zfQbBcNaiX6hcd7hblIs=; b=fWhU4HuqOkm7jMjUnGPGXp4/xqAD+tm9z1xJp13XphqUkAPy2aTFdJ7v fE2mqHDlbmHJaKy2pD3R3Dlmt0HX08jrrLp6hFPlij6eiCxT0FfZPpDIy nw6UH0fY56J5DIJ0oh2Vp4FBGeC9hIBG2TiJojGjOPq3zjlxXjnxyKNGo BecB8Ivj84ZrDrPkmoDQDco8JLZDDHcF6UXxL3gdoIWrT6+sZcEWdE4wL SQuKedpTl+d76Tja1qFRoRP9OPzNhhfmM1EzEIabTmc8EXsM1qRc9iK7D sLdg5g9RswfhaYd5/00lUkvrkIT+IHSKuwQ7qukySkMAK22ZhU75SN0Dk g==; X-IronPort-AV: E=McAfee;i="6600,9927,10775"; a="346626709" X-IronPort-AV: E=Sophos;i="6.01,215,1684825200"; d="scan'208";a="346626709" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Jul 2023 15:30:54 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10775"; a="727112101" X-IronPort-AV: E=Sophos;i="6.01,215,1684825200"; d="scan'208";a="727112101" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga007.fm.intel.com with ESMTP; 18 Jul 2023 15:30:52 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id E184E16E; Wed, 19 Jul 2023 01:30:58 +0300 (EEST) From: Andy Shevchenko To: Bartosz Golaszewski , Andy Shevchenko , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Linus Walleij , Bartosz Golaszewski , Andy Shevchenko , Ray Jui , Broadcom internal kernel review list , Florian Fainelli , Scott Branden Subject: [PATCH v3 1/3] gpio: bcm-kona: Make driver OF-independent Date: Wed, 19 Jul 2023 01:30:53 +0300 Message-Id: <20230718223055.2809-1-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.40.0.1.gaa8946217a0b MIME-Version: 1.0 X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1771800249785810160 X-GMAIL-MSGID: 1771800249785810160 There is nothing in the driver that requires OF APIs, make the driver OF independent. Signed-off-by: Andy Shevchenko --- v2: new patch v3: fixed compilation error (LKP) drivers/gpio/Kconfig | 2 +- drivers/gpio/gpio-bcm-kona.c | 21 ++++++++------------- 2 files changed, 9 insertions(+), 14 deletions(-) diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig index 638f0e771105..a70622d32a3b 100644 --- a/drivers/gpio/Kconfig +++ b/drivers/gpio/Kconfig @@ -191,7 +191,7 @@ config GPIO_RASPBERRYPI_EXP config GPIO_BCM_KONA bool "Broadcom Kona GPIO" - depends on OF_GPIO && (ARCH_BCM_MOBILE || COMPILE_TEST) + depends on ARCH_BCM_MOBILE || COMPILE_TEST help Turn on GPIO support for Broadcom "Kona" chips. diff --git a/drivers/gpio/gpio-bcm-kona.c b/drivers/gpio/gpio-bcm-kona.c index 70770429ba48..c977144eff10 100644 --- a/drivers/gpio/gpio-bcm-kona.c +++ b/drivers/gpio/gpio-bcm-kona.c @@ -8,12 +8,14 @@ #include #include -#include #include -#include #include +#include #include #include +#include +#include +#include #define BCM_GPIO_PASSWD 0x00a5a501 #define GPIO_PER_BANK 32 @@ -556,19 +558,12 @@ static void bcm_kona_gpio_reset(struct bcm_kona_gpio *kona_gpio) static int bcm_kona_gpio_probe(struct platform_device *pdev) { struct device *dev = &pdev->dev; - const struct of_device_id *match; struct bcm_kona_gpio_bank *bank; struct bcm_kona_gpio *kona_gpio; struct gpio_chip *chip; int ret; int i; - match = of_match_device(bcm_kona_gpio_of_match, dev); - if (!match) { - dev_err(dev, "Failed to find gpio controller\n"); - return -ENODEV; - } - kona_gpio = devm_kzalloc(dev, sizeof(*kona_gpio), GFP_KERNEL); if (!kona_gpio) return -ENOMEM; @@ -601,10 +596,10 @@ static int bcm_kona_gpio_probe(struct platform_device *pdev) chip->parent = dev; chip->ngpio = kona_gpio->num_bank * GPIO_PER_BANK; - kona_gpio->irq_domain = irq_domain_add_linear(dev->of_node, - chip->ngpio, - &bcm_kona_irq_ops, - kona_gpio); + kona_gpio->irq_domain = irq_domain_create_linear(dev_fwnode(dev), + chip->ngpio, + &bcm_kona_irq_ops, + kona_gpio); if (!kona_gpio->irq_domain) { dev_err(dev, "Couldn't allocate IRQ domain\n"); return -ENXIO;