From patchwork Tue Jul 18 19:24:50 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fabrizio Castro X-Patchwork-Id: 122208 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:c923:0:b0:3e4:2afc:c1 with SMTP id j3csp1967482vqt; Tue, 18 Jul 2023 12:39:05 -0700 (PDT) X-Google-Smtp-Source: APBJJlG200iCbmahE7Rdx6cUB7AB9aac5G5vbFDu0cIZVQt7y3TJAT2xsw4iSJ4UTngArD2PPKi6 X-Received: by 2002:a05:6512:2384:b0:4f8:7781:9870 with SMTP id c4-20020a056512238400b004f877819870mr13723223lfv.60.1689709145500; Tue, 18 Jul 2023 12:39:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689709145; cv=none; d=google.com; s=arc-20160816; b=ACaSiucmafLdFoBoY8qK9HmQaCdWUfsw3roir6u/grI+q2+ovcX8H46JBktpq2QTR0 UU7BhNpF77JP9pkGlPIlRuC+KsyB22H1XgVNxdQdk3K9F9ZgukMw6yIGOyPv6k59OEAu wXSIi25DV8nWvbF5wazAbO0aQyjvf01F6dj8PH5gAR89Jn77M+/aEPMakiaQ0NYbpqcK OQc3wmhvY/X+CoSl8SsKCRJxZ10x6Cg15dUYeih+I4ePfp+q40KLt0JDW9Nr5R2P8XTi KtaQbVD+XLV3KRjZCnAPQbp6QpEGNXJ7wekjS/t/i+ucDUhSJNcafwseAiqhjZAt+Ba3 /9iw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=ENvebFhUGalFOvoFIx+6b6xRDi4NrrM52euRcb8ZswU=; fh=8SPOXdXcsbbrdLjCtKFrhdDDaSSTCLFzjvpt84tri9w=; b=vVcl/JV7GsxATAhKRH+L7FZa7Vu/2Z8bA+JSl+ezoXMLoxJfXwzdXLCictS3n6SX5r 1ptn03cRCacaRRzP8VvAvokfRF6oO6l10wwCdzkORDS/UMcx/XGNZ4tXqRcNLd4+joFh T3FyuoIXBNhZAErFYqhmMd9KWoBOeIu/NfEGSlIIH5XPLxdJH1eZ3mZXdEWyinIRutgb 8vs+V6GQdk2je/LRP72iNcyRcu+W3kX2v5hKS8yRmCD5cp68mF9SSo2y79loe9E579Ev xXCyyyyBWZUT7uzcailuGUtrUpQwVyMXBFKkF8Z90WBPlTX+mauGqixYidrsD+DII1ns KOSQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=renesas.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id d17-20020a05640208d100b0051de088f170si1689075edz.127.2023.07.18.12.38.41; Tue, 18 Jul 2023 12:39:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=renesas.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230200AbjGRTZN (ORCPT + 99 others); Tue, 18 Jul 2023 15:25:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51896 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229749AbjGRTZJ (ORCPT ); Tue, 18 Jul 2023 15:25:09 -0400 Received: from relmlie5.idc.renesas.com (relmlor1.renesas.com [210.160.252.171]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 0F51D19AF; Tue, 18 Jul 2023 12:25:06 -0700 (PDT) X-IronPort-AV: E=Sophos;i="6.01,214,1684767600"; d="scan'208";a="169810329" Received: from unknown (HELO relmlir6.idc.renesas.com) ([10.200.68.152]) by relmlie5.idc.renesas.com with ESMTP; 19 Jul 2023 04:25:05 +0900 Received: from mulinux.home (unknown [10.226.93.62]) by relmlir6.idc.renesas.com (Postfix) with ESMTP id CD2E44067F07; Wed, 19 Jul 2023 04:25:02 +0900 (JST) From: Fabrizio Castro To: Mark Brown , Geert Uytterhoeven Cc: Fabrizio Castro , Andy Shevchenko , linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, Chris Paterson , Biju Das , Lad Prabhakar , linux-renesas-soc@vger.kernel.org Subject: [PATCH v2 1/4] spi: rzv2m-csi: Squash timing settings into one statement Date: Tue, 18 Jul 2023 20:24:50 +0100 Message-Id: <20230718192453.543549-2-fabrizio.castro.jz@renesas.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230718192453.543549-1-fabrizio.castro.jz@renesas.com> References: <20230718192453.543549-1-fabrizio.castro.jz@renesas.com> MIME-Version: 1.0 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1771788456672489193 X-GMAIL-MSGID: 1771788456672489193 Register CLKSEL hosts the configuration for both clock polarity and data phase, and both values can be set in one write operation. Squash the clock polarity and data phase register writes into one statement, for efficiency. Signed-off-by: Fabrizio Castro Suggested-by: Andy Shevchenko Reviewed-by: Andy Shevchenko --- v2: No change. drivers/spi/spi-rzv2m-csi.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/spi/spi-rzv2m-csi.c b/drivers/spi/spi-rzv2m-csi.c index 038f1486b7d7..faf5898bc3e0 100644 --- a/drivers/spi/spi-rzv2m-csi.c +++ b/drivers/spi/spi-rzv2m-csi.c @@ -38,6 +38,7 @@ /* CSI_CLKSEL */ #define CSI_CLKSEL_CKP BIT(17) #define CSI_CLKSEL_DAP BIT(16) +#define CSI_CLKSEL_MODE (CSI_CLKSEL_CKP|CSI_CLKSEL_DAP) #define CSI_CLKSEL_SLAVE BIT(15) #define CSI_CLKSEL_CKS GENMASK(14, 1) @@ -408,10 +409,8 @@ static int rzv2m_csi_setup(struct spi_device *spi) writel(CSI_MODE_SETUP, csi->base + CSI_MODE); /* Setup clock polarity and phase timing */ - rzv2m_csi_reg_write_bit(csi, CSI_CLKSEL, CSI_CLKSEL_CKP, - !(spi->mode & SPI_CPOL)); - rzv2m_csi_reg_write_bit(csi, CSI_CLKSEL, CSI_CLKSEL_DAP, - !(spi->mode & SPI_CPHA)); + rzv2m_csi_reg_write_bit(csi, CSI_CLKSEL, CSI_CLKSEL_MODE, + ~spi->mode & SPI_MODE_X_MASK); /* Setup serial data order */ rzv2m_csi_reg_write_bit(csi, CSI_MODE, CSI_MODE_DIR,