diff mbox series

ARM: keystone: Drop unused includes

Message ID 20230717225610.3214029-1-robh@kernel.org
State New
Headers
Series ARM: keystone: Drop unused includes |

Commit Message

Rob Herring July 17, 2023, 10:56 p.m. UTC 
  Several includes are not needed, so drop them.

of_platform.h is not needed, but it implicitly includes platform_device.h
(for now) which is needed.

Signed-off-by: Rob Herring <robh@kernel.org>
---
 arch/arm/mach-keystone/keystone.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

Comments

Nishanth Menon July 25, 2023, 11:35 a.m. UTC | #1 
Hi Rob Herring,

On Mon, 17 Jul 2023 16:56:09 -0600, Rob Herring wrote:
> Several includes are not needed, so drop them.
> 
> of_platform.h is not needed, but it implicitly includes platform_device.h
> (for now) which is needed.
> 
> 

I have applied the following to branch ti-keystone-next on [1].
Thank you!

[1/1] ARM: keystone: Drop unused includes
      commit: 630c191b3396c6aaccab1234f8834848a2c42e8a

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent up the chain during
the next merge window (or sooner if it is a relevant bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

[1] https://git.kernel.org/pub/scm/linux/kernel/git/ti/linux.git
Rob Herring Aug. 22, 2023, 10:28 p.m. UTC | #2 
On Tue, Jul 25, 2023 at 6:35 AM Nishanth Menon <nm@ti.com> wrote:
>
> Hi Rob Herring,
>
> On Mon, 17 Jul 2023 16:56:09 -0600, Rob Herring wrote:
> > Several includes are not needed, so drop them.
> >
> > of_platform.h is not needed, but it implicitly includes platform_device.h
> > (for now) which is needed.
> >
> >
>
> I have applied the following to branch ti-keystone-next on [1].
> Thank you!
>
> [1/1] ARM: keystone: Drop unused includes
>       commit: 630c191b3396c6aaccab1234f8834848a2c42e8a

Did you really? Doesn't look like this is in linux-next.

Rob
Rob Herring Aug. 23, 2023, 4:53 p.m. UTC | #3 
On Tue, Aug 22, 2023 at 6:03 PM Nishanth Menon <nm@ti.com> wrote:
>
> On 17:28-20230822, Rob Herring wrote:
> > On Tue, Jul 25, 2023 at 6:35 AM Nishanth Menon <nm@ti.com> wrote:
> > >
> > > Hi Rob Herring,
> > >
> > > On Mon, 17 Jul 2023 16:56:09 -0600, Rob Herring wrote:
> > > > Several includes are not needed, so drop them.
> > > >
> > > > of_platform.h is not needed, but it implicitly includes platform_device.h
> > > > (for now) which is needed.
> > > >
> > > >
> > >
> > > I have applied the following to branch ti-keystone-next on [1].
> > > Thank you!
> > >
> > > [1/1] ARM: keystone: Drop unused includes
> > >       commit: 630c191b3396c6aaccab1234f8834848a2c42e8a
> >
> > Did you really? Doesn't look like this is in linux-next.
>
> Seems to have been there for a while?
>
> https://git.kernel.org/pub/scm/linux/kernel/git/ti/linux.git/log/?h=ti-keystone-next
>
> https://patchwork.kernel.org/project/linux-soc/patch/20230814160702.6l2fcujbx33eogap@junction/
>
> $ git tag --contains 630c191b3396c6aaccab1234f8834848a2c42e8a
> next-20230801
> next-20230802
> next-20230804
> next-20230807
> next-20230808
> next-20230809
> next-20230816
> next-20230817
> next-20230818
> next-20230821
> next-20230822
> ti-keystone-soc-for-v6.6
>
>
> Did I miss something?

Sorry, I sent the davinci changes also with 'keystone' in the subject
by mistake and confused myself...

Rob
diff mbox series

Patch

diff --git a/arch/arm/mach-keystone/keystone.c b/arch/arm/mach-keystone/keystone.c
index 68039aad3014..e0ca26182e0b 100644
--- a/arch/arm/mach-keystone/keystone.c
+++ b/arch/arm/mach-keystone/keystone.c
@@ -7,12 +7,10 @@ 
  *	Santosh Shilimkar <santosh.shillimkar@ti.com>
  */
 #include <linux/io.h>
-#include <linux/of.h>
 #include <linux/dma-map-ops.h>
 #include <linux/init.h>
-#include <linux/of_platform.h>
-#include <linux/of_address.h>
 #include <linux/memblock.h>
+#include <linux/platform_device.h>
 
 #include <asm/setup.h>
 #include <asm/mach/map.h>