From patchwork Mon Jul 17 23:15:19 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Gleixner X-Patchwork-Id: 121685 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:c923:0:b0:3e4:2afc:c1 with SMTP id j3csp1407835vqt; Mon, 17 Jul 2023 16:42:46 -0700 (PDT) X-Google-Smtp-Source: APBJJlFlq78TBhxXDZXNrax5tLZmDMHlBdaLrcjZtNqiKiRsCMQqRoMMT4jDAP2dXJwkhVjZ/47o X-Received: by 2002:a17:902:ec88:b0:1b6:b805:5ae3 with SMTP id x8-20020a170902ec8800b001b6b8055ae3mr15347150plg.3.1689637365812; Mon, 17 Jul 2023 16:42:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689637365; cv=none; d=google.com; s=arc-20160816; b=atisllz9F3WybtQ6Zl9EJ1cOAIta7WcvwnxrdM1VyNzJAYqU+kIuPnLukNtR6u3RKO maBxOIsM5oAv1KNiU8FPkpmfUdou3vUBWRVrwDFCDemt7VGxTUQ0nCkFUDXXRfX7a19Y aqtiiw0a1xsS8eZZEBH9RfyuEJquNYkysFgFhU/+pPGl74sjqfDT0yQyHxTOhhoArV7c sUFpkx9/k7dkcRzHAmq8pViDUMr9bmeN41UhhivAPK//voVencarMqqjsJQfqqoqPkA3 PjqVye9qosUEyKupm8ALsBPoHEP6whKnejgZ9kzFHJXxj0SmBCQ5ajJXz8EtEwouWA1n GGpQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:date:mime-version:references:subject:cc:to:from :dkim-signature:dkim-signature:message-id; bh=1fi5EfwywiW+JxLoqkaaJxdnnrJM3lL64yD5t1OC3bQ=; fh=MJzvnywV9/WrN/ASipmGkNx/7jKFHnq83nsgXe/obdc=; b=bSRubNYxR1CEVg4faG2otY/1E9g68j8Cj5R/p0p4e7+U/mdmLiSXJN1KvPUPsSTEj7 Rwxx4QMwVpHG1YkCWK8zSjAMq6j6EIK7oK08SXt8i1Hs7akDH1/TDjwxHpXI38Di/gYL WtefZM0wMpEkFdV7fuNEGjgkopzx4r1AW7lTJBQFOlLPMaykwLO+W+rYniMPfdYJGtwr ISh7VcErlM6cdm7aOPbVMCu8jEBEzM2U2FAOtJbtP+3+HpW+uAnZUDyHT3hMmTdmYCtH sumb0mzdt9IPoBGV1Hsdz0d9TUt5zy53UjzzG407BETGil/b11pERYlIMuOqH+RzRrtr v8Ew== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=BADiRAFT; dkim=neutral (no key) header.i=@linutronix.de header.b=gEMTuYy1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id im15-20020a170902bb0f00b001bb42c274a9si280282plb.504.2023.07.17.16.42.32; Mon, 17 Jul 2023 16:42:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=BADiRAFT; dkim=neutral (no key) header.i=@linutronix.de header.b=gEMTuYy1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231553AbjGQXSU (ORCPT + 99 others); Mon, 17 Jul 2023 19:18:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37548 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231508AbjGQXSR (ORCPT ); Mon, 17 Jul 2023 19:18:17 -0400 Received: from galois.linutronix.de (Galois.linutronix.de [IPv6:2a0a:51c0:0:12e:550::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3774F172E for ; Mon, 17 Jul 2023 16:17:27 -0700 (PDT) Message-ID: <20230717223224.801556578@linutronix.de> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1689635720; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=1fi5EfwywiW+JxLoqkaaJxdnnrJM3lL64yD5t1OC3bQ=; b=BADiRAFTkC6r+a6gyybktPa+HfMXroxjn94l+bXbqaw3hq9umOUNeI+hfDtflvabJCgkd5 QafHXvflNvNJy/0aP7T1om1tokKWKy0kWeS+wIa6a4G5IGSmufLN9xvcqtTEjwOi5+MXx3 8GezOJsDcGML0gR+CwAMJGMfWTiy3rS/rOqo0rJkKJerU87KohFbetomtjwF9muWhZpVNZ RESKOnkG/WXU0hxG3iczaPFjdgcOdTFWoH2KDBpEX4wf1GuCXUvbJphNnlnb2y2YfXeuTK uvQ6KOXl/URhjav4FU825U9eo8rowRqpyoA8+YJI3k64zJF5s4YiDqPk1NdtLQ== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1689635720; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=1fi5EfwywiW+JxLoqkaaJxdnnrJM3lL64yD5t1OC3bQ=; b=gEMTuYy1EBhlm7p9f9Q1LKgSaDPFxw28WPcOb9fBTWlqY6cWG1255arVxNdYPX4Kr9ZFwy ZCcvTKnNXjsBQoCw== From: Thomas Gleixner To: LKML Cc: x86@kernel.org, Linus Torvalds , Andrew Cooper , Tom Lendacky , Paolo Bonzini , Wei Liu , Arjan van de Ven , Juergen Gross Subject: [patch 29/58] x86/ioapic/32: Decrapify phys_id_present_map operation References: <20230717223049.327865981@linutronix.de> MIME-Version: 1.0 Date: Tue, 18 Jul 2023 01:15:19 +0200 (CEST) X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1771713190972706527 X-GMAIL-MSGID: 1771713190972706527 The operation to set the IOAPIC ID in phys_id_present_map is as convoluted as it can be. 1) Allocate a bitmap of 32byte size on the stack 2) Zero the bitmap and set the IOAPIC ID bit 3) Or the temporary bitmap over phys_id_present_map The same functionality can be achieved by setting the IOAPIC ID bit directly in the phys_id_present_map. Signed-off-by: Thomas Gleixner --- arch/x86/kernel/apic/io_apic.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) --- a/arch/x86/kernel/apic/io_apic.c +++ b/arch/x86/kernel/apic/io_apic.c @@ -1511,12 +1511,9 @@ void __init setup_ioapic_ids_from_mpc_no physid_set(i, phys_id_present_map); ioapics[ioapic_idx].mp_config.apicid = i; } else { - physid_mask_t tmp; - - physid_set_mask_of_physid(mpc_ioapic_id(ioapic_idx), &tmp); apic_printk(APIC_VERBOSE, "Setting %d in the phys_id_present_map\n", mpc_ioapic_id(ioapic_idx)); - physids_or(phys_id_present_map, phys_id_present_map, tmp); + physid_set(mpc_ioapic_id(ioapic_idx), phys_id_present_map); } /*