From patchwork Mon Jul 17 23:15:08 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Gleixner X-Patchwork-Id: 121666 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:c923:0:b0:3e4:2afc:c1 with SMTP id j3csp1406057vqt; Mon, 17 Jul 2023 16:36:51 -0700 (PDT) X-Google-Smtp-Source: APBJJlGT+VILCtoY+sPMBDuyRPgzmTsJNM1Lz78RyIQ0sVSM515+rCOE9S+teDeWGw5ahF4oOnBh X-Received: by 2002:a05:6a00:a29:b0:675:667c:f261 with SMTP id p41-20020a056a000a2900b00675667cf261mr17764858pfh.2.1689637010652; Mon, 17 Jul 2023 16:36:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689637010; cv=none; d=google.com; s=arc-20160816; b=NrUpx2LmB5eRZhAz3h6NChY5sTvzwLribQJ0hgtixFLvkx8fXSs9JvWj4TP3AmAWFJ yyF0E2TWXixDT9Rq1bfSzOG4ikqJ0LhMra+e+LSe0CW/y4ABpmU3Ueueuyj8ld3gPVK2 zS2TUf7Wl78HBkfkp1bqsiuoqbOtFC2/tGMKvtwIpyR0X6dDDHBuaYIbVqphx+WZqqcA G5foHaAGvBZGeHDIGfbEiGcZ6L0SB8aQr+sGk9UIEBNnIY9JLbmI0C+F0RitxWoCdPRu VWnKjnPL1uNH6q3UJ+kO8Af+MUjnWK8+bnSwWwHMtnb8UI3fCge1uBj9xNDbrdLdqWY6 25mw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:date:mime-version:references:subject:cc:to:from :dkim-signature:dkim-signature:message-id; bh=oBy16z9oVs8uzIdM6vzKosS3I9qeD3Jk8eFl+Cs6+fk=; fh=MJzvnywV9/WrN/ASipmGkNx/7jKFHnq83nsgXe/obdc=; b=d1Grp+2w5f+ks3vKD4tMVSdTmLExi2gTWiGTsdlm6y+pm8/1BY+9+QUwPSG2Ibuyzi dhDXQnxDR3u6/+4bmt79gC8MoOmXB9Mk/2SX1+oqDd1E5+NKxR2pK/Lhahcv84SHXMRS Giy8Yry5SAcnjSJQc1Muh0iHundpg5zApdhIjVACdmxBLKxpuGLyK1eA8TgFIVeZdmm1 CUtOFC6L//+jOSW/yjdU6PqaVadARfBf8XjSrLBj1QbD5LVnAsAdcOePyJqKI6B1tO+D mF11tY8kxy5B3Hdqny0dl+12FzoKkiQm0ev9eACjnt+2wlKQVjgYyBFNkTg31NpQNfOB D2rg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=tmIcEk9X; dkim=neutral (no key) header.i=@linutronix.de header.s=2020e; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id x24-20020a63f718000000b0054fdb063301si561440pgh.252.2023.07.17.16.36.37; Mon, 17 Jul 2023 16:36:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=tmIcEk9X; dkim=neutral (no key) header.i=@linutronix.de header.s=2020e; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231438AbjGQXQb (ORCPT + 99 others); Mon, 17 Jul 2023 19:16:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36276 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231432AbjGQXQ3 (ORCPT ); Mon, 17 Jul 2023 19:16:29 -0400 Received: from galois.linutronix.de (Galois.linutronix.de [IPv6:2a0a:51c0:0:12e:550::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 002A4132 for ; Mon, 17 Jul 2023 16:15:42 -0700 (PDT) Message-ID: <20230717223224.387322230@linutronix.de> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1689635709; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=oBy16z9oVs8uzIdM6vzKosS3I9qeD3Jk8eFl+Cs6+fk=; b=tmIcEk9XpjQcUhC77tzrt+q6FJfA7Knf1Ts0BMgMqrctHb+QoRjibisDoJ+IlNuvLYbdHv Y3t5PbjQ34QB12uGL4rRDgtbBlTsBEQM1vUxhslhlp+EL0AXi6WVOspkW3vWriRoDHWIcF 21rlQp09gIBPBDTSx5doUgfDue9Dj3Lope9QbyjBGRcC+4Cm52sVTdR9caVuRM9ub1XIyf VeDbUgz7AcsvfhZUDIy3CS8yderQtxaVl1K0cR6ELUAAA0RG9Mv6X6IA57H6O05F5gE60d 8U9Y6un/5bfDVB6EWESnD706BJrJHTDUmKTYhdgwzI0qnB0Fppl2yyODXwiD+g== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1689635709; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=oBy16z9oVs8uzIdM6vzKosS3I9qeD3Jk8eFl+Cs6+fk=; b=OMBprqP0VGos8jmJkNRVP95C0AxZwsyctJ+1dU9Xsy94RSKAwUReBcNWlf5zFtOlMcIbqH rmyWLpGg2NiFaDAQ== From: Thomas Gleixner To: LKML Cc: x86@kernel.org, Linus Torvalds , Andrew Cooper , Tom Lendacky , Paolo Bonzini , Wei Liu , Arjan van de Ven , Juergen Gross Subject: [patch 22/58] x86/apic/ipi: Code cleanup References: <20230717223049.327865981@linutronix.de> MIME-Version: 1.0 Date: Tue, 18 Jul 2023 01:15:08 +0200 (CEST) X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1771712818246323814 X-GMAIL-MSGID: 1771712818246323814 Remove completely useless and mindlessly copied comments and tidy up the code which causes eye bleed when looking at it. Signed-off-by: Thomas Gleixner --- arch/x86/kernel/apic/ipi.c | 23 +++++++---------------- 1 file changed, 7 insertions(+), 16 deletions(-) --- a/arch/x86/kernel/apic/ipi.c +++ b/arch/x86/kernel/apic/ipi.c @@ -184,18 +184,13 @@ void default_send_IPI_single_phys(int cp void default_send_IPI_mask_sequence_phys(const struct cpumask *mask, int vector) { - unsigned long query_cpu; unsigned long flags; + unsigned long cpu; - /* - * Hack. The clustered APIC addressing mode doesn't allow us to send - * to an arbitrary mask, so I do a unicast to each CPU instead. - * - mbligh - */ local_irq_save(flags); - for_each_cpu(query_cpu, mask) { + for_each_cpu(cpu, mask) { __default_send_IPI_dest_field(per_cpu(x86_cpu_to_apicid, - query_cpu), vector, APIC_DEST_PHYSICAL); + cpu), vector, APIC_DEST_PHYSICAL); } local_irq_restore(flags); } @@ -203,18 +198,15 @@ void default_send_IPI_mask_sequence_phys void default_send_IPI_mask_allbutself_phys(const struct cpumask *mask, int vector) { - unsigned int this_cpu = smp_processor_id(); - unsigned int query_cpu; + unsigned int cpu, this_cpu = smp_processor_id(); unsigned long flags; - /* See Hack comment above */ - local_irq_save(flags); - for_each_cpu(query_cpu, mask) { - if (query_cpu == this_cpu) + for_each_cpu(cpu, mask) { + if (cpu == this_cpu) continue; __default_send_IPI_dest_field(per_cpu(x86_cpu_to_apicid, - query_cpu), vector, APIC_DEST_PHYSICAL); + cpu), vector, APIC_DEST_PHYSICAL); } local_irq_restore(flags); } @@ -283,7 +275,6 @@ void default_send_IPI_mask_logical(const local_irq_restore(flags); } -/* must come after the send_IPI functions above for inlining */ static int convert_apicid_to_cpu(int apic_id) { int i;