Message ID | 20230717164307.2868264-1-m.felsch@pengutronix.de |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:c923:0:b0:3e4:2afc:c1 with SMTP id j3csp1230354vqt; Mon, 17 Jul 2023 09:56:46 -0700 (PDT) X-Google-Smtp-Source: APBJJlEosuPnL+p4nfH1tWZy7tgspDUPME9Vx5D9+ku1IogeGbKJ+2M7NWpwy4JJJfAw6BZzn01t X-Received: by 2002:a17:906:7a53:b0:997:865a:77e5 with SMTP id i19-20020a1709067a5300b00997865a77e5mr36530ejo.45.1689613006685; Mon, 17 Jul 2023 09:56:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689613006; cv=none; d=google.com; s=arc-20160816; b=0PS7yTz828b6Q/CgpHJ7bLiT/sI9NE5qkPlA+TD2E1omAqpyhI7m3z97xrRGpy/94H SOjMpUZ59LqNTpIw21luE0qNf+FpEXvvHPr8/7Bd2IiNUCqBQLftAU3eA4100AI4btth s4O470bkpoG1sKb3gPJ3c92cuerF7qG+E1Q2aOzm+q4hgXB88HDs45pRWPZNs3vvQmxI JUmoNBYOkN+L6JBUcZ21kdFsmRm67+t98mKhfRQPVOc9DVbUFKL66oLtATD5oo+uRbxT mEc+pfWiMhCfPUpMy4z52otFb+QcAAP/eTuxz/Rp4EGI87SxY+HCnIz+/xbmiTbo8bBH AZdA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=GDaQa+/l/gRV7xliUMKVx4FQT2nL6EDhXZL53b60KM8=; fh=QeWVog8QaeVa5KwK+2bMGjtIYPo3unmUnrTfqI3CztU=; b=vhlBrvIk/Y7MtbqZ4V9TM6La75Z1esrfqvFIOEgvP33acNOjVhzSfoMFF7vEFFZ2i2 ZVszt4hZp3z6UNez/PeL4QCFyUT7WzK9C51D+zhXfQAp/qk+2GlMeGfmTTc45VnCCBn3 SoyoJWrRvKUMiDnGZZa0egU/6JBRmYJ9skbW66elSGtQmLs2GLMlU5D2Z6oHAATBmyN2 +gdsQVFkWhqH2PqM0eQs5SaIjvgVWzKAUDklewXfREOJo8gRaEooloY4utPMBxWqppYc 4TgqGWyO+HW88/pb6XbzpWiG206elRDfC+Cmx/LLW2X671IRspzxV94ZJenL1OEDZVMm oELA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q27-20020a17090622db00b00997b74a738esi2952902eja.448.2023.07.17.09.56.22; Mon, 17 Jul 2023 09:56:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231719AbjGQQnq (ORCPT <rfc822;hadasmailinglist@gmail.com> + 99 others); Mon, 17 Jul 2023 12:43:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49118 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232066AbjGQQnm (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Mon, 17 Jul 2023 12:43:42 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0D0F510D9 for <linux-kernel@vger.kernel.org>; Mon, 17 Jul 2023 09:43:37 -0700 (PDT) Received: from dude02.red.stw.pengutronix.de ([2a0a:edc0:0:1101:1d::28]) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from <m.felsch@pengutronix.de>) id 1qLRJd-0004l0-57; Mon, 17 Jul 2023 18:43:17 +0200 From: Marco Felsch <m.felsch@pengutronix.de> To: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, peppe.cavallaro@st.com, alexandre.torgue@foss.st.com, joabreu@synopsys.com, mcoquelin.stm32@gmail.com Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de Subject: [PATCH net-next 1/2] dt-bindings: net: snps,dwmac: add phy-supply support Date: Mon, 17 Jul 2023 18:43:06 +0200 Message-Id: <20230717164307.2868264-1-m.felsch@pengutronix.de> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 2a0a:edc0:0:1101:1d::28 X-SA-Exim-Mail-From: m.felsch@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1771687642093818133 X-GMAIL-MSGID: 1771687648161624912 |
Series |
[net-next,1/2] dt-bindings: net: snps,dwmac: add phy-supply support
|
|
Commit Message
Marco Felsch
July 17, 2023, 4:43 p.m. UTC
Document the common phy-supply property to be able to specify a phy
regulator.
Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
---
Documentation/devicetree/bindings/net/snps,dwmac.yaml | 3 +++
1 file changed, 3 insertions(+)
Comments
On 23-07-17, Krzysztof Kozlowski wrote: > On 17/07/2023 18:43, Marco Felsch wrote: > > Document the common phy-supply property to be able to specify a phy > > regulator. > > > > Signed-off-by: Marco Felsch <m.felsch@pengutronix.de> > > --- > > Documentation/devicetree/bindings/net/snps,dwmac.yaml | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml > > index 363b3e3ea3a60..f66d1839cf561 100644 > > --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml > > +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml > > @@ -159,6 +159,9 @@ properties: > > can be passive (no SW requirement), and requires that the MAC operate > > in a different mode than the PHY in order to function. > > > > + phy-supply: > > + description: PHY regulator > > + > > Isn't this property of the PHY? Why would the Ethernet controller play > with a supply of a phy? Because this is the current state. Please check the all other MACs handling the phy-supply (if supported). Some of them handling it under the mdio-node (not the phy-node) but most bindings do specify this on MAC level (e.g. FEC, DWMAC (suni, rk)). I agree that the phy sould handle this but this would be a lot more effort and since the dwmac-sun8i/rk bindings do support this on MAC level I would keep it that way. Regards, Marco
On 17/07/2023 18:57, Marco Felsch wrote: > On 23-07-17, Krzysztof Kozlowski wrote: >> On 17/07/2023 18:43, Marco Felsch wrote: >>> Document the common phy-supply property to be able to specify a phy >>> regulator. >>> >>> Signed-off-by: Marco Felsch <m.felsch@pengutronix.de> >>> --- >>> Documentation/devicetree/bindings/net/snps,dwmac.yaml | 3 +++ >>> 1 file changed, 3 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml >>> index 363b3e3ea3a60..f66d1839cf561 100644 >>> --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml >>> +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml >>> @@ -159,6 +159,9 @@ properties: >>> can be passive (no SW requirement), and requires that the MAC operate >>> in a different mode than the PHY in order to function. >>> >>> + phy-supply: >>> + description: PHY regulator >>> + >> >> Isn't this property of the PHY? Why would the Ethernet controller play >> with a supply of a phy? > > Because this is the current state. Please check the all other MACs > handling the phy-supply (if supported). Some of them handling it under > the mdio-node (not the phy-node) but most bindings do specify this on > MAC level (e.g. FEC, DWMAC (suni, rk)). > > I agree that the phy sould handle this but this would be a lot more > effort and since the dwmac-sun8i/rk bindings do support this on MAC > level I would keep it that way. Indeed phy bindings do not allow a supply. Best regards, Krzysztof
On 17/07/2023 18:43, Marco Felsch wrote: > Document the common phy-supply property to be able to specify a phy > regulator. > > Signed-off-by: Marco Felsch <m.felsch@pengutronix.de> > --- Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml index 363b3e3ea3a60..f66d1839cf561 100644 --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml @@ -159,6 +159,9 @@ properties: can be passive (no SW requirement), and requires that the MAC operate in a different mode than the PHY in order to function. + phy-supply: + description: PHY regulator + snps,axi-config: $ref: /schemas/types.yaml#/definitions/phandle description: