From patchwork Mon Jul 17 15:03:55 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rob Herring X-Patchwork-Id: 121410 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:c923:0:b0:3e4:2afc:c1 with SMTP id j3csp1182868vqt; Mon, 17 Jul 2023 08:30:44 -0700 (PDT) X-Google-Smtp-Source: APBJJlFzh+9ECszOziIOwjKG/vmyv61eJpmR1Gj550oSZKIrQJjdEBcddyTyQWuaiKnHMqFx6AdL X-Received: by 2002:a17:906:7a1d:b0:992:d013:1132 with SMTP id d29-20020a1709067a1d00b00992d0131132mr10618171ejo.1.1689607844234; Mon, 17 Jul 2023 08:30:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689607844; cv=none; d=google.com; s=arc-20160816; b=zumEPUTaFWs6Hx9ogNsXHG5k6Ws8PTLLV70qvxKX6XLH/8gANXg/5e6Ths3AQqhphY BpthSxpBFJ+WkiE5upVkts5OTQEiDCYl2NfC5W5I5cjv8FInqOYq4bhzWfVYEqejxBbh UxQw8jODTGbBMxw1LdKXDtz8MpewD5p+gifbaGF6eM1yXr6L30aHODdbNhe8OERxesal z7daNyg4BYljJGDVazzbhJR8pUOE239Ub18hA6p6VnMcO6sBJmjEjD1Hs7lhIH7SksCT CW9XBU3NvATg+ShE+lW8T8l64y542sqiK/u3fuUpZWuwo9h+2E7rmrwH4KC4fFFTMM5Q iQ4A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=iFCGjvftM9axvub8iTYGaiLg9AIpWZi5i+H1PO4PCvE=; fh=h7mmAtDUFEIpuZAcSsk1RTfyGz3S9LLnDCqQzK0CWyo=; b=LlTzirysknxt3Tn87IVyoxjNeRm5+YU4fCi00X4x6/JpVdGf/qM+WWttR9cdMXz1Tz /OyoSeZga5bZJrtN2kF7dV1vQz4WcvjyzhHDZoJTjbeqfwCoXuF9whMu8Tgs26lCqHDR p+pwCEeVGxRz/Z/efKgM0jt67q6VtcCQxoWf0pEfyk6HeAgSsL+EFqDw3zKsj6hiAUAw RpZ4dI0oZ4Ul7q9uA3/qzxc/FuPE6H4Zp62SERwdqFtqFjsEs2qJLG67YLGY/yizQAka GsdWiKSfiewr3B6+api6Wr6hrm7aOVUsH9i063NuKe2IRzB94XwAlPpxnQAwxzaWVTVX 3+rA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=EKyWMGof; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id w17-20020a1709067c9100b0098e2aa0bb92si13575182ejo.137.2023.07.17.08.30.19; Mon, 17 Jul 2023 08:30:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=EKyWMGof; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230421AbjGQPE5 (ORCPT + 99 others); Mon, 17 Jul 2023 11:04:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43678 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230019AbjGQPEz (ORCPT ); Mon, 17 Jul 2023 11:04:55 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 02276E7F; Mon, 17 Jul 2023 08:04:55 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 952E26105C; Mon, 17 Jul 2023 15:04:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7C921C433C8; Mon, 17 Jul 2023 15:04:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1689606294; bh=kRV/xSf86iTldaNK/Wk2zNVVTiDcvdiI33s7jGOYRsM=; h=From:To:Cc:Subject:Date:From; b=EKyWMGofhVGHC07otPIzcKxMQP9WkSc0w09sua0P48+YuirRmJ9+cumJ+PYMUZZq6 Fmrg2Uhqv8vo79m9hav8qbQTKKilWJNCOo3DmGYEfxybMb/aIsYo+3eVzpJ/BHFI6R 9/pKQe75PGK6U7bF+of2BeS/U4in0wIupcYlqX7/dnIDfpS1jyGkCgjUmuNUu34nrO i2QZDIQFGiWGX9QySp2w5ngK86PKv3jU6rr4Vx8WoBUrKCLfMjqHlKBVmVbWumM6jF uIBvHkkLShoM54a9k3A3Pht4DHOFTjiMVrBD8swttw1Rt5t04BINnTJi/uSqdl5qV0 hfTisV50GKvkQ== Received: (nullmailer pid 1750720 invoked by uid 1000); Mon, 17 Jul 2023 15:04:52 -0000 From: Rob Herring To: Nipun Gupta , Nikhil Agarwal , Greg Kroah-Hartman Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] cdx: Explicitly include correct DT includes Date: Mon, 17 Jul 2023 09:03:55 -0600 Message-Id: <20230717150355.1749845-1-robh@kernel.org> X-Mailer: git-send-email 2.40.1 MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1771682234552549870 X-GMAIL-MSGID: 1771682234552549870 The DT of_device.h and of_platform.h date back to the separate of_platform_bus_type before it as merged into the regular platform bus. As part of that merge prepping Arm DT support 13 years ago, they "temporarily" include each other. They also include platform_device.h and of.h. As a result, there's a pretty much random mix of those include files used throughout the tree. In order to detangle these headers and replace the implicit includes with struct declarations, users need to explicitly include the correct includes. Signed-off-by: Rob Herring Acked-by: Nipun Gupta --- Note that drivers/cdx/ is missing a MAINTAINERS entry. Please add one. drivers/cdx/controller/cdx_controller.c | 3 ++- drivers/cdx/controller/cdx_rpmsg.c | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/cdx/controller/cdx_controller.c b/drivers/cdx/controller/cdx_controller.c index dc52f95f8978..bb4ae7970e21 100644 --- a/drivers/cdx/controller/cdx_controller.c +++ b/drivers/cdx/controller/cdx_controller.c @@ -5,7 +5,8 @@ * Copyright (C) 2022-2023, Advanced Micro Devices, Inc. */ -#include +#include +#include #include #include diff --git a/drivers/cdx/controller/cdx_rpmsg.c b/drivers/cdx/controller/cdx_rpmsg.c index f37e639d6ce3..04b578a0be17 100644 --- a/drivers/cdx/controller/cdx_rpmsg.c +++ b/drivers/cdx/controller/cdx_rpmsg.c @@ -7,7 +7,8 @@ #include #include -#include +#include +#include #include #include