From patchwork Mon Jul 17 14:18:44 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 121374 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:c923:0:b0:3e4:2afc:c1 with SMTP id j3csp1152709vqt; Mon, 17 Jul 2023 07:38:32 -0700 (PDT) X-Google-Smtp-Source: APBJJlH33xZY7mMCdhZiZg9jF1nG2ijze/belcQn5zvEHxel5jBoDsep8Fospy1msYEX1ul1pf0R X-Received: by 2002:a05:6512:368e:b0:4fd:b223:92c with SMTP id d14-20020a056512368e00b004fdb223092cmr3587840lfs.60.1689604711759; Mon, 17 Jul 2023 07:38:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689604711; cv=none; d=google.com; s=arc-20160816; b=p0ss7z+Mg7wPkhTRHyj4/k3DdUL9Xjt3zvgDGEZNZtSk18kxw6pYWfbnInd5XTHvUm JKWuvIZOb9hF2yIPb03mZ9EXUBAWvQkB/Y+0f2NHK2scaaeGjK/X0QalPxlSsa7CXruI 5SfaciqnYYOsnzIKBz+u7bjtYix0j3M7JztOdoYkc2IYeRum0dUb71bfv4HTlmYtjisD yz0RDrhxa+sBJNQgVw4GcO4TtxCrZK2jvj4iBMQd2bvPsxwvMTO2yIOFe5KGBpsKdwfy OdtGakjOrr32lMMLsJi3a3WdY5CJgbY9SHnCQq6iRIwdawh0r9R1xKgTIC35wR6Uobkz E4KQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=p2QBN2EvxPUX9YaGGwCQYR9CYTTQX1TRNFIqJ2M2JN4=; fh=6N+JAM4FebgFIxXJ2DQRFCuSPB1doca09wKKbmSYZwg=; b=SlE4yqt61XAqykHa11alH/nUiYrmhefVOn/LolVloJu+WiRNWLSDjnocibzgaKb81m K4cVIauNHQDdK+RnDtNZSj64RU4eU4L8c/9L3kllHx4Or1xN3vBSY9FY9ALXjoHt4/mf BJGvflFF/w5KKN6JyLx8yKtjEKGU8XCcketsckYNKrivoEKhxFTvCkLF/uPau9qe+BGN NcXOVJSYNfczLbddqGC1oI3zp6rlp+2aoKJhS82HwbInwgEtm+XfYOBmS66MPKG8rQHC VQGLoKrlDPqm4uODCVW9C4MlBDUefKbEa+9gchWUjTVPpcVtLqDgS0jitpRjEkMai48Z JwZw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=VIecBbYv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i4-20020aa7c704000000b0051beec1b3f3si14336230edq.500.2023.07.17.07.38.06; Mon, 17 Jul 2023 07:38:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=VIecBbYv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231320AbjGQOWC (ORCPT + 99 others); Mon, 17 Jul 2023 10:22:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48558 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229696AbjGQOVx (ORCPT ); Mon, 17 Jul 2023 10:21:53 -0400 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 32748C0; Mon, 17 Jul 2023 07:21:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1689603712; x=1721139712; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=dlya23t5w/DWoWEhF+Gie3H8fOznZfDlCPsSfPRQCYI=; b=VIecBbYvKcYA3ZFodDfWmFoq9VBd/dTkguVOiQKDzSYN6iVg3PG7BtzG ZLcXtFJQhw+gGmPsNQB7D+T/3UaRpuPFuLTE/8kMgGHxgHGq7v4dqzN2a TjuCm8uiUM2Cl+gB9U58N3DtbMsw+PundVjtFp72EJOpbqWFupZpJ+B7w qKXYk7AYySmTnYrZfzIS+210R2ICYtGFwNDn8lY11XAHRFkcFX4gV1t6Q cXvRC3hTgFQ1MzDU4QJKSIVR/M8ziwCxyYSpdv9lH38VS/HbpYutxxw8X lDexDQd2RT6F6FtpGKPMQn53ZFo/Ncp846l0CF2qL2I6ZRzqz87VUi1ss w==; X-IronPort-AV: E=McAfee;i="6600,9927,10774"; a="432112889" X-IronPort-AV: E=Sophos;i="6.01,211,1684825200"; d="scan'208";a="432112889" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Jul 2023 07:18:52 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10774"; a="717257683" X-IronPort-AV: E=Sophos;i="6.01,211,1684825200"; d="scan'208";a="717257683" Received: from black.fi.intel.com ([10.237.72.28]) by orsmga007.jf.intel.com with ESMTP; 17 Jul 2023 07:18:40 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id 2D0C024F; Mon, 17 Jul 2023 17:18:47 +0300 (EEST) From: Andy Shevchenko To: Bartosz Golaszewski , Andy Shevchenko , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Linus Walleij , Bartosz Golaszewski , Andy Shevchenko , Ray Jui , Broadcom internal kernel review list , Florian Fainelli , Scott Branden , Andrei Coardos , Alexandru Ardelean Subject: [PATCH v2 2/3] gpio: bcm-kona: remove unneeded platform_set_drvdata() call Date: Mon, 17 Jul 2023 17:18:44 +0300 Message-Id: <20230717141845.41415-2-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.40.0.1.gaa8946217a0b In-Reply-To: <20230717141845.41415-1-andriy.shevchenko@linux.intel.com> References: <20230717141845.41415-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1771678950027789776 X-GMAIL-MSGID: 1771678950027789776 From: Andrei Coardos The platform_set_drvdata() call was never used, ever since the driver was originally added. It looks like this copy+paste left-over. Possibly the author copied from a driver that had this line, but also had a remove hook. Reviewed-by: Alexandru Ardelean Signed-off-by: Andrei Coardos Signed-off-by: Andy Shevchenko --- v2: no changes drivers/gpio/gpio-bcm-kona.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpio/gpio-bcm-kona.c b/drivers/gpio/gpio-bcm-kona.c index 0aa7d710509d..9af1549ee0df 100644 --- a/drivers/gpio/gpio-bcm-kona.c +++ b/drivers/gpio/gpio-bcm-kona.c @@ -591,7 +591,6 @@ static int bcm_kona_gpio_probe(struct platform_device *pdev) return -ENOMEM; kona_gpio->pdev = pdev; - platform_set_drvdata(pdev, kona_gpio); chip->parent = dev; chip->ngpio = kona_gpio->num_bank * GPIO_PER_BANK;