From patchwork Wed Jul 19 15:17:06 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eric Van Hensbergen X-Patchwork-Id: 122690 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:c923:0:b0:3e4:2afc:c1 with SMTP id j3csp2522493vqt; Wed, 19 Jul 2023 08:36:33 -0700 (PDT) X-Google-Smtp-Source: APBJJlGDccgQ2Em4ShKzn2PfMpffbKzasVX0Nb7qKvj9pb4Mqyf0ST12pS55r1jFhDCBJa45ObxH X-Received: by 2002:a17:90b:19c3:b0:256:807e:6bd with SMTP id nm3-20020a17090b19c300b00256807e06bdmr16614251pjb.28.1689780993060; Wed, 19 Jul 2023 08:36:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689780993; cv=none; d=google.com; s=arc-20160816; b=dVk1PGpQ9xXmdXN4PBkXO/BaRxjbHBZhSoiMMMR2AySsqpsNpcTiZZLIJJvufb30Zk SZge7ID7fQL5Dz8gO9e+243053zhGG9hk9tNvC9A5WNdvqKJ0XuSYJZTBg0bvwjr6pWf KGTBgxwtajpqmatqyYbewA7cYQTsQEwaSi73RngfHkLPc27qQB2ln5dAYUpqmxKll+sU sH43Hd/7NxGQ8gctx3sTZDDjwUrOedE8qtnn4zicC2YxB6xtkHWuUGv7J4jUTb0cmWCS tOUUZHStXajspTZ8xNPuzMlbfEczasuRrvrNUzrXXLxvWAW/glZz+7vd0Aep4EYyzW0+ 8SMg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:message-id :content-transfer-encoding:mime-version:subject:date:from :dkim-signature; bh=fazTuyvtxaNF0knhegD+9qxwHojpihyBTl5I0Zyz0d8=; fh=deCyYo6QkFncNtSlW+COYKWV+QHrPm0qFhnqufnpqmk=; b=gtj/H/QNzhUCtpdBc46QpHTrZiIYXrCFjc3yXeyJRBAyAfcTwG5s1ZzaqNAyjlrIQH Vvl7vssJV/9otJZpV9pIPKr8dMujdYzORAOCevk7/WjGkFCyNCp32QB3zzIZBgNr+swH Rw+7Tpc2Iy5LA0KHGBdKCKdEFSDnsfm6ldj2AJ9TxsEKWrYApjxIh136Tiw5LEjGCVsY wQq04yLWVde0rJJ5DDYLijoq6SqiLx2njJuBmGYB22tblo5hVevW+IiE1IwNxU9CDRVQ j0k5KYq26DsY+ZgcpgJYoYnsdWh6eNra/UeJFu25E5HEkP4Ao6K1Pfcj5PDTthiXrKOn u1nQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="t/oe2DsB"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id a2-20020a17090ad80200b00259a3c7fb52si1529156pjv.27.2023.07.19.08.36.19; Wed, 19 Jul 2023 08:36:33 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="t/oe2DsB"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231533AbjGSPRe (ORCPT + 99 others); Wed, 19 Jul 2023 11:17:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54330 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231351AbjGSPRY (ORCPT ); Wed, 19 Jul 2023 11:17:24 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9833BBE; Wed, 19 Jul 2023 08:17:23 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 288A76173E; Wed, 19 Jul 2023 15:17:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 84DD4C433C8; Wed, 19 Jul 2023 15:17:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1689779842; bh=cdptwf+tCAM2+aWoAXX9cPeXcqVcV7F8UHRwJ0Ju4kw=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=t/oe2DsB04e2eegO989Vv0cqI+6ZK/iNawU1RvdIfkuDSQ6pCeymBGqCjMhkAdNd8 vUUNDzEGV6Pdt9GW6Os5Q0hNFGyaCDP3tJJ7EIqeHxQ1wclu0Sg9jWmW6Acqx7eKYe L+hVEr98EfnROW5I/GJBIp04UoymQZ6NKneQ4nlg+1SuoqTqo1URYaAoQb+g3z4/fq jnyy5aNv4G6uQC4ZLxd+OG2fawqUDtXAXAtYf33BQXZOaLsv/T+iGg/n5g8oQfPf9m TI3lBlDRwaubvCnZ0SwRGzImqW2wCh1WpRqoJJTv0IUVS0AqrSjjRfz4hA/k8HDCLy Q/a+AKWsCMQfw== From: Eric Van Hensbergen Date: Wed, 19 Jul 2023 15:17:06 +0000 Subject: [PATCH v3 2/4] fs/9p: fix typo in comparison logic for cache mode MIME-Version: 1.0 Message-Id: <20230716-fixes-overly-restrictive-mmap-v3-2-769791f474fd@kernel.org> References: <20230716-fixes-overly-restrictive-mmap-v3-0-769791f474fd@kernel.org> In-Reply-To: <20230716-fixes-overly-restrictive-mmap-v3-0-769791f474fd@kernel.org> To: Latchesar Ionkov , Dominique Martinet , Christian Schoenebeck Cc: v9fs@lists.linux.dev, linux-kernel@vger.kernel.org, kernel@pengutronix.de, stable@vger.kernel.org, Robert Schwebel , Eric Van Hensbergen X-Mailer: b4 0.12.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1068; i=ericvh@kernel.org; h=from:subject:message-id; bh=cdptwf+tCAM2+aWoAXX9cPeXcqVcV7F8UHRwJ0Ju4kw=; b=owEBbQKS/ZANAwAKAYj/1ftKX/+YAcsmYgBkt/5/HnwbXRdNIzUha4P+gQM2t1MHNIResSrWm bTMBQOwTuqJAjMEAAEKAB0WIQSWlvDRlqWQmKTK0VGI/9X7Sl//mAUCZLf+fwAKCRCI/9X7Sl// mEshD/43bFiL1TWaXPJYjtdnXsN4qkzvuLpslJVZnNOdR0dfKG4KEKO3/TYZYGt+SFSjm/6oZeh /VNFGu98+1QS5WT8+b1ezHW/hiyi22DyLyD9ohYP1Aoor9MijoDgu5YNlz/UetUSIu2+G5FjRqp K1PMamBX72Rp16AOrafjmoZM+onrZSwtQVQhjgDrRwBcM3IYSVT8IdvwSwUNQiDwcySi+AngtGq gA+3+GXEnjr2kAnLNF5PYeFbaO1z+Qsm0YcvZYn7WQi4ipCIvy5H8SZgpivpqLRnZSlgP6aMUs4 odkx+RibL0RhJ5IX+5wgby16UKrrwF/xONA9X/q6h2JGVEp9k5Rw+1mLjnxMfhpikCBV7uY8Ddd pmknhTFPko/zZHjbo21AdBBKrUewFvFV9VAReseKrmO1VlRvxvtifJ/EFKCU9gLz9wrIE4dQW6o rt6zVGgUj1vZNiJhhpBL2H7Ay+6P0c0N5smWYQFpBR8gkLxdcx098uOa7y6vsNjfKDVqmTUy77J tFgMwTSubsmTf1J1mPd43K7N0JnCabqjW0ZcXUwudu8bAPGlCi43qMw6frlFVOPjxqxCXJOC/JX IhNcXnrsc+2PgJgHVjjkkEKqk6WpzqziMHYNHJXAOgRY5vehDaIoDyQY3Dg9W7cRyvSxN1fFG/j FuashKVhN2c/19g== X-Developer-Key: i=ericvh@kernel.org; a=openpgp; fpr=9696F0D196A59098A4CAD15188FFD5FB4A5FFF98 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1771863794613982736 X-GMAIL-MSGID: 1771863794613982736 There appears to be a typo in the comparison statement for the logic which sets a file's cache mode based on mount flags. Fixes: 1543b4c5071c ("fs/9p: remove writeback fid and fix per-file modes") Link: https://lore.kernel.org/v9fs/ZK25XZ%2BGpR3KHIB%2F@pengutronix.de/ Reviewed-by: Christian Schoenebeck Reviewed-by: Dominique Martinet Signed-off-by: Eric Van Hensbergen --- fs/9p/fid.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/9p/fid.h b/fs/9p/fid.h index 0c51889a60b3..297c2c377e3d 100644 --- a/fs/9p/fid.h +++ b/fs/9p/fid.h @@ -57,7 +57,7 @@ static inline void v9fs_fid_add_modes(struct p9_fid *fid, int s_flags, (s_flags & V9FS_DIRECT_IO) || (f_flags & O_DIRECT)) { fid->mode |= P9L_DIRECT; /* no read or write cache */ } else if ((!(s_cache & CACHE_WRITEBACK)) || - (f_flags & O_DSYNC) | (s_flags & V9FS_SYNC)) { + (f_flags & O_DSYNC) || (s_flags & V9FS_SYNC)) { fid->mode |= P9L_NOWRITECACHE; } }