Message ID | 20230716-fixes-overly-restrictive-mmap-v2-4-147d6b93f699@kernel.org |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:c923:0:b0:3e4:2afc:c1 with SMTP id j3csp2018527vqt; Tue, 18 Jul 2023 14:26:14 -0700 (PDT) X-Google-Smtp-Source: APBJJlGgst2CgU9ImLNivEEuHlFzROjJ/oNUTQkh806GnSp2PbBly0pj9O+FR/mBG7FCP5WUPh/B X-Received: by 2002:aa7:d805:0:b0:51d:b89d:9818 with SMTP id v5-20020aa7d805000000b0051db89d9818mr817405edq.12.1689715574570; Tue, 18 Jul 2023 14:26:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689715574; cv=none; d=google.com; s=arc-20160816; b=GerQTe1+cqMJe/J6/Nt8i/iOv17MAMFQA/lWpc7LgViklifSq+LNlQ9GM5TRvVqXQP CPRWbC6i5X8IQL8zJB6C1B84dNXEhJRXIggSbYmKZ5QQk9GwiSeY0MAX/eJvoRUjR3Pp jtT2HVGYxVWsukqzNSqf2z+hMwJ1oID/jVFEqo8R3hd9sXT+iLACNbDI+4oM2+2a8amr BcUwwNAciEfD5bgD7HkLHXv+IK8TzNIfBulPkEuqKWF0KntbMP3+bGxCF4WNb5Kd2c3m uInuRWJAM8CYu9ZPgLb7HRBctosGYLjV72QSE6gWsktMFqoHoSt2J+DOQLZ4itBN011s y4Nw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:message-id :content-transfer-encoding:mime-version:subject:date:from :dkim-signature; bh=MRtIjLAEPTsIshmeCdj4+weqhzxCEUplfltP22NpV4Y=; fh=j3YVng1RRZ6+ldvc9lS8NG/D3Vm7wGIMCbG7LdLsfsQ=; b=DauOW4ciq0LpYeySc5SLekZRUMq67EvBPF8BbBi5Z1G79JaM1Lro9PNH4LcavWfo9A 69od8qzWbxf6neahO/o3yKnLiOSaK9NU5xwPRaMT2TzM/6jH9zGYZGp3UJXlvzC2pbYb TxvOzDp18NqLUYf5fMGHyBoMZ00A0RgsHboVibMcQraTGqtR24FUteyJDY73wTOguEO3 QqVsDQQTLSn6gLi+R2nYY3Ue6Oc4SbdnNEjNvPO6gzfbCJVUh+lQVAcfYDg7vAA/qqLl MgA/ur+P3LKQ8WyCNimUl5mGw6dF1MkclvcjyEglu6R/oeGmLrJFXAOENsJhridPBeSY 5JPA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=gQLfe2sZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id w1-20020a50fa81000000b0051df1fef473si1800175edr.549.2023.07.18.14.25.50; Tue, 18 Jul 2023 14:26:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=gQLfe2sZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230519AbjGRUug (ORCPT <rfc822;assdfgzxcv4@gmail.com> + 99 others); Tue, 18 Jul 2023 16:50:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52578 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230320AbjGRUu1 (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Tue, 18 Jul 2023 16:50:27 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 82D07C0 for <linux-kernel@vger.kernel.org>; Tue, 18 Jul 2023 13:50:26 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 21C3D60F7F for <linux-kernel@vger.kernel.org>; Tue, 18 Jul 2023 20:50:26 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BEACFC433CB; Tue, 18 Jul 2023 20:50:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1689713425; bh=scxEmsmSS3yAw8Pb9vs+lLcPVOwcbwDaNQFx5fsoDzg=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=gQLfe2sZU78/8tGyOQjHfsxtD3oQUv+Px5p2nKSG2zOFChi/ssTKr3JBCzye1qq+8 7VNbb0lJBrjlbHvzinxbFVOanGpdbgiFHSIpmwpcfz6sOowDLYcJFdexcC5UZQl2rc SIWcIec7RA+pcZhOZbMmxW1u/MvG+Q55kF3HcCJ4d2fWg+ORaLXnpXhqrJATV5Jpvc KfFkXep5yxpZYkcOYus1diAFXr7sFso2FEF81FqQIm89o1eGkiPbDOy+41kVGnGr5w peJolAYeeC7dwcwWHCBKcGrmv9x7qJfarLKKD29P63QWodHBhllrC+vUff5TJ5SVm8 HgB8WgpmNxWwg== From: Eric Van Hensbergen <ericvh@kernel.org> Date: Tue, 18 Jul 2023 20:50:18 +0000 Subject: [PATCH v2 4/4] fs/9p: remove unnecessary invalidate_inode_pages2 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20230716-fixes-overly-restrictive-mmap-v2-4-147d6b93f699@kernel.org> References: <20230716-fixes-overly-restrictive-mmap-v2-0-147d6b93f699@kernel.org> In-Reply-To: <20230716-fixes-overly-restrictive-mmap-v2-0-147d6b93f699@kernel.org> To: Latchesar Ionkov <lucho@ionkov.net>, Dominique Martinet <asmadeus@codewreck.org>, Christian Schoenebeck <linux_oss@crudebyte.com> Cc: v9fs@lists.linux.dev, linux-kernel@vger.kernel.org, kernel@pengutronix.de, Robert Schwebel <r.schwebel@pengutronix.de>, Eric Van Hensbergen <ericvh@kernel.org> X-Mailer: b4 0.12.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=634; i=ericvh@kernel.org; h=from:subject:message-id; bh=scxEmsmSS3yAw8Pb9vs+lLcPVOwcbwDaNQFx5fsoDzg=; b=owEBbQKS/ZANAwAKAYj/1ftKX/+YAcsmYgBktvsM6EaD3uQIChje/362palMFSayDgR3qaOWO dsMdF9cc6qJAjMEAAEKAB0WIQSWlvDRlqWQmKTK0VGI/9X7Sl//mAUCZLb7DAAKCRCI/9X7Sl// mLrFEACWjUV9pX/ivEzfBsAWNxyETtVIY4AVufEY6ephLHNpEIegrcmzupnJ+Jz7uFRLdTLMF7c 9GQPcjG9oq8tu7JxTsvRJd5dRRDunPi+caDam+5BmpVMVJ4JjJEoTyX/EwSylM7BX8zGcYtgcBc BOYOTznWqLKc7O6QGewfAl19EbsbZL8d6EFAo19p/LEo7sMR1Jy0u4c0/9gPniZ+3HDMZtz3Hs0 SXLwNi9gr06sAlxc2jBFyy7cgSbXWHzD/+Wp4WWsIqeL7h7jUHKfH6WYmsIbYi2fPMejghZeNsI IDyxbaHm4jSNYnLulLDuTK7JeO/03t1zyZryLh4UfVBeYSXSotY9HycOXQWjDGue0ScZddviXU4 hxV9+wq5j6Zn2AIpej8C07r5xQ1oNAYRG7xtmbETUYSDUQP+D5fTJHI4JWnZCbRZriNzbgW0TyF d6sh9ARoaoyUNabFuzxwobOkuS9w78MPfA7WNOfje2aGsul9v4YT497597CijRYqnRsnudf8Wsg ay0c2ME8h8RatfPVZV1GtmqrOTDf5ZzQdforHXTSl99X9VzlunbiDn3dJa50gVc27bOuQ7w6eHi m8jBvuxPu6Sb7gDTRshrje4uv32/pYL+0vwN17BLFnq6bYlMSmKqW2ejcx5MNQouF33jBJaX18e hUNzK/SW/afmSsg== X-Developer-Key: i=ericvh@kernel.org; a=openpgp; fpr=9696F0D196A59098A4CAD15188FFD5FB4A5FFF98 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1771795198324174378 X-GMAIL-MSGID: 1771795198324174378 |
Series |
fs/9p: fix mmap regression
|
|
Commit Message
Eric Van Hensbergen
July 18, 2023, 8:50 p.m. UTC
There was an invalidate_inode_pages2
added to mmap that is unnecessary.
Signed-off-by: Eric Van Hensbergen <ericvh@kernel.org>
---
fs/9p/vfs_file.c | 1 -
1 file changed, 1 deletion(-)
Comments
On Tuesday, July 18, 2023 10:50:18 PM CEST Eric Van Hensbergen wrote: > There was an invalidate_inode_pages2 > added to mmap that is unnecessary. > > Signed-off-by: Eric Van Hensbergen <ericvh@kernel.org> > --- Reviewed-by: Christian Schoenebeck <linux_oss@crudebyte.com> > fs/9p/vfs_file.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/fs/9p/vfs_file.c b/fs/9p/vfs_file.c > index bda3abd6646b8..3809f3a531499 100644 > --- a/fs/9p/vfs_file.c > +++ b/fs/9p/vfs_file.c > @@ -506,7 +506,6 @@ v9fs_file_mmap(struct file *filp, struct vm_area_struct *vma) > > if (!(v9ses->cache & CACHE_WRITEBACK)) { > p9_debug(P9_DEBUG_CACHE, "(no mmap mode)"); > - invalidate_inode_pages2(filp->f_mapping); > return generic_file_readonly_mmap(filp, vma); > } > > >
diff --git a/fs/9p/vfs_file.c b/fs/9p/vfs_file.c index bda3abd6646b8..3809f3a531499 100644 --- a/fs/9p/vfs_file.c +++ b/fs/9p/vfs_file.c @@ -506,7 +506,6 @@ v9fs_file_mmap(struct file *filp, struct vm_area_struct *vma) if (!(v9ses->cache & CACHE_WRITEBACK)) { p9_debug(P9_DEBUG_CACHE, "(no mmap mode)"); - invalidate_inode_pages2(filp->f_mapping); return generic_file_readonly_mmap(filp, vma); }