Message ID | 20230715185343.7193-7-tzimmermann@suse.de |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:c923:0:b0:3e4:2afc:c1 with SMTP id j3csp297563vqt; Sat, 15 Jul 2023 11:55:16 -0700 (PDT) X-Google-Smtp-Source: APBJJlEf8jpIYycE2ULY/MyDn3A2ZMGk+H4RAwXDBXlGf4OA9S5UFAr1n9zAAc+F67XNCCjlqEzb X-Received: by 2002:a17:903:2345:b0:1b5:5fd2:4d6e with SMTP id c5-20020a170903234500b001b55fd24d6emr10305496plh.58.1689447316434; Sat, 15 Jul 2023 11:55:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689447316; cv=none; d=google.com; s=arc-20160816; b=WVUk9umgMSpJTkBIF+s1dizVrAAnul9XyPVR+Vm/vNpjbWA6OJdL+0HnPziv6WQSXE ZZr48ooINqXLp2KC6DlxZOIIkRlUC/IZvRGriLsUdHeOQmZ3T65G5x4D8+vsi62fnMSK J2NJ7+9Pyv133ynlGdVaoYXPzp1XIb/pzPp28h6JHh5tU0HYws70hcC31BZ2Vu3Z1Xz5 BNi4Y6u+egYY+tBVlTFVFCTOOlvCOGV8yQGaR+7b9SrEfFka35BOWTKjv3BModHAp7xW ED4DbUXyyzAJZwBdRX0b+SvWAWwnxrLJiI8NuyJJBAzKeEouu3OAAc0MzwpioqRLnaOo AJ6w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature:dkim-signature; bh=fHWIv3bHRzrRKcyf/zVidbDkljZLPdxvWwq51ebKJX8=; fh=glXtVh1udAHSBzOrxSgVu4M7l1fHwKn8jl3vtcX/cV0=; b=bSHu8H3qJI7vrCi5M3LKfVgXUe700nFNK6DUI7RHG/sF3XVKJRkHNZwm8TFnjvmpW9 Ij3Bxi0gvovXUsLDPqq6Rqe+Wbc5rjJdN7W4A64ZjiTBZBQ4Qc+JgIsfrJsLyYPTD/Pn Y4aPFAtgc6tSccijJwkOUWgaMH+61WuKK9Axs6HwTgRSFIu4bNX/xYkgz2uBPWn8tTEy M2FYzREbR/7Hl4/tISvle1gRw6qaSA9QtT4Rq6OEJ8m2z6btKsaQWLebIB9QT0y3Ixr9 NurdqXkRfueo2pKeva95n+PI+BetpQ0r10FiG+vBOKqnecHjpoIGWclGdzjLoRuCJ63V dmTA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=Md5XmYzk; dkim=neutral (no key) header.i=@suse.de; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l6-20020a170903120600b001b9d5d4d75dsi9687041plh.112.2023.07.15.11.55.03; Sat, 15 Jul 2023 11:55:16 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=Md5XmYzk; dkim=neutral (no key) header.i=@suse.de; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231408AbjGOSyM (ORCPT <rfc822;daweilics@gmail.com> + 99 others); Sat, 15 Jul 2023 14:54:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50090 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230423AbjGOSx5 (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Sat, 15 Jul 2023 14:53:57 -0400 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D11E92D55; Sat, 15 Jul 2023 11:53:49 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 74AB51FD63; Sat, 15 Jul 2023 18:53:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1689447228; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fHWIv3bHRzrRKcyf/zVidbDkljZLPdxvWwq51ebKJX8=; b=Md5XmYzkPAU72bfn5tZ3LmGKbYdoHIvAEM3f9AYLz/VUB/cSsGWSfkf1agPsiDAZAoNXzx Scogw4aKsbgp4poY35d42V7pzr/dIsSRSgSGozb+y7mMxmA3DiHg4BMqw4iu2t2rJzl6xD GHblC7uej66xS61taBLrVaBcr/yEvK0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1689447228; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fHWIv3bHRzrRKcyf/zVidbDkljZLPdxvWwq51ebKJX8=; b=mN0NFMMwwN52Bn50PmBZuqYOaf4TMu9dSmO8298Nqylmi+ygkzkCYIrYN+Iri/baTeLx7i UjXr5OVPJ0DEy1Dw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 1426B13A23; Sat, 15 Jul 2023 18:53:48 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id cOYEBDzrsmQCBwAAMHmgww (envelope-from <tzimmermann@suse.de>); Sat, 15 Jul 2023 18:53:48 +0000 From: Thomas Zimmermann <tzimmermann@suse.de> To: deller@gmx.de, javierm@redhat.com, geert@linux-m68k.org, dan.carpenter@linaro.org Cc: linux-sh@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, linux-input@vger.kernel.org, linux-media@vger.kernel.org, linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-geode@lists.infradead.org, linux-hyperv@vger.kernel.org, linux-omap@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm@vger.kernel.org, Thomas Zimmermann <tzimmermann@suse.de>, Sam Ravnborg <sam@ravnborg.org>, Timur Tabi <timur@kernel.org> Subject: [PATCH v4 06/18] fbdev/fsl-diu-fb: Remove flag FBINFO_DEFAULT Date: Sat, 15 Jul 2023 20:51:48 +0200 Message-ID: <20230715185343.7193-7-tzimmermann@suse.de> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230715185343.7193-1-tzimmermann@suse.de> References: <20230715185343.7193-1-tzimmermann@suse.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1771513909283056822 X-GMAIL-MSGID: 1771513909283056822 |
Series |
fbdev: Remove FBINFO_DEFAULT and FBINFO_FLAG_DEFAULT flags
|
|
Commit Message
Thomas Zimmermann
July 15, 2023, 6:51 p.m. UTC
The flag FBINFO_DEFAULT is 0 and has no effect, as struct fbinfo.flags has been allocated to zero by dmam_alloc_coherent(__GFP_ZERO). So do not set it. Flags should signal differences from the default values. After cleaning up all occurrences of FBINFO_DEFAULT, the token will be removed. v2: * fix commit message (Miguel) Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> Acked-by: Sam Ravnborg <sam@ravnborg.org> Cc: Timur Tabi <timur@kernel.org> Cc: Helge Deller <deller@gmx.de> --- drivers/video/fbdev/fsl-diu-fb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/fbdev/fsl-diu-fb.c b/drivers/video/fbdev/fsl-diu-fb.c index 785eb8a06943..c62b48f27ba9 100644 --- a/drivers/video/fbdev/fsl-diu-fb.c +++ b/drivers/video/fbdev/fsl-diu-fb.c @@ -1476,7 +1476,7 @@ static int install_fb(struct fb_info *info) info->var.activate = FB_ACTIVATE_NOW; info->fbops = &fsl_diu_ops; - info->flags = FBINFO_DEFAULT | FBINFO_VIRTFB | FBINFO_PARTIAL_PAN_OK | + info->flags = FBINFO_VIRTFB | FBINFO_PARTIAL_PAN_OK | FBINFO_READS_FAST; info->pseudo_palette = mfbi->pseudo_palette;