Message ID | 20230714174946.4063995-1-robh@kernel.org |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:a6b2:0:b0:3e4:2afc:c1 with SMTP id c18csp2665829vqm; Fri, 14 Jul 2023 11:01:23 -0700 (PDT) X-Google-Smtp-Source: APBJJlEVGamrvJEKmizVXeLnvgL+qnc2ihjMfxvL0iglcSpZbmabV3nWdM4NTH1SO7TvdnUvTJYo X-Received: by 2002:a17:902:be0d:b0:1ac:a28e:4b29 with SMTP id r13-20020a170902be0d00b001aca28e4b29mr3949866pls.26.1689357683403; Fri, 14 Jul 2023 11:01:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689357683; cv=none; d=google.com; s=arc-20160816; b=ZbtsrCTQMJJ8IIYynEwUXpMHuRca+84IbNLBfTwrPZ9ql+fU+9cEwkHXjuzPWvOAcx XPqJh3cXY/R32JNL+J/155smvPzmoePaH3Q5en/s7qigba+nuYRK+NnauYqPswVKNOKv Bwcu/BKZ7lJUPIzDiG7FbyrAtziTPi9likZidV624T9XPXlpGkytwCr4FrqTuZc6q0It pE8BfN23LoRwSjVOWs5VJVL6TbF8GdiILzxjY1nEh29gCN9nmk8J4Dh0LPoxWlfXm0Oa 8Vg8BkI7XT7PpwRl5vbnU+JAaGMkUdEmki8LQFfume1SbFrixgbdfAUo70df9ueJKRX0 cJBg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=h1rucALi6oAv2chldSxXwAIScTfciNmzHu3E9+4nv0w=; fh=zQ47eXNdxe2C4wfKHJThHTKFLjcyz/hHfSYXD8o85GY=; b=JtNSOmd23EwPEvqMcQXMP/1YNEz9hEX2RpxjLZq/BKsZY9Ciw0Z5GgSjLrOjeKqf1z UHlvX9RZqW8NvriZi5KNUY3wPHTfgsslgAfG4+PaQCcx9X1T/0TCplaSlxoQAsxlFs/h olJUT3/A3iz99EPmYWNcvlXK1evAGmvBkxNzHiOO4Z2Vvcx/P5fLeYe8TSIYCUCzjqjD Jbf0FwI5NRZci8X3ER3GTYlAqbTDSl0u6SF1JjckiHWyX8Tqb33VZFZv2EEPSj3jW5GX SR932utSa6bShGn22/oXAa3EpcSb9JgIboF4qSj3MXL0yx9mSZbuENEzZKxm029f/2j8 NlIA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id p18-20020a170902ebd200b001b8698149fbsi7098748plg.477.2023.07.14.11.01.09; Fri, 14 Jul 2023 11:01:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236353AbjGNRwY (ORCPT <rfc822;daweilics@gmail.com> + 99 others); Fri, 14 Jul 2023 13:52:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39092 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235524AbjGNRwW (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Fri, 14 Jul 2023 13:52:22 -0400 Received: from mail-il1-f176.google.com (mail-il1-f176.google.com [209.85.166.176]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4AF0F173B; Fri, 14 Jul 2023 10:51:47 -0700 (PDT) Received: by mail-il1-f176.google.com with SMTP id e9e14a558f8ab-345fcf8951fso9673875ab.1; Fri, 14 Jul 2023 10:51:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689357022; x=1691949022; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=h1rucALi6oAv2chldSxXwAIScTfciNmzHu3E9+4nv0w=; b=ANZLQPrT9uP74q4HOgMjCHTOwfJtF54K8CfN5rM6Z3PgdCi4kyTHNqgR/9R+1RPZnN iwYXuODuhvo7Eu5kUhw9mVQDt4EtTkQEuoQtNHibveJBuQOT8eXS8qCOj6SRN8Xd3TbL I/064pZZxOSzro56qEaLNcDw6B5DgzEqPUUG8tDoLnqB7autIu1sHpbH7ZZ9gXwnWzXq 4r0icddM4euB/am5PWkJ6/d7LqhnGY3dgV9Y8xP5NewaShBBeyRwUU+cBEmtkDRcysbH SGxfmHbh4eiks6K08pNDhxdztTofTjEMmhXEk5UifWGXCtPdFLPcAiLzRwdX95Kjx/TY rDEg== X-Gm-Message-State: ABy/qLb3GNTZSwlcXCW12PoLcxLMBjytEVgSBuXpVnjICpe9l1zUUdLH uwY5eg/M+iNMkQ/TuNwZXw== X-Received: by 2002:a92:d28c:0:b0:346:420f:2bb7 with SMTP id p12-20020a92d28c000000b00346420f2bb7mr5771848ilp.16.1689357021983; Fri, 14 Jul 2023 10:50:21 -0700 (PDT) Received: from robh_at_kernel.org ([64.188.179.250]) by smtp.gmail.com with ESMTPSA id x8-20020a92dc48000000b0034607609251sm2874160ilq.87.2023.07.14.10.50.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Jul 2023 10:50:21 -0700 (PDT) Received: (nullmailer pid 4064131 invoked by uid 1000); Fri, 14 Jul 2023 17:49:52 -0000 From: Rob Herring <robh@kernel.org> To: Andy Gross <agross@kernel.org>, Bjorn Andersson <andersson@kernel.org>, Konrad Dybcio <konrad.dybcio@linaro.org>, Vinod Koul <vkoul@kernel.org>, Bard Liao <yung-chuan.liao@linux.intel.com>, Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>, Sanyog Kale <sanyog.r.kale@intel.com> Cc: devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: [PATCH] soundwire: Explicitly include correct DT includes Date: Fri, 14 Jul 2023 11:49:46 -0600 Message-Id: <20230714174946.4063995-1-robh@kernel.org> X-Mailer: git-send-email 2.40.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_00, FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1771419922508148842 X-GMAIL-MSGID: 1771419922508148842 |
Series |
soundwire: Explicitly include correct DT includes
|
|
Commit Message
Rob Herring
July 14, 2023, 5:49 p.m. UTC
The DT of_device.h and of_platform.h date back to the separate
of_platform_bus_type before it as merged into the regular platform bus.
As part of that merge prepping Arm DT support 13 years ago, they
"temporarily" include each other. They also include platform_device.h
and of.h. As a result, there's a pretty much random mix of those include
files used throughout the tree. In order to detangle these headers and
replace the implicit includes with struct declarations, users need to
explicitly include the correct includes.
Signed-off-by: Rob Herring <robh@kernel.org>
---
drivers/soundwire/qcom.c | 1 -
1 file changed, 1 deletion(-)
Comments
On Fri, 14 Jul 2023 11:49:46 -0600, Rob Herring wrote: > The DT of_device.h and of_platform.h date back to the separate > of_platform_bus_type before it as merged into the regular platform bus. > As part of that merge prepping Arm DT support 13 years ago, they > "temporarily" include each other. They also include platform_device.h > and of.h. As a result, there's a pretty much random mix of those include > files used throughout the tree. In order to detangle these headers and > replace the implicit includes with struct declarations, users need to > explicitly include the correct includes. > > [...] Applied, thanks! [1/1] soundwire: Explicitly include correct DT includes commit: 3f92da3ea4480648ebeb8a4802085908a5c64cee Best regards,
diff --git a/drivers/soundwire/qcom.c b/drivers/soundwire/qcom.c index 7970fdb27ba0..d178a0dc0918 100644 --- a/drivers/soundwire/qcom.c +++ b/drivers/soundwire/qcom.c @@ -10,7 +10,6 @@ #include <linux/debugfs.h> #include <linux/of.h> #include <linux/of_irq.h> -#include <linux/of_device.h> #include <linux/pm_runtime.h> #include <linux/regmap.h> #include <linux/reset.h>