Message ID | 20230714174600.4057041-1-robh@kernel.org |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:a6b2:0:b0:3e4:2afc:c1 with SMTP id c18csp2671919vqm; Fri, 14 Jul 2023 11:10:52 -0700 (PDT) X-Google-Smtp-Source: APBJJlE90jCtDY2lCFoIXEYtbz65ALCi6pOTFBJs4ngbMNsB0PaqJz0k8qgwVGa+mS21g6seIIuO X-Received: by 2002:a17:90a:6349:b0:25e:f696:1cf8 with SMTP id v9-20020a17090a634900b0025ef6961cf8mr4431720pjs.14.1689358252202; Fri, 14 Jul 2023 11:10:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689358252; cv=none; d=google.com; s=arc-20160816; b=AY3dOPXocUTr8ncZ946Sa0+lYMVw4CvAwgnjlT89r7cVZdSV4h8+VebM6yDc9zkP1l 74rRM31SGTtTF2fwSTg+djDwnjL8aMSIty77V/KDiyVFpIeZB15FKgLV+D9Sp471ebOc +jhcQkGf6gMPa0o+EK+YJygHtFydmbRqKmffTbD7a4MJzIZPi9Ck4rj/Q4bJEmvx9LY6 q/YYqLkx2kQhI4AawbqUSrAOMfJFQGWcVWGZ+SoiuSjkShjFYXddeGr5XrMUYJKduq1q ZFtaha+U5rvRE1QQchI7/r03E2E158lSPmZaHMxgskwgIdK64TjjRHopMiMHq3dYo4jo FBzw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=AD0GCzyHwk+fw3TWcRW0UAKm/GOePKzWL5Rq+E6gtqA=; fh=pLJlDwlUhOVsIFAIlkSo9v9qeHSnfKeyncyMAdgrVNM=; b=n0+3/+KEdtJsToGKdnYkvoQVanrGKvAFp2oLc0WkAl5g2WrO1nnhjxn0fLmIwZGo7h LaqChgWfxOEKdcOYlkjKM3ts/VhRFuoe7tCaZzrS1TCmk824Z+R8bfH03AX3buffxbD1 FTpxqDdRIAJHZVL2G+lPc1fFL+QKkgTDIAjGrOqsRwFDU2lbgf70X52aPyKwWackPOva GjfqMMvkdE1AbXSauj+vsyDNy8K2k46cDw5pvrqoKSfl8Ojgf04L7ZivKVPpw1smN2rL 75nFZZISh19XQFOIZHOkmo8WQfX7Q5j8RPSTpfW7zR52Qh1JRiyDAyLJugvTi8o8pSh0 IDPw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z8-20020a17090a8b8800b0025e9a3124c7si1562275pjn.143.2023.07.14.11.10.39; Fri, 14 Jul 2023 11:10:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234916AbjGNRrp (ORCPT <rfc822;daweilics@gmail.com> + 99 others); Fri, 14 Jul 2023 13:47:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34664 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236339AbjGNRrf (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Fri, 14 Jul 2023 13:47:35 -0400 Received: from mail-il1-f172.google.com (mail-il1-f172.google.com [209.85.166.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AAE863C22; Fri, 14 Jul 2023 10:47:12 -0700 (PDT) Received: by mail-il1-f172.google.com with SMTP id e9e14a558f8ab-34617b29276so8041585ab.0; Fri, 14 Jul 2023 10:47:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689356779; x=1691948779; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=AD0GCzyHwk+fw3TWcRW0UAKm/GOePKzWL5Rq+E6gtqA=; b=HQrAw6ViQ2VAF1n8xOzf0Eru8ihbzKVn3176kKoUY+EmowWvwx9kTFcqS8I/CfsfO5 JJXduJgOvAyn53B2W67rwSciaqq1hvIe16CshqRAK/BENjerudj1OLKwWPpP6HwuBGB1 rK1VYTdmkL4jYEwPWvOru3LezoIMUW2vMxVjG7lk4wImu4zBTc7+6emaYzAGORsg/eQh Vl9ntBKWJznh7Le2yFP9yQQHZQiSychY9BNKw5QLQB0k7Z0eeUyo7v7k09LLr7u+eNMx X1GRKDf31eoYSbNEig6TOIu3GL+NlAbwydGul8KIFFah9UlzE8UZa9NXb4seSkXAy+GY HcwQ== X-Gm-Message-State: ABy/qLaIw8+nIn2NdhlaOC/BWIDEVkhwxk+kL+6lmBdkOjlHVa06sezm taTbHJu3sVHMNJRhiKa9iQ== X-Received: by 2002:a05:6e02:e0e:b0:33e:51bf:727d with SMTP id a14-20020a056e020e0e00b0033e51bf727dmr2417113ilk.10.1689356779202; Fri, 14 Jul 2023 10:46:19 -0700 (PDT) Received: from robh_at_kernel.org ([64.188.179.250]) by smtp.gmail.com with ESMTPSA id j3-20020a02cc63000000b0042bb2448847sm2620708jaq.53.2023.07.14.10.46.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Jul 2023 10:46:18 -0700 (PDT) Received: (nullmailer pid 4057142 invoked by uid 1000); Fri, 14 Jul 2023 17:46:04 -0000 From: Rob Herring <robh@kernel.org> To: Dipen Patel <dipenp@nvidia.com>, Thierry Reding <thierry.reding@gmail.com>, Jonathan Hunter <jonathanh@nvidia.com> Cc: devicetree@vger.kernel.org, timestamp@lists.linux.dev, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] hte: Explicitly include correct DT includes Date: Fri, 14 Jul 2023 11:46:00 -0600 Message-Id: <20230714174600.4057041-1-robh@kernel.org> X-Mailer: git-send-email 2.40.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_00, FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1771420518870398076 X-GMAIL-MSGID: 1771420518870398076 |
Series |
hte: Explicitly include correct DT includes
|
|
Commit Message
Rob Herring
July 14, 2023, 5:46 p.m. UTC
The DT of_device.h and of_platform.h date back to the separate
of_platform_bus_type before it as merged into the regular platform bus.
As part of that merge prepping Arm DT support 13 years ago, they
"temporarily" include each other. They also include platform_device.h
and of.h. As a result, there's a pretty much random mix of those include
files used throughout the tree. In order to detangle these headers and
replace the implicit includes with struct declarations, users need to
explicitly include the correct includes.
Signed-off-by: Rob Herring <robh@kernel.org>
---
drivers/hte/hte-tegra194.c | 1 -
drivers/hte/hte.c | 2 +-
2 files changed, 1 insertion(+), 2 deletions(-)
Comments
On 7/14/23 10:46 AM, Rob Herring wrote: > The DT of_device.h and of_platform.h date back to the separate > of_platform_bus_type before it as merged into the regular platform bus. > As part of that merge prepping Arm DT support 13 years ago, they > "temporarily" include each other. They also include platform_device.h > and of.h. As a result, there's a pretty much random mix of those include > files used throughout the tree. In order to detangle these headers and > replace the implicit includes with struct declarations, users need to > explicitly include the correct includes. > > Signed-off-by: Rob Herring <robh@kernel.org> > --- > drivers/hte/hte-tegra194.c | 1 - > drivers/hte/hte.c | 2 +- > 2 files changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/hte/hte-tegra194.c b/drivers/hte/hte-tegra194.c > index 06ef349a2265..6fe6897047ac 100644 > --- a/drivers/hte/hte-tegra194.c > +++ b/drivers/hte/hte-tegra194.c > @@ -12,7 +12,6 @@ > #include <linux/stat.h> > #include <linux/interrupt.h> > #include <linux/of.h> > -#include <linux/of_device.h> > #include <linux/platform_device.h> > #include <linux/hte.h> > #include <linux/uaccess.h> > diff --git a/drivers/hte/hte.c b/drivers/hte/hte.c > index 67c15724ee78..598a716b7364 100644 > --- a/drivers/hte/hte.c > +++ b/drivers/hte/hte.c > @@ -10,12 +10,12 @@ > #include <linux/err.h> > #include <linux/slab.h> > #include <linux/of.h> > -#include <linux/of_device.h> > #include <linux/mutex.h> > #include <linux/uaccess.h> > #include <linux/hte.h> > #include <linux/delay.h> > #include <linux/debugfs.h> > +#include <linux/device.h> > > #define HTE_TS_NAME_LEN 10 > Acked-by: Dipen Patel <dipenp@nvidia.com>
diff --git a/drivers/hte/hte-tegra194.c b/drivers/hte/hte-tegra194.c index 06ef349a2265..6fe6897047ac 100644 --- a/drivers/hte/hte-tegra194.c +++ b/drivers/hte/hte-tegra194.c @@ -12,7 +12,6 @@ #include <linux/stat.h> #include <linux/interrupt.h> #include <linux/of.h> -#include <linux/of_device.h> #include <linux/platform_device.h> #include <linux/hte.h> #include <linux/uaccess.h> diff --git a/drivers/hte/hte.c b/drivers/hte/hte.c index 67c15724ee78..598a716b7364 100644 --- a/drivers/hte/hte.c +++ b/drivers/hte/hte.c @@ -10,12 +10,12 @@ #include <linux/err.h> #include <linux/slab.h> #include <linux/of.h> -#include <linux/of_device.h> #include <linux/mutex.h> #include <linux/uaccess.h> #include <linux/hte.h> #include <linux/delay.h> #include <linux/debugfs.h> +#include <linux/device.h> #define HTE_TS_NAME_LEN 10