From patchwork Fri Jul 14 09:17:47 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 120383 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:a6b2:0:b0:3e4:2afc:c1 with SMTP id c18csp2386237vqm; Fri, 14 Jul 2023 02:49:59 -0700 (PDT) X-Google-Smtp-Source: APBJJlEaKGnaQcEyDtSDsDIruf7rzWOfqk6yR+a+KgOBCmfqKl8bGvvBrK4R+fKh5vjTUhwsImN/ X-Received: by 2002:a67:fbd6:0:b0:443:880c:79e7 with SMTP id o22-20020a67fbd6000000b00443880c79e7mr2618107vsr.11.1689328199007; Fri, 14 Jul 2023 02:49:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689328198; cv=none; d=google.com; s=arc-20160816; b=rV5AieIUudb59w7wmgYbAE5XGeURHYJXXwHkFDrScGGYfHVXHyy0qrgK8sKr/la663 fnlYUKyUq0gIFurvUeMlG7GwHkJCYnCXXy31xZc6wDFuw2jwDNkM63Pp03z/JoaNyoVW uD0nL3R9vWnxqQqbxXE+DgPUet+EQG6GPiDZEKWY0JSd9k9WYZJSTgtengoKkJZuAeNq YHozvdQ/1q/VLjgzqbtw8JqYhcMVFNK46vvH0nRLvVhgoW5Ds+CcGXHJiJNufJTu1cXw Ezl0ZtK0E+h4WVlcI5N90ZrQZuJvR1ojbd0DxQmtfDf/A7OoKsnQZEBJZlHf6PgyFdDk KSbw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=JRs7OFl29U1R19xdsi4P9oTz8VD2dpwKgvXMesSZdRE=; fh=Qdz9kbAdPAfvhj/swQYvX2BMbB6C1mb3M8cD7Q9tvzc=; b=m5jCok+iH07bVeGRJKwEEC7UNQr8g2gAZFyyWL0GQMdTn7ZSjF5WsqpHBOTTGrZ0Md pbWqLSb1Z2EPhFYR1zRgI74JVlz/lzUanpccJD8nSscyCL7/0U0pCCbGp5boQtN1b3ln p5LAi+0OnzTvDoQrh/94NqdnrCmYnrWXTHFXxHcF1mpnKQtjwt/n++1K3rWZS7heijwf FBzOjfiEdFz8HtaWAZq34RYOBR+VpUk7RrcEOMI0KYgrCjzfOAoNFOvUs2hfmNVs+bx6 Kop2ZQElBhfF1Mvaf7n8AytBl1OXRgWVjepg+12kkD3Ns90Lt3sMnnLOVMMl0lgijlaI dy0w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=L8LfPZ4w; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e9-20020a636909000000b0055337ca9ce9si6483685pgc.248.2023.07.14.02.49.46; Fri, 14 Jul 2023 02:49:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=L8LfPZ4w; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235775AbjGNJSU (ORCPT + 99 others); Fri, 14 Jul 2023 05:18:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47318 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231415AbjGNJSS (ORCPT ); Fri, 14 Jul 2023 05:18:18 -0400 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DC6682D77; Fri, 14 Jul 2023 02:18:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1689326289; x=1720862289; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=H0rPHJ2jq2GzhHsonePV+vqX4ZEBf1cEpTQE3p6vSwE=; b=L8LfPZ4wD2c2davDQGqrFRU8kVeBWQtGLMOkPb0XmugTaWUT3QaWfrMk bDG5B2IiXDf8pHuL2TV1UAEvdOymhfvvtMwvCdV3w1IDMsPnogqcgrt2s MuYKaHZxSiGFMiXTn95WrgVSSr+x5IdIAVDwPjFygguDno8arnqS/46Gu GjtAfAXhZh4EUWWjG6J+OzHnGQzJmgidsTXPKxYxoKa2v53AM3a6LPY3/ Dw4vmBPExw5trK5mo3fvPTo1BemrN8VGbgF0Ki4k1bMETXZ6pJaRJnFoR JckdNAJzrdoB6HzrNSWScmMjQsIya2x5t/vtKckBGIgO/BS/DlYNA3Flo Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10770"; a="365469003" X-IronPort-AV: E=Sophos;i="6.01,204,1684825200"; d="scan'208";a="365469003" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Jul 2023 02:17:46 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10770"; a="716281744" X-IronPort-AV: E=Sophos;i="6.01,204,1684825200"; d="scan'208";a="716281744" Received: from black.fi.intel.com ([10.237.72.28]) by orsmga007.jf.intel.com with ESMTP; 14 Jul 2023 02:17:44 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id A652C4BD; Fri, 14 Jul 2023 12:17:50 +0300 (EEST) From: Andy Shevchenko To: Mark Brown , Andy Shevchenko , linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Sebastian Reichel Subject: [PATCH v4 3/4] spi: Use BITS_TO_BYTES() Date: Fri, 14 Jul 2023 12:17:47 +0300 Message-Id: <20230714091748.89681-4-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.40.0.1.gaa8946217a0b In-Reply-To: <20230714091748.89681-1-andriy.shevchenko@linux.intel.com> References: <20230714091748.89681-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1771389005411259879 X-GMAIL-MSGID: 1771389005411259879 BITS_TO_BYTES() is the existing macro which takes care about full bytes that may fully hold the given amount of bits. Use it. Signed-off-by: Andy Shevchenko --- drivers/spi/spi.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c index 05f702339182..8d6304cb061e 100644 --- a/drivers/spi/spi.c +++ b/drivers/spi/spi.c @@ -3877,11 +3877,9 @@ static int __spi_validate(struct spi_device *spi, struct spi_message *message) */ if ((spi->mode & SPI_CS_WORD) && (!(ctlr->mode_bits & SPI_CS_WORD) || spi_get_csgpiod(spi, 0))) { - size_t maxsize; + size_t maxsize = BITS_TO_BYTES(spi->bits_per_word); int ret; - maxsize = (spi->bits_per_word + 7) / 8; - /* spi_split_transfers_maxsize() requires message->spi */ message->spi = spi;