From patchwork Fri Jul 14 07:49:39 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Zimmermann X-Patchwork-Id: 120311 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:a6b2:0:b0:3e4:2afc:c1 with SMTP id c18csp2345830vqm; Fri, 14 Jul 2023 01:05:44 -0700 (PDT) X-Google-Smtp-Source: APBJJlGW4HOeA9NRMi6xlsipxySo9anVX849TY9EN6Kj8MsIy3/guhgmX9tFjXGDVHAoEtac+HX5 X-Received: by 2002:a05:6870:4396:b0:1b7:5f27:5c52 with SMTP id r22-20020a056870439600b001b75f275c52mr5026333oah.2.1689321943889; Fri, 14 Jul 2023 01:05:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689321943; cv=none; d=google.com; s=arc-20160816; b=S6+F8DkSXXh1Zh4v3aaU+aDLL98YVoN3Ft8ta19pkkduYSgylpNrVM4Fj0P0r3YAJj 0hAIaGm69bDwrARzJNUvkIL1TQl1X7aIAhGBDRRelw9o2LFEjqpQpxiGx4/+IJw5gjOb wBzOInsz7b97Vl+IFtZU25wNOIe3rsx4NDl+aPMicbMZ+USKCK4+zDGkFZtDUVJiJs0C RwD5BCUJKrMoIKosgUr0QgbZmNnbqI5j6Z3S77VQdpXoSZStvfGGk91trjtqD5cSDexQ K915haLsk1GxcTcO2WOJswIT0fvs0ykO25kkE0c1JYBN7rQJJVWZKkQwaSS7tEymJXse 4zKw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature:dkim-signature; bh=8SrYfuYp2Zej0wYpXum9GiB3XZhSVLAFxOB80dQcWiA=; fh=mvKkI/feN5uBvMvLKron+TT82pNBp6fnqUuM2n/jviQ=; b=T4yF19PnzfF3XvKhqYTqXnVqZCB9bTyMvT+8F3ci2Y+NRrgteozfIFeR5qKfDeap0W 6X3pFOr0jB7TJIwM1TaWbRCPrdRoVIGh75oiZY3C9R+lkFck8pCx7dpIkGFGHiCW7UMk NcJF/Y+slLxw/fG/1Ydaze4sYIUn2BTk456wMP4xawSzPEFlgqTSovG39Xf3WFT2r0si qKLBEb4OI5FK7LeyQpprP4xcIoJnkwwVqHGlN+MQdK4U1Qo+9LLUPV3J+p35g2zH2cJd ZNDe98N+uTt4VPVLxK9zP44qS3VnA3dtPNo78bzozDRSVNmgqAh/aORMZNMbhjK2XiR/ RecA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=vX09X1Rk; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519 header.b=Ntt+CCUt; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l64-20020a638843000000b0055c875bed32si2785421pgd.706.2023.07.14.01.05.31; Fri, 14 Jul 2023 01:05:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=vX09X1Rk; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519 header.b=Ntt+CCUt; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235699AbjGNHw0 (ORCPT + 99 others); Fri, 14 Jul 2023 03:52:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45884 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235537AbjGNHwG (ORCPT ); Fri, 14 Jul 2023 03:52:06 -0400 Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A267730F4; Fri, 14 Jul 2023 00:52:03 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 626D02215F; Fri, 14 Jul 2023 07:52:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1689321122; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8SrYfuYp2Zej0wYpXum9GiB3XZhSVLAFxOB80dQcWiA=; b=vX09X1Rk9IJ0SVYZLWISuMwW68/mjTDUM1z4Ts9/xT/CsG1vzvLpIlzeifJoCO+kwp/GyU vPTnCh5ekRNWcYclsZj1wF6/8Wb+hf4AwcHtObvan5bDEcwK8veYEqW99ie0TUol4uG8UG W91ne63a3qDYnWtrNnx3kZ2JWYXqhX8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1689321122; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8SrYfuYp2Zej0wYpXum9GiB3XZhSVLAFxOB80dQcWiA=; b=Ntt+CCUtu+0A8DDmXsVVyaT0JAyRqgwl8rpzgyJxkB4ppT8aG+L/wqi6v9RQsPtpiJDCZE WpQb3HxoNFddh5Ag== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 1332313A92; Fri, 14 Jul 2023 07:52:02 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id aOPiA6L+sGQCQwAAMHmgww (envelope-from ); Fri, 14 Jul 2023 07:52:02 +0000 From: Thomas Zimmermann To: deller@gmx.de, javierm@redhat.com Cc: linux-sh@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, linux-input@vger.kernel.org, linux-media@vger.kernel.org, linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-geode@lists.infradead.org, linux-nvidia@lists.surfsouth.com, linux-hyperv@vger.kernel.org, linux-omap@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm@vger.kernel.org, Thomas Zimmermann , Sam Ravnborg Subject: [PATCH v3 13/18] fbdev: Remove flag FBINFO_FLAG_DEFAULT from fbdev drivers Date: Fri, 14 Jul 2023 09:49:39 +0200 Message-ID: <20230714075155.5686-14-tzimmermann@suse.de> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230714075155.5686-1-tzimmermann@suse.de> References: <20230714075155.5686-1-tzimmermann@suse.de> MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1771382446736775710 X-GMAIL-MSGID: 1771382446736775710 The flag FBINFO_FLAG_DEFAULT is 0 and has no effect, as struct fbinfo.flags has been allocated to zero by kzalloc(). So do not set it. Flags should signal differences from the default values. After cleaning up all occurrences of FBINFO_DEFAULT, the token will be removed. v2: * fix commit message (Miguel) Signed-off-by: Thomas Zimmermann Acked-by: Sam Ravnborg Cc: Helge Deller --- drivers/video/fbdev/amba-clcd.c | 1 - drivers/video/fbdev/matrox/matroxfb_crtc2.c | 5 ++--- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/video/fbdev/amba-clcd.c b/drivers/video/fbdev/amba-clcd.c index e45338227be6..24d89e6fb780 100644 --- a/drivers/video/fbdev/amba-clcd.c +++ b/drivers/video/fbdev/amba-clcd.c @@ -461,7 +461,6 @@ static int clcdfb_register(struct clcd_fb *fb) } fb->fb.fbops = &clcdfb_ops; - fb->fb.flags = FBINFO_FLAG_DEFAULT; fb->fb.pseudo_palette = fb->cmap; strncpy(fb->fb.fix.id, clcd_name, sizeof(fb->fb.fix.id)); diff --git a/drivers/video/fbdev/matrox/matroxfb_crtc2.c b/drivers/video/fbdev/matrox/matroxfb_crtc2.c index 7655afa3fd50..372197c124de 100644 --- a/drivers/video/fbdev/matrox/matroxfb_crtc2.c +++ b/drivers/video/fbdev/matrox/matroxfb_crtc2.c @@ -603,9 +603,8 @@ static int matroxfb_dh_regit(const struct matrox_fb_info *minfo, void* oldcrtc2; m2info->fbcon.fbops = &matroxfb_dh_ops; - m2info->fbcon.flags = FBINFO_FLAG_DEFAULT; - m2info->fbcon.flags |= FBINFO_HWACCEL_XPAN | - FBINFO_HWACCEL_YPAN; + m2info->fbcon.flags = FBINFO_HWACCEL_XPAN | + FBINFO_HWACCEL_YPAN; m2info->fbcon.pseudo_palette = m2info->cmap; fb_alloc_cmap(&m2info->fbcon.cmap, 256, 1);