diff mbox series

lib/test_meminit: Allocate pages up to order MAX_ORDER

Message ID 20230714015238.47931-1-ajd@linux.ibm.com
State New
Headers
Series lib/test_meminit: Allocate pages up to order MAX_ORDER |

Commit Message

Andrew Donnellan July 14, 2023, 1:52 a.m. UTC 
  test_pages() tests the page allocator by calling alloc_pages() with
different orders up to order 10.

However, different architectures and platforms support different maximum
contiguous allocation sizes. The default maximum allocation order
(MAX_ORDER) is 10, but architectures can use CONFIG_ARCH_FORCE_MAX_ORDER
to override this. On platforms where this is less than 10, test_meminit()
will blow up with a WARN(). This is expected, so let's not do that.

Replace the hardcoded "10" with the MAX_ORDER macro so that we test
allocations up to the expected platform limit.

Fixes: 5015a300a522 ("lib: introduce test_meminit module")
Signed-off-by: Andrew Donnellan <ajd@linux.ibm.com>
---
 lib/test_meminit.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Alexander Potapenko July 14, 2023, 12:09 p.m. UTC | #1 
On Fri, Jul 14, 2023 at 3:53 AM Andrew Donnellan <ajd@linux.ibm.com> wrote:
>
> test_pages() tests the page allocator by calling alloc_pages() with
> different orders up to order 10.
>
> However, different architectures and platforms support different maximum
> contiguous allocation sizes. The default maximum allocation order
> (MAX_ORDER) is 10, but architectures can use CONFIG_ARCH_FORCE_MAX_ORDER
> to override this. On platforms where this is less than 10, test_meminit()
> will blow up with a WARN(). This is expected, so let's not do that.
>
> Replace the hardcoded "10" with the MAX_ORDER macro so that we test
> allocations up to the expected platform limit.
>
> Fixes: 5015a300a522 ("lib: introduce test_meminit module")
> Signed-off-by: Andrew Donnellan <ajd@linux.ibm.com>
Reviewed-by: Alexander Potapenko <glider@google.com>
diff mbox series

Patch

diff --git a/lib/test_meminit.c b/lib/test_meminit.c
index 60e1984c060f..0ae35223d773 100644
--- a/lib/test_meminit.c
+++ b/lib/test_meminit.c
@@ -93,7 +93,7 @@  static int __init test_pages(int *total_failures)
 	int failures = 0, num_tests = 0;
 	int i;
 
-	for (i = 0; i < 10; i++)
+	for (i = 0; i <= MAX_ORDER; i++)
 		num_tests += do_alloc_pages_order(i, &failures);
 
 	REPORT_FAILURES_IN_FN();