From patchwork Fri Jul 14 01:37:54 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Sebastian Reichel X-Patchwork-Id: 120176 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:a6b2:0:b0:3e4:2afc:c1 with SMTP id c18csp2211853vqm; Thu, 13 Jul 2023 18:57:42 -0700 (PDT) X-Google-Smtp-Source: APBJJlF/xBIfgp3pkOtmiYviq2UaMGVCfh8P7KaLM1Jhyd52XMxBuUgkcnNDItODsc4YZdZIscDX X-Received: by 2002:a17:906:7a45:b0:98c:eef2:d0bc with SMTP id i5-20020a1709067a4500b0098ceef2d0bcmr2982950ejo.12.1689299862284; Thu, 13 Jul 2023 18:57:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689299862; cv=none; d=google.com; s=arc-20160816; b=Y8qEmGl+3B6mrwMRTO6y7AY3xbN6AhyqfME3XrERFBQbH2erPwD9nBUBlFiFsJGxUf NQEBF7I9Flwi44sIjRW9KYhviYM3HDq+AWFp/4SFuUYMeGDMjApTUl9usktwPjEQtMKX 5j1aJvzBvQ1FCHHp6MxXKFtSzqrM6ZNtXO66rps0W9Qs8jBrZaokoU8qf4WXIl846ZGs 8ugFCSiJcqf8177qtURCM4u2dU/ijd/dUxaRtSKdBeZ1iUpuqkl/je1ZCLg2oarM5mAv PT0+We0Fl53ow7ChAnbpRV4DBjhERr5bQZ99SrMyVwqhbmCQW6oZiu0sHdjJ2xAWe3xU IgxA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=FqwkOkpgalGn+PCX8TxsVL7y/E7Z0eJGiGrJJrTcMcM=; fh=wwBPu85TPXIK4FLncOwNybaDiJKO1Kxi3dU/u1PDfbo=; b=LWwJIn1asG5ku1ex/dlwqqoiVQ4VDfnE4h8XyLWOHvcsWAyZml5h6B6xk1Nrc5+JWT vbttUDVi/T7b3EoUrKR2xBKlSNP6bCAZsUNf9GJ643UNQE7ERG7PSBfC8S2IPdu0vSeV FIFST8Povy/x4uqQTC46gpMnBtwxyTo31jjDBUnIYIwayaFiLki4timohA2eCtyho67M HeJhuvxXfhDLv7OIPxe8jO9y7ExDpBQC+UmRGt81geFggTFbo7hC+aItAdLTRcjknvg8 MFAQ2UnglPL0QbGMPxmyf9ED/8fgJjO5HoM+ik4rqWNvJXGiLw/wMywN9+CLAmM8fTgU B5hw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=NplkxFIi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id m9-20020a170906160900b00993949aad30si822037ejd.37.2023.07.13.18.57.19; Thu, 13 Jul 2023 18:57:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=NplkxFIi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234748AbjGNBi4 (ORCPT + 99 others); Thu, 13 Jul 2023 21:38:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58748 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234143AbjGNBiO (ORCPT ); Thu, 13 Jul 2023 21:38:14 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9A3D930C5; Thu, 13 Jul 2023 18:38:08 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id CC34061BD4; Fri, 14 Jul 2023 01:38:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 10100C433BB; Fri, 14 Jul 2023 01:38:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1689298687; bh=JwVyMf+LI5609rJcs4u5/6p3F2Fz4dr3IzHJqqJME3Q=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=NplkxFIiKaYucIJGPbFI00OchcTXnSS7ITA+imWxJl72VlrHqufd12GBOOKjFvoG7 oQgonSo7UCsFFiF6KwB2ydLTBxVlRzLfOs/g2oKkWds4L+rM/JKJKv+5pfXBdzY6Pc bKPpqkhktjUAvsKI6Sm3UVZkI5QaQRmkXUl/WGSzqDhfUpJD2l5FToFbYdmctrSPbL xE50P+kvcp/RhJSIEZlJmQYVcJyPI6z6P+XJd2jZIOPLwfTVtGSHbfQxcOL765prej a193TKMDTTtQKMb2o30dkmbicH4WecnNNhK1LCs2+THFoRT6UuV5lFiTXVdew1e6bK hMSAWifK9B9KA== Received: by mercury (Postfix, from userid 1000) id 01D3910676F9; Fri, 14 Jul 2023 03:37:59 +0200 (CEST) From: Sebastian Reichel To: Sebastian Reichel Cc: Gerald Loacker , Michael Riesch , Miquel Raynal , Thierry Reding , Sam Ravnborg , David Airlie , Daniel Vetter , Rob Herring , Krzysztof Kozlowski , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, Maxime Ripard Subject: [PATCH v3 17/19] drm/panel: sitronix-st7789v: Clarify a definition Date: Fri, 14 Jul 2023 03:37:54 +0200 Message-Id: <20230714013756.1546769-18-sre@kernel.org> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230714013756.1546769-1-sre@kernel.org> References: <20230714013756.1546769-1-sre@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1771359292557605599 X-GMAIL-MSGID: 1771359292557605599 From: Miquel Raynal The Sitronix datasheet explains BIT(1) of the RGBCTRL register as the DOTCLK/PCLK edge used to sample the data lines: “0” The data is input on the positive edge of DOTCLK “1” The data is input on the negative edge of DOTCLK IOW, this bit implies a falling edge and not a high state. Correct the definition to ease the comparison with the datasheet. Signed-off-by: Miquel Raynal Acked-by: Maxime Ripard Reviewed-by: Sebastian Reichel Tested-by: Sebastian Reichel Signed-off-by: Sebastian Reichel --- drivers/gpu/drm/panel/panel-sitronix-st7789v.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-sitronix-st7789v.c b/drivers/gpu/drm/panel/panel-sitronix-st7789v.c index 33bdf9ee4085..3d24690e891b 100644 --- a/drivers/gpu/drm/panel/panel-sitronix-st7789v.c +++ b/drivers/gpu/drm/panel/panel-sitronix-st7789v.c @@ -27,7 +27,7 @@ #define ST7789V_RGBCTRL_RCM(n) (((n) & 3) << 5) #define ST7789V_RGBCTRL_VSYNC_HIGH BIT(3) #define ST7789V_RGBCTRL_HSYNC_HIGH BIT(2) -#define ST7789V_RGBCTRL_PCLK_HIGH BIT(1) +#define ST7789V_RGBCTRL_PCLK_FALLING BIT(1) #define ST7789V_RGBCTRL_DE_LOW BIT(0) #define ST7789V_RGBCTRL_VBP(n) ((n) & 0x7f) #define ST7789V_RGBCTRL_HBP(n) ((n) & 0x1f) @@ -259,7 +259,7 @@ static int st7789v_prepare(struct drm_panel *panel) if (ctx->info->mode->flags & DRM_MODE_FLAG_PHSYNC) polarity |= ST7789V_RGBCTRL_HSYNC_HIGH; if (ctx->info->bus_flags & DRM_BUS_FLAG_PIXDATA_SAMPLE_NEGEDGE) - polarity |= ST7789V_RGBCTRL_PCLK_HIGH; + polarity |= ST7789V_RGBCTRL_PCLK_FALLING; if (ctx->info->bus_flags & DRM_BUS_FLAG_DE_LOW) polarity |= ST7789V_RGBCTRL_DE_LOW;