[docs] docs: maintainers: mention tag -s for signed tags

Message ID 20230713230606.1505458-1-kuba@kernel.org
State New
Headers
Series [docs] docs: maintainers: mention tag -s for signed tags |

Commit Message

Jakub Kicinski July 13, 2023, 11:06 p.m. UTC
  The documentation talks about -u and how to configure the default
key. It does not mention that once the default key is set one
should use the -s flag. Which is likely what most people end up
using.

Signed-off-by: Jakub Kicinski <kuba@kernel.org>
---
 Documentation/maintainer/configure-git.rst | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)
  

Comments

Jonathan Corbet July 14, 2023, 6:19 p.m. UTC | #1
Jakub Kicinski <kuba@kernel.org> writes:

> The documentation talks about -u and how to configure the default
> key. It does not mention that once the default key is set one
> should use the -s flag. Which is likely what most people end up
> using.
>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> ---
>  Documentation/maintainer/configure-git.rst | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/maintainer/configure-git.rst b/Documentation/maintainer/configure-git.rst
> index ec0ddfb9cdd3..a054de0c50dc 100644
> --- a/Documentation/maintainer/configure-git.rst
> +++ b/Documentation/maintainer/configure-git.rst
> @@ -7,9 +7,10 @@ This chapter describes maintainer level git configuration.
>  
>  Tagged branches used in :ref:`Documentation/maintainer/pull-requests.rst
>  <pullrequests>` should be signed with the developers public GPG key. Signed
> -tags can be created by passing the ``-u`` flag to ``git tag``. However,
> -since you would *usually* use the same key for the same project, you can
> -set it once with
> +tags can be created by passing ``-u <key-id>`` to ``git tag``. However,
> +since you would *usually* use the same key for the project, you can
> +set it in the configuration and use the ``-s`` flag. To set the default
> +``key-id`` use
>  ::

Applied, thanks.

jon
  

Patch

diff --git a/Documentation/maintainer/configure-git.rst b/Documentation/maintainer/configure-git.rst
index ec0ddfb9cdd3..a054de0c50dc 100644
--- a/Documentation/maintainer/configure-git.rst
+++ b/Documentation/maintainer/configure-git.rst
@@ -7,9 +7,10 @@  This chapter describes maintainer level git configuration.
 
 Tagged branches used in :ref:`Documentation/maintainer/pull-requests.rst
 <pullrequests>` should be signed with the developers public GPG key. Signed
-tags can be created by passing the ``-u`` flag to ``git tag``. However,
-since you would *usually* use the same key for the same project, you can
-set it once with
+tags can be created by passing ``-u <key-id>`` to ``git tag``. However,
+since you would *usually* use the same key for the project, you can
+set it in the configuration and use the ``-s`` flag. To set the default
+``key-id`` use
 ::
 
 	git config user.signingkey "keyname"