From patchwork Thu Jul 13 16:36:14 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jim Cromie X-Patchwork-Id: 120027 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:a6b2:0:b0:3e4:2afc:c1 with SMTP id c18csp1955155vqm; Thu, 13 Jul 2023 09:53:04 -0700 (PDT) X-Google-Smtp-Source: APBJJlEVFzhpmj4K4BNLnc4Q6P30e7TGx27MUXQw75n8WA4Z1pK0LeeNKdF7Bypq25hSoS8ps08S X-Received: by 2002:a2e:84d7:0:b0:2b4:75f0:b9e9 with SMTP id q23-20020a2e84d7000000b002b475f0b9e9mr2009599ljh.10.1689267183742; Thu, 13 Jul 2023 09:53:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689267183; cv=none; d=google.com; s=arc-20160816; b=kfpCDyKk1Ud7NN8RuXME1xtanpJ8/VIBoX3UcKcDRHQxfIEWn3CF0Kqsve1jpKvpcC MLkexDM1FYfRZHiOfcrz37BR8i37OC3nJtUkVceQF27g47Sntrwiav7XkVCA5OZPHaRx 101vLzx8DaQH39xlfubCgMFEz+tGmIMweM8nUww5sLxM/4eUlVpHfGnPyaE38je+q7db oQt/hM5h0OUlw9CPOUKH0xhfg+3fvTYvqzMNnnKBKB2CkFAMdTAmsVrERyJ1afdkBX8b doqHwFL9lX0TAHwAdKVQuAHRMPkAqq3AbIHJa2GyXBV7xsKIRt7Yb4wfOIY+5ORNp+RK Pg/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=ge7HQUHFN0SdBhoqRDpb0JNuijpwX6fCYvOeNIH8KRc=; fh=/CYHsJHkAPOgOy4IDXYU5w+VojxE3561vOD18ijZg9Q=; b=RfnTSFJiHsbmMMSrRMbXJZcejqPizAk4/TvsW1YLIcenaY620xpxQQ6fLRhLTnvXvg 5WEajGMl+KfUly/J+OPn8ufQQWEfypJI7S58XJ4XK+pc425KvhVLRmj22oyjGfTgI8T0 kYqQnRCPWPjQJwdUkBAg62/T0b0mZTTbugsYPED6x+fHEEPFz02VnTcf35jfI9uwKAs4 4oMzH+GF9fP28eT8C9u/3HWBmaRF8HvV47zvvLsYTf/4gsOJyV+W69NmDEcy56/9BgwX WdvKfKSkvrEU5DabXcob6c43Bl0elAS6/2qr/ZYPEZlTr0gvBxGtUzPSj6TzocU82p4V Xgtw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b=n3bBlGnl; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id c9-20020a170906170900b00991f598188csi7085858eje.214.2023.07.13.09.52.39; Thu, 13 Jul 2023 09:53:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b=n3bBlGnl; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235274AbjGMQhu (ORCPT + 99 others); Thu, 13 Jul 2023 12:37:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48058 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234203AbjGMQhS (ORCPT ); Thu, 13 Jul 2023 12:37:18 -0400 Received: from mail-il1-x132.google.com (mail-il1-x132.google.com [IPv6:2607:f8b0:4864:20::132]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F1D2635AE for ; Thu, 13 Jul 2023 09:36:55 -0700 (PDT) Received: by mail-il1-x132.google.com with SMTP id e9e14a558f8ab-34617b29276so5095815ab.0 for ; Thu, 13 Jul 2023 09:36:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1689266214; x=1691858214; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ge7HQUHFN0SdBhoqRDpb0JNuijpwX6fCYvOeNIH8KRc=; b=n3bBlGnlSg9QDxZ/zCAJpz7Pc8pBJRk+4xVFJ0sAQSSYAsQVsbLE4H2H37JSOHj8pd QcIGXwYWABv0GdR0B+Sf3oxpZejkcpfjzTPy5LC98Awji4CISg+TWEIH9ukXZw9+XP1j znzGIoD/xa0Ocx7fxHzrmKFn5W7poEyqzlvK1w6AP2rH8vOQ/ichOn8jfMEldAdAs0/s 4HZRU9tjV2B3MAHWgy7UQ0/zI3upx6P18W9CInoOGDCs46viWZ4aJwfZqFHiLUwOSs8J W1L+gV6ZEJeBgq8W2J5rzeDgkXOtWAyIsIyVbLRNP+kuTCJ+ZEG/pmQFHByUl94Gf2Df j7Hw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689266214; x=1691858214; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ge7HQUHFN0SdBhoqRDpb0JNuijpwX6fCYvOeNIH8KRc=; b=AARG1+weLlaO+kE5dVuc8RG2CoNQpeLgwBD2DFnvsxcg9wdEUEGp9Xb+rh+rslMORT yaJXCF9zkDe3/CeBQYcHEl+KG8BoPVlmsA3ekH9Nzcd2VRmYKd8unLzdE8PoHaXdZVQL /vbbcz7gUY4G5iMci1QUL+aQTSi5RwfoicXVkN3CKZFOzjGy5ropcf8Qk9n4zCEpv4sA n4GYzqnpQ3HGn897bENKlUE4iaxQaBP/zhQBDkpxWuiWVm3DxJMV+/gp4hSpbJO6X6uM 6oubwI3yFJ2Q0jxxacH8QobEy5wWZwmSZotiU/qIJn1AhnAhb86ExPiNOTauSRzSyZCx 0Tvw== X-Gm-Message-State: ABy/qLauWf8lKWyTrWESJjgEB6xLVK/amOV4ZacVwmKgcEjBJafuJJNs ljOndeXul3ChJDKbVZsLBYE= X-Received: by 2002:a92:6c0f:0:b0:346:7fc:4fb8 with SMTP id h15-20020a926c0f000000b0034607fc4fb8mr122634ilc.1.1689266214495; Thu, 13 Jul 2023 09:36:54 -0700 (PDT) Received: from frodo.. (c-73-78-62-130.hsd1.co.comcast.net. [73.78.62.130]) by smtp.googlemail.com with ESMTPSA id s7-20020a92d907000000b00345950d7e94sm2147571iln.20.2023.07.13.09.36.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Jul 2023 09:36:54 -0700 (PDT) From: Jim Cromie To: jbaron@akamai.com, daniel.vetter@ffwll.ch, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, intel-gvt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org Cc: jani.nikula@intel.com, ville.syrjala@linux.intel.com, seanpaul@chromium.org, robdclark@gmail.com, gregkh@linuxfoundation.org, Jim Cromie Subject: [PATCH v4 09/21] dyndbg: silence debugs with no-change updates Date: Thu, 13 Jul 2023 10:36:14 -0600 Message-ID: <20230713163626.31338-10-jim.cromie@gmail.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230713163626.31338-1-jim.cromie@gmail.com> References: <20230713163626.31338-1-jim.cromie@gmail.com> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1771325026802729592 X-GMAIL-MSGID: 1771325026802729592 check for actual changes before announcing them, declutter logs. Signed-off-by: Jim Cromie --- lib/dynamic_debug.c | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c index 2a5cbb68d88d..a8973d1a6896 100644 --- a/lib/dynamic_debug.c +++ b/lib/dynamic_debug.c @@ -590,7 +590,7 @@ static int ddebug_exec_queries(char *query, const char *modname) return nfound; } -/* apply a new bitmap to the sys-knob's current bit-state */ +/* apply a new class-param setting */ static int ddebug_apply_class_bitmap(const struct ddebug_class_param *dcp, unsigned long *new_bits, unsigned long *old_bits, const char *query_modname) @@ -601,8 +601,9 @@ static int ddebug_apply_class_bitmap(const struct ddebug_class_param *dcp, int matches = 0; int bi, ct; - v2pr_info("apply bitmap: 0x%lx to: 0x%lx for %s\n", *new_bits, *old_bits, - query_modname ?: ""); + if (*new_bits != *old_bits) + v2pr_info("apply bitmap: 0x%lx to: 0x%lx for %s\n", *new_bits, + *old_bits, query_modname ?: "'*'"); for (bi = 0; bi < map->length; bi++) { if (test_bit(bi, new_bits) == test_bit(bi, old_bits)) @@ -617,8 +618,9 @@ static int ddebug_apply_class_bitmap(const struct ddebug_class_param *dcp, v2pr_info("bit_%d: %d matches on class: %s -> 0x%lx\n", bi, ct, map->class_names[bi], *new_bits); } - v2pr_info("applied bitmap: 0x%lx to: 0x%lx for %s\n", *new_bits, *old_bits, - query_modname ?: ""); + if (*new_bits != *old_bits) + v2pr_info("applied bitmap: 0x%lx to: 0x%lx for %s\n", *new_bits, + *old_bits, query_modname ?: "'*'"); return matches; }