From patchwork Thu Jul 13 13:19:21 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Ilpo_J=C3=A4rvinen?= X-Patchwork-Id: 119905 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:a6b2:0:b0:3e4:2afc:c1 with SMTP id c18csp1832157vqm; Thu, 13 Jul 2023 06:39:58 -0700 (PDT) X-Google-Smtp-Source: APBJJlHnqJbxCWedlX/CLapK+zN5BAiZTvVLytycUqCBQvpcpD4ZdmWufv5ND5qrU8mT+lk6eLL0 X-Received: by 2002:a05:6a20:395:b0:12f:dc60:4817 with SMTP id 21-20020a056a20039500b0012fdc604817mr796207pzt.47.1689255598502; Thu, 13 Jul 2023 06:39:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689255598; cv=none; d=google.com; s=arc-20160816; b=JsMF33z2hWzpcKH887i6LdMTdcayUa2LB0cN9tUDWQukDHJ4IU/ECx8wAOPu4s4nHg IKZ3kkS5WGj2Ih/7VHSW8+hGXNY4EC02LNmRPiySCR0iPEAFRFnmXf04d0L9vDqR/Mwe YvKdr/GDRJ10pVbCastRktQbPCN6mO9+sNTC5YSMFg7CijQ6nZ4AOMSzNa1HNRNqhPwW GYZTgwz1hMYQgTpaM+HzFjbBLVnhwUuXkEZ13XpGx73LQpFBmqnSoFy2L75ZPlVxvku1 4wHRkn52ebwyw28tewru8DZudyTYJuL8ggj278GuEEZAiqkJwK+66FJyjftopV5YFUvh JGcQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=pD6YiBohF94cKlaTdo3/zKI2HUnuH2zpLzeN1CWu2+0=; fh=yQZVCT9uasVczKlazciVDh1mdZVasudsfBJLxIYHjUw=; b=mfF4RkXQPZUqSEpG7fVAxJppr3SNRwrFNi3Ii+BMbVAbtU/Q3aOxHJfaFvJpmDwBgS h3S6lUotl/J1VBPgJvKlxkuxxztgkOozTIhCr0dP6o2ObRM0+h5cFXOSQ5VKeGd8sDcs xRhFIYo15DvY3DX/j4FNUsj8hAsHBl/N4Jde5sCEPAyyZ3Xx3SxIVPyrnbdKlZ8thNGk tum8IhaT3GgZ18UL3iaeXWN2wDJYXYn5amuPePFWF9RFB9o5rjlopn+ZpT8yNtojFfnf 8286xoDZcTPtrIHgeET2FBNIrvlOwyt75RMwUoV2pBPRWW/qPQuFIoi21e3bC4tcbnAN nKTw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b="RqU7pA/e"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id j71-20020a63804a000000b005579d6bdf85si5070156pgd.882.2023.07.13.06.39.45; Thu, 13 Jul 2023 06:39:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b="RqU7pA/e"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235203AbjGMNV1 (ORCPT + 99 others); Thu, 13 Jul 2023 09:21:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51116 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234797AbjGMNUy (ORCPT ); Thu, 13 Jul 2023 09:20:54 -0400 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 60EC72D65; Thu, 13 Jul 2023 06:20:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1689254447; x=1720790447; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=1njCDh4AQc1HNVmmNcrVGlu3E0csxRiOqUiCj2TLy5Q=; b=RqU7pA/eNP3z3WQscjbmLFacK8ckMLAq+xC9bqS/H70pjJs+YmLUrWtj AI/HGutXlkseJTDhyKs5nc+/quonKZeDO+W3OvqQluIt2r3onarLxpM/b bxGUNoxotFujBqpcDceupO5Q/vmuXapqN0tOG8fo+2UH177EssfwjO9/H hIf1U3h5Gj19CMeYC5II3kXoAvupiIruTqwUC5BKS++NupXB3vXNdSCjU sblWzVrhJTWMePf3EmTRWYS9h8CbPQPRDS3yoiDr1VV2Z0K3F+BFOgF2W aTxs4i6VOFJFPw8YweLUwz45OcxPE5OErEU10PoMLNmm/gNE+Uot1pqZE g==; X-IronPort-AV: E=McAfee;i="6600,9927,10770"; a="345496714" X-IronPort-AV: E=Sophos;i="6.01,202,1684825200"; d="scan'208";a="345496714" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Jul 2023 06:20:46 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10770"; a="968615837" X-IronPort-AV: E=Sophos;i="6.01,202,1684825200"; d="scan'208";a="968615837" Received: from ijarvine-mobl2.ger.corp.intel.com ([10.251.222.39]) by fmsmga006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Jul 2023 06:20:42 -0700 From: =?utf-8?q?Ilpo_J=C3=A4rvinen?= To: linux-kselftest@vger.kernel.org, Reinette Chatre , Shuah Khan , Shaopeng Tan , Fenghua Yu , linux-kernel@vger.kernel.org Cc: =?utf-8?q?Ilpo_J=C3=A4rvinen?= Subject: [PATCH v4 08/19] selftests/resctrl: Remove mum_resctrlfs from struct resctrl_val_param Date: Thu, 13 Jul 2023 16:19:21 +0300 Message-Id: <20230713131932.133258-9-ilpo.jarvinen@linux.intel.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230713131932.133258-1-ilpo.jarvinen@linux.intel.com> References: <20230713131932.133258-1-ilpo.jarvinen@linux.intel.com> MIME-Version: 1.0 X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1771312878384813960 X-GMAIL-MSGID: 1771312878384813960 Resctrl FS mount/umount are now cleanly paired leaving .mum_resctrlfs in the struct resctrl_val_param unused. Remove .mum_resctrlfs from the struct resctrl_val_param that is leftover from the remount trickery and no longer needed. Signed-off-by: Ilpo Järvinen Reviewed-by: Reinette Chatre --- tools/testing/selftests/resctrl/cat_test.c | 1 - tools/testing/selftests/resctrl/cmt_test.c | 1 - tools/testing/selftests/resctrl/mba_test.c | 1 - tools/testing/selftests/resctrl/mbm_test.c | 1 - tools/testing/selftests/resctrl/resctrl.h | 2 -- 5 files changed, 6 deletions(-) diff --git a/tools/testing/selftests/resctrl/cat_test.c b/tools/testing/selftests/resctrl/cat_test.c index e1c071dec1b0..480db0dc4e0e 100644 --- a/tools/testing/selftests/resctrl/cat_test.c +++ b/tools/testing/selftests/resctrl/cat_test.c @@ -140,7 +140,6 @@ int cat_perf_miss_val(int cpu_no, int n, char *cache_type) struct resctrl_val_param param = { .resctrl_val = CAT_STR, .cpu_no = cpu_no, - .mum_resctrlfs = false, .setup = cat_setup, }; diff --git a/tools/testing/selftests/resctrl/cmt_test.c b/tools/testing/selftests/resctrl/cmt_test.c index 426d11189a99..d31e28416bb7 100644 --- a/tools/testing/selftests/resctrl/cmt_test.c +++ b/tools/testing/selftests/resctrl/cmt_test.c @@ -113,7 +113,6 @@ int cmt_resctrl_val(int cpu_no, int n, char **benchmark_cmd) .ctrlgrp = "c1", .mongrp = "m1", .cpu_no = cpu_no, - .mum_resctrlfs = false, .filename = RESULT_FILE_NAME, .mask = ~(long_mask << n) & long_mask, .span = cache_size * n / count_of_bits, diff --git a/tools/testing/selftests/resctrl/mba_test.c b/tools/testing/selftests/resctrl/mba_test.c index cde3781a9ab0..3d53c6c9b9ce 100644 --- a/tools/testing/selftests/resctrl/mba_test.c +++ b/tools/testing/selftests/resctrl/mba_test.c @@ -154,7 +154,6 @@ int mba_schemata_change(int cpu_no, char *bw_report, char **benchmark_cmd) .ctrlgrp = "c1", .mongrp = "m1", .cpu_no = cpu_no, - .mum_resctrlfs = true, .filename = RESULT_FILE_NAME, .bw_report = bw_report, .setup = mba_setup diff --git a/tools/testing/selftests/resctrl/mbm_test.c b/tools/testing/selftests/resctrl/mbm_test.c index 538d35a6485a..24326cb7bc21 100644 --- a/tools/testing/selftests/resctrl/mbm_test.c +++ b/tools/testing/selftests/resctrl/mbm_test.c @@ -123,7 +123,6 @@ int mbm_bw_change(int span, int cpu_no, char *bw_report, char **benchmark_cmd) .mongrp = "m1", .span = span, .cpu_no = cpu_no, - .mum_resctrlfs = true, .filename = RESULT_FILE_NAME, .bw_report = bw_report, .setup = mbm_setup diff --git a/tools/testing/selftests/resctrl/resctrl.h b/tools/testing/selftests/resctrl/resctrl.h index 23af3fb73cb4..99678d688a80 100644 --- a/tools/testing/selftests/resctrl/resctrl.h +++ b/tools/testing/selftests/resctrl/resctrl.h @@ -54,7 +54,6 @@ * @mongrp: Name of the monitor group (mon grp) * @cpu_no: CPU number to which the benchmark would be binded * @span: Memory bytes accessed in each benchmark iteration - * @mum_resctrlfs: Should the resctrl FS be remounted? * @filename: Name of file to which the o/p should be written * @bw_report: Bandwidth report type (reads vs writes) * @setup: Call back function to setup test environment @@ -65,7 +64,6 @@ struct resctrl_val_param { char mongrp[64]; int cpu_no; unsigned long span; - bool mum_resctrlfs; char filename[64]; char *bw_report; unsigned long mask;