From patchwork Thu Jul 13 13:19:24 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Ilpo_J=C3=A4rvinen?= X-Patchwork-Id: 119901 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:a6b2:0:b0:3e4:2afc:c1 with SMTP id c18csp1829945vqm; Thu, 13 Jul 2023 06:36:04 -0700 (PDT) X-Google-Smtp-Source: APBJJlF5peArebHXlvr6HrHH/g/TOQshJ23xLwI0Bvk3ruMAwntPsU4Cunbt3r3ODWzNUNZcJSND X-Received: by 2002:a05:6a20:154:b0:125:699a:5998 with SMTP id 20-20020a056a20015400b00125699a5998mr1026885pzs.54.1689255363994; Thu, 13 Jul 2023 06:36:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689255363; cv=none; d=google.com; s=arc-20160816; b=Fu+lJWM+Hob7Z5WdyaCSAtzc1qiKyyMeffes4XYp5buX0F1V0LtWxjj01U6cwdk0Fu d/SCGegyMq9E+N/Q/2HaXWHOW2gaxeQuHZP5PGiWCJTdCqIlTDGFqVhOtGB/75JHoER3 R0F7lBk1A5KX3PZ9RBquksIhDVhPYtH3j2NzhcB1zosB5fgZQVJTkYQlazUgd6ZCD4// fb5yjh8AE5NnWAvFY3/8cnaP6ZaP0hwPhuDwW5nZtX+XyvQUg2N82HmmMhoCJgTN5RC8 9mq/94wPnkXhewTFMSu5bVlzT2pfppwUFAMsfXCgapmwhEMM7D/y5Ma6OpBHqKEuzvaf UgvQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=DMID/qBOCkmNw/JRDrZa8Ol4ErJagg09Wtvylivr69Q=; fh=yQZVCT9uasVczKlazciVDh1mdZVasudsfBJLxIYHjUw=; b=vjirqJfIriI1qaS1slNuFHnHx4Johm1weoxaumrEFO+/8MnxcIOnM2jHczFwPymvVc SovrL1miokuKr2BaVbN1Pr6F/pIZqx7+G8yZlwiV1iSWHV+kx1fXMgUNqYN/ZpTuvuZu Z0ITSIKz9SCbKjgzLa8Ke+f/Qvlw91uFK7ecC7BWRNAbh5pFLdWCs+Z3EJYT34kwvdep RrnWMwdVjUvVL1UcvGIFDHPlxKl9GOBUza6aDPVvSbMuK9ZK/3twiNq00csIbxJNkSsV 6eMCtatqEXrRVk8IHtf+6jS51guQMvnG0NMGF3aP8DmasOHQw2zEPF+p0lyYgReSRexc ojvA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=iyBG81yl; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id m16-20020a63fd50000000b005578a320ea8si5173678pgj.867.2023.07.13.06.35.51; Thu, 13 Jul 2023 06:36:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=iyBG81yl; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235129AbjGMNVw (ORCPT + 99 others); Thu, 13 Jul 2023 09:21:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54630 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235198AbjGMNVU (ORCPT ); Thu, 13 Jul 2023 09:21:20 -0400 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 03F20359F; Thu, 13 Jul 2023 06:20:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1689254458; x=1720790458; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=BklG/eCoHhbYFvki+htdCl8nS8+nMI8Vo6bNJZ2Xh8o=; b=iyBG81ylZduZNI/CzGdFf+gibXqcZt1sd9N9zQURB9AD3bzJxanp3gVt T7ziILS64/7N8wznblYpU6fYzloCeIJeALaZDiQaD5tx/AjY1KmaVCTho VGRQc4TVd32wRnSAjIh0mhI2zoNosXz7xACivTIhPHdkRpMofIF9j9/8L CEQBG0KUfrwzdM1wqfu52T6vrC/T2Ql/fDBD5qFyCFEFP704cYhWU6627 dxnGsNmfszI4R+vr1ls7ALS07h2J7grCzW3p/KXMdOgmFqNUez+MOIX/W T5/AFOXYgLaiBZq4WmDKllfLiv9Bl/OAUd3hCyju59Or3SnklTz4oYSh1 Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10770"; a="345496801" X-IronPort-AV: E=Sophos;i="6.01,202,1684825200"; d="scan'208";a="345496801" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Jul 2023 06:20:54 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10770"; a="968615874" X-IronPort-AV: E=Sophos;i="6.01,202,1684825200"; d="scan'208";a="968615874" Received: from ijarvine-mobl2.ger.corp.intel.com ([10.251.222.39]) by fmsmga006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Jul 2023 06:20:52 -0700 From: =?utf-8?q?Ilpo_J=C3=A4rvinen?= To: linux-kselftest@vger.kernel.org, Reinette Chatre , Shuah Khan , Shaopeng Tan , Fenghua Yu , linux-kernel@vger.kernel.org Cc: =?utf-8?q?Ilpo_J=C3=A4rvinen?= Subject: [PATCH v4 11/19] selftests/resctrl: Remove duplicated preparation for span arg Date: Thu, 13 Jul 2023 16:19:24 +0300 Message-Id: <20230713131932.133258-12-ilpo.jarvinen@linux.intel.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230713131932.133258-1-ilpo.jarvinen@linux.intel.com> References: <20230713131932.133258-1-ilpo.jarvinen@linux.intel.com> MIME-Version: 1.0 X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1771312632527163728 X-GMAIL-MSGID: 1771312632527163728 When no benchmark_cmd is given, benchmark_cmd[1] is set to span in main(). There's no need to do it again in run_mba_test(). Remove the duplicated preparation for span argument into benchmark_cmd[1] from run_mba_test(). After this, the has_ben and span arguments to run_mba_test() can be removed. Co-developed-by: Fenghua Yu Signed-off-by: Fenghua Yu Signed-off-by: Ilpo Järvinen Reviewed-by: Reinette Chatre --- tools/testing/selftests/resctrl/resctrl_tests.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/tools/testing/selftests/resctrl/resctrl_tests.c b/tools/testing/selftests/resctrl/resctrl_tests.c index 5205a13ed250..6e693f381a6e 100644 --- a/tools/testing/selftests/resctrl/resctrl_tests.c +++ b/tools/testing/selftests/resctrl/resctrl_tests.c @@ -99,8 +99,7 @@ static void run_mbm_test(bool has_ben, char **benchmark_cmd, size_t span, umount_resctrlfs(); } -static void run_mba_test(bool has_ben, char **benchmark_cmd, size_t span, - int cpu_no, char *bw_report) +static void run_mba_test(char **benchmark_cmd, int cpu_no, char *bw_report) { int res; @@ -117,8 +116,6 @@ static void run_mba_test(bool has_ben, char **benchmark_cmd, size_t span, goto umount; } - if (!has_ben) - sprintf(benchmark_cmd[1], "%zu", span); res = mba_schemata_change(cpu_no, bw_report, benchmark_cmd); ksft_test_result(!res, "MBA: schemata change\n"); @@ -298,7 +295,7 @@ int main(int argc, char **argv) run_mbm_test(has_ben, benchmark_cmd, span, cpu_no, bw_report); if (mba_test) - run_mba_test(has_ben, benchmark_cmd, span, cpu_no, bw_report); + run_mba_test(benchmark_cmd, cpu_no, bw_report); if (cmt_test) run_cmt_test(has_ben, benchmark_cmd, cpu_no);