From patchwork Thu Jul 13 12:58:32 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Zimmermann X-Patchwork-Id: 119871 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:a6b2:0:b0:3e4:2afc:c1 with SMTP id c18csp1818497vqm; Thu, 13 Jul 2023 06:18:21 -0700 (PDT) X-Google-Smtp-Source: APBJJlFz1pvFi6aNCeyod/X9LzWGlv5Dp/CO39mUtKAMycHNrOzEn75WCpW4YCPOmxh/fw+fTBiJ X-Received: by 2002:a05:6512:340b:b0:4fb:8948:2b8e with SMTP id i11-20020a056512340b00b004fb89482b8emr1660852lfr.8.1689254301738; Thu, 13 Jul 2023 06:18:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689254301; cv=none; d=google.com; s=arc-20160816; b=N8P6hdoU/kq8EzVGBsadZSIijV4UcIRlZRQ4g5raw8B8BNPOWAjHRprKT4azECcZs3 G03P2wj3i1D75wywRGhF5wq6F24j79KyFjaumEqPE7x4Ocwq+lMlqnFJFyKRMBelnPHe 2mCoRAI12XJpWdtJV1xuGAyT7OrDfPT5Wqmi/qe/v8az7RuGFJEN7qkl0fzxIvVQ6/QQ 46Dz27PH74unlf5Ns2IcjklwKegrYDswRpUK7HnwDfAzzuJePQCafkRiAKSvmVtMFx6w wH/DNhFFieiBP1maGGrdgFm3HxQk/muShsW/v5d7emb2cgzjNiGeJPj6aU6BUGIZa1+B fHIw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature:dkim-signature; bh=HF0ntTEfTFR2eIXkYuLTyCKB+tFcMggnqDzzMkFmIGA=; fh=3yNFpFW59vsXBqjjOQQ9Y6FkgLMRU9vk1eNRMOwCv6U=; b=C/QdIHj5y8aHiBD4/ihg40Xm5jmwkqKH2TcjKra4Y+j7bMLNDU1/u6i2hOzqaZkzcE xhbwIgu7k1A4iLlOeP1i19qladc2mzFDUfyC29YBeW8qEP+GdzGRkeNTrOOuGXevFoNh S5KAVbbUmw/CWLr/rm28hUKYdhvHwU8fQghUATEbvzB2DmWC2ZX4psrRiKlKe5g5RyZ+ NAjsgz0eHsbKrpUbrLmeWMOEECEKtDf+k62ga34s7h451Qd0gBxoCRPSw6ibeen6eG2m RAfjbleH8xb69NHKynqupX4Z0gQog9BvcgnQlzeky5BnTx6TUJ6FWvVnoM4s+dUjsGoY wQLA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=pe+qEXqJ; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519 header.b=oB84ogaZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id v13-20020aa7d80d000000b0051fde01961dsi4302970edq.667.2023.07.13.06.17.57; Thu, 13 Jul 2023 06:18:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=pe+qEXqJ; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519 header.b=oB84ogaZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235017AbjGMNEI (ORCPT + 99 others); Thu, 13 Jul 2023 09:04:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40560 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234659AbjGMNDt (ORCPT ); Thu, 13 Jul 2023 09:03:49 -0400 Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 907471BF0; Thu, 13 Jul 2023 06:03:48 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 1EA931FDC9; Thu, 13 Jul 2023 13:03:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1689253427; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HF0ntTEfTFR2eIXkYuLTyCKB+tFcMggnqDzzMkFmIGA=; b=pe+qEXqJT+w10Pj0fQwIyEJNJ7j/Bori0K7x9Dm/FhkLEWa80NpjznEwi/zmXxEKMJnQR5 x1cH6p2e+ll9PtyZWYjOuIj38TZKMFoyvh5GgknRzsp4r4EsO0e9pzHZdLp+glZF0bvu4x WordDcVoUxe3yXVHMy/M/kS+SlY4uWM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1689253427; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HF0ntTEfTFR2eIXkYuLTyCKB+tFcMggnqDzzMkFmIGA=; b=oB84ogaZr49lPA5lWsqOwuCBJmr3240Mz/gxj4+2FgMua3ao0lDwllYU8VxJI03P/YNaIp 3xYRcz33b31UpHDg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id A6B1F13489; Thu, 13 Jul 2023 13:03:46 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id EE7FJzL2r2TVPgAAMHmgww (envelope-from ); Thu, 13 Jul 2023 13:03:46 +0000 From: Thomas Zimmermann To: deller@gmx.de, javierm@redhat.com Cc: linux-sh@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, linux-input@vger.kernel.org, linux-media@vger.kernel.org, linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-geode@lists.infradead.org, linux-nvidia@lists.surfsouth.com, linux-hyperv@vger.kernel.org, linux-omap@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm@vger.kernel.org, Thomas Zimmermann , Sam Ravnborg , Greg Kroah-Hartman , Sudip Mukherjee , Teddy Wang Subject: [PATCH v2 12/18] staging: Remove flag FBINFO_FLAG_DEFAULT from fbdev drivers Date: Thu, 13 Jul 2023 14:58:32 +0200 Message-ID: <20230713130338.31086-13-tzimmermann@suse.de> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230713130338.31086-1-tzimmermann@suse.de> References: <20230713130338.31086-1-tzimmermann@suse.de> MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1771311518766317638 X-GMAIL-MSGID: 1771311518766317638 The flag FBINFO_FLAG_DEFAULT is 0 and has no effect, as struct fbinfo.flags has been allocated to zero by framebuffer_alloc(). So do not set it. Flags should signal differences from the default values. After cleaning up all occurrences of FBINFO_DEFAULT, the token will be removed. v2: * fix commit message (Miguel) Signed-off-by: Thomas Zimmermann Acked-by: Sam Ravnborg Cc: Greg Kroah-Hartman Cc: Sudip Mukherjee Cc: Teddy Wang --- drivers/staging/fbtft/fbtft-core.c | 2 +- drivers/staging/sm750fb/sm750.c | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/fbtft/fbtft-core.c b/drivers/staging/fbtft/fbtft-core.c index 3a4abf3bae40..eac1d570f437 100644 --- a/drivers/staging/fbtft/fbtft-core.c +++ b/drivers/staging/fbtft/fbtft-core.c @@ -684,7 +684,7 @@ struct fb_info *fbtft_framebuffer_alloc(struct fbtft_display *display, info->var.transp.offset = 0; info->var.transp.length = 0; - info->flags = FBINFO_FLAG_DEFAULT | FBINFO_VIRTFB; + info->flags = FBINFO_VIRTFB; par = info->par; par->info = info; diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c index c260f73cf570..79bcd5bd4938 100644 --- a/drivers/staging/sm750fb/sm750.c +++ b/drivers/staging/sm750fb/sm750.c @@ -807,7 +807,6 @@ static int lynxfb_set_fbinfo(struct fb_info *info, int index) info->screen_base = crtc->v_screen; pr_debug("screen_base vaddr = %p\n", info->screen_base); info->screen_size = line_length * var->yres_virtual; - info->flags = FBINFO_FLAG_DEFAULT | 0; /* set info->fix */ fix->type = FB_TYPE_PACKED_PIXELS;