From patchwork Thu Jul 13 08:08:05 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?5p2O5oms6Z+s?= X-Patchwork-Id: 119691 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:a6b2:0:b0:3e4:2afc:c1 with SMTP id c18csp1689773vqm; Thu, 13 Jul 2023 02:06:31 -0700 (PDT) X-Google-Smtp-Source: APBJJlGJ9e1utJXGynywzfPD9d/BvCyYK4jv4ltkM3vCPMEQ/c0rXPyH0V0bofooUAULYa0h52fn X-Received: by 2002:a05:6402:254c:b0:51e:5bd5:fe7e with SMTP id l12-20020a056402254c00b0051e5bd5fe7emr6015896edb.17.1689239191574; Thu, 13 Jul 2023 02:06:31 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1689239191; cv=pass; d=google.com; s=arc-20160816; b=rcXrvLv0taS/fxESWybTiJSScjFGXwO1G/8S2GIhf/fWI0Z5bRdFCFg9HF1lyE9IJ9 UF0oOYKnRSijjafKZjABtMXNVfD998NxzigkNWPzB2vAsLDU4waqQhC3O2mO67TtsvYP covav1EaELloa1NI19bNjO8qJYZt4waygMF77c3T+LgCmBmyT+mjAX2iR29oPSQdFxcT r06lk2Dmw7u4tJi4KRO73PT3CetO/PEaRipZ2Q1vVsL/RirnRzNFXRcDieelNPp9cRmB KQpmgAv9Kzq0Rot7Xm0w0ed0qqb4RHLUVt5nzsJFwDJ5FPJtp61aFi0fIsCDo++Ldoxx mNWw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:content-transfer-encoding :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=VbvoRarTmihEE9SfYnfLmCP64NcG9T0qKBlCHawhwDE=; fh=ZYodWTe0KCUO3NR7BtRFAqGMu45kjt7wn2F8buQXmlM=; b=qij9t7SsURYgU3mcLOOY/HOEVO6UskjeKJUndidlWRp+1qJcgoXn1WXJbe4rUv+il+ qHZ5g8rI/56iuS+58dy7bYYaWJo1bykS/sh4kyBftZUzd9b+RJDZOdRoRufOUq4mXxTd 3gmMNXCkpwtLj4wiWLekhjcUxBCPbqqJ2XN5X3HQbz5P1aq6ZJb581p8okl5LI3hmCnR qVXVz5s39WO/dxqeJ7gMaJiU/UYYFOoVjKpKSWLELXNcEBVWfgXjSRMCDnovMxA9vNht gkbBUCnLZsU+HnhwIe/KJPuRrYrZOr9v6EEoys/XQTEW+K380Y3P8LZYipfBhEqyYBNy Qmaw== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@vivo.com header.s=selector2 header.b=AYHvr834; arc=pass (i=1 spf=pass spfdomain=vivo.com dkim=pass dkdomain=vivo.com dmarc=pass fromdomain=vivo.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=vivo.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id p13-20020a056402074d00b0051da08decbdsi7255786edy.636.2023.07.13.02.06.07; Thu, 13 Jul 2023 02:06:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@vivo.com header.s=selector2 header.b=AYHvr834; arc=pass (i=1 spf=pass spfdomain=vivo.com dkim=pass dkdomain=vivo.com dmarc=pass fromdomain=vivo.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=vivo.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234520AbjGMIPi (ORCPT + 99 others); Thu, 13 Jul 2023 04:15:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54056 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233803AbjGMINh (ORCPT ); Thu, 13 Jul 2023 04:13:37 -0400 Received: from APC01-PSA-obe.outbound.protection.outlook.com (mail-psaapc01on2120.outbound.protection.outlook.com [40.107.255.120]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 84A293AAD; Thu, 13 Jul 2023 01:10:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=feYPKqM09Rwe+84PFwBiwzx6IvZx4tLxuB6OjqbNTncKHATg6lke0MiLSU9oWdPEXxKJaDipEFs/EVYEDfErWSKmyL1NJ00XcCg6QOpRFygmyCW81azyJhzmwHRcFfDHGhDFVGN555+zS8qOH7ELtJ6P6S/qdGp6DQGCiUq3nHBiROD652LsoT6vBTFzU8vjgFRxRDVFeu9qukZUwzV0Zpd4n0f715klabRkVeOrWdwsugMDspmf23lxd/v0VPJ8SFS826EDC6XgRFRfb5lQOoKphX6Lz4lkkUZlEw5dX2eAgGuAT+IXt9GgS8k0hP5/He8rV3QbJ2DzgWeRLA9SFQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VbvoRarTmihEE9SfYnfLmCP64NcG9T0qKBlCHawhwDE=; b=OwrT+VYS7/sj0d6dWPjtCU7n9nKXMsa/9wpcnHEOr0T46o0lIpDdJSU+S7igTsyLu18XU1ff7KGwkBhN+3xNejmvK55Qd8fftFCWk2LO9uFEdAdEjrSAM/21bdZ86lir0Oe68bav05YbdxrfFDZvtDmSaRcU+NQOGjIph8loqXoZIMNHQK8eozlf0HoabaF51VEYsWcmJ7iv294LdplamcvcFru/nbj69kr1E7ge4B9ghVcvOWwt8pqMcBW6z0sIyEcnIXLeBi+go/gFBDLnqYkmVLdXq6S4XEne9cMR9xcfec/L7qPbwgXcpAjBaHgXO8Zx9tmvdGXRKzwVYGICoQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VbvoRarTmihEE9SfYnfLmCP64NcG9T0qKBlCHawhwDE=; b=AYHvr834Zc2nmgvSQBvvnmkNmzEQdEpqg/Q6aka7kNd5NMKcZYbNtNkwXKrcdteqsrDr4nij6TPGBPG8FfbJfipbMS9iTERE7rn2e6wVrYoFCwXattBUXb5Ddcv+GndoUHCa4sa9IxgjAX18P/3epJdJYHAMfJ+UxC7x9pcClYRChMNw1Cosd8CcBCaxztiNKbdaNXFc3GgQq2V+Px5MfoafOx+VIVdJTSxF6kNfH6B1AWYoVuoqwoCQGI+dasb9YRXi+3X8XyFI9QX71RwcTq5QpCcTPIXYG63WWuB6rejXIQmIHZ84Zksy03iA1YGSt41RHz5qC2Eo/xq+3SgaLQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) by PUZPR06MB5984.apcprd06.prod.outlook.com (2603:1096:301:118::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6588.22; Thu, 13 Jul 2023 08:10:04 +0000 Received: from SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::fa0e:6c06:7474:285c]) by SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::fa0e:6c06:7474:285c%5]) with mapi id 15.20.6565.028; Thu, 13 Jul 2023 08:10:04 +0000 From: Yangtao Li To: Ulf Hansson Cc: Yangtao Li , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 56/58] mmc: pwrseq: Convert to platform remove callback returning void Date: Thu, 13 Jul 2023 16:08:05 +0800 Message-Id: <20230713080807.69999-56-frank.li@vivo.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230713080807.69999-1-frank.li@vivo.com> References: <20230713080807.69999-1-frank.li@vivo.com> X-ClientProxiedBy: SG2PR02CA0091.apcprd02.prod.outlook.com (2603:1096:4:90::31) To SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5269:EE_|PUZPR06MB5984:EE_ X-MS-Office365-Filtering-Correlation-Id: 067aa949-a9ec-47d2-3285-08db83788ce9 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: du9G7VOMrNu2lIGtZ+FVzXV4xi9u44F0krhpXTMj0APFbd2pno/1CrWHY9CPawacrBQRyjSaNNbB56j/SdbtjPwLEQ2tJkt1vzSUaBtEHz9Aq/d7AV8oUHyRg/b82TrpoC4Cuiis5pHHph6kSTN10y33N/Psc5mn8lBRBpjPXwgom8T1FKm3PU3sOSYQqbsvG8sGE12u9zTJP0fOnxgJ20byHlyY6fp5X7llUEallFZuqBcEGnmvsDf/0ydt7SdEXH8aho+rFNSx+Voaf8YKCqhUJODR1SePstuI2+tfIyWCzCom8kw5AKWA0uyUJexQ9haJwUGtfClmAG3Nv96Y+j9DTIJDGMf1hAPhg0q2LsILWPRvAmLY9g6wK9g+p/kJt5nw0eMfafDd4eHn5VJgREE0ioKMZBMQcCZTul3mqYZhHOmbhvLwcUzgROvF5OyIwvsPdjuga5DBw9vbt18y+120spqu/PHEZViI+D55dgROhpB6akfSrLHJYS9Aj/QAl6QOWw4U1B0bwJceOKR14olq8ATy+J6OXtpXj3LL0kTMkZ4/JQy93sc2Tg0CULjPyXmEAFMxVsdzXkzLUUEZmQhkt5dhBybTU7fhJ3x/+106rfKoW5zE8HK/Fq0yclTB X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SEZPR06MB5269.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(136003)(346002)(376002)(396003)(39860400002)(366004)(451199021)(478600001)(54906003)(52116002)(66476007)(66946007)(66556008)(6486002)(6916009)(4326008)(316002)(41300700001)(2616005)(186003)(2906002)(8936002)(8676002)(38100700002)(6506007)(1076003)(36756003)(26005)(5660300002)(6512007)(86362001)(38350700002)(83380400001);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?rM+vkmj5bQ83z85FsR0aLl+V9TxV?= =?utf-8?q?/DE2+LuOYPdMbFR9YdLozsxtNwYmgJwzDz1oKHUyEOMwDwOw5wTBz3E9r9bA0F2D7?= =?utf-8?q?wspcNN6Cep4SA9B5DcjtphtyMV7dFTdOq66PiXmqmuD3B1qLtjSEEG4IGZrhIW11i?= =?utf-8?q?MRCqDJBgJfdmpkLOtCEiaA9I+pXJoIQoUQru28Fcrjzw9AxvY96A2rIe9dM4RtkvQ?= =?utf-8?q?VJtaUqR/4F4vtypojc4NWCzQsRXxVovPnjGeBvaBOQ/cR0EQZMTw0sHp0mivB6roq?= =?utf-8?q?tGD/Ygkmqfijwu+a6YfhWvUMg59jlCrqXz9Vp4PEdHc525jdfIK0hNpvkteDPKsEg?= =?utf-8?q?Ma8obTJ9SymAiCla/ZZCrMn3wyVXa1xnAPDNPKLe5EFA0W94ZNuWzbPy1vaMsrjVH?= =?utf-8?q?nVUwaGIJa1JkEFj9SKeNOraORql2ozOWAeGl6wpH71+1WDptUDiYFddMDcHJLqIun?= =?utf-8?q?Mpq/EUbCWzdEF2BUNXOprPWx+usywy5qP9yybkY7MUqG2SGsRnxbE7iLoaUVfxz08?= =?utf-8?q?rv8geSImM/NY6Zg87lvGeh0I3BtA5vquN6vL94TUsytfMmOhbt7x+yTpkeA++m6av?= =?utf-8?q?j865MKbPrtvx6iGUxg7JHG6+Q/5FtJ8vXm6DHAkhjQ09r/T6lYriR4LpBi65TGodT?= =?utf-8?q?LT4Ykkokm66flbvf44lNkv67p3XSV1sV77UZkAVhB1TOqj29QDj7JELAjVv10wBn5?= =?utf-8?q?RONMIFF5e9+MMkXLuGkLlKCNHbx/9M8r/sCnV1i84JTnxL3D6t3NjkD9RHlHighsc?= =?utf-8?q?fiDrxuazY4jQ4Cc0XaFnwyv0V7hxJfzT1scSqeMzcssFjfng1eQkT+pjuedJe+Kjr?= =?utf-8?q?7cOL2WyuPpEXUafZzW9K0zzQwT4x9hwUbjadyTnjkrKJ5kjdtHjiPLLE5y4dwkaGa?= =?utf-8?q?AvAjyrelQKkGc0CR/VUWs9FPAhUBrYBEGxbHaRzJ7TnMTL11L4c4Akt9GSrir538Y?= =?utf-8?q?00UIrXSuzgdhsenVLZUdP4gp/Zk8+h9zP2LNLCgxlHiMcOjquOB8mJ65QKhzTPxzE?= =?utf-8?q?wAMYJNqsyTQOUrVoQCXAD4IrGnzeeMITvxTpgjqN6Ss639QWmrYxwDRkKvLurjl1X?= =?utf-8?q?cwu/TOe6AyQTivrFyYND/xZtjJuMnuqsAEGpOjI6mp6tL5/wE3N4Bi804OtnTywhn?= =?utf-8?q?Gspt8WemQi/2zQYFp9sW5kfvYDK8I09BjRp6R5HWQ/JLM1+4/WhnKopgk9jGpzkTB?= =?utf-8?q?iSaTRfiMRBM/deQO+56yIkRvGCffkxUgu6/NrYpO51n2GV6RQAm8DPmRcxMas6DpQ?= =?utf-8?q?RKMKs5DjGXTey2Y8l5G3qbA/C2KAl91UESvnJm+xtzxSs8yDgjNNj7SWygVlGA83z?= =?utf-8?q?gKwMjixE/TN6q7vjytEJL0qoBqF86v+IKfDeOWYo77FkVnTHc8G9eJBsL5744t/Or?= =?utf-8?q?jeRh0TJIQ1Oy0rQ594ByksfcgFx96cN25sy//2eM6bgFmNYgh1r4UlXicskYji0zK?= =?utf-8?q?6sRDDe7LKfzreu+eUfncwnahgcpc6Mpdprl0kXzIvHgRJxwNz9JCmNG3wK3yfjdA6?= =?utf-8?q?UIk+u1jw5eTm?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 067aa949-a9ec-47d2-3285-08db83788ce9 X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jul 2023 08:09:58.7784 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: lZX3K/eTVawsrFH8gHk0Pn24LwEYnofN4JueXTqE7jnmVjCkCD8FqQRabXCcuPj9gBCidekQiBINznOpIsrjsQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PUZPR06MB5984 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1771295674616287365 X-GMAIL-MSGID: 1771295674616287365 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Cc: Uwe Kleine-König Signed-off-by: Yangtao Li --- drivers/mmc/core/pwrseq_emmc.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mmc/core/pwrseq_emmc.c b/drivers/mmc/core/pwrseq_emmc.c index f6dde9edd7a3..3b6d69cefb4e 100644 --- a/drivers/mmc/core/pwrseq_emmc.c +++ b/drivers/mmc/core/pwrseq_emmc.c @@ -90,14 +90,12 @@ static int mmc_pwrseq_emmc_probe(struct platform_device *pdev) return mmc_pwrseq_register(&pwrseq->pwrseq); } -static int mmc_pwrseq_emmc_remove(struct platform_device *pdev) +static void mmc_pwrseq_emmc_remove(struct platform_device *pdev) { struct mmc_pwrseq_emmc *pwrseq = platform_get_drvdata(pdev); unregister_restart_handler(&pwrseq->reset_nb); mmc_pwrseq_unregister(&pwrseq->pwrseq); - - return 0; } static const struct of_device_id mmc_pwrseq_emmc_of_match[] = { @@ -109,7 +107,7 @@ MODULE_DEVICE_TABLE(of, mmc_pwrseq_emmc_of_match); static struct platform_driver mmc_pwrseq_emmc_driver = { .probe = mmc_pwrseq_emmc_probe, - .remove = mmc_pwrseq_emmc_remove, + .remove_new = mmc_pwrseq_emmc_remove, .driver = { .name = "pwrseq_emmc", .of_match_table = mmc_pwrseq_emmc_of_match,