From patchwork Thu Jul 13 08:08:04 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?5p2O5oms6Z+s?= X-Patchwork-Id: 119697 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:a6b2:0:b0:3e4:2afc:c1 with SMTP id c18csp1691107vqm; Thu, 13 Jul 2023 02:09:16 -0700 (PDT) X-Google-Smtp-Source: APBJJlFdn/IFF7MDXk8hq7aSBp55Pt/N38UMxeCsinnXrq8RzELC0Ze1I+kmmmPOYmGCZyVLACTE X-Received: by 2002:a17:906:1d4:b0:982:c69c:8c30 with SMTP id 20-20020a17090601d400b00982c69c8c30mr887312ejj.55.1689239355984; Thu, 13 Jul 2023 02:09:15 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1689239355; cv=pass; d=google.com; s=arc-20160816; b=cpGwSk5muziv2HrVe/nTmWipVsyOwERg0f42m4dMiGA7NnhNLHrfd+MUWZYxhblWSF J0eDBWahSyYO3ZdJ9qm8j3Nwz0m9W/94/LI+S2wCdGVNmnGrOyNlsSH3+bKRcdVyQ26f ilqWLrS/jRmAlrMMcMdrDTjxp4g60q/Idzp90q8CCCcIIezRaOW/D7tMRw8LAaVv93Fz cy8Hth2Z8pGAaCkDvC4S0ET7Dtxz9u7ekSfYeiOrnnYGXi0Sd0mWJwpRpsAbl41/7J02 6Bs8zZqQh0N8/WKUtSBVLbCmZ75R6t7qDPCToFalmCV5vxEpI+dqPRzb1z0yBSsN9+FC AIzA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:content-transfer-encoding :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=bSVSY0tmOM4h4fHb2UFkj/zeTOsEVDjfwp+nRZtPSG8=; fh=ZYodWTe0KCUO3NR7BtRFAqGMu45kjt7wn2F8buQXmlM=; b=aND6LsV253j6A+ImhvFq6Ers9ahG6p42MJ/hr95mi2iVW229bNLrIVpT9aVv8qT7qr DcC9eioUJSF2A42fpEMMiZ77Qa0ZZFqrH8A517IyLNt8zOtsviT4n8lOZ7Fz/+3FqwHg I5R1iEeGPeYrSIHbuOAx8VIu/gEghShewuauR5vEAdCa5smUN6LI06VkEOYcajPQCPkH 3D7vdBOUZvkyyyNQM4ekAoYGV+LFsktYSBOLp7pUjSJgve9BbHmGduTs/4KNSvQV9xo1 TGWswZIIfrlpjCIQ0mQaagLh2x3y3FggcunMUNfVFieEjAyk03FjnOO4VSDciFheVwBP 6tPw== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@vivo.com header.s=selector2 header.b=jGEVR4Jh; arc=pass (i=1 spf=pass spfdomain=vivo.com dkim=pass dkdomain=vivo.com dmarc=pass fromdomain=vivo.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=vivo.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id n24-20020a170906119800b00992f7fe9c0bsi6813115eja.328.2023.07.13.02.08.51; Thu, 13 Jul 2023 02:09:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@vivo.com header.s=selector2 header.b=jGEVR4Jh; arc=pass (i=1 spf=pass spfdomain=vivo.com dkim=pass dkdomain=vivo.com dmarc=pass fromdomain=vivo.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=vivo.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232011AbjGMIPc (ORCPT + 99 others); Thu, 13 Jul 2023 04:15:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49790 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233746AbjGMINh (ORCPT ); Thu, 13 Jul 2023 04:13:37 -0400 Received: from APC01-PSA-obe.outbound.protection.outlook.com (mail-psaapc01on2123.outbound.protection.outlook.com [40.107.255.123]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DAE2030FD; Thu, 13 Jul 2023 01:10:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZmqHDE4KgX4HWN8N2mtjFJ84ngQY3HGiVNWIgmQwt4qGIvD0hkmdCO3ZyqZ51N5xHQEBZAJ4CaN+gA+VRcowN3e6UAK1pE5gDseUkBuh9UK/7GIC150L5JkAx6vZ+97EbYKpT4a2VAtCtMRDtcZCkdfBN+qAmw1yktK66+IVEyfjVzI5prO862apF9kOI84W/eyvIvET6nLN4YGf20RHoosFlKToFoz/4/c0zRN5eGVEOensPd26yhEhYx+EAyTjdo+ZtkupPIUBt+7ZPsbeoU1eChpaKC3LkHxR/bVUPCYBD0Qzu77fLvQoby6z0v5DiR6+ZJHJxGsAPE8zdRuCqA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bSVSY0tmOM4h4fHb2UFkj/zeTOsEVDjfwp+nRZtPSG8=; b=K9HAXPoJwFt90Gqw8u7P1tj8KQFWGHmCCj+os1w78q5KwBxxCLD8Z8EBJx3rms2UN7PrBBdBCNIpyxRxJNLxOtBSc/RSoGwY6zV/XtCNcAQBuazo8f6DX+37MQayLGL7xQFo5x10+/LaFjjajCxBsYZ24vcT1/hbCpjHQ8S95EstpHr3CNdmo/4nhozAjRy85aSie5wtfM3QcfRiJJoi6YlZM15UDDuJlbotZ9DLStV4MlAy7gpuGFQGeK0FQ/VRVNKarGuDG1r3aZc3PW3HWtF9G369mvlmE482ORPGgfpeN4JtyQljijxbuqPj0yM5jeZe653pZ11iQiI0y/Dl4Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bSVSY0tmOM4h4fHb2UFkj/zeTOsEVDjfwp+nRZtPSG8=; b=jGEVR4JhSArKKp7YpaSBJZz3egQBLceO00GZOvrjAkpHibCCy5+7FFtmAc7KvOU+Z5G/VX+WcX7h992KOsDtyJMXkfypDgjM3phYnzycnuzhKHVx8m5wPkQUcygxLppfUQ/oOYaM8za13kYqMIKHjJ6kVa7fUDNuxrxLI+LMaY9vqWDIYlfJbK6w4XMZIKHuayt88jheQA23gZMXgZIWZ41aXEQ3BGS+1HqvAS4xd14uiUmwIWSIFn5SOqlDOUPSdLcT6Brzas+3jCKkEddzSy3Qh3BK7V+QdlLBqtwCOgQ8lQmEy8Dbw/ZtVmypO6wNpfJ283Isw6f5pTXMYw7QZg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) by PUZPR06MB5984.apcprd06.prod.outlook.com (2603:1096:301:118::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6588.22; Thu, 13 Jul 2023 08:10:04 +0000 Received: from SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::fa0e:6c06:7474:285c]) by SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::fa0e:6c06:7474:285c%5]) with mapi id 15.20.6565.028; Thu, 13 Jul 2023 08:10:04 +0000 From: Yangtao Li To: Ulf Hansson Cc: Yangtao Li , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 55/58] mmc: pwrseq: sd8787: Convert to platform remove callback returning void Date: Thu, 13 Jul 2023 16:08:04 +0800 Message-Id: <20230713080807.69999-55-frank.li@vivo.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230713080807.69999-1-frank.li@vivo.com> References: <20230713080807.69999-1-frank.li@vivo.com> X-ClientProxiedBy: SG2PR02CA0091.apcprd02.prod.outlook.com (2603:1096:4:90::31) To SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5269:EE_|PUZPR06MB5984:EE_ X-MS-Office365-Filtering-Correlation-Id: 5c93b580-a866-4199-cfcc-08db83788c19 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: uGuwkwYYMfYCsnCQw6g94pV14j18hdvN0sapPP0998AxNU+1jRgci5zlOp+n+WQckFaUBK2PPoxk/4jTsA3EujA4YlbvQSXaKbxM6f+9KDT9MCMQZ2yPt/m3c+Kc2tDmjYavj4cd4FiXaEUQEKeY7ev1nxNHdTH+Nqj/jZwcdELLcuK7TVkOE/85JMVxI0XBKwsUUC1845bYWwn7YHf7EcVAtvMVfDDxIWBRWq/qNy3oktUCoavrF6MpNaJjT8bFylpIrct64SzvfdAVPki0m2dgiV1Iw2h4A9j2uu6SZ7kRqO6FJrRV44CPXeBppt2P/YWTQzuc22RBLihreamWVSJtIyrdRxgjXISIa11k//0CmArQOpJH9CAOa00JcCk10hTXtz0X479nfPh/9IZnOxTy+fvQL4Z5myEfOaYbEw9oy+oLcND8cT68dcasKYq1419UJzQbTcS2ySjX7Kt2YDBnIz5UAdNVAPbgPP0Es3u+esiwVWOyokVbPBRNVyp/VCaafSURN2+H8OjyGBSlOSA2eKTjyufVtKAqk4dLjdwgR93c86U1XUOuv9njZvCM8AhPz3ppdk1qP+PV/8wBlkuCHkPGTBYLkk7SmdyjuJfmxeqTsIhsNZwCQUv50Ice X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SEZPR06MB5269.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(136003)(346002)(376002)(396003)(39860400002)(366004)(451199021)(478600001)(54906003)(52116002)(66476007)(66946007)(66556008)(6486002)(6916009)(4326008)(316002)(41300700001)(2616005)(186003)(2906002)(8936002)(8676002)(38100700002)(6506007)(1076003)(36756003)(26005)(5660300002)(6512007)(86362001)(38350700002)(83380400001);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?1la8k37r/A2hdNhUlSlB2zvF0iSk?= =?utf-8?q?Tf+iQjAQsMB48X+3TYJftBeMtzPVwajcgWinN1g0SGSEk/hkanElREiX8QDZQvBcU?= =?utf-8?q?pqXIeP58UPoBPdAbIfH/IAhhTlmBKnC01ih1f/LOMZ4ZWZSSJ1Y2MZZ+aP27mOksf?= =?utf-8?q?ZqVt4LWtmKeJL4mynahU++Hf/jECAUO8CBkQ3PJwqR31sNPWBSScuFoKlKXta0rEK?= =?utf-8?q?8pbMfc1/A3dBjo3A2NeZxZ3y+vid8MyWPLaeGxzuztLCbLbjhzBWmQYGiGDcVvzF9?= =?utf-8?q?MKFEYgK4y+H3HGvVok/creLaVxKR0bcS4nlpKDBl+y9bk5ULEkG866aOBI+Qn1Z4i?= =?utf-8?q?6uHdosOoopfYXBJ0ngzk9rQW3duqhYqFZHavIF/5h4rxwrLqikU93Z3v6SR6vi2ID?= =?utf-8?q?RsylwQTk6R2CIpJwtmpwEGpQ0tlM1YbuuhF7Y8sLSiBeuFCpErAGfDdhlxmCr9ns+?= =?utf-8?q?OH4EQeCc42u/UD654xUqauVmTxbxK/YED61p6uJ2oaSB/9J8i+49XQh99tQYSOf/0?= =?utf-8?q?q1hboTCqV8nt2ex8kfiTYCXgMeoutqz1GWgDC2WbNDTWCp59F3Bi6Z7gRMHcQGsAQ?= =?utf-8?q?erYWPx4ghlGVPVlGxf2QI5tgOreYOJ+O/4ytpcH+20YqkLN/kaCXcQDFFhfJUTDnW?= =?utf-8?q?eOSY5jClbHAfkyN/xYyA8XgfxS3ZhoChS8OPhJb8QpGze6l+HAGHPk+QTOsaoMde4?= =?utf-8?q?BLBCnaY4qyp1bF3GL12rK7AeV/4DNUCT8x/g4HVZNEcj3eCeE1/Ty/o6D2wYpNTS1?= =?utf-8?q?VGV2Ah3TaVJjysFCHshUP9ywZNpiHJ471talaqL+aAd0Kk93AoXeM544pvPTrbAGY?= =?utf-8?q?s80gFuL0v8ngLgpgotGa6GExUmqrkh2IFnHS1kz7X075R7E0mpIRtdhvEAyEC2WLN?= =?utf-8?q?YCLaxU/COJG73+5dJHhgWCx3y+C8fPC2Obm2uA3NOQS713ztFbdqonV62RWNTW6zU?= =?utf-8?q?NG1DWvp3Og14DgXrManpsoxtuvxiWuzJQ/c9zdLhw3kN/AcLbV/wHkrz3nUCmTn43?= =?utf-8?q?OyHT2BkKDhi2E9O6/eNrlZyvsSnwIrnBT0kFZ2VhXhS6dQiQlQgfXP5Tr2QLw4qsf?= =?utf-8?q?qgwRLFUcWUPweoiucbUHkpc1n3f1InZQZsQU+mA6jWVCvIrFAyGhsnJGFtXq72FKh?= =?utf-8?q?kiHtEteH80VRVQDsoGe2SKEk86znGPzQbuf2+QyfxplEaNgdfo1e0GB4A/MbCywqQ?= =?utf-8?q?mkfQLV7gkh8PB/lxifKKr/7i6cnFhrGKoW8QGcBKVGym8MmcZdewQNwvWozctEsAh?= =?utf-8?q?JUChuDE4XPNZsgs5+aN3xDqEPR05+5PLYBGQX6T6tr4qZWtkpCrsnuSMvbgeq79gv?= =?utf-8?q?srcZjTqnifEehvuxsNr3an2BbIz1zpDFWFUcp6l1tsu/SQSO6UYO0o1TOPTkSjLXj?= =?utf-8?q?s08XMrcYSiEhpnX7ndOKzZV8aCrQPHN7o/xk99iCjSlb7pw2rdpA7KA0WHWASEXDs?= =?utf-8?q?nkm5/oZNWrXLf+EMYqjwdjn2Xz/AFaIGve6TAC6pAyx/HCMh0u1hfuGRNYvSnkLWl?= =?utf-8?q?DE3s51eBuUH9?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5c93b580-a866-4199-cfcc-08db83788c19 X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jul 2023 08:09:57.4242 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Czk01kq7GZ+A60rU/4OmNn22KHDXnzfKkEfjt90R5EEAUa+aZKSJsqG06pcSeZ7XQYfm7hmHloXJhl907FrlsQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PUZPR06MB5984 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1771295847253442819 X-GMAIL-MSGID: 1771295847253442819 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Cc: Uwe Kleine-König Signed-off-by: Yangtao Li --- drivers/mmc/core/pwrseq_sd8787.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mmc/core/pwrseq_sd8787.c b/drivers/mmc/core/pwrseq_sd8787.c index 0c5f5e371e1f..0c5808fc3206 100644 --- a/drivers/mmc/core/pwrseq_sd8787.c +++ b/drivers/mmc/core/pwrseq_sd8787.c @@ -113,18 +113,16 @@ static int mmc_pwrseq_sd8787_probe(struct platform_device *pdev) return mmc_pwrseq_register(&pwrseq->pwrseq); } -static int mmc_pwrseq_sd8787_remove(struct platform_device *pdev) +static void mmc_pwrseq_sd8787_remove(struct platform_device *pdev) { struct mmc_pwrseq_sd8787 *pwrseq = platform_get_drvdata(pdev); mmc_pwrseq_unregister(&pwrseq->pwrseq); - - return 0; } static struct platform_driver mmc_pwrseq_sd8787_driver = { .probe = mmc_pwrseq_sd8787_probe, - .remove = mmc_pwrseq_sd8787_remove, + .remove_new = mmc_pwrseq_sd8787_remove, .driver = { .name = "pwrseq_sd8787", .of_match_table = mmc_pwrseq_sd8787_of_match,