From patchwork Thu Jul 13 08:07:53 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?5p2O5oms6Z+s?= X-Patchwork-Id: 119659 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:a6b2:0:b0:3e4:2afc:c1 with SMTP id c18csp1680151vqm; Thu, 13 Jul 2023 01:44:19 -0700 (PDT) X-Google-Smtp-Source: APBJJlEdbxUH5GzlKrEgv/DpfLn8CfT1OJxk780vXa/28U68KN/chDrJ/yPI0gsKieud+Jim68B5 X-Received: by 2002:a2e:3315:0:b0:2b6:fa8d:ff91 with SMTP id d21-20020a2e3315000000b002b6fa8dff91mr902633ljc.3.1689237858825; Thu, 13 Jul 2023 01:44:18 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1689237858; cv=pass; d=google.com; s=arc-20160816; b=iy1ovOULa7XnaOYjQ9PKIwIMtJUzErESxoxmEMzQ/kLb19tCnbbJQtYwUuazM9qUXq wq7dcVpEERAkGWBcWh0VFGkwPDpXqxbi3wvmsIXk0YzJ1lItwu8EmtddY5xWKI5jhVT7 OBGp5Wdn/v2fx4OY4iMiM5/9LqDXs8/qTsV9A92XWAyQZI21vqFbbeHTrPRGjyYUiYeo 7hd0Lqqkzi59b6pMeDKaw8zCGnuv3o28xelM8OLr6seuvxZgkODCZ3o5AJ/XHePie/zR 2dlT4+s7dzp1+ZYRaIvxw8I/IuDDXtoDpG0FkM3AGd501MZGZB8mnyJzMl9Gk4zTBHR4 rM2Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:content-transfer-encoding :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=Sc43eVj8D+jXjv+UOKZmNNsyrS57jCHl9PeQXr9Ahyc=; fh=6cdLzAmRtuylSKIxaYw9sY9DAq4BCLf68zkyCZCuc9k=; b=Af5OPIvMesPGUJFSfPn3pvwuhB/Nvm1spXKXP666BZKRrpQXsEg5hgs6iJqBsM/d1i fGBqEann7H6ENMnmpzXCBy8nJqmCACgXtXj8Gja8u0K9SNcJRYB/0S5/3flHSkEeODsz m4lAWM1mUVeYCuf/5uyK6KI7r45Z45HtX8XrakRKP2tXu93dHsM8cwKk5aLIzmj00E3S nDlj1QM6Xn/UEVbZmSu+bFHA+O5Y1uybrfUPwzePIBLhGEmSZ2G4Z7RHuaJfQJSBAl47 1cFZ9stBvvk1wv7PBtoPkI9m+avmUI3fEQtgUPwpdNo3g85V8QrL8Ly4p7mYnhPsnHTM JyQg== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@vivo.com header.s=selector2 header.b=XJoJsLiX; arc=pass (i=1 spf=pass spfdomain=vivo.com dkim=pass dkdomain=vivo.com dmarc=pass fromdomain=vivo.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=vivo.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id gs15-20020a170906f18f00b00993150e5326si5973872ejb.626.2023.07.13.01.43.55; Thu, 13 Jul 2023 01:44:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@vivo.com header.s=selector2 header.b=XJoJsLiX; arc=pass (i=1 spf=pass spfdomain=vivo.com dkim=pass dkdomain=vivo.com dmarc=pass fromdomain=vivo.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=vivo.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234242AbjGMIOW (ORCPT + 99 others); Thu, 13 Jul 2023 04:14:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49636 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234036AbjGMINN (ORCPT ); Thu, 13 Jul 2023 04:13:13 -0400 Received: from APC01-PSA-obe.outbound.protection.outlook.com (mail-psaapc01on2120.outbound.protection.outlook.com [40.107.255.120]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7AC8A2702; Thu, 13 Jul 2023 01:10:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=k5PS2ZmIeLBXOJBQOTXXng1+4gF4jZk5I+1NDXvLSa/mgVZUwrYj4leGy454IaV+prwnbh6vk/PtDRstX8HrCVLlmkGYk/k2TchI9y06aVszshX+o/GE/WBP5zgZ4Gr34yaFZUhDdcs5mxvUxn5GD/d58g0HT1xNxtqKUDRcUzkRaaPOsJ/Wq2WNB8YrrSRUFfWlYNCl9DiY0aEekd77R9vA2oXDv74qFD4E0IxXCspW/dZfx+zkCkJjKS3DBDNdZK2rp86M6JkiCFpOtcyhm9u53Jhzz3Frn6i8Sp6Se0xkLBgfbyK7C8h2ZxWmUN2sQJtyDrDbOQzX2GJBMuN+0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Sc43eVj8D+jXjv+UOKZmNNsyrS57jCHl9PeQXr9Ahyc=; b=MLLRSdBed894kxnL3NR7ALsUd7N9uaBogtJpMiwyq+htWv0rrx2oNHi1QDfV7exL0WCUX7CLK0+EDsCMb00OEhsYA+Wjf6flUahG0RuOCLsPkuJ5Duc8UypT9GZ2dxtLUM0Htyvhb5AJD6/GRabMWmkT/4INJxEmUmsUm2/2jTUo2uW9DeSUV90d3l2n0foQyOrkJLuVSZk55lVXBm/My581LL0S9LZZRnHO3urakjzxgwM5cqc9SCrcVyKhUY4zejavR8C9LCJIzcU0s1QQcXNNZzXD19h8R7d7Aw6co3xz4ClYR5M/Y8VuCJDMG2zorDGnh+o8ZM0TF7AfbhadKg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Sc43eVj8D+jXjv+UOKZmNNsyrS57jCHl9PeQXr9Ahyc=; b=XJoJsLiXXXBI/SsaoJnEKyBUFjpEqQjmjRxo5Hge2OfRcjn/9NE52AJlPHczokWJELbCySeBtWB6VkH5MMJ+SrrYJQaZum/KixVciSYneC1e0+9vN+b1RnJzq0XlFUp7OtF/nfxfMFjZQA4kxmrLFvyduCGB55aEvxc+rKp9z6NgHYSaey8MtUccEOdEfyG4ezMA/SGjOop+ObtUK+bBHFcwl90c55m1No7VGcq29tdw23qJ+k07Z+77DSk0q5uNEnfRof9I2NZrbcu60fc00R92BZdnZrq9B6FTEEdDeMn6GQ5jpTG1MQPtcRdBvYxitLyY6hyrwBBbYg6J9fcbXw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) by PUZPR06MB5984.apcprd06.prod.outlook.com (2603:1096:301:118::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6588.22; Thu, 13 Jul 2023 08:09:59 +0000 Received: from SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::fa0e:6c06:7474:285c]) by SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::fa0e:6c06:7474:285c%5]) with mapi id 15.20.6565.028; Thu, 13 Jul 2023 08:09:59 +0000 From: Yangtao Li To: Pierre Ossman , Ulf Hansson Cc: Yangtao Li , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 44/58] mmc: wbsd: Convert to platform remove callback returning void Date: Thu, 13 Jul 2023 16:07:53 +0800 Message-Id: <20230713080807.69999-44-frank.li@vivo.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230713080807.69999-1-frank.li@vivo.com> References: <20230713080807.69999-1-frank.li@vivo.com> X-ClientProxiedBy: SG2PR02CA0091.apcprd02.prod.outlook.com (2603:1096:4:90::31) To SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5269:EE_|PUZPR06MB5984:EE_ X-MS-Office365-Filtering-Correlation-Id: 8cbded1d-7064-4d90-b854-08db837880d0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +GWbHP8OICCMWvBViByBOK3ixyMMdcIqDPsLdscp18R2ciEIpkCRkU2ajLSeqbtOEp6ludZGbPXkjSkD0Fcrde3C0WwtnlmvphXGbooPmSlMFzA5Q3qrMTeLlpTg/2dUWcJCHVrwWBXB6aFfVWMHxsFAa8f4x3Wx3dDSad34JYYr+IpEUGFiumwobDz0xpc+6/MuW2eelWIyqSd9bpbg5ylN3zMHc1Rtp7lQkz6+LTmYyYx8p8A6j57PlTlRrAG9w4xYbyqNPaYNqoHwOomVF0TRzbivRnh8v9u7d0ROZSUEeC5dgJCQ89qMXZ+EaUVSI82LjwtuWQpf6rkYOvx5tbdOV9X+MnHZza42XvDepyIZrOjuKWzvEjmDUOYgh4FGwQsGcCyyT3DlJdK73XFhz4BuqDCFc9waIxw7+IfXQwvp7lN7gYCmS7T3HoS76HftfL58ACS9jOOX+xCuxBfnwpP1KT+82Ys9G27RxIE0bvZkfbLoEWGr725i/8imkOmgOSXPUxDpEjQN5CGgVrzasB10Czm2HzL3DZFUpHqUdCK8P/yc0CSifLsLd4+TMJsTVb8bFWjwCw1/t0AAvftfnghHeadIVd7Xei7rw2wqr/aoukokSgWjUZ9uUysG2acn X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SEZPR06MB5269.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(136003)(346002)(376002)(396003)(39860400002)(366004)(451199021)(478600001)(6666004)(110136005)(54906003)(52116002)(66476007)(66946007)(66556008)(6486002)(4326008)(316002)(41300700001)(2616005)(186003)(2906002)(8936002)(8676002)(38100700002)(6506007)(1076003)(36756003)(26005)(5660300002)(6512007)(86362001)(38350700002)(66574015)(83380400001);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?cBOq+ByCg0/bc/LR2elN68xJrs4M?= =?utf-8?q?rPgZPmHIXE+cG5IbkSl6EAEwcSNIBX04oigUm3sS4Sqgp69duCkCmCx+AkDywg5Aj?= =?utf-8?q?SLmGFjw4L4TcdyTQQYjmnlWpfLXPCuU/8ofrmAT1RkpMhesD9zhWb1ZAfd4pG+R1x?= =?utf-8?q?PXdhE0iA0+LuKH78RT2BR+bKQpjaDWtOAXvJdXG5xhOlhhboe3umu4DUNmCw4d1qt?= =?utf-8?q?l08NEFL2v3Ew5p0K1OmoPFBiKNfOYDQH9cFUY2W5w5W7IoG8YuAIpxCO2dMfhJnb+?= =?utf-8?q?N0vr+eaT+USGi13C26u3r6GIitxySRhk/PqlOQSAYfUnJx3ZIBCVaKHG7NciQiS96?= =?utf-8?q?bVDLBkNOVHeAsALfEOrbNHpCNGVL6Z+PfA/mqNeJqya+2T0dKNusswCL39J1knF+y?= =?utf-8?q?P2Y6fmmZ6UEl1LUYTPbEkmmnJ3yZhtZS7kk3JzSn0ywPxCdWC2p5Acf1F4n9QdxRs?= =?utf-8?q?0e9g8QYPmNhPwRpxPEIjHVHR089F7W+8tYN43XkN104b1x29j71GTh+AIwW4KpT5m?= =?utf-8?q?Ja2ejO5s3uf8TEvOKVhcNujBtU0LsxlMU6lk1MbOujN/TKziyfkhM6ItBRiWor3pb?= =?utf-8?q?UU3GRrEcO07uah6yWYnqOcQ1Vo6+t0VMl2g5T6n1wul6YLhoGs+VVLFSordH89wT2?= =?utf-8?q?a2bV2+s12pzDojnKmTiU1e4b0wnYSeqEp8VfRGuSJbug9Wge/hOVcgU6xVzTeFaTo?= =?utf-8?q?+1DuSMg12G2XZL4e4dbT+YA54x5DVL59iORq46yrF/byl4MELysceXJdt01e+Rpep?= =?utf-8?q?qKzNmRox55lU8VNiKLDjra9RUvq0Gy2fkQvv/I5W6D1beZr0JqKXf6cssinO/ovq6?= =?utf-8?q?l22lkbvCnNAn4vmJKsU1q6sdqEDF0njTzSl7kmPvcXjDTt0c9UBXoxKWOtKANEjmI?= =?utf-8?q?SEhou5HcGIsgCsdssCmq/eWYcAb6pJHROXz3WXTq1xKAovu9uuLMHyTlmafPVCDaO?= =?utf-8?q?pVaFK9CzIS3wzZuUaU83nAJ58lH8fLnk914J8ISjFyE/CwaJCr75zUpJeJDANuHNa?= =?utf-8?q?kR6mdgWjRVeNkQpKdEaJKrZ4JFLQnctDdL3TTLlj5xc79YCUwwVYU3co2muUJgIqq?= =?utf-8?q?dmB2KklxCatAjlzV9pYdF9vGuN0DgJxMxG0ATRIyWsc8OXgnFDWcwtt/AfweVIsOl?= =?utf-8?q?0KFOgmr0giRcgjpnr0ysjvKvw04SFquGdEvsK/pdfjsWVrzrmWLvN+AJ0TIAg/ZDS?= =?utf-8?q?v1R6I44ZC/M42I/kpE3iKWoAuypC7crsiBUbWdFZ3TXIrCtQ2U9hipyChi9A0viKH?= =?utf-8?q?luKPQ/aUDYhVhbfJdvWSdGPIjVYbo1900wS95dNgCsB+QTWZwwrZ4lVtB3c0msn4L?= =?utf-8?q?qhP+zm4+TY8ihK2Au8cmzn+HIvtRAsVEKPZ2lbajv86kFW7AXDJV7WZTKYn873Brr?= =?utf-8?q?7gYInv08eJ23l0he/INSA+GU7JuLAqr/tWzTg+yQg4bWlFEu1o4YCDtMAGgI8cBLm?= =?utf-8?q?TXZcAZRps8nrdylA54nzaPeVzB8+wZmtYi+QXfMcki61bVkLJUmWbY4vNhUcJRAtS?= =?utf-8?q?ujB0D4SW1mv7?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8cbded1d-7064-4d90-b854-08db837880d0 X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jul 2023 08:09:38.4901 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: zfOi5MirEmZMeICPxfJA2CXwNyh98CiHD0kIFTBMSilyz6wn1C1lvSMYhjxxPUl4S9ziEj6Du6Dh1tstjkB2XA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PUZPR06MB5984 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1771294276931715187 X-GMAIL-MSGID: 1771294276931715187 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Cc: Uwe Kleine-König Signed-off-by: Yangtao Li --- drivers/mmc/host/wbsd.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/mmc/host/wbsd.c b/drivers/mmc/host/wbsd.c index 521af9251f33..f361cefcee01 100644 --- a/drivers/mmc/host/wbsd.c +++ b/drivers/mmc/host/wbsd.c @@ -1758,11 +1758,9 @@ static int wbsd_probe(struct platform_device *dev) return wbsd_init(&dev->dev, param_io, param_irq, param_dma, 0); } -static int wbsd_remove(struct platform_device *dev) +static void wbsd_remove(struct platform_device *dev) { wbsd_shutdown(&dev->dev, 0); - - return 0; } /* @@ -1904,8 +1902,7 @@ static struct platform_device *wbsd_device; static struct platform_driver wbsd_driver = { .probe = wbsd_probe, - .remove = wbsd_remove, - + .remove_new = wbsd_remove, .suspend = wbsd_platform_suspend, .resume = wbsd_platform_resume, .driver = {