From patchwork Thu Jul 13 08:07:48 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?5p2O5oms6Z+s?= X-Patchwork-Id: 119652 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:a6b2:0:b0:3e4:2afc:c1 with SMTP id c18csp1679203vqm; Thu, 13 Jul 2023 01:41:59 -0700 (PDT) X-Google-Smtp-Source: APBJJlGx2upuyuQzwY5TFvZ5+vcY3u4Z8L2KcQCeUxvnbOtcIFjpw56hYf2efoxaIBDTYxx5mYSP X-Received: by 2002:a17:906:73cb:b0:982:2586:f85 with SMTP id n11-20020a17090673cb00b0098225860f85mr839199ejl.65.1689237718670; Thu, 13 Jul 2023 01:41:58 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1689237718; cv=pass; d=google.com; s=arc-20160816; b=Ls1DGP4CuG6GwHkGDpJ/ml0YE3bQ27ghByuhN5hDkM+XgxdrYphgsCysz26zQ7BvKP hrO1Qqt+RgK0SjiFVHFVq6/4lukuerN9cFEiEGc40X/CiS8zAdIydscHbqj7jZh5OKxi RmRqn9xdWD956W0M7dpw3OHFoGy7Xr+7NEcPLRCExnb5QvccExBZUVG3v3SiBikU7LWQ jG0iQKN+bBMxx1qaZ+9NzvPC0iisv867gGbxRyUBoFEYWfbH0fBS82XNLJUUW5RwwOzn 62LzZR+q4vw+Hkm+SbbH/zFUZthkcOCP28OXiAKEFqhHhSD+E4lZ34ixi+fbQ3/OPQjj nY6A== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:content-transfer-encoding :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=ojpLTgBzv5+ZNx3nkgEvgE/P4GpJkxrZ7R2nyuhf08k=; fh=b9dHX9k7LQUBH7MV8y7hwirzK4SEG5gZGgG6c7DQpKM=; b=lMeH3p/qbsOknnJr1+5uQ+PUqSI2WE6ZyNNWia31RAXKt6+lX2jJIn/Km3wZ39Xxy6 8U/pTXJrJyExUhPDPrS9y4+tCm5rbQYn3abJI0x+r77Q9zURlwdsSZ5iawCZvUiHNGyJ 5On7XlS1VUakkqbJd6+fQuk2BwRDzYaXo64bC+WUMJABFdUT2HdPczp7YCcmxMWj4e59 ukI+lAlH5gCfjGeF9CV0HnQ3ABqnf+F/C6TVLzg/0b1zoLa0sU26s26LI48Az4S2hMEb Yrs6On9jWh0S1JOlbWpwOsWlLXb5KQRcZMlSr5TaNJx4ErTm2pgnERRcnFwgS3Is9+QT Q7lA== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@vivo.com header.s=selector2 header.b=qh3rwJGJ; arc=pass (i=1 spf=pass spfdomain=vivo.com dkim=pass dkdomain=vivo.com dmarc=pass fromdomain=vivo.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=vivo.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id bn19-20020a170906c0d300b00982a267a399si6348559ejb.561.2023.07.13.01.41.34; Thu, 13 Jul 2023 01:41:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@vivo.com header.s=selector2 header.b=qh3rwJGJ; arc=pass (i=1 spf=pass spfdomain=vivo.com dkim=pass dkdomain=vivo.com dmarc=pass fromdomain=vivo.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=vivo.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234268AbjGMIOd (ORCPT + 99 others); Thu, 13 Jul 2023 04:14:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50270 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233535AbjGMINc (ORCPT ); Thu, 13 Jul 2023 04:13:32 -0400 Received: from APC01-PSA-obe.outbound.protection.outlook.com (mail-psaapc01on2107.outbound.protection.outlook.com [40.107.255.107]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6C3E42709; Thu, 13 Jul 2023 01:10:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cIZ9YvSl/nmfAebVWG1I90bHS5PRDjV9V+3S+vCyi5AX7B2KQTwjuQNwf/4RLJy7Nq3BkmTAGIqCFQxYecKoWTSsY6/6gdsyq5lFUW9+gxSqBSpxo3cOVVad0aJqWP8nQdO3hbqskJmW3+5Om0mYwDF0nExJzP4v96KqCrUZ9RztubkUy/uR1a2SvtjZB9e8UVg9/INy3VdJCjeL9U+GtYf+CMRU9YBc4i6SEsq7ZrohdyZaiZF4NpwZ5tK/ht59tRlv/hjyREWRX64DkLhRdCZkCNyN1+YO2+cGJWCZhtSN8VXKFm1UXIii2XTAOpyJ5eWDk+A3dDQu7LsDivfp9Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ojpLTgBzv5+ZNx3nkgEvgE/P4GpJkxrZ7R2nyuhf08k=; b=gxXOqPl6cQgFGjaU6iS/BXkClbFhywTjjhMOkWp0XQxeWHYd3OGoXRkSPW2hJE5iOd+jnuZRhf4QVxE+1ZsXPQiCLi3DC6Sps1QNybW8T+rHe6KMfc8iEfXeeLSg9kx6pqQyfb02Okn2sk+xAluzKA57JewCawFiaD/SvrHXb0HzvIpVCaJXx/vMzLgtod2HuX7coYRS50qjNKgecZZohXZdp/865V4zyktKYTAhg6Io+WWQ1AceWo6fNZFrp0tXU76BuIGAoawPBZAMoefPSvezZ1bkPhksAztEPztOo0l3Bujnz7z8cKr0Kz3lQFERGrv3FXIyx6E2/jWfovmulw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ojpLTgBzv5+ZNx3nkgEvgE/P4GpJkxrZ7R2nyuhf08k=; b=qh3rwJGJdTTewpYVCZO5EWJBEjE9xlnjRsBANlBceMkI5RgEjcgArESVeAuMWAFLCVUWrjqxSHTWNljqa0Klo69x101S2YqYgI4EFBOKwLYsrXgMRH5skuH47kmz/kr9pJZnEIsE2ExVLFqqJKYaZudDLBy4S8tCxr1/Dj1dKCrqdCpmth7HyY6sfvNndeXyOVqiRPxp5J09mSve3DXkZXUuKRrVlfZzd00xo6QlohVpEA6naVge9dJD7p3RH7YWQqThxMXh89dvi968R3ev3yUJCh4sZ4vC78HZBgtmIibujFAG9qeAX6P5+lBHS7ZkjWLXxulwGyIDdVEbRKP/Xw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) by PUZPR06MB5984.apcprd06.prod.outlook.com (2603:1096:301:118::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6588.22; Thu, 13 Jul 2023 08:09:58 +0000 Received: from SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::fa0e:6c06:7474:285c]) by SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::fa0e:6c06:7474:285c%5]) with mapi id 15.20.6565.028; Thu, 13 Jul 2023 08:09:58 +0000 From: Yangtao Li To: Adrian Hunter , Haibo Chen , Ulf Hansson , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team Cc: Yangtao Li , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 39/58] mmc: sdhci-esdhc-imx: Convert to platform remove callback returning void Date: Thu, 13 Jul 2023 16:07:48 +0800 Message-Id: <20230713080807.69999-39-frank.li@vivo.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230713080807.69999-1-frank.li@vivo.com> References: <20230713080807.69999-1-frank.li@vivo.com> X-ClientProxiedBy: SG2PR02CA0091.apcprd02.prod.outlook.com (2603:1096:4:90::31) To SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5269:EE_|PUZPR06MB5984:EE_ X-MS-Office365-Filtering-Correlation-Id: 0d9d181b-c6c1-4d1b-4d71-08db83787b71 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: o2lo3VeOM0oFYnHX8j+bwqdHdrZyTCSGhx9cnq863lHCPWhsSKQVhSLJEz5Y4WCEsTjiIyRwXYW1bEDgq9PHdDSZVOz+Opcax7ta/7vTVZtrTwv4D0gFii6GhDPJfCuYogCnVh0XfQYfoz0eik3ulXyzOIjC+7txAHVS+0hXgFdtYpgCK4dJ1h8581QCrp1Cf4jfTmen+S6biGi4M9mUK+7pDStWd0uomIMHw2mDMQK2VVexMat1YfwG4RUjADNJ00pqkZAH+vWVhRrrVsRN3EF55zXk4gfNSZ8WobFmu8mDWiZWaSZ7hJHjVxs+DrU0+A/NA52q92BJXBPuye4YRzdkLu0HFx0JDKXHIEAOiiZ22l6yNFsX6g6/pgPSLWskzj1JgSWGDJELVyC1ZMSUO5HmWFeEp3RMdyl3kUzALsexBA5fZtgkHmtTfExoG2BXPHykIZmIW/jSunsJeoJ+dPSHCyxgTYLriVoXhOBv/b3XrlwAfMFi7ij9ZxlhrAt5c0D2o7OEmNrY6q53PJyo/qqAZluavXF03o6zxcU/1WqRNbCEvftIJ9IZ7GGmbpDA8HZflmJeT6FTrwclvR5bTkw7FHJ+lPN2uUp6zLKUrjb75TSYvi0Cb9j7Yz07sy9s X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SEZPR06MB5269.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(136003)(346002)(376002)(396003)(39860400002)(366004)(451199021)(478600001)(6666004)(110136005)(54906003)(52116002)(66476007)(66946007)(66556008)(6486002)(4326008)(316002)(41300700001)(2616005)(186003)(2906002)(7416002)(8936002)(8676002)(38100700002)(6506007)(1076003)(36756003)(26005)(5660300002)(6512007)(86362001)(38350700002)(66574015)(83380400001);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?1q349hkOwz1vwAXqfcFBPHaYRlwI?= =?utf-8?q?KDGC4tpk0O37/bqtm22n9YUXV2nqks7SsDYKFE3i8PUwkvcL9tWQroIVXB+hBzcL6?= =?utf-8?q?pwdoKnNpTQbGjsNtHQL5/6Ta81EriGj5PpSSF+WzXSqKKH/J8pZAeK2EGF74VJrYX?= =?utf-8?q?2NB+FysDPcyCBoV+Es6+urT+cwqq2C6xzSgYOTYxCLdtVMCKAoDkeAveC+gnxTefx?= =?utf-8?q?2PJbzUdKT6zCkiv+K1KPuNhNXvuYfh7hk8Z5jUO5W0sjBN5sD29aH4Ry+TctfeS7S?= =?utf-8?q?iAPuMvFT0Xu79lOWq5WY+qZm2cARm4eI31OZjUufPIUQPeqjYC5rP8TeHkwrEpNmu?= =?utf-8?q?8pLnp485hjsdM8aFaCAmfu1K4wZd0aToBx89+vA7+NlhSgO2K8Jhtp8LyOflM631/?= =?utf-8?q?OY4Tm5c9tytvIbnPUM5w9qdFvjYKYBv9kYTDQllBrCfe6dRDSkbld4FzsVKVDaHb8?= =?utf-8?q?QryG4qXh75dIj86Or35f4fuBPuH+93KVQ+8O3MJkjMg0XKcoKuhwZGNE9BkfpA3ES?= =?utf-8?q?1o9Bwqe5ZTVCdVuWDwbwcJinRCMTymZih2HPo7/m6NKg3EYxiERF/gCO6/KMQKR7N?= =?utf-8?q?ndJhg5we9RmhHdPtq9RdXfCOv1wcdqa2JQ3Uv+8N4GN70rTbB4bA+Fw3qZZUsymz7?= =?utf-8?q?LtZkub5DhcBmBWGIN1EZAcwQBy3MrqnkMmru6RGpKn+Okr7ubsUNmQWenkjjNwg4d?= =?utf-8?q?pc+/MCkK7IliqJGZHVcPtCDOtscbm1CS3pMqIaVB26nl61vNuMILlxVYR9jTKz0Zh?= =?utf-8?q?+efdcZ1WIhzz65KFPo+y4+f/zx277luIkuVKDDF5Da4VnQYIqcCTe0DwC9QQsXkos?= =?utf-8?q?xHrvnxOu8FruQ1uzg0D4YUmxrtYXTW0ROg7gRqV3UkX+uFa/D3BEhqAGvpRUOFXEl?= =?utf-8?q?JjA96q2NkrG217nIKFrCWUA2m6tWPiXa9rmxZaq2jnnuOIqPYtpTyhsJC0YpASZkH?= =?utf-8?q?WIDE5E41UMDB7q1FIRa6+EbeC6vXU/dt05jTK1wISew78GlNVuWNnptMLuH72yny9?= =?utf-8?q?4ECDRfVllDGlYuCj29nCV9apBnH87n0iitKhRb47lgm32pD9buVjRZ7BqqXN5t4hi?= =?utf-8?q?TQkGApmctVqEv/le+Olvl8z+9AzR+rTooHxD1p477JySbgIt+rvQUt3XlK693okQW?= =?utf-8?q?S17tgemOt3BhP+f/zhz3RHqakP8RJSBMr6Q9k6aJVRZjrGVCGm2lLxzMz8Fu77l+s?= =?utf-8?q?NIQC/Az1wL2a7ShAtFLEUyf/Jfw79j0oEStqQ3yYHYRMchnEnL9ePpmM6uTPLX2qF?= =?utf-8?q?F2ApIfAhmnO7ZYXscO6Ri5E/UQVn4NtLpkMq1piWzRs/nsD+4UgzCwlZsZjVByoOy?= =?utf-8?q?q6rBCvnbjxkcLt7P4bpWNeBPYWvyOD0z1k/G51GYfEsOGovCsvpZgQBNeTu01mNhV?= =?utf-8?q?F0tMklZW09xDU8h6ZP2FZ2IqHY6JO8BYP0X0/kbl5u0gpjwIb1e7/tOdp6PXY+F7f?= =?utf-8?q?aMAMeLzDwRNvRlB0ByLj9Z9bqExG7cxwHbVJXZohz+RGHE9DRDOpO0aJpFDRCDiOL?= =?utf-8?q?BvAvNOEmJSCN?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0d9d181b-c6c1-4d1b-4d71-08db83787b71 X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jul 2023 08:09:29.4831 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 2TJBdXdwuXVCa3KrFUe0N/EoNfeqLU9IL0M3wyNcq4+P9xvMsdP/LDD+Te31xGjkBYIUdmW09cK8BmNNsqP1WQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PUZPR06MB5984 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1771294130294969440 X-GMAIL-MSGID: 1771294130294969440 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Cc: Uwe Kleine-König Signed-off-by: Yangtao Li --- drivers/mmc/host/sdhci-esdhc-imx.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mmc/host/sdhci-esdhc-imx.c b/drivers/mmc/host/sdhci-esdhc-imx.c index eebf94604a7f..e882067366da 100644 --- a/drivers/mmc/host/sdhci-esdhc-imx.c +++ b/drivers/mmc/host/sdhci-esdhc-imx.c @@ -1802,7 +1802,7 @@ static int sdhci_esdhc_imx_probe(struct platform_device *pdev) return err; } -static int sdhci_esdhc_imx_remove(struct platform_device *pdev) +static void sdhci_esdhc_imx_remove(struct platform_device *pdev) { struct sdhci_host *host = platform_get_drvdata(pdev); struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host); @@ -1824,8 +1824,6 @@ static int sdhci_esdhc_imx_remove(struct platform_device *pdev) cpu_latency_qos_remove_request(&imx_data->pm_qos_req); sdhci_pltfm_free(pdev); - - return 0; } #ifdef CONFIG_PM_SLEEP @@ -1986,7 +1984,7 @@ static struct platform_driver sdhci_esdhc_imx_driver = { .pm = &sdhci_esdhc_pmops, }, .probe = sdhci_esdhc_imx_probe, - .remove = sdhci_esdhc_imx_remove, + .remove_new = sdhci_esdhc_imx_remove, }; module_platform_driver(sdhci_esdhc_imx_driver);