From patchwork Thu Jul 13 08:07:45 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?5p2O5oms6Z+s?= X-Patchwork-Id: 119676 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:a6b2:0:b0:3e4:2afc:c1 with SMTP id c18csp1686436vqm; Thu, 13 Jul 2023 02:00:43 -0700 (PDT) X-Google-Smtp-Source: APBJJlHqzE2aI3MREw2ElgqeLAHev2aSi49Y3gTWFNc6yatUFhAShE7QFu5DpAgxP1x8i/8GgL8x X-Received: by 2002:a17:907:8197:b0:991:7874:ef71 with SMTP id iy23-20020a170907819700b009917874ef71mr727170ejc.44.1689238843243; Thu, 13 Jul 2023 02:00:43 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1689238843; cv=pass; d=google.com; s=arc-20160816; b=IDYuHPSbS/SeAVDHkNmstaXiFNX+CbP+eu/FeHf7EypmxUFDRZBo919VvKJPYqBaAr O/njugiv7/smZSV/HR9mtcCkBnQjBbiazeOZcggdbPELk3Xe9l9m2tdsmWBIPCsqjT5c briNSNh0p27IMWtupM/WHOVDwjlCdxCQ8mUb7f5SaRxzXFk8ENr5YCjiMRNmzd60ugTs 6gE6wrLIZKn/y8iLhTtOCodUYxmHXUcTyCNdlIjZZaOwNfTHXkjr0AcFpCrQCgUuQb+S Ye44xifbmqUjU2zs/aSYQV24iUi4eInBfmt/nl0IGyQqOA65Nd4LH8N4m5HYViayiect Kg0A== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:content-transfer-encoding :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=iRmZXFCwumSmLXQwjvRHThU5yBcyjcWZ8ZYYoqniSk8=; fh=0b1WHgzFaKa3wEZ+TH0lsKqGVNqDKrTFnhkKsch2fbM=; b=m1alhSQSV8ob1Wa5s+m5O4d/MrfCYCAjJO05T9yg4Um+6DN/WRIHTt+bKifT19uivU GoOD7Iob9KdZB99z+wq1Lpudea2tSeh+GEVm7yKIU72e3y0l6eXZ430aqGQCfnNVggaJ GCMwH9YrHQSBPJXuePGew4wuQNiUmoPlbNzNOBI6/j2y42K6HrU0kg7bcLa4JbemHB4G num3k5dkMyZqDP65OvbRojh8jawYBzKMfRUe4LaKN2cnBYiPPscpHp4VyXphrYgl5u+A 4M7C5FKvv7dcOZoHvfvpJradH3FN6k64jjDYA6RN5VxrAINrMxmud3fhBrOWgWv8K2gS Pgug== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@vivo.com header.s=selector2 header.b=JOzyjoDS; arc=pass (i=1 spf=pass spfdomain=vivo.com dkim=pass dkdomain=vivo.com dmarc=pass fromdomain=vivo.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=vivo.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id m9-20020a1709066d0900b00992c195ac80si7115615ejr.357.2023.07.13.02.00.17; Thu, 13 Jul 2023 02:00:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@vivo.com header.s=selector2 header.b=JOzyjoDS; arc=pass (i=1 spf=pass spfdomain=vivo.com dkim=pass dkdomain=vivo.com dmarc=pass fromdomain=vivo.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=vivo.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233042AbjGMING (ORCPT + 99 others); Thu, 13 Jul 2023 04:13:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50382 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234052AbjGMILc (ORCPT ); Thu, 13 Jul 2023 04:11:32 -0400 Received: from APC01-PSA-obe.outbound.protection.outlook.com (mail-psaapc01on2100.outbound.protection.outlook.com [40.107.255.100]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 49AF21BB; Thu, 13 Jul 2023 01:09:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=U8TN/RY/M++kKH7+r5s5Z2vBrf8C3UkF2myQXxhwkps8NtIegn3HYZXyx1cF7K5CjSdaKmK5dmIn4/mqjLP8X+dLPl4R3Q4rmtuCie8o6sd8yYNYkgrfJi1mLIX9eawDgFqS7NDCYMtmyW7rRgJzxxsRvWw4l5NXtym7JqZR91bRVc19+CJWLR6jhVGsEQ9D39Vy6yWF+bUHdhk9wbhmdWo/zNY6ItjfYSXh1PJ2LCA3X2n9KJBPlSDwKQf/E9OCf7/oA/z2Rnn/M5bX6z/3KjDWMjPJWFkZv/8y4+kUdu5+EBVPvvm5WOG27wRFVwmIMUveSWZ4z7Edbqn8jouUCw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=iRmZXFCwumSmLXQwjvRHThU5yBcyjcWZ8ZYYoqniSk8=; b=jsSGgsy8eEQMX509+bxl52GLpLeEE7fjLnU+TzkPIkrAKd72Fucx3w/KzocHBs6WO9NqZgwpxclM5fjZ9/moMbZkckO//5RBd5gRzF/1Ey/XnQ/Tgx2fly8zNM2AyiCNV+HSTomO86UtV4VEcpyy5c3cfAvwfzfnS6+cQJTQknprELFDYhmdl5xsJPE2j3oFvJUDeck/rZ7XD2IVAtBHQbCmNu+blFaZDpF47wEKs98S+tq4ieQY9REjUJK/Q6dqjrpts+PIpel6NFzaAzLhLG2+IKPXRoGSzIRI/KQPhIHuybimv/XYUuHC0iCq3771FYE1VcVeZ6xOZ1a5ja4Hnw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iRmZXFCwumSmLXQwjvRHThU5yBcyjcWZ8ZYYoqniSk8=; b=JOzyjoDSQ3KG3ckIZpJqyc858jSyD5vd5qM5/8jbp2lWad8H/6koQeimFKHr8sBujlKOXVRciFKXAhfckTbALQ1F+fMcMgCsQZoAgZQ7rPdeJOz6n23PZiLKZm1oZa5/gA6bv9feg4QcyYUGzEyMi2wDMIZMHXsGQ5/+jiPQzG1R+7qcOSHku777bC7ac7+azmWQFujbuHQiQ15B6w7zmUeVZDc3xvxzsnx9S1yqEkCesQNuNtg7vS8PNr8ndRISPIBG5eQ9fn7yuOotSLcvudMT9AnuULOT48K3zUWYVqMsKFlrMAKDLe6zKczy1ZRQ/Pun9A7lF8udl/LCmMYAYQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) by SI2PR06MB4409.apcprd06.prod.outlook.com (2603:1096:4:15c::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6588.24; Thu, 13 Jul 2023 08:09:24 +0000 Received: from SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::fa0e:6c06:7474:285c]) by SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::fa0e:6c06:7474:285c%5]) with mapi id 15.20.6565.028; Thu, 13 Jul 2023 08:09:24 +0000 From: Yangtao Li To: Adrian Hunter , Ulf Hansson , Orson Zhai , Baolin Wang , Chunyan Zhang Cc: Yangtao Li , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 36/58] mmc: sdhci-sprd: Convert to platform remove callback returning void Date: Thu, 13 Jul 2023 16:07:45 +0800 Message-Id: <20230713080807.69999-36-frank.li@vivo.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230713080807.69999-1-frank.li@vivo.com> References: <20230713080807.69999-1-frank.li@vivo.com> X-ClientProxiedBy: SG2PR02CA0091.apcprd02.prod.outlook.com (2603:1096:4:90::31) To SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5269:EE_|SI2PR06MB4409:EE_ X-MS-Office365-Filtering-Correlation-Id: 312846ec-be51-4a84-60a1-08db83787831 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ltSQOnqZIgVizz71ttodLZPPVNaL6MfA+lzxtmHsiOydId2lU+GF+Olp7VJWjVeB6bJYSVs8zYYbjVAVemqZUIwIn0x0SzjK0lAndTaJXDwKzqxnHb6jgO+P32ZKov4o6+wzyhMaYx48eo7+++iJmUwdQQ9hNKtMdsE9LdCeMuo1+G0XcBXygZtpu9PSgzKQI8Okmn1H9JZ8OKJ+wXierUn9OWKvD5nZxEIuVfNzlxSFIZJqzJS/xk0x5+DJ/kHo1N5z03e00Adn6PAkpqjVZd9oBYwro6F4q8oNsw/HOkzcufUMP+GddssoSJNO2jAMgZoDeZ5yqtEvcaqVxFblwYleBRE8qyDd+Kzws6wOthTqKzxrogFPpJmiAd8Wa1XsCf1VuHpSjfPEspEswYDMo2AVQQg7FSeae7aR2NicamW5ZgLIY6JkqxKxlCwEdgqIFVpeBhgrn8RdEuJQWoeCut3AVGVxmgOHJMmrSd4t0Lsm21ypSRRgQTew2n+dscxD1JldnQh5bcIGLk6Hf/+mEN8hGgCIkwk7jyowsuYTXUXjLCowB7pQpqyI8RUydggPNDSBrcBfCSzQLtjcFd3RvJ8KcF1QxVs53PKPP1hiAVwitYcJYCYmchFMG+j2FDYC X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SEZPR06MB5269.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(376002)(346002)(396003)(39860400002)(366004)(136003)(451199021)(478600001)(52116002)(6486002)(6666004)(110136005)(54906003)(83380400001)(2616005)(36756003)(86362001)(2906002)(186003)(26005)(6506007)(1076003)(6512007)(38350700002)(38100700002)(4326008)(66946007)(66476007)(41300700001)(316002)(8676002)(5660300002)(66556008)(8936002);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?uNgZlO6nq2F06gjTJHseYqxMudHY?= =?utf-8?q?iw8bJcaI6PCPY4KElV64NRWJuXfADYj4JLLxiAldJsnRwkfjaAJlVR65zD8O4om7g?= =?utf-8?q?gLm1PksAGjAsdXVJWMHMRNUfRPiVTnJLeiYoFVwHIYRX9hppn6hmi60hkW3aoJw4f?= =?utf-8?q?GP7wBdR5CLU8hBAzwM2nixycisczJeCpDQ9209EqK2E/oXKMD5C6eITLVhyIG1qI6?= =?utf-8?q?k5oempDG1vmvYX9WwvWtiyJrJq6CUrBZ9qpgxAufz9uKcS0YfrqgqOYnUXKwznrDd?= =?utf-8?q?jAetykOaBK52hl1WP2UIbranIjxJZt5oS91G9CBpBwq0Oh7TuxmUAmPrkmNIJTYot?= =?utf-8?q?jkhVUwoK7/t1r+CuTEt8LCySjzJLCdb4sDIibhn7ipddxLbWgyWoNeUudVl/e+8Zy?= =?utf-8?q?v/OX/BbXh+gSdQKo8n3enAQZc+RfMAIbt7/AMwNgBqdaBaow1SY+HafRF8jXtb1gq?= =?utf-8?q?3xNr5QhPfNDlNPDC+eWUfj1bA34CFOwT4hnp/uAV0KfYXwPkikhbPbqfhLH7wBegq?= =?utf-8?q?3GdpIHNUWArT0mWyh3sn7UwvXFQR15vdcOcmeN9ka2rNbs/karrdIdaTadKGPBJnJ?= =?utf-8?q?hqvF5I42z+SWmvOXnRAdwQ5GYp8pwNblbyqVL7i9bOv0SE3FN/VFHEYA/P1hLYjQ3?= =?utf-8?q?dQ/aLX9uWV4pUwFO0VE3IbVHcrbAThgMBuMzsqfWPOp7mioj9YtpGPItPJgZ/sQDK?= =?utf-8?q?ysMYLAWQYeO24iKQlZC/5ohaJ79VtGndtyX+JRmXQDFOQbUGZURC+UcT9JoIcithh?= =?utf-8?q?MNi6nqRERDdgiE2whOuD1ZJUVkcalV6Kix0R3uPq9klt+kuVpnSmcqSeX4XmFCuez?= =?utf-8?q?XINlCTPhAm6nR0UFc9RdVevcNl5RFKjYCTb4Y3il33RCbPu4YpbRX1n0lJ0Kf2E96?= =?utf-8?q?gyF+ISJDTz6u3GbUGmu/tAMLxSPNKAPvRSvW4mim3GXtgDCbQqd5hwbaQgRvfwv75?= =?utf-8?q?q5SQHwVDQQv792SHmKgxNjz++Dfrf5+Y3479WTiHk9L7oXebv8fMYiy29MeODZpHT?= =?utf-8?q?b/3uovH2hxFuOLFYNowL0PfOHLIzVYuHMQy7jdpCsBJVRjDlJVLkdPuub9G525bQt?= =?utf-8?q?QBSKX9hylRc0SRA4XHRUpo850wBHriOJYgz+JYOEASzOjDl5FF1ZJTKxh1ynWgIAw?= =?utf-8?q?LoVbjq0UXxHGiROl5Yz+dkYNmIfEgdosSpTQfHXcZfIKd9xLqMYgBkn2wxv0h3dP1?= =?utf-8?q?PEdyT0vlA8gDI3/bzx1iZooEBk4Pat0JUPSzaRtw9cI7UN5eE4pWZ6gNoBvbNeTlV?= =?utf-8?q?7qxxvVAyyFd40H1tr0tzC4Q/Uj+8H6B51wze5G1w3UVmHG+VW9Y1qzPeGdGRPgmiD?= =?utf-8?q?Sp+tH8t4E467mUZh46ZQyrsu/i9Ffv+hdiYI9Zu1FW0C77GwY3i+yZzNvnd2NkiQI?= =?utf-8?q?IN2uMesZufj0cSU4nnGoTwj2NwpW8Hb6ni98N8AYeEIeiPC277ljN5z50f3kv2ZvL?= =?utf-8?q?4RDRmASR22//tXZXc/C//EhERQ3ZoELV5bffXG6GtKyipBIBeSaJLF/aHLLie9bmW?= =?utf-8?q?zJfR09mXwynw?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 312846ec-be51-4a84-60a1-08db83787831 X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jul 2023 08:09:24.0414 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: hE6FkbKXjWPVcOwcgkavleHyXAvExoTkTAloAbgwmgnnch/bgbJVgXnTDB2MEZDTjQhe74wCQ/zlg7/CyV46dg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SI2PR06MB4409 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1771295309368777173 X-GMAIL-MSGID: 1771295309368777173 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Cc: Uwe Kleine-König Signed-off-by: Yangtao Li --- drivers/mmc/host/sdhci-sprd.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mmc/host/sdhci-sprd.c b/drivers/mmc/host/sdhci-sprd.c index 7f4ee2e12735..379cb3892757 100644 --- a/drivers/mmc/host/sdhci-sprd.c +++ b/drivers/mmc/host/sdhci-sprd.c @@ -720,7 +720,7 @@ static int sdhci_sprd_probe(struct platform_device *pdev) return ret; } -static int sdhci_sprd_remove(struct platform_device *pdev) +static void sdhci_sprd_remove(struct platform_device *pdev) { struct sdhci_host *host = platform_get_drvdata(pdev); struct sdhci_sprd_host *sprd_host = TO_SPRD_HOST(host); @@ -732,8 +732,6 @@ static int sdhci_sprd_remove(struct platform_device *pdev) clk_disable_unprepare(sprd_host->clk_2x_enable); sdhci_pltfm_free(pdev); - - return 0; } static const struct of_device_id sdhci_sprd_of_match[] = { @@ -800,7 +798,7 @@ static const struct dev_pm_ops sdhci_sprd_pm_ops = { static struct platform_driver sdhci_sprd_driver = { .probe = sdhci_sprd_probe, - .remove = sdhci_sprd_remove, + .remove_new = sdhci_sprd_remove, .driver = { .name = "sdhci_sprd_r11", .probe_type = PROBE_PREFER_ASYNCHRONOUS,