From patchwork Thu Jul 13 08:07:41 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?5p2O5oms6Z+s?= X-Patchwork-Id: 119635 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:a6b2:0:b0:3e4:2afc:c1 with SMTP id c18csp1677117vqm; Thu, 13 Jul 2023 01:36:54 -0700 (PDT) X-Google-Smtp-Source: APBJJlFOXFsYpl/tya9LPknjoupgt5gu/nzIg1t8DgIUiVsIxsSQ7aHrQBhJ1Le72NF3Dc5B79Ho X-Received: by 2002:a19:8c04:0:b0:4fb:7592:7e03 with SMTP id o4-20020a198c04000000b004fb75927e03mr665620lfd.20.1689237413821; Thu, 13 Jul 2023 01:36:53 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1689237413; cv=pass; d=google.com; s=arc-20160816; b=RYofIDkFnrPCLT76Q+aNG9MBUp+Np2FrCorl8rpqOTQq1o3eZWfsxVsg0UZCsCpfmp +Zn0I9Zk8WRdNlXOyOpmxywqgjbTfEaI48RWR/KMOiThbSLQ6Re67wIzvxwF2lUrq23X 4gMU5tIa75IZoaNN8It7vsuV4SK1n9UyltO57zQq3Kz32t0toUfcDebJZyqGivmcU1VN g05OXEwbwPy/RvBOoEYJ4czhdhkYO44c/4fbyklb8c341M3TG6rrN00Y+kITUeJ00RRB qAilfqOpjbBzvI6BsikEgsTrVGQKraMAjEZwjHniU3g+I6CBOMh9ZXI0GCmqqMPNXknL 0OdQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:content-transfer-encoding :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=wifvEmyuIqm8s70tv9XlGEIJA4YhoVtEMbmSaHweM+o=; fh=ZYodWTe0KCUO3NR7BtRFAqGMu45kjt7wn2F8buQXmlM=; b=bcCgrKj+Zu3/ZZ6CZ3tGTcJu5h407qLh7y7JhEKHEuNYunJf4mafLN9T4dHJFiI6/m WE2/PhJ4Re616nfbSB0Q3Wglzyi9lcc7wf8xI7GKqayF5tGiYt43d99mPlVFvpxm7goB 38Q/Zs/XYOn38hqAPWqPFcI0YkYHv80pB+17FPCSCe72AKI3WgSxnfhfuyl7Ez/tmaJz 57ImZrHzJZw8xjQBMkcjRNMBsg95P1mCv4EYfywzQavyZWhoNp+Tn8SG0F3K6EtN1Kai Mp90ZKe87ImU3nPQ9oMaXb2VJC56bdQtgyNU5nvhpkpFqsFpAwP3kcEfPzg9yJxp0HU9 gDew== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@vivo.com header.s=selector2 header.b=j0V6J1jy; arc=pass (i=1 spf=pass spfdomain=vivo.com dkim=pass dkdomain=vivo.com dmarc=pass fromdomain=vivo.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=vivo.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q7-20020aa7d447000000b0051dd487b0d6si6978472edr.361.2023.07.13.01.36.30; Thu, 13 Jul 2023 01:36:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@vivo.com header.s=selector2 header.b=j0V6J1jy; arc=pass (i=1 spf=pass spfdomain=vivo.com dkim=pass dkdomain=vivo.com dmarc=pass fromdomain=vivo.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=vivo.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234371AbjGMIMu (ORCPT + 99 others); Thu, 13 Jul 2023 04:12:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49580 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233833AbjGMIL3 (ORCPT ); Thu, 13 Jul 2023 04:11:29 -0400 Received: from APC01-PSA-obe.outbound.protection.outlook.com (mail-psaapc01on2112.outbound.protection.outlook.com [40.107.255.112]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E729030C1; Thu, 13 Jul 2023 01:09:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Gd1DWizDWwyRnVwfOJF8eLlVhQ2vzfX7vHMGaOQD6QHuvNUQIekz1Nq3PelzPgiqpuXQWhe4au5Q4xeAAdQLs8PaT6e/udouJsB5e8N/I9fBC4Vs1CjKhlyQqQTfSmXMPfDr8+KAFfGwFMI6SFGpDbop3taj1vvwMJ5nTb7GGdAkSe5IV6LjXusgjKCFi405SZ1WxOG5DulLfwPT942xbhfJUYD1EUtgyy6BmzQwym7pOg+NbVGtAA02+OTSPXN1F3Y4l0npM2vjratD6ef/5UpYFQaB7J+2UGbkk+sT2YJC9NPiseLrjcnb8kaY/K5Yt0//ftNlTbjqjURsTFLJxA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wifvEmyuIqm8s70tv9XlGEIJA4YhoVtEMbmSaHweM+o=; b=fTWqCr5JS3HEkTeBRqh9psD/fH0jUFwc0h/0916bSKkkNcUk6XcFazXUileqvkFaZla+p6OtdQDBZF/Cl/8katfC9IihgRwKmJpmvIQrU4QnkH+kTXzVHV6ZBDsSIughnAnlQCI0YSUvdOT8+NpB+6e74PYfBAmDGWcg4C77jee6/BvVmwP0aPUOUgxU+KizsJq502fCBKzDF9fGgCF3a9aT9c79ehi2BWU9oXrizDM5E0C4+BxsFYiIi228BzUKIVSKklL/T7YxJmjihluB4IJ8JGQrOPYQ6FX46w7fCXcUskghaY6B3onuBhHjrzfbrZ2oQ4vEUhK6kVA1/mLwcw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wifvEmyuIqm8s70tv9XlGEIJA4YhoVtEMbmSaHweM+o=; b=j0V6J1jyKx9Dj9+gsH/uNM2jBTjDwD2gnhI4wW0gjM3jWDLMhttPXLRrgCn3YK+HzhrW3CrrMeM76gdQLmOaRniqbIv8YQcBvs1yjvZDkbxb2l98ia2I9LmEfu35A6N+ynF9AMUQgOZLXNlU9M07po1YPRwpRVQOA5TkqPWdLfKpkqRXLVjJEGGymaGSVPV/rtZqzrCpDGCU4dP00KvfFdosoxoMAP7BEr1ZfvKB+kpIO8QcXWhwYJAwsI9vyAQWnvikA1v26mOqnuyRkhz8bd448m2/jbOBF+4mZVthUOisWK9aqFR0IOHwwCL+2L+TK0mtOJLn5Jd9dUx+rUI7YQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) by SI2PR06MB4409.apcprd06.prod.outlook.com (2603:1096:4:15c::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6588.24; Thu, 13 Jul 2023 08:09:16 +0000 Received: from SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::fa0e:6c06:7474:285c]) by SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::fa0e:6c06:7474:285c%5]) with mapi id 15.20.6565.028; Thu, 13 Jul 2023 08:09:15 +0000 From: Yangtao Li To: Ulf Hansson Cc: Yangtao Li , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 32/58] mmc: moxart: Convert to platform remove callback returning void Date: Thu, 13 Jul 2023 16:07:41 +0800 Message-Id: <20230713080807.69999-32-frank.li@vivo.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230713080807.69999-1-frank.li@vivo.com> References: <20230713080807.69999-1-frank.li@vivo.com> X-ClientProxiedBy: SG2PR02CA0091.apcprd02.prod.outlook.com (2603:1096:4:90::31) To SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5269:EE_|SI2PR06MB4409:EE_ X-MS-Office365-Filtering-Correlation-Id: 0e05fc2c-0cdc-408d-78cb-08db83787319 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: LbHvsRVkHupX0Qln1hb0AWarMt+pzPqCnCuCA0HQ4aCae1AnqeWroUPWLD+3iqxRR9msUDPhHHZO89l5+NCB+GJLpmoSMHQAe/VS2z3rreccYcnUOpbqnFOrCAX8iVFVs1d0mDMMql9kRerPMX5LJHrtEnOEE0jvdBNwJOBGEi3W3w4rjMa4tXKYi5Az05JNghVKedWrqt59RzNKHzkqsxC04LVgVgtCHDfzKvQYDEuCB79Surhwhk/rN5hs/HHFlv7RALAgwxu7jxUW6MoEixkjRr5bcL6Ps9B7qpDtEOYLsRJwBS3bUPdw98s7B7+7v432H9xXs1M7CnBFui+LgPm6aEsl2SlVrzLrWyJ+g7qMZ0AnXz1y+rC7OYBSGMwzidTulGSZBc2+8Hgk0QNi2XKhaV73R+dTw8rNCYme7N2vvn1hlxlVsOBjJUG1ZyVI1+qPokiMoOR+UBRZZPY7SoOKhTwAQ9c1z6Ypgpp5yKN1oEiL8UY4Rg3Tj5SMIXZKPCcsSqO2VjEZxZy+VZyAIrdncbTFpzs/IuFXvMeCyKEQ0JaEtuMmFTFtcHT4MQN/3fC35F36TgAIQF1UyMBxvFRqarXh0Cb679Mld1gduwuqadSzh5cBp5v6aMUrrKu2 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SEZPR06MB5269.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(376002)(346002)(396003)(39860400002)(366004)(136003)(451199021)(478600001)(52116002)(6486002)(6666004)(54906003)(83380400001)(2616005)(36756003)(86362001)(2906002)(186003)(26005)(6506007)(1076003)(6512007)(38350700002)(38100700002)(6916009)(4326008)(66946007)(66476007)(41300700001)(316002)(8676002)(5660300002)(66556008)(8936002);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?fxrjnQXLnwalowP5j06N7i1ZuG3p?= =?utf-8?q?39rvAX2WGsjvKNoOj2AjROg1qYa66HpIOd+V7jpniRao5hPvc+LwShwSIwwdkzbiX?= =?utf-8?q?mS6onohDaxUOk/iSZAcPMGDWsERRtAc9kOU1EEt42WudU/9TdlBGQpUC44oYrX8DO?= =?utf-8?q?8SAe8NWjXaDr+Z2qk+jNLr1ryK22qASJ7nGJdiQG+FNtn8P9rAvtt0wwumIkxz/xS?= =?utf-8?q?vOJsTLSxxH4E+PB0Ee06zFRRCecibwx+kf9sEgxQv8rjHfzcxDkLP3D9pKVzJbNoy?= =?utf-8?q?hu4/4WObP9dT0QarawwoY9osOfljJLaagsegCk90Duz9OlGHEbYrtamHljKFvy0Vb?= =?utf-8?q?mqRCG85Z7cFl59RqqOSGjo7vls9P+szOQ8GsLiM6b2RAyqAvABqVYOmbBJu6jo3fZ?= =?utf-8?q?rGEFZhua236mZnsxFXDtzFnEJofwywMQbXnnzl+8PW5J5sM7KvBNuY+QFE1Wovx1a?= =?utf-8?q?hMyPKL2g8UZKTpedbqxD4EEtT+L776L+PZK3N6du0UOVDXtJIRCx36VkOaOIZAw4U?= =?utf-8?q?bf7CXWQ0FVxsymjZZ3Doh70JAnhXb+dJ9lvaao4lE8Z/+D3aIJTkb3hLNZY14Mr/B?= =?utf-8?q?FKkr5L3UTrPS8p9/PFrrvZIlXicuPnYt2897X5uvV426Qx9M4XjE7iWPLiVmFGQJq?= =?utf-8?q?dJ6D/kFI1L0y31QprDnWxQ0ljlpgFwO5EgbWwSaZh4eNnhcI6LcM8/Mvf0bnfxwab?= =?utf-8?q?ZBzbJNr4btappnrKjAG8G70d5Ha2Y3a5PdfoFqtp5h8qzLorgCycI/NHs7ghBUaZw?= =?utf-8?q?4D9j4tdh8DOspGFHg0qOsUDynCHQqMD0hNGCLwh+uKebcX0RMUeuxVh52yjrRCz8a?= =?utf-8?q?AiZ/LsxuKvYmfgkQDE0bIAI3eRW/LSklHOMqlwtnSWca3/zLmNYce2npuO/Xj3ixR?= =?utf-8?q?+/3MwItduu8agFvJRnje0uVgdyCH18+kGkUFANnLy+vH1PaClXpZGRPnDXXaLiK7w?= =?utf-8?q?IJB2T2iLuDqCB7SUKFox7GFNxXzRCgkOzsqmniIf7+N2yXYqSdzE3OUcz9jpZ5eLh?= =?utf-8?q?fJ/PnE1rMOnCMSb5bXm7nJWg+3G7FODkId+MwCvoQDyNM4wpg64odzbAMkrcAIzuu?= =?utf-8?q?EEvr30aB6ueB0mPXwOFyJDhrA8LSrfPqJvMwqKfv7yqbGps84QaxnYtX1FFoajWbx?= =?utf-8?q?rutVW1W/OcehxqRg71kaJ3gmr7+tmDVU5iLKy8ZY7OQGksZO1WPCd/Ttpile5PJCG?= =?utf-8?q?AExxsQggF8Q3kdrKKiKF5+qJ23LIsiZX6+3d8RDPU57UKlvoVVZ0++OrE9DG4sPBD?= =?utf-8?q?jNmbbkI89uIv8kAyA9LjGAhAalGGMPAdI5a0/y5psgAiN+Ol2dJxDVf+bPBT9jF3B?= =?utf-8?q?za7cs84Ui1RjeKtejXzmCtwQI16DOgKDaM+j1WsEb4FX6e0Yiqbq3Ak/TkCltLQ4h?= =?utf-8?q?9ur/Y0F2D/ae+mgulKgBRbHPg515jjBEBgRTWs91+xxeoxW1SDiKQbeSClmPlGSHn?= =?utf-8?q?1rRe+3nwhOL3U2Xi0c2US/6TQ5mZWjYTG44nngTUg0DyFgEAdwKm3iwO242MbDyxq?= =?utf-8?q?2x8yV0jq6QhN?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0e05fc2c-0cdc-408d-78cb-08db83787319 X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jul 2023 08:09:15.4686 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ykh6j87FJvUE7UqNACcsoNUM0ffY9qC8Z9DZc5d4yCoP7tZYS8f+Nmtrkx2T6rGEFMLxWLSuUhgLOqEcGnSUfg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SI2PR06MB4409 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1771293810339014339 X-GMAIL-MSGID: 1771293810339014339 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Cc: Uwe Kleine-König Signed-off-by: Yangtao Li --- drivers/mmc/host/moxart-mmc.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mmc/host/moxart-mmc.c b/drivers/mmc/host/moxart-mmc.c index 2d002c81dcf3..7d35476c9ef4 100644 --- a/drivers/mmc/host/moxart-mmc.c +++ b/drivers/mmc/host/moxart-mmc.c @@ -693,7 +693,7 @@ static int moxart_probe(struct platform_device *pdev) return ret; } -static int moxart_remove(struct platform_device *pdev) +static void moxart_remove(struct platform_device *pdev) { struct mmc_host *mmc = dev_get_drvdata(&pdev->dev); struct moxart_host *host = mmc_priv(mmc); @@ -711,8 +711,6 @@ static int moxart_remove(struct platform_device *pdev) writel(readl(host->base + REG_CLOCK_CONTROL) | CLK_OFF, host->base + REG_CLOCK_CONTROL); mmc_free_host(mmc); - - return 0; } static const struct of_device_id moxart_mmc_match[] = { @@ -724,7 +722,7 @@ MODULE_DEVICE_TABLE(of, moxart_mmc_match); static struct platform_driver moxart_mmc_driver = { .probe = moxart_probe, - .remove = moxart_remove, + .remove_new = moxart_remove, .driver = { .name = "mmc-moxart", .probe_type = PROBE_PREFER_ASYNCHRONOUS,