From patchwork Thu Jul 13 08:07:34 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?5p2O5oms6Z+s?= X-Patchwork-Id: 119636 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:a6b2:0:b0:3e4:2afc:c1 with SMTP id c18csp1677131vqm; Thu, 13 Jul 2023 01:36:56 -0700 (PDT) X-Google-Smtp-Source: APBJJlEx1o/uKGCUYxiMBadu07Y9ayQiysrdLlcmCJpKIGEmrP7B3U8Z6zKDR1KUn+lWiS/+57uc X-Received: by 2002:a50:fb17:0:b0:51e:26c8:25f7 with SMTP id d23-20020a50fb17000000b0051e26c825f7mr1050973edq.42.1689237416173; Thu, 13 Jul 2023 01:36:56 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1689237416; cv=pass; d=google.com; s=arc-20160816; b=VniixhREemfj5H009DpTS1kK5cj8VXQgbT2EVQm4lNu49yhNp616ROoiBjWQCbtjbt SirA37OXLiimZepuB3uExv7Em4PrC5v/niqVwFM3tL7ksE92pTFHA4ObJaDtnJoGReke gmwaocox05UYsTGp21OQZh7bUm+7S5NRs9Q363MTmApv7IcvD/VC0WOVNjAmapWKFlSy hUswrBDwUchRCKf7KRNq+7c2yOJ6qCOmUiFp/TVqjwgpRuwdQe7gX3Aog+DzgHgGdH5q umpQ+9UYAl+zCcTznxU4A4Skx5OgyYytmrCin3gPHtM07vYHb0NSvj042qoC/KntzXsQ 8Z/A== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:content-transfer-encoding :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=J5jSVvTfy21nexuFITYTeRJZPViozYwLNoQA6yut0bE=; fh=7b0Y5Cx3utyrzaG4S8aa3Mo2ByBxutW+yB8187lmbIY=; b=m0Ks79W/hVRUYa6s9gjnkGfyreoYlbnsM5nPKE7YYaSDLfM6brsJf/wROnEXnnNBb3 kmUS9P++9vJU8wTP0SGgjKQkTpdJY3H8cZPX0fTVMH/MhWNQ8QBoBkzNulb+p6CtEr9u vtyHu6Z+okql51nn/CtbeKVX4SODOJiljQZSfxGoZCAgQZsKwZhwKyM0iYpEmq6bZj9g vtzHW0cgRC5Sct9McOgzpejLaJLrXmNwQO/aefQYcQZsiXKCQC2fOvOwcLT9W9uzNUq5 3EOHEPzfjXeAmxyd37iNaEzSryggO8oMmIGdJBZNAQ5HCzY2vRYW7wdpoX9JcuqkSV+W xvGQ== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@vivo.com header.s=selector2 header.b="UtrCq/nk"; arc=pass (i=1 spf=pass spfdomain=vivo.com dkim=pass dkdomain=vivo.com dmarc=pass fromdomain=vivo.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=vivo.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id r24-20020aa7da18000000b0051fdaa08fd8si4193586eds.261.2023.07.13.01.36.32; Thu, 13 Jul 2023 01:36:56 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@vivo.com header.s=selector2 header.b="UtrCq/nk"; arc=pass (i=1 spf=pass spfdomain=vivo.com dkim=pass dkdomain=vivo.com dmarc=pass fromdomain=vivo.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=vivo.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234325AbjGMIMb (ORCPT + 99 others); Thu, 13 Jul 2023 04:12:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50272 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233552AbjGMILT (ORCPT ); Thu, 13 Jul 2023 04:11:19 -0400 Received: from APC01-PSA-obe.outbound.protection.outlook.com (mail-psaapc01on2112.outbound.protection.outlook.com [40.107.255.112]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2A26F1BEB; Thu, 13 Jul 2023 01:09:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iELBa7CsJSLAuUWWFAqJ3Hr6v5J+alAZS/Arq54nI/+kyrn/sUH+LWoqgLno24UMrHyyIwAx0MMzdicT80/QfbRNxDnpjRIgQ86bD8vpKLU/DPPH8nZzIFYeVbN5hv4a0yYIx7oEi1llZnWwvccv08pTEFvt4aIuZEq3ceJ4uutPTBAiqX58ne3sZYtdLpep5DkQLPm/0W2en+zYlkq4F7zKy+YkF96aUmcSVLGPy6Xv349Hyvm0/9K9+f80GxNJaR+iW4ubdYfZFmlx7ZMnTBFKsbqDHwK3IfgSqnWtY9L1cC8FuDsS9Z2XW67DiVW/dQ7qtyY22X7e5QNK/a3yGw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=J5jSVvTfy21nexuFITYTeRJZPViozYwLNoQA6yut0bE=; b=kBci9uG3Epi4xUKDnkr6muhSKCHUJLJwjOA4TDjKfv88AiDSnLsXcvRCRKjSm3g41sd644+6yM518zjUY8Oov5xV56nwOf3WLHhIRDNAcC126givfnArAoZJ+mM337sqypQ4F21XK1E3Nd9mj3aoZTTvTb4gDkR/d1r0WGynaxqlEufwPoa4TsOJESTS9SUk+x6Tt9Zp3JIq5/8G1IxJPXgfB34fQpKdPwBW7v++qJUhz0XPxYQ0beziir8aaGUScqs48cTYv3aJhaaklxKGvv8tUhdN9qaGnATukAlZ/l0JVd5npO48Ht/PbS8P4rWEHWnj61zSMuXdXKhlp5SZZQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=J5jSVvTfy21nexuFITYTeRJZPViozYwLNoQA6yut0bE=; b=UtrCq/nk+QfjnJ3K3Qpw/+lpITTeYDNaBf9M2vpqMw5epuu1JxGS0tcSb1C1RcihnfZSdNqZSQrMmtaV6dEKBe07BcR+2NK9eYI/qqql20M0+NMEy/DFHU1Do9JNZ5TJqusuj/gnu56OGUMQflDlcARqfu9c//kXodaylPGSI7ajhqBwpYIHLU/05E0EbDsSt4ftefcxpnZSeBGlk2dxwTtczESxh2j0NQ8IWquD8e/CmL8g/EnElVTHsYnTuw3IEmag9bCZyuSQ++unCe3tndGQtapphLjaKT88R8PpOKv6OWIe+EbYyuqFA+MT0ebEX2OL0A2KgU7eP6mj0n63HQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) by SI2PR06MB4409.apcprd06.prod.outlook.com (2603:1096:4:15c::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6588.24; Thu, 13 Jul 2023 08:09:04 +0000 Received: from SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::fa0e:6c06:7474:285c]) by SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::fa0e:6c06:7474:285c%5]) with mapi id 15.20.6565.028; Thu, 13 Jul 2023 08:09:04 +0000 From: Yangtao Li To: Ulf Hansson , Kunihiko Hayashi , Masami Hiramatsu Cc: Yangtao Li , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 25/58] mmc: uniphier-sd: Convert to platform remove callback returning void Date: Thu, 13 Jul 2023 16:07:34 +0800 Message-Id: <20230713080807.69999-25-frank.li@vivo.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230713080807.69999-1-frank.li@vivo.com> References: <20230713080807.69999-1-frank.li@vivo.com> X-ClientProxiedBy: SG2PR02CA0091.apcprd02.prod.outlook.com (2603:1096:4:90::31) To SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5269:EE_|SI2PR06MB4409:EE_ X-MS-Office365-Filtering-Correlation-Id: fff4feb9-875e-4a62-281d-08db83786ca3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Vj3tGXbA/hNN+K0kbADOJxLK5ThT9tbLqsDP09nyjEhdBJGZd6cdSaNlj0LsKJO+Idt7vwLZvWPuHHxX5SXLVa+ApIRn8vodOPwXWAzceBm63wPGfTxt5TKj0vqJoRjpGt0bXx/KabKswC70HBtPI9LpCiwwFSFOvqhSwslNYqUh6fyOXBUK4lX0mljIsQIlnmDJzxPgKAJcIKQ4cCf4lLZ724KDgppHzSZ90QNn/XHQAcFNHcdN7ejibRgpjx0Z2DJEgGLyOZzwGmUJ2ofM40I9rWIxta5qZbc20jfq11iHHcoefhRnaBfiKnfrfBMrJXfbdmWD7KFrNkN2y+VaDiO6NeUnnQU8n+BtCPuI7ZqqXr2i7YBcUgJRC43hPELzA8YP4x/MqTrMoG3KWoRPaYugMkWeSRYNP9MzO3GGt4wiw2X1nwOCQPqXVgkW17ssFkhXntFf28M0mYbjPPQf6WXxcv4RkHjLXq8F3Gole6KiIn4By1jO1Xwm8PLlusAY4hQAD8VNVNtPDVQu+AOFhS0fnd5k+mF0AHkdUup2jUxN5hGOwOY7Q+8hTjXJM40XrqMteuIxHSWjnOU1kqjv75D0SQ02MJnzMxUcA/1EZtC5Y9ldg/9hXJUxtwnKtWXI X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SEZPR06MB5269.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(376002)(346002)(396003)(39860400002)(366004)(136003)(451199021)(478600001)(52116002)(6486002)(6666004)(110136005)(54906003)(83380400001)(2616005)(36756003)(86362001)(2906002)(186003)(26005)(6506007)(1076003)(6512007)(38350700002)(38100700002)(4326008)(66946007)(66476007)(41300700001)(316002)(8676002)(5660300002)(66556008)(8936002);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?zP19iBG0/QBKGdM9jrHhYYxIjqoy?= =?utf-8?q?Y0KcBwApQ7tF+unUwoC0l54m8kcXQdX8GpcBjhEvDLV2qjO6RGHAIzQNFxi6VWJnF?= =?utf-8?q?PC4iuY0bM5+nBdTF8SIn8nw+d9Ih2U6bXwCDKYnjSyM4PvH/r8a1wpYZmVQGTixfg?= =?utf-8?q?6tp/5mFm42Q2Dxid5Oxz335WcU6QilmT+43GBwISwnRg7kwF2PERcrag0yb+bMCDK?= =?utf-8?q?S8VJPSrkhrSgWEp0CqisOy2v+X/MSaJCGUK23l7JgnkAJx5qPVfgbKIaEWoGVcCCD?= =?utf-8?q?IsBMpinfKCwq5Gn1ejMLw6e097sRQxjCIvAo343r33TG/lADk2Oxg7XprX66ykmv6?= =?utf-8?q?5XC0eaD3OEmsp3EpA4P6DyZEkV9bnhSI82hkB8wGvQsyZdHsPh4mxdwkGAPM65+Y1?= =?utf-8?q?dmvU30pqNUfbgvXXzEpAI/R+MXvXgFxX0flpwrJhk3rrAiKvg5U52AUlZ+hbwFyoq?= =?utf-8?q?8C/f5ZvIJADpqHyAJyREsW6XVVflPYZ1nMRmq40C46nxwFcDxszOAuenwYE3NbtkX?= =?utf-8?q?4e56deRu4NKzhKH4nGZn4c9TwOFlQrNXKlaiTF4T/cWbCOsPrCstowIfnUNVuRLjB?= =?utf-8?q?Sa//Ad+W1iBOs2IgA0Gpoe8gLNVTTHVY6/TiYm6OTJawPr5LrP+krOCtuIqdFN+46?= =?utf-8?q?koNBvwoqvC/tEFGwmf2qiVO8fR/3aEEIDkTJ3ucCMqT6Wr66lP7VjkEohTFB/eqGY?= =?utf-8?q?pVegpqnr5k9CZxZq3nsG6uVaWizzj8UUUWJLHrZPvkZZcx6mBT9jaG5BiyW4l6e4g?= =?utf-8?q?542cJ77ER9E3ncCUfcOqHdRJzGkciNT41ntVXp+Og9AUTOD4603v4MmYLnNFV5Out?= =?utf-8?q?TH8kzDjsmCFj/VrIIfxOYVbaw5EvLAMXi7QZmr8mktqqvaQIoXzPz+ZsY26Mg+t+M?= =?utf-8?q?wdzxRsAndK7ArlrEMusLpcjWFDLJRb6aCEU+6+2ca4/mVSSgWl3L63cLsJD8/xAU9?= =?utf-8?q?M/amoDh8SyQBNLsFhqaLyLZ6avN/l/fJpxqb9Robyu2e+ZahJcT5m8U/XWt4ZZIZM?= =?utf-8?q?zYAigcu9CLLFsrEurg3RjhCIZRHRFWhecYM2MnLYV7NDsGAaKxQbzFGyv7g22soLK?= =?utf-8?q?gXWgtWciVaHjsGqDkPlzqtKCbHApFK1XvszlkahzffBpJc0bdyXoZQQglMjpLn9qq?= =?utf-8?q?2aMFz26fFYzHAvAqmXjQCsBLJePAX8gCB+DkyOcZmlMZHA5Axwu+ywOg8iPaWrz4w?= =?utf-8?q?lQaiZvHLkJ79NcRsTL4sEvEd8Pwyu1tNdw8PMHf1tm6Jq4rG1pcfKNFC7UfD4byPz?= =?utf-8?q?96RfgyK3ofNhr383D2frFJUpQjZK3pnN87prr6y+mOLt9rl2mxmRrw6OSUPSCDwSh?= =?utf-8?q?967d2npRtYeov+g31O6no84Ed6genAM0D4lhHaRgob2KlYBIKvbGnmJk6VmHX0ctT?= =?utf-8?q?b/lO0QItgo9Wud3X51FOCYV7EwmD3wEXW/6Bq49n/Biw7Nt9+xzViS0qOVsDJe4a6?= =?utf-8?q?gvBvxcK1w4pX8QduOUnT2i/vGeF3cBgXrpvhrL5qA6OzzplXqjruDRKRZOPQeKska?= =?utf-8?q?Ph9PfREcUWH3?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: fff4feb9-875e-4a62-281d-08db83786ca3 X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jul 2023 08:09:04.6399 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: lftmugZw51U8Hhl9rrtMlZQtfxyRrc/Mxj7JI2Vg4y/c0s7/0lyLcZ/tVNNz7W3Bj7DYWrZNsCrYXxzdo0wYrQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SI2PR06MB4409 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1771293812717107912 X-GMAIL-MSGID: 1771293812717107912 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Cc: Uwe Kleine-König Signed-off-by: Yangtao Li --- drivers/mmc/host/uniphier-sd.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mmc/host/uniphier-sd.c b/drivers/mmc/host/uniphier-sd.c index 61acd69fac0e..33a4d1c6ef04 100644 --- a/drivers/mmc/host/uniphier-sd.c +++ b/drivers/mmc/host/uniphier-sd.c @@ -727,15 +727,13 @@ static int uniphier_sd_probe(struct platform_device *pdev) return ret; } -static int uniphier_sd_remove(struct platform_device *pdev) +static void uniphier_sd_remove(struct platform_device *pdev) { struct tmio_mmc_host *host = platform_get_drvdata(pdev); tmio_mmc_host_remove(host); uniphier_sd_clk_disable(host); tmio_mmc_host_free(host); - - return 0; } static const struct of_device_id uniphier_sd_match[] = { @@ -757,7 +755,7 @@ MODULE_DEVICE_TABLE(of, uniphier_sd_match); static struct platform_driver uniphier_sd_driver = { .probe = uniphier_sd_probe, - .remove = uniphier_sd_remove, + .remove_new = uniphier_sd_remove, .driver = { .name = "uniphier-sd", .probe_type = PROBE_PREFER_ASYNCHRONOUS,