From patchwork Thu Jul 13 08:07:27 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?5p2O5oms6Z+s?= X-Patchwork-Id: 119656 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:a6b2:0:b0:3e4:2afc:c1 with SMTP id c18csp1679836vqm; Thu, 13 Jul 2023 01:43:27 -0700 (PDT) X-Google-Smtp-Source: APBJJlH6YynY+eNmiL37XmyryWY3UwhwGFfxcj3BeINvugIYmFfXYDQ3M9rhcyRcPgE8+/XUtesO X-Received: by 2002:a05:6808:150e:b0:3a1:cbea:3bf2 with SMTP id u14-20020a056808150e00b003a1cbea3bf2mr952180oiw.11.1689237807283; Thu, 13 Jul 2023 01:43:27 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1689237807; cv=pass; d=google.com; s=arc-20160816; b=UM59W+KAUf+jLIxInPVLx2kUR4ndw3NblUlpGjGh0u+O5dPJGCZuLLgW8+nzI7Sr5q jsDbhKP5nosblauFMI4dRD+OvPn8USF1cumsljyuscfEnA7eSqbdXeF7UHgw2Vxznm2Z HBk48qyX7nUq2rqhxdfZyPoCUBS/6K52khfKuj/O3pfCuPiuPDLQIVsjcWAtBIMRFx2U qkysR02Qn7L01mg9mal4aMvs78wjhOJQK3Lwg+KOxsX5/iRUTF9NVWwy/+5anD92Q7a1 LsXuP2b4cvrw464DO2W1UJlMa9uuiIhUw7TVYKYWNMhj1ts8q8W7BA0jcHaer0wlAGFG Crbg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:content-transfer-encoding :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=sJmqNg0QneXTVaXei41tdTyNv8PCANAb8lCgdK9ikdg=; fh=sy30M9eLByds7Tlvf2H8U/dRo3J3gGi9Sy6vmtIbxfI=; b=HAsRVZmTi06KmCns4uzJU13fJSmGa/jWQm5dTTcfLSeryEDx9JEGCpMx6fIO9YsmQ2 jxP6HkWHqVUyE9Y3HS1FwdLAUKHKkdi/MIHdjsLD9LsZgmvR0Q43Utsm8JhMLbGuduMw trZC/1a9/ckdBXCWZF+NEzYCLy4tXgGImx5ymOguuvfUIGcoEJpVsRv+H/2bXY9FvYDY thKVF4tHcogOyX/WCJbO+6ZdfRH2EXu/rBxJs2oRxagms8d2r2QDPx+y133Kr+4a6oby IIu6qzzBAPsd2b3X3ueP3rLG3pRaCZjpR2aaiclz9FDrYoSFbjkBb7l/VrtGLeJhpZwL oCFA== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@vivo.com header.s=selector2 header.b=YcnfxP9K; arc=pass (i=1 spf=pass spfdomain=vivo.com dkim=pass dkdomain=vivo.com dmarc=pass fromdomain=vivo.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=vivo.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e192-20020a6369c9000000b0054ff42dff19si4675228pgc.121.2023.07.13.01.43.14; Thu, 13 Jul 2023 01:43:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@vivo.com header.s=selector2 header.b=YcnfxP9K; arc=pass (i=1 spf=pass spfdomain=vivo.com dkim=pass dkdomain=vivo.com dmarc=pass fromdomain=vivo.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=vivo.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234254AbjGMIMA (ORCPT + 99 others); Thu, 13 Jul 2023 04:12:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49098 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232644AbjGMILD (ORCPT ); Thu, 13 Jul 2023 04:11:03 -0400 Received: from APC01-SG2-obe.outbound.protection.outlook.com (mail-sgaapc01on2104.outbound.protection.outlook.com [40.107.215.104]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DD0282D47; Thu, 13 Jul 2023 01:09:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JOgCy39PpsGvv6V5D/LyVp2oAQ0IcjqlbjHfCLtP+XeFex2BBP0G8NwsF6PCRG00Dsft4wmFVagjGRawxsxEBhZcmcmbgivBxnm820iQSORdDDpqagE7AgCEJH/u7Z2bYlP7ZCUQElDuO6HtTG6rWRePkAENfIfECcx7UL2L/yYPsjSkWpsz/Dy+1jB7mzmj2bqXeGVe6K52TxeRgu4pOGwzDCDlq8n9uj6AjShlR6JHQQNcU4UgK63B0flRI3LXa1zuKXb9pUD2Z1zCL+fx4eGkbO13GU+9THx16Wo9kKvP8Hvo9qD7rDy+vOg3A347OMNgCfpNlklk0hjpf4bYzQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=sJmqNg0QneXTVaXei41tdTyNv8PCANAb8lCgdK9ikdg=; b=ZdvyroEy+lP6VsZhku70d1UtWeJKO0yXX038wXOQ9tuBBk5hBEwqUVwndHMOqCgL3mv9MoR2YVhrazOWPe7Gb8uii+wU7ZBTS80snxTkElyLPhTvBSzJIYsyse/TeNjjF6DkhULcSsk4UW3OFrPV6px+VjLmPhwz5OsxzZWicNCyx277huPUPZ5hgVlTxgC4kUClnhYhTDemSAgQG9BDxwGde+w8ROsMw6bv1ZSdfwe1SEZutIgZsZaDD0a+VDQHiLKigV72VqmFUPOksQfz62Y48WrldHtpsP9YCwB7tbW5Y2tSzhyLF6od9fWt4+xwqBsQtDS0LSoH5XIcLdKXsg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sJmqNg0QneXTVaXei41tdTyNv8PCANAb8lCgdK9ikdg=; b=YcnfxP9K0d/WKHpzKVllSw2/5rOS53+3k9w+Sy3qjAJ7totNKQtQzk8+q+2PiFXxoIeRk7zjVFuWgt7SwsEgf7tvIzU+UYrVIKbsImaJmfnqpcdNPYCzUKULhvlulGSafVbtugvXhX9fwGZddk6i29FjvUW7BJR9FFG09CsmcDX8mJwVUtIntTsQKg7IECgcz56hzAy8WWazKWGE/DxdGpOblTPOVBoeNsM2xMbPCq99R8n1nkuysLvaffpRhX4sU28baDog4gZWRhUXUO4DUJcO3qq2gFYu7LWwHRgkO0qP+SzngRs1iWZEirz/xApk+N2p1G7IpUZd5anS2TPzUw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) by KL1PR0601MB4371.apcprd06.prod.outlook.com (2603:1096:820:74::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6588.22; Thu, 13 Jul 2023 08:08:51 +0000 Received: from SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::fa0e:6c06:7474:285c]) by SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::fa0e:6c06:7474:285c%5]) with mapi id 15.20.6565.028; Thu, 13 Jul 2023 08:08:51 +0000 From: Yangtao Li To: Ulf Hansson , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl Cc: Yangtao Li , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 18/58] mmc: meson-gx: Convert to platform remove callback returning void Date: Thu, 13 Jul 2023 16:07:27 +0800 Message-Id: <20230713080807.69999-18-frank.li@vivo.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230713080807.69999-1-frank.li@vivo.com> References: <20230713080807.69999-1-frank.li@vivo.com> X-ClientProxiedBy: SG2PR02CA0091.apcprd02.prod.outlook.com (2603:1096:4:90::31) To SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5269:EE_|KL1PR0601MB4371:EE_ X-MS-Office365-Filtering-Correlation-Id: e4bcc5f0-125e-41a1-fd33-08db83786499 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: gaXHu4hn4rtQ1qTn2+bI5YjoNz9+/QPpQAZVBWHoZsBjHBqIJM35PqNonsPlL/zbtj2FpEmOCBTbdgXIg36uR2D6Pe1lZdOU9wDSGMLP6cBq88lLeN6o76B7+4mpPjsQvYrAqrn7XwlKMu1hGIm6cVIzJQI84ei9nWiyR7e1vuM6qO+y06pSuGulA5i1Dz8G0H7SEiGrX8GFIA8mUnvWbjezbqOnjXDzyTgiESHC3wJbhM/WF3xAktYkUo1XMAhwiFRAxEvDBvJwMurBLLPXHXyUdIEtMx51g47a6hnLaaGnTaHlmV9+ySXKIZ2o53yipWJpae5R3o6FpyF8Y+Ik4jDPxbxWhvEyHu1zuIyRDuIGUYiGpVwIYzgD+uVy48rLzOvUFxFWttXgIDg88iAL1gmb2Gtzju4cfQNfM72UK1GK2Vfj7l95QxfdoFOraKHKF8XUE0n1Ay9FMcZlM6bNT0yQ8jdqcV05ZNfTGNOtfBL1/sqakkhGcySAKFTckVeVueHpWQBZ5c/LmGxCw/xbAfD96Q3AdMTbnUwgNanGJqFHb/3Dfh1IGHMCXhK/HhAbihnVt7wRox01iNDA/7A5G8J3GXo5AnGX9Lawo7amUnNOq2nezd/TX1UCNUCZ0OFCOPQEbEMmXfpJwjIL/oRvO1KSg/DebAdGnR7KKz5Z4PA= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SEZPR06MB5269.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(396003)(136003)(346002)(376002)(39860400002)(366004)(451199021)(38350700002)(38100700002)(478600001)(4326008)(6666004)(86362001)(52116002)(110136005)(6486002)(54906003)(66476007)(66556008)(66946007)(316002)(6512007)(41300700001)(83380400001)(186003)(2616005)(2906002)(36756003)(8936002)(8676002)(26005)(7416002)(5660300002)(6506007)(1076003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?VNOGT2x5KCa9kphtbG12urV7Li/N?= =?utf-8?q?jMTq5n3ER1k6Yvmkns3Iq9PnIvlm4/lOk6m5MnJijzHSb5PXxo4/7Ogy9+Ia1N3Sk?= =?utf-8?q?DbKg/loknSfECTK8nxDzhgIg22r9/q3Zl8oRhb5v6uIwQcuicMJvoeAaFAAkfQxPq?= =?utf-8?q?uqvjU1iBDnKOW0fY2FlMFBi1sOeco4CupFMp5wo7bGfnECRIlC3VqEVeKjmNa60A0?= =?utf-8?q?cRC15ixWJVeAPpvKnMMh7PZiMuh6ievvJpGREvHED6oqecVG2sGM8rqW9Xz0QjpR+?= =?utf-8?q?iPaJhNWlp4+UI1GGW3QTGh2zdDlWiDfrD6OyF7BKhkc/D4jMLchCjRF8OS+q8TEZs?= =?utf-8?q?dij2VenDdXUS3I2zYkFsNNXVn5Ib1W7zHvTwNZXj872/pWOwkaA4yWO+iVAgE9biR?= =?utf-8?q?6iuJxySl+IMQKCjKWxp7BmHqRm/q/UrKE7f8kpHz+H28rDzQAv/brNsO/nUuBuV6S?= =?utf-8?q?8kjCKoqHvQCrpdjTCkpMN0e0KjbRWOok8r5DYUNg1JC70UbT8f2pFSOiRaR709A1L?= =?utf-8?q?poZq5cn7SVhBKzHuij5TatzdviRBCpbN6QFA9RYHQVALFpuxk5W/3m5KBzc8tO86Y?= =?utf-8?q?JejYHD7l6cMcDXOeQYovUNpvAmCLusecdST/vFmHGMcszw4LLoOe3DVm+BnoBy7jy?= =?utf-8?q?sTGvSGEDqwwj50spxale8ZMhusBpmO9M3dk/TvFByuKGPpwSj8cA5dqHsNcr6lXVw?= =?utf-8?q?HFbTMOROLCTe7YeVA+dsiJMZ1Z43OovfGJIsdHdkKM07ETzKcy0XUF2NaBoRbCyBR?= =?utf-8?q?ovyTOSe0DWzvus2guoUHx+XxDTZthRLRPzVcyGTpz179fReJ1byIIIYbWD4cp7lZW?= =?utf-8?q?yLNr2GsoouklAgztFrTMX5Bf0sCm+qLYqmdBDy1CdcYx6PO1tTcuUtVZmzAxjnEUZ?= =?utf-8?q?KjiuR09pJU4ZngvEPJNd6DItegCYxUaeofZz4gYCdrXE5ojsR5QGKHSPXyR4VC2sD?= =?utf-8?q?fm3G23U3hlQDCSLhXcW+VkteNgIa0fkB9/PRHOmk9oTBoR4hq8ICFw9higqwRPoQb?= =?utf-8?q?aebEjQLmYyiBWzD2fkJAQ5pkc//1N6GMqyYvs6+3OcewjadptWb3BBOJb6TilEsud?= =?utf-8?q?CAZNMZb3Ufg0ebM55pjTS5uZhWUBm3GLfHO7wq2aWpYQvbLsbMttXOsj3djqHXoaf?= =?utf-8?q?sUqieK2DHLQNz3TjHrLm1OgCHi7I3u5N7tmohi6fjIi0tcNYbiwQIaPsek2H4mfQw?= =?utf-8?q?uuvbQlfYGIfXGwz7v+oOgAAo6yYukQ7JXXTSlQsPs7U1SDa+2PhZrfouZC2OmmhMB?= =?utf-8?q?39qAWveRo/96uh18Nu7uaH1DDSxxGSQKbAuGCVJYzPPWQpt3imwj2RF5BweUDx1QJ?= =?utf-8?q?d+nAQWc55tZnmP8kWXkkZYv1m+lnFMK2B2SjeSSrlOfB7lt0NtJnnETugwJhgMqx9?= =?utf-8?q?RfNQvF1t7Txcht+rygmdp0MU+JeHkDW0ykAWtziiEhYQnzTXjoxghAKNUDxokJaop?= =?utf-8?q?43rd/37xGBjqt/Regp0DzIZiyAbLXdcTYhqafZwa+Cv68ZzU+y6++n+J4QSfKUI33?= =?utf-8?q?WsY9fH/vbpRE?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: e4bcc5f0-125e-41a1-fd33-08db83786499 X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jul 2023 08:08:51.1516 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: wgytmeNpYFPSQeD7l0zJpWHAUh0s6rn6Dt3ddBa/IFXfZ3o7PFM93QWp68Wn2hBg/5AuaXui9dxtVEvvGNDTbg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: KL1PR0601MB4371 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1771294223348219354 X-GMAIL-MSGID: 1771294223348219354 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Cc: Uwe Kleine-König Signed-off-by: Yangtao Li --- drivers/mmc/host/meson-gx-mmc.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mmc/host/meson-gx-mmc.c b/drivers/mmc/host/meson-gx-mmc.c index ee9a25b900ae..106ebc1fd36f 100644 --- a/drivers/mmc/host/meson-gx-mmc.c +++ b/drivers/mmc/host/meson-gx-mmc.c @@ -1297,7 +1297,7 @@ static int meson_mmc_probe(struct platform_device *pdev) return ret; } -static int meson_mmc_remove(struct platform_device *pdev) +static void meson_mmc_remove(struct platform_device *pdev) { struct meson_host *host = dev_get_drvdata(&pdev->dev); @@ -1308,8 +1308,6 @@ static int meson_mmc_remove(struct platform_device *pdev) free_irq(host->irq, host); clk_disable_unprepare(host->mmc_clk); - - return 0; } static const struct meson_mmc_data meson_gx_data = { @@ -1340,7 +1338,7 @@ MODULE_DEVICE_TABLE(of, meson_mmc_of_match); static struct platform_driver meson_mmc_driver = { .probe = meson_mmc_probe, - .remove = meson_mmc_remove, + .remove_new = meson_mmc_remove, .driver = { .name = DRIVER_NAME, .probe_type = PROBE_PREFER_ASYNCHRONOUS,