From patchwork Thu Jul 13 08:07:20 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?5p2O5oms6Z+s?= X-Patchwork-Id: 119616 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:a6b2:0:b0:3e4:2afc:c1 with SMTP id c18csp1668618vqm; Thu, 13 Jul 2023 01:15:25 -0700 (PDT) X-Google-Smtp-Source: APBJJlGVX2Rq8FxSGTkCTu1RPHjVd4rUYu0X1KcT7ES5l0Wl7ceWmjpPLz78Whj6C2PEL2/y/wkq X-Received: by 2002:a05:6a20:190:b0:131:40bc:2285 with SMTP id 16-20020a056a20019000b0013140bc2285mr227538pzy.56.1689236125549; Thu, 13 Jul 2023 01:15:25 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1689236125; cv=pass; d=google.com; s=arc-20160816; b=t0aMD5t9a3+A4o16WISaOcWghfnoIupxYILEWIgsaa9rv89JbhdFAJCLX8Expb4TM3 INbEmtT4KvBIsXhoXpAxAdWTq/+C3ae9WAScmw9uIlUjU9n1u+W0tCBiKmlrqDZBIbY4 QsTx2xA+wo+fxwdsIlpM0ZJo8TIp/JZU39PYqvd/gdcuZdS9GrGytSeXMndifSicjaDy JUpiscmtciDR7cJMOxyUcUWoByLMu2KHAdK19gcjvIlPDuYFJe8epVGa8uA6RrX9KxMX 2sPWT1rM8YjABFpVpxBdrHfd+I71KaKIkcwNNosdT5nbiuBDlVCeftjEXSUpQHbct2He PaiQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:content-transfer-encoding :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=BmsUH21Sitgu80/p1tFfJIH7tg7gkEnk91pBdItWAUc=; fh=lsBBgZtt9Zp64MNFIVDMQqe1hUqbGcY3umQCuckK8YY=; b=gmxgt0P+A/4DdQ2BVkfXh/grWIndI8PW21pGynvm/posIpb0Xc5VF4HLyM+ANEDpUF Jxb/ipfW4fjrzQt/ADqX8ECS4Maflfn2VDSYrbnIzuKQ0uxzExTZT9VziKJtJ8vUbJgo 5gqI+DPbUIIzY8heruQX5vra98bwG2nY00qgoWReXhuAV/HO1KiWQrp6umDrsCq3X8v6 DOQa9dw8A8X2mVTwZnE8ArJaVrVpqqwWA5i5pafRJSwRdqLznxG/3WsQJj2XmS0V2z6u jmzw40sm5b+fuhpGQxwCsP1ibSAk1gpd2OBN31AzgZshreM2yhZ9XfhlVEtb02s4PSxX QixQ== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@vivo.com header.s=selector2 header.b=ebJZxWGl; arc=pass (i=1 spf=pass spfdomain=vivo.com dkim=pass dkdomain=vivo.com dmarc=pass fromdomain=vivo.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=vivo.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u15-20020a170903124f00b001b9d180fd9asi4982521plh.121.2023.07.13.01.15.12; Thu, 13 Jul 2023 01:15:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@vivo.com header.s=selector2 header.b=ebJZxWGl; arc=pass (i=1 spf=pass spfdomain=vivo.com dkim=pass dkdomain=vivo.com dmarc=pass fromdomain=vivo.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=vivo.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232943AbjGMILE (ORCPT + 99 others); Thu, 13 Jul 2023 04:11:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50076 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234005AbjGMIJy (ORCPT ); Thu, 13 Jul 2023 04:09:54 -0400 Received: from APC01-SG2-obe.outbound.protection.outlook.com (mail-sgaapc01on2115.outbound.protection.outlook.com [40.107.215.115]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ACD00358E; Thu, 13 Jul 2023 01:08:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lfPAw7FDxJqtTd3EOlYvSvqY2okeKJAXK/eEcRYoOZTCpiaR/VYoKa/0SLkdGO4IHOsroiTXZqBNJ/XlspcGi/X0LTBL3oPKxfvOgnDvw/CXf81O7oaSG3cnUILb9Qm72DbAnXnhHSL8BdGEwYFdIC/MsuG78uGtOSiUSz6f+63fRNWDgkrfuvEh9PbQFf5kGlTXxPbLVWusZVOqHqP3BdIklFlHjL4+9buGHFXEGu5JRp5RhEqzLBAAv1hMaF3/WUVxYm1qS2gNeabbI3/p3BnUI16AAe4gVVNNKyY0OMDxLy1U5BheWyyN/sCIbyqU9NRXjKuLP4zdrPNcBH25yQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BmsUH21Sitgu80/p1tFfJIH7tg7gkEnk91pBdItWAUc=; b=FTEY3w+V8q8FGR3VDgeNTlOi0abdobeyjNL9e/3QEn5Tgspb7wQ6hFdYdqNZj6qGI/3q55gMx2MAOt5u7bUtIrtgvhDstqbW1zCwR5hBpVLUhG3vDGPR+BUyZc1rKCQIkyt75Jl1JQT1PX0ZQ1FJcDjc3TdmR7n2QsCGUMBPSylCjukBZwZMu7kd+89yVzGwhk0Fv2yKo9dUGuoTHNbrRtDWuQq5X7/wwe62sY7O7aWYJzK1VaOlX91JwxiQknu4KCd6x+BUixJWCAH6unHYuCFm4a0BiPJgYw0KY95pjPO6L/0Yiu6zQTXviRLm/poW/Cyo1Cujr9Raaelmz6iWXg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BmsUH21Sitgu80/p1tFfJIH7tg7gkEnk91pBdItWAUc=; b=ebJZxWGlQJc2f5xMiqvZu/kKtt8ehVUiHy92uKgOHvuv6hZ9fxyYa0NLPK57eQsd1si1xG0p9k4vAwXZTa2YJezlXvFm1V8Xfq5zkL6/wSdDOSitlEkzYUBbSsEUNNV1QWgrwXOmzGsBif15Ur/eVUfntpYXyhhq/t0Yf0zcgtRgV53EsPJDyAfOg2ti0PDDciB6TqFsksBMoWFHUjOFP7avWmJAfwHGLRQPqd8hnr6m6x+yzq6jvtcbsUPR3TtmFoeQZ110mwrk00NsA4X3JkrXIKghPbUuQgiEBscrUYspWqC5wPbSsE4UAebMcfwg+GGKIbbcNQxpOc2hQ72FLQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) by KL1PR0601MB4371.apcprd06.prod.outlook.com (2603:1096:820:74::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6588.22; Thu, 13 Jul 2023 08:08:38 +0000 Received: from SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::fa0e:6c06:7474:285c]) by SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::fa0e:6c06:7474:285c%5]) with mapi id 15.20.6565.028; Thu, 13 Jul 2023 08:08:38 +0000 From: Yangtao Li To: Ulf Hansson Cc: Yangtao Li , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , linux-mmc@vger.kernel.org, linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 11/58] mmc: omap_hsmmc: Convert to platform remove callback returning void Date: Thu, 13 Jul 2023 16:07:20 +0800 Message-Id: <20230713080807.69999-11-frank.li@vivo.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230713080807.69999-1-frank.li@vivo.com> References: <20230713080807.69999-1-frank.li@vivo.com> X-ClientProxiedBy: SG2PR02CA0091.apcprd02.prod.outlook.com (2603:1096:4:90::31) To SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5269:EE_|KL1PR0601MB4371:EE_ X-MS-Office365-Filtering-Correlation-Id: 6a1e2f10-0310-42c5-f347-08db83785cd5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Bh22jU7U956oW3Lxr9ThNSwu7z5J9UjDN98GtJgCY/JztAFx38OoxV4PZEZ/28NM2WUyjNS/vWma+hF32eZK9T8G8xpc6QDau66b4yNLTg6UrZdeTRrawnya0qKvRuZ6nCPSGflepqdunc297Qgncl+++MyCBl0w0/Yd1x7dOuSZp8612UjFMvYUANUwCSGWITsEwHbV0WQpT6Svv4TBEBKbAFgnLjviPom5PuGPtthkEhMmaPT0ELQiUsUSBAcfkUkw8iLTsHATglsZU/0D1CeGqqo6fymj3m2cpyiCyoCH24zerKUk1TajIhIZpCI54C4KS8Mi5JdCotX4/eJ1mgn0CxuE3okBGLinWbFWoqc0H2Lju+0M7FKdvqD1Xm4znbMl4/ZWBL0dl2jfkkzF8PVJ+CQrYBhDBwfqoAKFfSsFROl4P2AZ1ykk5iaffEDfDf4TnqqU+nkGRdWdvaLDk6znl8+1s/4pEMKqAIhQm3iCUX8c0YU9kd/TBSJL72kC/WuQA6HDypUv9lDWQhQxI9JrhKq94UZrzEAwb1OkDRq0jRMRhNvsVTsSjVDHxH9oMPYdjdV8vQ3ncbChPTR9TRECkHy0QZLjEk27YuP3M10CXps+W5MPr7/BGxBm1ylXlYBXiKMuSjAtorsg1NEeZvBJPMCdxu6Oh7J+/rOWf6I= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SEZPR06MB5269.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(396003)(136003)(346002)(376002)(39860400002)(366004)(451199021)(38350700002)(38100700002)(478600001)(4326008)(6666004)(86362001)(52116002)(6916009)(6486002)(54906003)(66476007)(66556008)(66946007)(316002)(6512007)(41300700001)(83380400001)(186003)(2616005)(2906002)(36756003)(8936002)(8676002)(26005)(5660300002)(6506007)(1076003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?0mdBWuMYjlKgpp9gSeazPPY9fN+b?= =?utf-8?q?zr6oVVgmhL648JRMy5uGaDheCW9MU+NGw24CYmGz7Xi5vLC41nfUHU1n2lNRsSdVw?= =?utf-8?q?zoBpDE0jinbF/7RcwH90D8g9HFUqLrBU2/KZieQ6qI6pEgTbzE1HY2OtAXzoeP5mv?= =?utf-8?q?3Hx8YDF6sxBpMwepRCokBwS/4ZAx6BWu3QRpVnUvEp1ZKT+CIp4EvcudQmpRSpStv?= =?utf-8?q?1kRbytvzhOGbID1E5Vvlw1CHcqm4MglomEsdsuHDMG3V6nIBhuBTfBEjE5WlEJxRw?= =?utf-8?q?cW85xz5OMxma0Z3n+KB8khaty1zjIjA4XEa8rVi7oMJ3sDP0RZgXOFWecKaBTJGJf?= =?utf-8?q?1E1YM/tNEkGB1qKKY+zNLeeKbB3MohD5LZluXynUR64XviwHebYZLhQfsiWa8GZta?= =?utf-8?q?jKJ4MLlpNJVoBw00XvX7uwsplAlDvLT6aikD1O+ArqChj7Q1B5u0GineG9R1lhTWI?= =?utf-8?q?+lenb2Otsel0SeVNpsUGgb0zJk8Q2dA2Xn0ko9GBA51vRdA+6RnF6j3epoVBb4xY0?= =?utf-8?q?ByC2snufa0D3bqCMXojY4niMTIpHw3MTQlYEMZMyKnZADy0/WcKM9Kbg+A2qZ9zW4?= =?utf-8?q?xMb2iO9kQh5jHYYfIY+yXaIYI4bGzJ8VIoqTPkYSN8iDCO0bgJptrNhYs2MXRNRSC?= =?utf-8?q?PVL95vyPrj/g7Pf/slsA2IMqq2ZxXUW5R+USreAdl9xW07haPq36EosczLDSx2F2s?= =?utf-8?q?r1WqbmWKo1U5cIc97v+p45gdBOnJukWNkdEqZr3XNUO/EFScfyPis4vWxtC2W48TS?= =?utf-8?q?9DT/+RzGu3FT+VphkEN4YqqgIexEKSp+0xbPcBBVF+zkegOdFX4Qz/k3exIbfQa/J?= =?utf-8?q?gEvafBtCuVcoKI2fE3odrKWB/xgtO79SyrgLH1ZMDk4VEp1826NsZNLheJlDJQOdH?= =?utf-8?q?zBOQNMcc+dHS8CZdtXYm3SMeO1iTIlqTknW7GlDB7CnPsx2ItVkZjz7ptYe6CBJVe?= =?utf-8?q?416ptunyy80oAvYY/lw3V9AiktkHYrfG60wEMzjuY8WTT5Wodomk0KG3XuH2GxAM5?= =?utf-8?q?ELOWT462d7QCgabnYIbrYh7DuJ8cA/ePOyyIkSxR7dVWnkBS3rgBaU+cp+ggZwJ9n?= =?utf-8?q?92qmz9D7lPax8alPf/+wya9Oo7Aje1I95da0T3zzPrMiyBsbztSCGAKxU4kbUWWqp?= =?utf-8?q?sdRjinTFU7zJWUvyEKv2bImMGOW6P5tSFWR8/R/VUyEJcIE3C4tL408oVAfqZzuZP?= =?utf-8?q?kq2SBH6qLid9o0NMzd214RcIoLCW7u0ty7XOKuIOq3EytvTj3soyNpEQUEB3Uj1cR?= =?utf-8?q?H4X06Qd4WKnHK/87Jf5MIk32l73KwGRnjxKOh+9aR45hdaMsO0mB37F4/eIuS3ZMs?= =?utf-8?q?BXnSlcrkyxE+P/bjQuwSf239foXPXEFUZk2VcTd0tRgfBn5GRvad4SAJ0FqJGPYl8?= =?utf-8?q?uAKENq9zSkpYAUhQow/+JLpJ3XbuOdqLwCEdnfOKRItSenmZ6DT7jvAr/3ypwYzXU?= =?utf-8?q?mcuMpRixvWUoVR1AbwZLmbrLly+eDlFBRlNpPoKWrizBuE1ZVysBGdagmt8I4J7c8?= =?utf-8?q?PNO/PYa7IdkF?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6a1e2f10-0310-42c5-f347-08db83785cd5 X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jul 2023 08:08:38.1693 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: V1L9GhxRrKx4CHXcQO+2NBzZUrXhj1s6tXrJ/z4ZmXDWRi7LOgyuGtvkPE0TydMma5lRopx45EU7lAQRq7P8sA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: KL1PR0601MB4371 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1771292459605475315 X-GMAIL-MSGID: 1771292459605475315 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Cc: Uwe Kleine-König Signed-off-by: Yangtao Li --- drivers/mmc/host/omap_hsmmc.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c index 1e0f2d7774bd..c5a7bba3549d 100644 --- a/drivers/mmc/host/omap_hsmmc.c +++ b/drivers/mmc/host/omap_hsmmc.c @@ -1982,7 +1982,7 @@ static int omap_hsmmc_probe(struct platform_device *pdev) return ret; } -static int omap_hsmmc_remove(struct platform_device *pdev) +static void omap_hsmmc_remove(struct platform_device *pdev) { struct omap_hsmmc_host *host = platform_get_drvdata(pdev); @@ -2000,8 +2000,6 @@ static int omap_hsmmc_remove(struct platform_device *pdev) clk_disable_unprepare(host->dbclk); mmc_free_host(host->mmc); - - return 0; } #ifdef CONFIG_PM_SLEEP @@ -2126,7 +2124,7 @@ static const struct dev_pm_ops omap_hsmmc_dev_pm_ops = { static struct platform_driver omap_hsmmc_driver = { .probe = omap_hsmmc_probe, - .remove = omap_hsmmc_remove, + .remove_new = omap_hsmmc_remove, .driver = { .name = DRIVER_NAME, .probe_type = PROBE_PREFER_ASYNCHRONOUS,