From patchwork Wed Jul 12 23:45:58 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Brown X-Patchwork-Id: 119441 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:a6b2:0:b0:3e4:2afc:c1 with SMTP id c18csp1490117vqm; Wed, 12 Jul 2023 16:59:21 -0700 (PDT) X-Google-Smtp-Source: APBJJlHuRtSyXjD41HErg7IqomQnCiuHBTaSzzcOGFHOlb1SIoup3xbtahvL0mtyQh8JChXMyc+8 X-Received: by 2002:a17:906:8315:b0:992:6d62:42e1 with SMTP id j21-20020a170906831500b009926d6242e1mr20164345ejx.29.1689206361063; Wed, 12 Jul 2023 16:59:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689206361; cv=none; d=google.com; s=arc-20160816; b=PsYdi7OWr0DVUErSNshG+ua2wv/NlTa4cYHaTSGxLBMofeBMpDN/QvcDrkNnSVfrM6 XnFsys8tNg08/YfOznX7E8WidzVFYo8gY7M620EVm7T0yiRBOWttZXKXex7s2kI6XiCJ ac3JiNbrxGhmNppbkzvkj4P5iOHdUpF2AB4/r6IDX/OI39srEq/eGPRQjTeDZGcYHnx2 JV0YRu0/9+xE0HNWpVCMVMvpRPs380C6XbMJ7pSf45lURFAR2+rAXHncIFtBkckJC6LX oRy769lGeQ7o/BZ2f/7aoXy97Cl2MkSqggNwXtU084HrpYaE9d+qhahNzK8I+jry0Wmd PbDw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:message-id:content-transfer-encoding :mime-version:subject:date:from:dkim-signature; bh=m6/XLEXcuA2chsg4omTajSimxTAKRzgnQnBoOwNd4tY=; fh=dD5VRy62fGEC4qmQl5J3X6bNlUFi4ZQPLJ6+cF0aP94=; b=Ql8qxP+FKy8bPZRa7q2ZK1MY7EayARgHJsCcEuA/T4zswBOT9VzFFhxvHhTY9z32O1 cJJMkVZl6iAXuw2r1t7ii7vkjCayH8Wv4yqmVTK21nkdD6O8NdHk+132JA0108p1LCHo eqNfjCBrW2aKoC49yUaNv3GfqylXtu5RWf/lgvh7YyLhQGoSXFyCQZQmVmCYGbUBMZyn BRRefAgT2KJ1gD9cx5GNj2LFk+RRtl46+ogJjJpmCytA/OhryTJ6MTSu6wNXSRNBfn8W KpdKU46tb8+lsGkhDs5QQu8p5HCFzCBvYz6N7/9dQbvwSPJC6v2fqy8hfVGyuA4gk966 bV6A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=acHeiXov; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id v14-20020a1709060b4e00b009886c3287e0si5631198ejg.536.2023.07.12.16.58.57; Wed, 12 Jul 2023 16:59:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=acHeiXov; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233015AbjGLXqo (ORCPT + 99 others); Wed, 12 Jul 2023 19:46:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52532 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232938AbjGLXqj (ORCPT ); Wed, 12 Jul 2023 19:46:39 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1E8901FFF for ; Wed, 12 Jul 2023 16:46:20 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A51E6619AB for ; Wed, 12 Jul 2023 23:46:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A6781C433C8; Wed, 12 Jul 2023 23:46:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1689205579; bh=9qx22tB4mpdqCcRXiSQ1VQK+h0T6kKIZwwo2QtycCpM=; h=From:Date:Subject:To:Cc:From; b=acHeiXovv2tl8SFH5wp5Dg3dGylBw81PDDpOeHfKsmM+vktuFCBlPCNrd141EkSlc 1ulWf3qg9tDaQdT7SXqyDlnxp+eag6MNly5Hhf/q/35agJC/XksyLypRjPaP2afLex 6YKkeXGOOXQNx0a2HJmoZjBQVspra7tK6IBXC/D9OSRdbXDG7Sm0VSe+2JrXFXBDPa QFePJDxEF+8I6PPwQq9hIOg56lEdJumUS9RFT630u5ExE+NfEJWGYgPWsk5AumGl+w eTQgm2dW+X23RL4Z912FRpuoFqu2JUX9Zrzv/vAKjixnkWfdhnidGZt/Vac2vDLjyw eaI0jnx+H1qOg== From: Mark Brown Date: Thu, 13 Jul 2023 00:45:58 +0100 Subject: [PATCH] net: dsa: ar9331: Use maple tree register cache MIME-Version: 1.0 Message-Id: <20230713-net-ar9331-regmap-maple-v1-1-bffed9f09da7@kernel.org> X-B4-Tracking: v=1; b=H4sIADU7r2QC/x2MSQqEQAwAvyI5G+jFLX5l8NBo1MBMK+lBBPHvN h7qUIeqCxKrcIK+uED5kCRbzGLLAsY1xIVRpuzgjPOmNR1G/mNQ8t6i8vILO2a+jFTR3NhqdDU R5HpXnuV8z5/hvh8d4NSvaQAAAA== To: Andrew Lunn , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Mark Brown X-Mailer: b4 0.13-dev-099c9 X-Developer-Signature: v=1; a=openpgp-sha256; l=1222; i=broonie@kernel.org; h=from:subject:message-id; bh=9qx22tB4mpdqCcRXiSQ1VQK+h0T6kKIZwwo2QtycCpM=; b=owEBbQGS/pANAwAKASTWi3JdVIfQAcsmYgBkrztGUqrsjUoIl/NxV2tU4RDUVFhWGGrP4TPLU ufyns+hLzSJATMEAAEKAB0WIQSt5miqZ1cYtZ/in+ok1otyXVSH0AUCZK87RgAKCRAk1otyXVSH 0ENzB/96urJr8Khttq8xAfkIYpHuZaurFBPazWX2J+rrdJ/FLjCk6O1hDwBCy4j9HBn0PzdOxXo Y5V2CRCoT6cSeULcbjEIVLU/gCI9AtGsJfiQXNJuWDTN4v0rq9ReZrvdj1Ca94Xyd8r7CVk0nNg 4AkBoB9R4gco3oVIkmSDrlQBdcNjy0kEUUU23zln8ui3nOwJEQZh5pmAEmKHfS7PmZ/KV+b2WRH Oosf2f7tg3U1BRkGlIj6UDUONNnsh8B4ZU0s/hjzM3aiAkN7aHxvxwZl1s/SF1TsDtc01HSSDa2 JQj9jUr7uaSjYb+rszjhRRcapkzrK4kFPMkwDJC3U/uJZWj4 X-Developer-Key: i=broonie@kernel.org; a=openpgp; fpr=3F2568AAC26998F9E813A1C5C3F436CA30F5D8EB X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1771261248898207269 X-GMAIL-MSGID: 1771261248898207269 We now have a regmap cache which uses a maple tree to store the register state, this is a more modern data structure and the regmap level code using it makes a number of assumptions better tuned for modern hardware than those made by the rbtree cache type that the at9331 driver uses. Switch the ar9331 driver to use the more modern data structure. This should have minimal practical impact, it's mainly code modernisation. Signed-off-by: Mark Brown --- drivers/net/dsa/qca/ar9331.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- base-commit: 06c2afb862f9da8dc5efa4b6076a0e48c3fbaaa5 change-id: 20230708-net-ar9331-regmap-maple-949f614c2599 Best regards, diff --git a/drivers/net/dsa/qca/ar9331.c b/drivers/net/dsa/qca/ar9331.c index b2bf78ac485e..72730dcc9ca9 100644 --- a/drivers/net/dsa/qca/ar9331.c +++ b/drivers/net/dsa/qca/ar9331.c @@ -1010,7 +1010,7 @@ static const struct regmap_config ar9331_mdio_regmap_config = { .wr_table = &ar9331_register_set, .rd_table = &ar9331_register_set, - .cache_type = REGCACHE_RBTREE, + .cache_type = REGCACHE_MAPLE, }; static struct regmap_bus ar9331_sw_bus = {