From patchwork Wed Jul 12 17:42:20 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fenghua Yu X-Patchwork-Id: 119319 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:a6b2:0:b0:3e4:2afc:c1 with SMTP id c18csp1334292vqm; Wed, 12 Jul 2023 11:23:40 -0700 (PDT) X-Google-Smtp-Source: APBJJlEo2IIWFbh/xd8SBXHbH2lBFhbLNBwjMXPII0w1k0dyI4tT7DMTsZzYFlDVoXEW8UD+Jws1 X-Received: by 2002:a05:6a21:99aa:b0:132:cb65:ea25 with SMTP id ve42-20020a056a2199aa00b00132cb65ea25mr2712391pzb.53.1689186219767; Wed, 12 Jul 2023 11:23:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689186219; cv=none; d=google.com; s=arc-20160816; b=wxH+gixvIrap6NCYKBAr4URJS2jMHZz05/thOfpDjf9iwq2RxrpYGhdANLFkAL6jgx JKP1CBhbzM87BoKHgCOH/SMFjng4Ts5syHuXtlq1muNDpuSt/xTXJs1DzOKCLpx/iU0W el+PrkyNfcALLBSuYnl0FvzaUs6NWg/xItCAy1HHZHnh3nLKhfnyHS+WIXBH/OYpq/q1 2tOXYdQ6XAeTjEmMk9+Il3pcMqNoIaLBrpvWkE3iAr+iWGS0FzmCxy9z0Jn4/vhtj3yD s8uGCh+Y3c3FlfNuDXE+DizJMUNG/9pGZezvR7o3vEKSvc3x8BCGU4tS7Q6dIpNHelzP vRNQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=LO9rpE97lcwcTXoDwYeZMBa8WVHeAkKc2KvFF9yieLo=; fh=Y4N0eDKPElZOeGQE4q3Y9U5zoSjvt8HiQYvhFDMLD1M=; b=ohjgHhv1+eakSjONE+0dbky/X/vEa6W0TpjBRBohU9c5nGRQ0cTJ3jWBOK5gPkMkGj WiIsbt7uoZAP2pAftFm4Erw5LY5eXZPkZOuKIAY9NRA3u1tQkoKuyyB1zoaG7ioeyImE xDfZv7Wyn9j1i6tH0kr1oitgeMk3G8VDpuoMe8Vcqrg9vE43XfR3a2dqPjkjZ/rlowDf 9NDiRYKyeId3b3UR3yH5aHpwtTOrtjmOt+vrZN+0X3gBQNGDrXPFRP8VZ+b2vSOw+85S 2YTV9FHQ1vb79B2AHb+Z0iQM87wcjLHt3s1MTPapy7MmwfPrWmB14yDB2x8OjY48zo0E l3UQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=DkwxAfZW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e20-20020a656794000000b005538c82b70fsi3781532pgr.166.2023.07.12.11.23.27; Wed, 12 Jul 2023 11:23:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=DkwxAfZW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231675AbjGLRmW (ORCPT + 99 others); Wed, 12 Jul 2023 13:42:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45020 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231990AbjGLRmU (ORCPT ); Wed, 12 Jul 2023 13:42:20 -0400 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B115C119; Wed, 12 Jul 2023 10:42:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1689183740; x=1720719740; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=Wo2LSYIPXTFGEx73v06CYq+6xd1CJp9Oc6efKsK9DW0=; b=DkwxAfZWit1KQbMcuZTHJIMffq8sj0dpsL1OiHqzw6FJAud3mXqeO57x TJvYOCTlBxtyn1PZST+D41Vv8u4Hu1APNTG4w7UMEjDvLqElL1an/yeaF A3op128XCq1WpA9G5zO7y3m+Yo3VV9YhG42WEyjXJLErSXNT+/3JSiZ0W yJ2jbEu43cgRrLJhOLSK01TOElt8WMLmXwOinp74vmlPWKpAJVUW4p7WZ RMq2ifqqct5N9VL5qd6OwIoPEQVbSEIteOp7slFkEcjwm0L5TL1k40+4X /K+O2MFjW/Zxm7b5fFYtQLJ+4E/QhniGRwsD8uDM8B2jiUqcpC63+0h4M w==; X-IronPort-AV: E=McAfee;i="6600,9927,10769"; a="367581876" X-IronPort-AV: E=Sophos;i="6.01,200,1684825200"; d="scan'208";a="367581876" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Jul 2023 10:42:10 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10769"; a="724965910" X-IronPort-AV: E=Sophos;i="6.01,200,1684825200"; d="scan'208";a="724965910" Received: from fyu1.sc.intel.com ([172.25.103.126]) by fmsmga007.fm.intel.com with ESMTP; 12 Jul 2023 10:42:09 -0700 From: Fenghua Yu To: "Vinod Koul" , "Dave Jiang" Cc: dmaengine@vger.kernel.org, "linux-kernel" , Fenghua Yu , Tony Zhu Subject: [PATCH v2] dmaengine: idxd: Clear PRS disable flag when disabling IDXD device Date: Wed, 12 Jul 2023 10:42:20 -0700 Message-Id: <20230712174220.3434989-1-fenghua.yu@intel.com> X-Mailer: git-send-email 2.37.1 MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1771240129582086637 X-GMAIL-MSGID: 1771240129582086637 Disabling IDXD device doesn't reset Page Request Service (PRS) disable flag to its initial value 0. This may cause user confusion because once PRS is disabled user will see PRS still remains the previous setting (i.e. disabled) via sysfs interface even after the device is disabled. To eliminate the confusion, reset PRS disable flag when the device is disabled. Tested-by: Tony Zhu Signed-off-by: Fenghua Yu --- v2: - Fix Tony's email typo drivers/dma/idxd/device.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/dma/idxd/device.c b/drivers/dma/idxd/device.c index 5abbcc61c528..71dfb2c13066 100644 --- a/drivers/dma/idxd/device.c +++ b/drivers/dma/idxd/device.c @@ -387,6 +387,7 @@ static void idxd_wq_disable_cleanup(struct idxd_wq *wq) clear_bit(WQ_FLAG_DEDICATED, &wq->flags); clear_bit(WQ_FLAG_BLOCK_ON_FAULT, &wq->flags); clear_bit(WQ_FLAG_ATS_DISABLE, &wq->flags); + clear_bit(WQ_FLAG_PRS_DISABLE, &wq->flags); memset(wq->name, 0, WQ_NAME_SIZE); wq->max_xfer_bytes = WQ_DEFAULT_MAX_XFER; idxd_wq_set_max_batch_size(idxd->data->type, wq, WQ_DEFAULT_MAX_BATCH);