diff mbox series

ARM: dts: at91: ksz9477_evb: Add missing timer nodes

Message ID 20230712152111.3756211-1-lukma@denx.de
State New
Headers
Series ARM: dts: at91: ksz9477_evb: Add missing timer nodes |

Commit Message

Lukasz Majewski July 12, 2023, 3:21 p.m. UTC 
  Without this change the KSZ9477-EVB board hangs just after passing
execution flow from u-boot to Linux kernel.

This code has been copied from at91-sama5d3_xplained.dts.

Test setup: Linux 6.5-rc1
Config:     arch/arm/configs/sama5_defconfig
Toolchain:  gcc-linaro-7.3.1-2018.05-x86_64_arm-linux-gnueabi

Signed-off-by: Lukasz Majewski <lukma@denx.de>
---
 .../boot/dts/microchip/at91-sama5d3_ksz9477_evb.dts  | 12 ++++++++++++
 1 file changed, 12 insertions(+)

Comments

Lukasz Majewski July 26, 2023, 8:19 a.m. UTC | #1 
Dear Community,

> Without this change the KSZ9477-EVB board hangs just after passing
> execution flow from u-boot to Linux kernel.
> 
> This code has been copied from at91-sama5d3_xplained.dts.
> 
> Test setup: Linux 6.5-rc1
> Config:     arch/arm/configs/sama5_defconfig
> Toolchain:  gcc-linaro-7.3.1-2018.05-x86_64_arm-linux-gnueabi
> 
> Signed-off-by: Lukasz Majewski <lukma@denx.de>
> ---
>  .../boot/dts/microchip/at91-sama5d3_ksz9477_evb.dts  | 12
> ++++++++++++ 1 file changed, 12 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/microchip/at91-sama5d3_ksz9477_evb.dts
> b/arch/arm/boot/dts/microchip/at91-sama5d3_ksz9477_evb.dts index
> 14af1fd6d247..99cd6d15998b 100644 ---
> a/arch/arm/boot/dts/microchip/at91-sama5d3_ksz9477_evb.dts +++
> b/arch/arm/boot/dts/microchip/at91-sama5d3_ksz9477_evb.dts @@ -162,6
> +162,18 @@ };
>  };
>  
> +&tcb0 {
> +	timer0: timer@0 {
> +		compatible = "atmel,tcb-timer";
> +		reg = <0>;
> +	};
> +
> +	timer1: timer@1 {
> +		compatible = "atmel,tcb-timer";
> +		reg = <1>;
> +	};
> +};
> +
>  &usb0 {
>  	pinctrl-names = "default";
>  	pinctrl-0 = <&pinctrl_usba_vbus>;

Gentle ping on this fix ...


Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de
Conor Dooley July 26, 2023, 6:33 p.m. UTC | #2 
On Wed, Jul 26, 2023 at 10:19:02AM +0200, Lukasz Majewski wrote:
> Dear Community,
> 
> > Without this change the KSZ9477-EVB board hangs just after passing
> > execution flow from u-boot to Linux kernel.
> > 
> > This code has been copied from at91-sama5d3_xplained.dts.
> > 
> > Test setup: Linux 6.5-rc1
> > Config:     arch/arm/configs/sama5_defconfig
> > Toolchain:  gcc-linaro-7.3.1-2018.05-x86_64_arm-linux-gnueabi
> > 
> > Signed-off-by: Lukasz Majewski <lukma@denx.de>
> > ---
> >  .../boot/dts/microchip/at91-sama5d3_ksz9477_evb.dts  | 12
> > ++++++++++++ 1 file changed, 12 insertions(+)
> > 
> > diff --git a/arch/arm/boot/dts/microchip/at91-sama5d3_ksz9477_evb.dts
> > b/arch/arm/boot/dts/microchip/at91-sama5d3_ksz9477_evb.dts index
> > 14af1fd6d247..99cd6d15998b 100644 ---
> > a/arch/arm/boot/dts/microchip/at91-sama5d3_ksz9477_evb.dts +++
> > b/arch/arm/boot/dts/microchip/at91-sama5d3_ksz9477_evb.dts @@ -162,6
> > +162,18 @@ };
> >  };
> >  
> > +&tcb0 {
> > +	timer0: timer@0 {
> > +		compatible = "atmel,tcb-timer";
> > +		reg = <0>;
> > +	};
> > +
> > +	timer1: timer@1 {
> > +		compatible = "atmel,tcb-timer";
> > +		reg = <1>;
> > +	};
> > +};
> > +
> >  &usb0 {
> >  	pinctrl-names = "default";
> >  	pinctrl-0 = <&pinctrl_usba_vbus>;
> 
> Gentle ping on this fix ...

Claudiu has left Microchip, so things might've got a bit lost on the
way. I've added his new address, Claudiu, will you take a look/pick this
up please? I can also do it if that is easier for you.

Thanks,
Conor.
claudiu beznea July 27, 2023, 5:37 a.m. UTC | #3 
On 26.07.2023 21:33, Conor Dooley wrote:
> On Wed, Jul 26, 2023 at 10:19:02AM +0200, Lukasz Majewski wrote:
>> Dear Community,
>>
>>> Without this change the KSZ9477-EVB board hangs just after passing
>>> execution flow from u-boot to Linux kernel.
>>>
>>> This code has been copied from at91-sama5d3_xplained.dts.
>>>
>>> Test setup: Linux 6.5-rc1
>>> Config:     arch/arm/configs/sama5_defconfig
>>> Toolchain:  gcc-linaro-7.3.1-2018.05-x86_64_arm-linux-gnueabi
>>>
>>> Signed-off-by: Lukasz Majewski <lukma@denx.de>
>>> ---
>>>   .../boot/dts/microchip/at91-sama5d3_ksz9477_evb.dts  | 12
>>> ++++++++++++ 1 file changed, 12 insertions(+)
>>>
>>> diff --git a/arch/arm/boot/dts/microchip/at91-sama5d3_ksz9477_evb.dts
>>> b/arch/arm/boot/dts/microchip/at91-sama5d3_ksz9477_evb.dts index
>>> 14af1fd6d247..99cd6d15998b 100644 ---
>>> a/arch/arm/boot/dts/microchip/at91-sama5d3_ksz9477_evb.dts +++
>>> b/arch/arm/boot/dts/microchip/at91-sama5d3_ksz9477_evb.dts @@ -162,6
>>> +162,18 @@ };
>>>   };
>>>   
>>> +&tcb0 {
>>> +	timer0: timer@0 {
>>> +		compatible = "atmel,tcb-timer";
>>> +		reg = <0>;
>>> +	};
>>> +
>>> +	timer1: timer@1 {
>>> +		compatible = "atmel,tcb-timer";
>>> +		reg = <1>;
>>> +	};
>>> +};
>>> +
>>>   &usb0 {
>>>   	pinctrl-names = "default";
>>>   	pinctrl-0 = <&pinctrl_usba_vbus>;
>>
>> Gentle ping on this fix ...
> 
> Claudiu has left Microchip, so things might've got a bit lost on the
> way. I've added his new address, Claudiu, will you take a look/pick this
> up please? I can also do it if that is easier for you.

It's on my list.

Thanks,
Claudiu

> 
> Thanks,
> Conor.
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
claudiu beznea Aug. 2, 2023, 4:50 a.m. UTC | #4 
On 26.07.2023 11:19, Lukasz Majewski wrote:
> Dear Community,
> 
>> Without this change the KSZ9477-EVB board hangs just after passing
>> execution flow from u-boot to Linux kernel.
>>
>> This code has been copied from at91-sama5d3_xplained.dts.
>>
>> Test setup: Linux 6.5-rc1
>> Config:     arch/arm/configs/sama5_defconfig
>> Toolchain:  gcc-linaro-7.3.1-2018.05-x86_64_arm-linux-gnueabi
>>
>> Signed-off-by: Lukasz Majewski <lukma@denx.de>

Applied to at91-dt, thanks!
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/microchip/at91-sama5d3_ksz9477_evb.dts b/arch/arm/boot/dts/microchip/at91-sama5d3_ksz9477_evb.dts
index 14af1fd6d247..99cd6d15998b 100644
--- a/arch/arm/boot/dts/microchip/at91-sama5d3_ksz9477_evb.dts
+++ b/arch/arm/boot/dts/microchip/at91-sama5d3_ksz9477_evb.dts
@@ -162,6 +162,18 @@ 
 	};
 };
 
+&tcb0 {
+	timer0: timer@0 {
+		compatible = "atmel,tcb-timer";
+		reg = <0>;
+	};
+
+	timer1: timer@1 {
+		compatible = "atmel,tcb-timer";
+		reg = <1>;
+	};
+};
+
 &usb0 {
 	pinctrl-names = "default";
 	pinctrl-0 = <&pinctrl_usba_vbus>;