Message ID | 20230712130215.666924-1-amit.pundir@linaro.org |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:a6b2:0:b0:3e4:2afc:c1 with SMTP id c18csp1170806vqm; Wed, 12 Jul 2023 07:02:01 -0700 (PDT) X-Google-Smtp-Source: APBJJlGzhNTOx641koMKxFyi5lw13d6IN2c3RXPWxl7ripUVm7UZR8cl6MNs0kDjfkieeExt17kj X-Received: by 2002:a05:6a00:3a2a:b0:682:8899:f6e6 with SMTP id fj42-20020a056a003a2a00b006828899f6e6mr14115743pfb.28.1689170521422; Wed, 12 Jul 2023 07:02:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689170521; cv=none; d=google.com; s=arc-20160816; b=P0vxO1DPSEv3yhI1zBljz5bAVhL1lrnegWUfY5/yOT3FC6etr9B+uzFtwhA6ntiDU9 bVjwyEDdMcKxYLmNlDxZ1VFoVmsZEmCQ1RljFfodPC7ydVPBfeBnyA/rC+dCBCuqBFsg vFDwASOD0WmtpG4XQ19NRh+XSY6XLZzDTI9CGbYMCyCXdvAc+U8zdhz/Xq7FqIT8eDV3 qo6fyHLnBh1PsXXiIPIdDJzyHPej+4zILZrQCjAJXs0Qxn1y5J/QuOxdTNYbyq9kedrB 469C1KvjqXo24/wj80wxAFTdxeupxp3Mzv5ZujS3MmBDb0o9zj30CCUsFgRMrl2ZOi8D mqqw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:author:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=KMdohCdaLVd4HEOOg6g6eIdW9oFM4ELH5FlH42ryJA4=; fh=bUGzLlUT6AJNEZrTvniK2uKszsewdBL+00C8IeKdOoA=; b=o7mK/eRE4QghjuH2TXdikM+Po5MHxJ/50OhKttM7m0jEmra9mjoEYfoyNoOLJuN0kY NHtOrC89UyAGYVrmB5ymyM9BQDaEsmFJtcI7IKqKr5LHOk0OEBDKWNMB911XecKQclOW zpYCDVj3z0IwICeVD3jBH8GAq7zkfgGBD/XYnBacUmczg+46zqwv7exXapfe9VY2CrO3 ygAK82KJvbgv/yFrCOXUiTzNHITHBx4I2AZTG2pCFKPHos8t0qlY84ejYesU1QzMtdRq rdhU4okgOe+EV7oAng6ccWfsw8U6a2a5nlK+30ATKztBY1CvUKw2SjLjr7p3woeCuSgs Gzmg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=FO8qnGg6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u12-20020a655c0c000000b0055b79986063si3298102pgr.300.2023.07.12.07.01.47; Wed, 12 Jul 2023 07:02:01 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=FO8qnGg6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233291AbjGLNCm (ORCPT <rfc822;gnulinuxfreebsd@gmail.com> + 99 others); Wed, 12 Jul 2023 09:02:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39040 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233419AbjGLNCe (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Wed, 12 Jul 2023 09:02:34 -0400 Received: from mail-pf1-x431.google.com (mail-pf1-x431.google.com [IPv6:2607:f8b0:4864:20::431]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DDBBA1FD2 for <linux-kernel@vger.kernel.org>; Wed, 12 Jul 2023 06:02:23 -0700 (PDT) Received: by mail-pf1-x431.google.com with SMTP id d2e1a72fcca58-666e916b880so3454652b3a.2 for <linux-kernel@vger.kernel.org>; Wed, 12 Jul 2023 06:02:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1689166943; x=1691758943; h=content-transfer-encoding:author:mime-version:message-id:date :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=KMdohCdaLVd4HEOOg6g6eIdW9oFM4ELH5FlH42ryJA4=; b=FO8qnGg64dU7X+U8EMUetFFnalKYf9NpPJ7dptUBQOkNpwc7ZLhwLDh025M7zMlcZH QrHgezV0MJQv6uDJjvMI858+eQbKt98luJKA7Jhm8UfQ/ivd9IQ8/0Il4x1hgFxv4U2P 4hJcwADL1GngCelhFCpOAOJ4XSZsmTcDTtgCEXyWYc3rSw6QVA//WnQY9BUan190iJ1E Lf8lebzMdld8H9io6dgAOTL0oqNJKMUl6Y1QMBrgIYSLlTmF7BLJxtSQxDfqIDXqSRW0 S8y56T0M4ovrAOWqzDZvFUIDSwd9AZpK7u2/48Os1oxVvgUcpXnCWXYDU3c85rz2MsNn pvYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689166943; x=1691758943; h=content-transfer-encoding:author:mime-version:message-id:date :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=KMdohCdaLVd4HEOOg6g6eIdW9oFM4ELH5FlH42ryJA4=; b=XmCzHc5euChieyOHrE5DT7TjHSOpDy6B4vP5Y0epj8ApVy9h6U0DCxpLVYKmEbGJM7 +A7q7KUjMKm6YK+eOebXEGDk6nVlkN+NFQGwqKYGgXUG5T0RJIazrdaINsJDcEDB335l QEeCdFRUrbqahHg+za+WQ5AcZMRWgc38nI2AVrDD7cb6QvPZKEJ9jJGv39e2x+nOGjrZ b+/+QwlRM/u9dsQuVtR9qUNkY7SxKZWjOO9jXEqiFzK0JbmqSvELEjqfu+2PHchTx9/R vu/jMxeSH+joV/7rMZrgfuN1ywQuDKYiea/8mwBT6xx7N0pTWa/MW4m1e0WfFCETq6re P+Og== X-Gm-Message-State: ABy/qLZrI7UwsLEX+WJ2/gkRZZyjRsyd9mH8utLHYXh1XVTrPr+HWGE0 VpuBiLugaX4YE5s+8xe8k9a6WQ== X-Received: by 2002:a05:6a20:12d0:b0:129:a9af:7ec6 with SMTP id v16-20020a056a2012d000b00129a9af7ec6mr16897403pzg.56.1689166943112; Wed, 12 Jul 2023 06:02:23 -0700 (PDT) Received: from x-wing.lan ([49.207.50.231]) by smtp.gmail.com with ESMTPSA id p1-20020a639501000000b0054fe07d2f3dsm3417023pgd.11.2023.07.12.06.02.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Jul 2023 06:02:22 -0700 (PDT) From: Amit Pundir <amit.pundir@linaro.org> To: Bjorn Andersson <andersson@kernel.org>, Andy Gross <agross@kernel.org>, Dmitry Baryshkov <dmitry.baryshkov@linaro.org>, Rob Herring <robh+dt@kernel.org>, Konrad Dybcio <konrad.dybcio@linaro.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, Caleb Connolly <caleb.connolly@linaro.org>, Bryan Donoghue <bryan.odonoghue@linaro.org>, Rob Clark <robdclark@gmail.com>, Abhinav Kumar <quic_abhinavk@quicinc.com>, Sean Paul <sean@poorly.run>, Marijn Suijten <marijn.suijten@somainline.org>, David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>, Krishna Manikandan <quic_mkrishn@quicinc.com> Cc: dri-devel <dri-devel@lists.freedesktop.org>, freedreno <freedreno@lists.freedesktop.org>, linux-arm-msm <linux-arm-msm@vger.kernel.org>, dt <devicetree@vger.kernel.org>, lkml <linux-kernel@vger.kernel.org> Subject: [PATCH 1/2] dt-bindings: display/msm: qcom,sdm845-mdss: add memory-region property Date: Wed, 12 Jul 2023 18:32:14 +0530 Message-Id: <20230712130215.666924-1-amit.pundir@linaro.org> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Author: Amit Pundir <amit.pundir@linaro.org> Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1771222251858499411 X-GMAIL-MSGID: 1771223668458904413 |
Series |
[1/2] dt-bindings: display/msm: qcom,sdm845-mdss: add memory-region property
|
|
Commit Message
Amit Pundir
July 12, 2023, 1:02 p.m. UTC
Add and document the reserved memory region property
in the qcom,sdm845-mdss schema.
Signed-off-by: Amit Pundir <amit.pundir@linaro.org>
---
.../devicetree/bindings/display/msm/qcom,sdm845-mdss.yaml | 5 +++++
1 file changed, 5 insertions(+)
Comments
On 12/07/2023 15:02, Amit Pundir wrote: > Add and document the reserved memory region property > in the qcom,sdm845-mdss schema. > > Signed-off-by: Amit Pundir <amit.pundir@linaro.org> Please keep consistent versioning, so this is new patch in v4. > --- > .../devicetree/bindings/display/msm/qcom,sdm845-mdss.yaml | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sdm845-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,sdm845-mdss.yaml > index 6ecb00920d7f..3ea1dbd7e317 100644 > --- a/Documentation/devicetree/bindings/display/msm/qcom,sdm845-mdss.yaml > +++ b/Documentation/devicetree/bindings/display/msm/qcom,sdm845-mdss.yaml > @@ -39,6 +39,11 @@ properties: > interconnect-names: > maxItems: 2 > > + memory-region: > + maxItems: 1 > + description: > + Phandle to a node describing a reserved memory region. Your description says nothing new. It's entirely redundant/obvious. Instead please describe what reserved memory is expected to be here. Best regards, Krzysztof
On Wed, 12 Jul 2023 at 18:45, Dmitry Baryshkov <dmitry.baryshkov@linaro.org> wrote: > > On 12/07/2023 16:02, Amit Pundir wrote: > > Add and document the reserved memory region property > > in the qcom,sdm845-mdss schema. > > > > Signed-off-by: Amit Pundir <amit.pundir@linaro.org> > > --- > > .../devicetree/bindings/display/msm/qcom,sdm845-mdss.yaml | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sdm845-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,sdm845-mdss.yaml > > index 6ecb00920d7f..3ea1dbd7e317 100644 > > --- a/Documentation/devicetree/bindings/display/msm/qcom,sdm845-mdss.yaml > > +++ b/Documentation/devicetree/bindings/display/msm/qcom,sdm845-mdss.yaml > > @@ -39,6 +39,11 @@ properties: > > interconnect-names: > > maxItems: 2 > > > > + memory-region: > > + maxItems: 1 > > + description: > > + Phandle to a node describing a reserved memory region. > > + > > Please add it to mdss-common.yaml instead mdss-common.yaml didn't like this property at all and I ran into a lot of new dtbs_check warnings: https://www.irccloud.com/pastebin/raw/pEYAeaB1 I need some help in decoding these please. Regards, Amit Pundir > > > patternProperties: > > "^display-controller@[0-9a-f]+$": > > type: object > > -- > With best wishes > Dmitry >
On Wed, 12 Jul 2023 at 19:46, Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > On 12/07/2023 15:02, Amit Pundir wrote: > > Add and document the reserved memory region property > > in the qcom,sdm845-mdss schema. > > > > Signed-off-by: Amit Pundir <amit.pundir@linaro.org> > > Please keep consistent versioning, so this is new patch in v4. ACK. > > > --- > > .../devicetree/bindings/display/msm/qcom,sdm845-mdss.yaml | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sdm845-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,sdm845-mdss.yaml > > index 6ecb00920d7f..3ea1dbd7e317 100644 > > --- a/Documentation/devicetree/bindings/display/msm/qcom,sdm845-mdss.yaml > > +++ b/Documentation/devicetree/bindings/display/msm/qcom,sdm845-mdss.yaml > > @@ -39,6 +39,11 @@ properties: > > interconnect-names: > > maxItems: 2 > > > > + memory-region: > > + maxItems: 1 > > + description: > > + Phandle to a node describing a reserved memory region. > > Your description says nothing new. It's entirely redundant/obvious. > Instead please describe what reserved memory is expected to be here. On it. I'll update in v5. Thanks. Regards, Amit Pundir > > > Best regards, > Krzysztof >
On Thu, 13 Jul 2023 at 18:34, Amit Pundir <amit.pundir@linaro.org> wrote: > > On Wed, 12 Jul 2023 at 18:45, Dmitry Baryshkov > <dmitry.baryshkov@linaro.org> wrote: > > > > On 12/07/2023 16:02, Amit Pundir wrote: > > > Add and document the reserved memory region property > > > in the qcom,sdm845-mdss schema. > > > > > > Signed-off-by: Amit Pundir <amit.pundir@linaro.org> > > > --- > > > .../devicetree/bindings/display/msm/qcom,sdm845-mdss.yaml | 5 +++++ > > > 1 file changed, 5 insertions(+) > > > > > > diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sdm845-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,sdm845-mdss.yaml > > > index 6ecb00920d7f..3ea1dbd7e317 100644 > > > --- a/Documentation/devicetree/bindings/display/msm/qcom,sdm845-mdss.yaml > > > +++ b/Documentation/devicetree/bindings/display/msm/qcom,sdm845-mdss.yaml > > > @@ -39,6 +39,11 @@ properties: > > > interconnect-names: > > > maxItems: 2 > > > > > > + memory-region: > > > + maxItems: 1 > > > + description: > > > + Phandle to a node describing a reserved memory region. > > > + > > > > Please add it to mdss-common.yaml instead > > mdss-common.yaml didn't like this property at all and > I ran into a lot of new dtbs_check warnings: > https://www.irccloud.com/pastebin/raw/pEYAeaB1 > > I need some help in decoding these please. I'm not sure what happened there (and it's hard to understand without seeing your patch). But after applying your patch to mdss-common.yaml, `make dt_binding_check' passes: diff --git a/Documentation/devicetree/bindings/display/msm/mdss-common.yaml b/Documentation/devicetree/bindings/display/msm/mdss-common.yaml index ccd7d6417523..924fe383e4a1 100644 --- a/Documentation/devicetree/bindings/display/msm/mdss-common.yaml +++ b/Documentation/devicetree/bindings/display/msm/mdss-common.yaml @@ -77,6 +77,11 @@ properties: items: - description: MDSS_CORE reset + memory-region: + maxItems: 1 + description: + Phandle to a node describing a reserved memory region. + required: - reg - reg-names > > Regards, > Amit Pundir > > > > > > patternProperties: > > > "^display-controller@[0-9a-f]+$": > > > type: object > > > > -- > > With best wishes > > Dmitry > >
On Thu, 13 Jul 2023 at 21:13, Dmitry Baryshkov <dmitry.baryshkov@linaro.org> wrote: > > On Thu, 13 Jul 2023 at 18:34, Amit Pundir <amit.pundir@linaro.org> wrote: > > > > On Wed, 12 Jul 2023 at 18:45, Dmitry Baryshkov > > <dmitry.baryshkov@linaro.org> wrote: > > > > > > On 12/07/2023 16:02, Amit Pundir wrote: > > > > Add and document the reserved memory region property > > > > in the qcom,sdm845-mdss schema. > > > > > > > > Signed-off-by: Amit Pundir <amit.pundir@linaro.org> > > > > --- > > > > .../devicetree/bindings/display/msm/qcom,sdm845-mdss.yaml | 5 +++++ > > > > 1 file changed, 5 insertions(+) > > > > > > > > diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sdm845-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,sdm845-mdss.yaml > > > > index 6ecb00920d7f..3ea1dbd7e317 100644 > > > > --- a/Documentation/devicetree/bindings/display/msm/qcom,sdm845-mdss.yaml > > > > +++ b/Documentation/devicetree/bindings/display/msm/qcom,sdm845-mdss.yaml > > > > @@ -39,6 +39,11 @@ properties: > > > > interconnect-names: > > > > maxItems: 2 > > > > > > > > + memory-region: > > > > + maxItems: 1 > > > > + description: > > > > + Phandle to a node describing a reserved memory region. > > > > + > > > > > > Please add it to mdss-common.yaml instead > > > > mdss-common.yaml didn't like this property at all and > > I ran into a lot of new dtbs_check warnings: > > https://www.irccloud.com/pastebin/raw/pEYAeaB1 > > > > I need some help in decoding these please. > > I'm not sure what happened there (and it's hard to understand without > seeing your patch). Yup.. It was my broken patch. I used "For example:" in the property description and it tripped off the checks. Didn't realise that casually used ":" can break yaml parsing until now. Sorry for all the noise. Regards, Amit Pundir > But after applying your patch to mdss-common.yaml, > `make dt_binding_check' passes: > > diff --git a/Documentation/devicetree/bindings/display/msm/mdss-common.yaml > b/Documentation/devicetree/bindings/display/msm/mdss-common.yaml > index ccd7d6417523..924fe383e4a1 100644 > --- a/Documentation/devicetree/bindings/display/msm/mdss-common.yaml > +++ b/Documentation/devicetree/bindings/display/msm/mdss-common.yaml > @@ -77,6 +77,11 @@ properties: > items: > - description: MDSS_CORE reset > > + memory-region: > + maxItems: 1 > + description: > + Phandle to a node describing a reserved memory region. > + > required: > - reg > - reg-names > > > > > > Regards, > > Amit Pundir > > > > > > > > > patternProperties: > > > > "^display-controller@[0-9a-f]+$": > > > > type: object > > > > > > -- > > > With best wishes > > > Dmitry > > > > > > > -- > With best wishes > Dmitry
diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sdm845-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,sdm845-mdss.yaml index 6ecb00920d7f..3ea1dbd7e317 100644 --- a/Documentation/devicetree/bindings/display/msm/qcom,sdm845-mdss.yaml +++ b/Documentation/devicetree/bindings/display/msm/qcom,sdm845-mdss.yaml @@ -39,6 +39,11 @@ properties: interconnect-names: maxItems: 2 + memory-region: + maxItems: 1 + description: + Phandle to a node describing a reserved memory region. + patternProperties: "^display-controller@[0-9a-f]+$": type: object