diff mbox series

[v4,8/9] dt-bindings: arm: stm32: add extra SiP compatible for oct,stm32mp157c-osd32-red

Message ID 20230712124248.2400862-8-sean@geanix.com
State New
Headers
Series [v4,1/9] ARM: dts: stm32: Add alternate pinmux for i2s pins |

Commit Message

Sean Nyekjaer July 12, 2023, 12:42 p.m. UTC 
  Add binding support for the Octavo OSD32MP1-RED development board.

General features:
 - STM32MP157C
 - 512MB DDR3
 - CAN-FD
 - HDMI
 - USB-C OTG
 - UART

Signed-off-by: Sean Nyekjaer <sean@geanix.com>
---
 Documentation/devicetree/bindings/arm/stm32/stm32.yaml | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

Comments

Conor Dooley July 12, 2023, 6:10 p.m. UTC | #1 
On Wed, Jul 12, 2023 at 02:42:46PM +0200, Sean Nyekjaer wrote:
> Add binding support for the Octavo OSD32MP1-RED development board.
> 
> General features:
>  - STM32MP157C
>  - 512MB DDR3
>  - CAN-FD
>  - HDMI
>  - USB-C OTG
>  - UART
> 
> Signed-off-by: Sean Nyekjaer <sean@geanix.com>

Acked-by: Conor Dooley <conor.dooley@microchip.com>

Cheers,
Conor.
Krzysztof Kozlowski July 12, 2023, 7:29 p.m. UTC | #2 
On 12/07/2023 14:42, Sean Nyekjaer wrote:
> Add binding support for the Octavo OSD32MP1-RED development board.
> 
> General features:
>  - STM32MP157C
>  - 512MB DDR3
>  - CAN-FD
>  - HDMI
>  - USB-C OTG
>  - UART
> 
> Signed-off-by: Sean Nyekjaer <sean@geanix.com>
> ---
>  Documentation/devicetree/bindings/arm/stm32/stm32.yaml | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/arm/stm32/stm32.yaml b/Documentation/devicetree/bindings/arm/stm32/stm32.yaml
> index 4bf28e717a56..232abdcef0fd 100644
> --- a/Documentation/devicetree/bindings/arm/stm32/stm32.yaml
> +++ b/Documentation/devicetree/bindings/arm/stm32/stm32.yaml
> @@ -143,9 +143,10 @@ properties:
>        - description: Octavo OSD32MP15x System-in-Package based boards
>          items:
>            - enum:
> -              - lxa,stm32mp157c-mc1      # Linux Automation MC-1
> -              - lxa,stm32mp157c-tac-gen1 # Linux Automation TAC (Generation 1)
> -              - lxa,stm32mp157c-tac-gen2 # Linux Automation TAC (Generation 2)
> +              - lxa,stm32mp157c-mc1        # Linux Automation MC-1
> +              - lxa,stm32mp157c-tac-gen1   # Linux Automation TAC (Generation 1)
> +              - lxa,stm32mp157c-tac-gen2   # Linux Automation TAC (Generation 2)
> +              - oct,stm32mp157c-osd32-red  # Octavo OSD32MP1 RED board

I would prefer the change without touching previous lines for
re-indenting the comment. However it's ok if your arch maintainers is happy:

Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/arm/stm32/stm32.yaml b/Documentation/devicetree/bindings/arm/stm32/stm32.yaml
index 4bf28e717a56..232abdcef0fd 100644
--- a/Documentation/devicetree/bindings/arm/stm32/stm32.yaml
+++ b/Documentation/devicetree/bindings/arm/stm32/stm32.yaml
@@ -143,9 +143,10 @@  properties:
       - description: Octavo OSD32MP15x System-in-Package based boards
         items:
           - enum:
-              - lxa,stm32mp157c-mc1      # Linux Automation MC-1
-              - lxa,stm32mp157c-tac-gen1 # Linux Automation TAC (Generation 1)
-              - lxa,stm32mp157c-tac-gen2 # Linux Automation TAC (Generation 2)
+              - lxa,stm32mp157c-mc1        # Linux Automation MC-1
+              - lxa,stm32mp157c-tac-gen1   # Linux Automation TAC (Generation 1)
+              - lxa,stm32mp157c-tac-gen2   # Linux Automation TAC (Generation 2)
+              - oct,stm32mp157c-osd32-red  # Octavo OSD32MP1 RED board
           - const: oct,stm32mp15xx-osd32
           - enum:
               - st,stm32mp157