Message ID | 20230712113731.3306-3-wsa+renesas@sang-engineering.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:a6b2:0:b0:3e4:2afc:c1 with SMTP id c18csp1085309vqm; Wed, 12 Jul 2023 04:41:11 -0700 (PDT) X-Google-Smtp-Source: APBJJlHCmThhcKmCbHHRP8K4tHqhH+4hRr7M3eMniU0PEkF4R0NbzjMe797REh4QA1i4K9wSO8jv X-Received: by 2002:a05:6a00:24d5:b0:682:bd6e:b16a with SMTP id d21-20020a056a0024d500b00682bd6eb16amr15224681pfv.14.1689162071254; Wed, 12 Jul 2023 04:41:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689162071; cv=none; d=google.com; s=arc-20160816; b=Qvrw2DTEohmRsbcUN+5qIZjtqaXZc/mb69FQ/3gCekt4s5lV+OwAR9H7Orzmd37kVa o77VHAQR2ScpUfEnJtzr6E4azSKx71snh9jGagvf+purcspeBCdrWBv5TXJXsgkZ/FDU H3i6czXgP2jjRT0wEPiS2sGBAuuws18M1AuGfwminsOWxqLf/gr8Xm8FfGush/XgU/Ay zuVvBg4k8LLoZ18I2JufxnogqkFTeAozI1CBLl/ZdIsgDnLcWNHOluKTFfg9Grk9wTQj RkzpQ7GfuTOaiKiQzVxtthmg6C5UjNlfk649+0bAWL/mOSQQ60c2vZWsaLDxFS5tRhcK wQXw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=ilnQAzhkzQbHlzdI76gswcqDlW6Rxu0S5Cd2vxmIpbY=; fh=EucViROd1TvRoMhtX01H3ckl7LOmWha31/vVUO7xyBk=; b=baL8fVquoUczLGRHiuCL1wNcoI14EkBExaSS3ybPy/LlbO+WBRLQ/PYafaaMMZWMyZ oFiZvdT/0U2YUXAcMSr55YlK/2vcJxeO62zm1stCZJn82ZmQA1rpKtjS7XZI3p18a5cl a11lPmGYyaLG9O5pu/Pp8j7Kt7Yrdgd2dY5GfYIjZa3GjFmdoSlI+QqXtFHzbfUjEDKd Owy3rzePb+boRb/B61uqr4Y3c7Z8hrqXotvK0Q9ETG68TcW/onzkhFVz69a4ZGQkS+5t z/cCiOac+o5LrdO06jo5MVnhq6BoKIJs/SOq6VlaDLo22Z2z/07RtPb5UI99OQpODvCb C40g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@sang-engineering.com header.s=k1 header.b=F2UijB02; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id cg15-20020a056a00290f00b00668731a497fsi3062649pfb.44.2023.07.12.04.40.58; Wed, 12 Jul 2023 04:41:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@sang-engineering.com header.s=k1 header.b=F2UijB02; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231741AbjGLLii (ORCPT <rfc822;gnulinuxfreebsd@gmail.com> + 99 others); Wed, 12 Jul 2023 07:38:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57468 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231588AbjGLLi3 (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Wed, 12 Jul 2023 07:38:29 -0400 Received: from mail.zeus03.de (www.zeus03.de [194.117.254.33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C9D961994 for <linux-kernel@vger.kernel.org>; Wed, 12 Jul 2023 04:38:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= sang-engineering.com; h=from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; s=k1; bh=ilnQAzhkzQbHlzdI76gswcqDlW6Rxu0S5Cd2vxmIpbY=; b=F2UijB 020gDZg0aQdUbhqDiFJbrOXtXLrgwaqr+1aQ/phqgDQcveY9q5C/zH45ra9P9YWv 33HOfZJ8RGHw1dmaZMtXvEco5AzsWUg5bq50e6Y+eM6cJegEpahKp1+I42wR9zvC VIa/y3DSQlSAN0CM4jreD9mEch6wiEOsst2mKzv69KEgtBgv4uHG93eEzWMAaYMX 73cKJo5sR8n7PNVQ7iItn48f7lN7TmPsUP4D9HMoTRujyeVd7TnRQnOr89uXpwBS u19i3hq+Sq1jutTzC1l+iCc1FedqgVPmYW3K/f0asARqnJBoogvsgtX1dLjeObol E/BU/BfYFdZOFT5g== Received: (qmail 1596815 invoked from network); 12 Jul 2023 13:37:45 +0200 Received: by mail.zeus03.de with ESMTPSA (TLS_AES_256_GCM_SHA384 encrypted, authenticated); 12 Jul 2023 13:37:45 +0200 X-UD-Smtp-Session: l3s3148p1@NN/tpEgAVqUujnvL From: Wolfram Sang <wsa+renesas@sang-engineering.com> To: linux-renesas-soc@vger.kernel.org Cc: Wolfram Sang <wsa+renesas@sang-engineering.com>, Johan Hovold <johan@kernel.org>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/3] dt-bindings: gnss: u-blox: add "reset-gpios" binding Date: Wed, 12 Jul 2023 13:37:30 +0200 Message-Id: <20230712113731.3306-3-wsa+renesas@sang-engineering.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230712113731.3306-1-wsa+renesas@sang-engineering.com> References: <20230712113731.3306-1-wsa+renesas@sang-engineering.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO, RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL, SPF_HELO_PASS,SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1771214807909122421 X-GMAIL-MSGID: 1771214807909122421 |
Series |
gnss: ubx: updates to support the Renesas KingFisher board
|
|
Commit Message
Wolfram Sang
July 12, 2023, 11:37 a.m. UTC
Needed to enable this chip on a Renesas KingFisher board. Description
copied over from the Mediatek driver which already supports it.
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
Documentation/devicetree/bindings/gnss/u-blox,neo-6m.yaml | 7 +++++++
1 file changed, 7 insertions(+)
Comments
On 12/07/2023 13:37, Wolfram Sang wrote: > Needed to enable this chip on a Renesas KingFisher board. Description > copied over from the Mediatek driver which already supports it. > > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> > --- > Documentation/devicetree/bindings/gnss/u-blox,neo-6m.yaml | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/Documentation/devicetree/bindings/gnss/u-blox,neo-6m.yaml b/Documentation/devicetree/bindings/gnss/u-blox,neo-6m.yaml > index 4835a280b3bf..8f6992b97ca6 100644 > --- a/Documentation/devicetree/bindings/gnss/u-blox,neo-6m.yaml > +++ b/Documentation/devicetree/bindings/gnss/u-blox,neo-6m.yaml > @@ -41,6 +41,12 @@ properties: > description: > > Backup voltage regulator > > + reset-gpios: > + maxItems: 1 > + description: > > + An optional reset line, with names such as RESET or NRESET. > + If the line is active low it should be flagged with GPIO_ACTIVE_LOW. > + > required: > - compatible > - vcc-supply > @@ -54,5 +60,6 @@ examples: > compatible = "u-blox,neo-8"; > v-bckp-supply = <&gnss_v_bckp_reg>; > vcc-supply = <&gnss_vcc_reg>; > + reset-gpios = <&gpio 1 GPIO_ACTIVE_LOW>; This should complain with errors, because of missing header for the defines, so usual disclaimer: It does not look like you tested the bindings, at least after quick look. Please run `make dt_binding_check` (see Documentation/devicetree/bindings/writing-schema.rst for instructions). Maybe you need to update your dtschema and yamllint. Best regards, Krzysztof
Hi Wolfram, On Wed, Jul 12, 2023 at 1:40 PM Wolfram Sang <wsa+renesas@sang-engineering.com> wrote: > Needed to enable this chip on a Renesas KingFisher board. Description > copied over from the Mediatek driver which already supports it. > > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> Thanks for your patch! > --- a/Documentation/devicetree/bindings/gnss/u-blox,neo-6m.yaml > +++ b/Documentation/devicetree/bindings/gnss/u-blox,neo-6m.yaml > @@ -41,6 +41,12 @@ properties: > description: > > Backup voltage regulator > > + reset-gpios: > + maxItems: 1 > + description: > > + An optional reset line, with names such as RESET or NRESET. > + If the line is active low it should be flagged with GPIO_ACTIVE_LOW. I think you can drop the description, as it describes only the obvious. Gr{oetje,eeting}s, Geert
On Wed, 12 Jul 2023 13:37:30 +0200, Wolfram Sang wrote: > Needed to enable this chip on a Renesas KingFisher board. Description > copied over from the Mediatek driver which already supports it. > > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> > --- > Documentation/devicetree/bindings/gnss/u-blox,neo-6m.yaml | 7 +++++++ > 1 file changed, 7 insertions(+) > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: Error: Documentation/devicetree/bindings/gnss/u-blox,neo-6m.example.dts:23.40-41 syntax error FATAL ERROR: Unable to parse input tree make[2]: *** [scripts/Makefile.lib:419: Documentation/devicetree/bindings/gnss/u-blox,neo-6m.example.dtb] Error 1 make[2]: *** Waiting for unfinished jobs.... make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1500: dt_binding_check] Error 2 make: *** [Makefile:234: __sub-make] Error 2 doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230712113731.3306-3-wsa+renesas@sang-engineering.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
diff --git a/Documentation/devicetree/bindings/gnss/u-blox,neo-6m.yaml b/Documentation/devicetree/bindings/gnss/u-blox,neo-6m.yaml index 4835a280b3bf..8f6992b97ca6 100644 --- a/Documentation/devicetree/bindings/gnss/u-blox,neo-6m.yaml +++ b/Documentation/devicetree/bindings/gnss/u-blox,neo-6m.yaml @@ -41,6 +41,12 @@ properties: description: > Backup voltage regulator + reset-gpios: + maxItems: 1 + description: > + An optional reset line, with names such as RESET or NRESET. + If the line is active low it should be flagged with GPIO_ACTIVE_LOW. + required: - compatible - vcc-supply @@ -54,5 +60,6 @@ examples: compatible = "u-blox,neo-8"; v-bckp-supply = <&gnss_v_bckp_reg>; vcc-supply = <&gnss_vcc_reg>; + reset-gpios = <&gpio 1 GPIO_ACTIVE_LOW>; }; };