From patchwork Wed Jul 12 09:33:10 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?5p2O5oms6Z+s?= X-Patchwork-Id: 119023 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:a6b2:0:b0:3e4:2afc:c1 with SMTP id c18csp1026905vqm; Wed, 12 Jul 2023 02:39:02 -0700 (PDT) X-Google-Smtp-Source: APBJJlEVqoCF7uPOjlzP0ErKIxFGotNWWBGmtO5O7/KproSuXtUx4slF0thowHE/xITguwF/3Bh2 X-Received: by 2002:a17:902:d50c:b0:1b8:a3e8:51d0 with SMTP id b12-20020a170902d50c00b001b8a3e851d0mr16484948plg.45.1689154741678; Wed, 12 Jul 2023 02:39:01 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1689154741; cv=pass; d=google.com; s=arc-20160816; b=TCwbqIN7yJ4xCeFA1YHpJ+vnIYc4Ax/uvjEWpbc9hFC0Xg5WasZLv5026wLuRvpr92 NHiPtXaug47vXQPBVFY3EiXdlo3crpTQSq9GJHHMaqoLDJxqxu9EV+8/fL990G4dFk/9 0zVCe1sWj4fxcQW0hcGLt0N3pR4VOWcUx1oCUvRbosYqur3I21ud6xANzgTqYIaU60zN OFFvF8ukleW4+fNspiQipf3h0s/kvg2blpkiDBnBkEUxNcAiCzGmxGEFneWwJO5CG4go oDCiSqhzxqHghbVQ5uJLOOMcjKAhZ3laS2irmpDYgW9RQc+IYeVEE73vjeD7RRb9nY81 D2uA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:content-transfer-encoding :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=nRt3nLHXeR3vcguH4NVhTOfBUAWdrygfM+C7TT3dW3g=; fh=XQQmhVsHwAoKsSlla2OxpBknm8DLG5iiAJbmcHBCdII=; b=Bz/m0Oj4xrS6wqI8JIg5ldsU+XR42ba+ort2c+xed5wNzHAiy4TzyTtw/zr6Wg2saK 6aMkvIiEqQYZGPOY4nV/mBO2WcqrI0DF46VD863cDyNzcAwggkhG8lxlQrGdwSPfOp8C PQW/qxPHIpDdyjaSu3PhML9Jc/heAbkzRap0nJe0zAhbLRoLEAgYJCa+/MEdCmAtGFZs gjd0RfyXhbAEDh+XqtWQNGx2BNrC6Vf4UIPdByxGi2JpRpTLJ/b6Mj/e9rnBfcpXEYTo ANIpeWQqbMvwsu0HVy4PmUjdRRZeEEpqZJegbU2E3SxauDA7BKA6od2fJVloMfbpF374 wc+g== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@vivo.com header.s=selector2 header.b=l7nLrNqa; arc=pass (i=1 spf=pass spfdomain=vivo.com dkim=pass dkdomain=vivo.com dmarc=pass fromdomain=vivo.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=vivo.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id jg19-20020a17090326d300b001b9c3daaf1fsi3046553plb.272.2023.07.12.02.38.48; Wed, 12 Jul 2023 02:39:01 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@vivo.com header.s=selector2 header.b=l7nLrNqa; arc=pass (i=1 spf=pass spfdomain=vivo.com dkim=pass dkdomain=vivo.com dmarc=pass fromdomain=vivo.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=vivo.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231846AbjGLJeQ (ORCPT + 99 others); Wed, 12 Jul 2023 05:34:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47748 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233184AbjGLJdu (ORCPT ); Wed, 12 Jul 2023 05:33:50 -0400 Received: from APC01-TYZ-obe.outbound.protection.outlook.com (mail-tyzapc01on2131.outbound.protection.outlook.com [40.107.117.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0930410CF; Wed, 12 Jul 2023 02:33:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=depkaKMFq/ZYClKftGSMklGQmcws6Uginx0YiEKWSqvE5ZBoNDUNTdPtpj8IKF8oeOVBAPKW10ZcQyAZKlolAcHBASOcdc/vGpxMzjSgwPcp78qG9//rfdGYbhxKME2RmTia3gf35TPVF4nXhiPXLOtwWCTr8NYn2vgNjPfv2KbgHn6hnn7EPkkvvXqUXz7HIgfNQ53WkW6MlHPWC3Zdq/cAPOuXA/aqiQvnbYYjodwvcygAM9zHtiXsMosF05BbOvjyxIKGCyuzUFYeJe7yLSL4WRFSdbYVMqOqRiTWmSQB++VoxKjUn5/TRgkEjg9ufhrA7QUTrXXpZ7QJO+Ccdg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nRt3nLHXeR3vcguH4NVhTOfBUAWdrygfM+C7TT3dW3g=; b=AXCXXfWd7bz2B/AhvJ9L7hNkaBlmyFXdKSGT2LmSgGjOUmeAKVsf54N/q4trcwJeBSUzFn5JB/B5Z6cy0gpgpV8C8a51B3Zcyfh1N+BTo3t0vmIqwhCI/MxWz93Y+bxGLABOZ5bcuFqv4920KAXJvFlxmiGRawKMm1iYmM+DG3Ta+1/lxqG4najnZneOEXMWo0BcGEKq6VUqW/12I9rUbcfCeNGtlFHU57RiVLxJ8Vw/K1pdm3XHhVgSyFI0HrsUmsn3Iqw0atNyE36ilvIqqMfqH7gmDdtMKkexA8Q1RK8fbPHZrYqD4L1z+VFAO0vdBD6VLXsZ4ZaTMaDGqDkqvQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nRt3nLHXeR3vcguH4NVhTOfBUAWdrygfM+C7TT3dW3g=; b=l7nLrNqatsnEOb1KtvCreFhSaJ7CFkujIoShDwXQuYzenSYRMvoTRRVFZhvotouuP9vxePG0Q2jSkgZUPY/fDW1XzwZz+uBHsU0vIwvb2yyNQSRJf9VhlfdAhqntBpn7TyYQYkpBEcgjw+GSohpUHHe7r82x+RI8JK0pGGIbgX1SR8M5q77UM2CpEq0Wf6of/Y8v3JKaKhbQLtSjzYECQK+sc2FC/OB4JUeis/uKfH8452PUI5MUB92SpScjVsAjixC1oji0ltN9hr8I8ia2709wpyx4yoBS9b/NoLgPyf8MKyHqpWmoV/yBpFvrJyg0CQ/zNgBn1yLLOZSTyvYTZA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) by SEYPR06MB5985.apcprd06.prod.outlook.com (2603:1096:101:de::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6588.20; Wed, 12 Jul 2023 09:33:45 +0000 Received: from SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::fa0e:6c06:7474:285c]) by SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::fa0e:6c06:7474:285c%5]) with mapi id 15.20.6565.028; Wed, 12 Jul 2023 09:33:45 +0000 From: Yangtao Li To: Sudeep Holla , Cristian Marussi , "Rafael J. Wysocki" , Viresh Kumar Cc: Yangtao Li , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 07/19] cpufreq: scpi: Convert to platform remove callback returning void Date: Wed, 12 Jul 2023 17:33:10 +0800 Message-Id: <20230712093322.37322-7-frank.li@vivo.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230712093322.37322-1-frank.li@vivo.com> References: <20230712093322.37322-1-frank.li@vivo.com> X-ClientProxiedBy: SG2PR01CA0172.apcprd01.prod.exchangelabs.com (2603:1096:4:28::28) To SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5269:EE_|SEYPR06MB5985:EE_ X-MS-Office365-Filtering-Correlation-Id: e2e4a9b8-274d-4bb3-026a-08db82bb16da X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: nHgV++bOtf7FZba5r+S0Ac9cQB9nN9T4QYcSlNkXLjtuSQfXuuJzpqMa1OJENACINKPZjEPlq0k8Ls2DuijtrAvrs7qE9uixsOsjAiWvjO0FNChGqIv0UCJShJNsc8PAVdeqOv5zK3lWjqW0YKX4y4s+LyFSHt3yC+eClM/fLhFSiVTfu95TVMEHUxqoKyyI//0QSZ5PzzH1fa3FAK2J+dAMmHi+pKVoMF84AaUoZoncVtrwmS5bruteRe3Grde1pAZYcqdKlYnZHsibOcx466itlH0+ulYkGNP2VZletDHyCR1SrjrBJ439vPI6QozakuM4PZax6pgI9kf6XWqBZfDIoSz+rxZGQ085xKYFTAdqPSDn2v/x6IKHxZDVWl0cRxtWkMlwElcKBG+Tnp5w4TnF9v+s5Ko6LfUTxl8znItBYSIAi7PK8xz9jNetkh5KsRUQzOYw+wVQZuYYq+uucZXuNCtrp3nQ3yxC67ZjrfoGXKCwJpPw+GoKa1LHvrz4m5GoN8XjRibQox0Cqkbdm3q+hlUV3PneT6uziRszhPtP7YlJyuTWvJKQWHE5LDevuG1GwUha6c7GamYPRRO2iT/YsRJdhpv3FjEAfiyxmBaYXVaGbfZAmMo8RKcM12cL X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SEZPR06MB5269.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(396003)(346002)(366004)(376002)(39860400002)(136003)(451199021)(186003)(2616005)(110136005)(54906003)(38350700002)(38100700002)(5660300002)(8936002)(52116002)(6666004)(6486002)(86362001)(8676002)(478600001)(316002)(41300700001)(2906002)(4326008)(66476007)(66556008)(66946007)(6506007)(83380400001)(26005)(1076003)(6512007)(36756003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?/R42d8jPsemMW5kXQ6SQCcU0w+Zi?= =?utf-8?q?y5/Cqs9zSq3r4a1wFl59w7vOoRAaZ38lcGnFpR/QNXdVrMvxDZZT6VHob31bBdael?= =?utf-8?q?nF0F2urJoI2BjKrxacBuwWOGfNhpKBDFv58bHSbC1yE8JRkuNq2cuwS98fTggqqFb?= =?utf-8?q?x5ZruOaz9tfCnu0k7lUmpMs2F0EpOExc0jEHTZgHMgrenxVRiUDilMiK4uj2x0JbU?= =?utf-8?q?0yCCuE3UuXT+umxSGzCVEZjox1KzMlxShQHY5Skaa4epqbgtLP4Q5ZMTtrIgIOx6F?= =?utf-8?q?IpsVYhcPcbct8D2yrc+A1rIi4fHRCxJQnYhXaXrfs9OZeqhx0uv3eFojkixG5pCHe?= =?utf-8?q?KB/jPoi0SzSmUUSYWE9gLzzjiXpfXui/gvisDK7HMfjpEctBHhZBqIovEcCu6W0tY?= =?utf-8?q?gxlRo5QqS+xfB/Mb8YrjzJ1FP9aJfmvgW6779VWlPV1eziTLvwaztAdGwqQiNT7p5?= =?utf-8?q?6CvMv/DkL4Q3hrIT5LjKCqtMQRcGJqYLJsCx1Yso6IImNnKjjDBeKXpCU2G3OZfxB?= =?utf-8?q?Ank8GjSeSyVQZBL2b1EWpQQfxqLAqtfiApzKeVdgRvXgajpnpo6dz9MJ7HadrOF76?= =?utf-8?q?fsmMIU0NKUcsrGnAHhTRtfO075TdZ7fmBml5jpvNOZd23KtwrLGvVoUq1luD6eier?= =?utf-8?q?EmrWVsUuIS/l2EEb60TwoshEwLCFbUutQWbcLJ1ocucsoFs6/vjfVazveVOkUM13J?= =?utf-8?q?/dsQWo278EcGKS5GVm0KAVz3kBe3+j2F893mTg8/0ibwnmUb3vBNvVnNPZDN66kuE?= =?utf-8?q?HVfDGmCmPVPeSwtPnkQCWTsRTpp+EoFv6eO6GdcMIXsnnkYrdFGfyobk7rrkXbZ8w?= =?utf-8?q?sGR/7nyiXT0/qvTM1O2BU6BS3dC4iWRSIVejhOqKOBMn+kHYT/ykmaFGFWVeBUUV6?= =?utf-8?q?UE34mkhek/cK3i5B0JcgqXAFDYSxt/GwcnRP3sHmexSP+zSPjwC/WfeeM6oeopT/u?= =?utf-8?q?Uqzbm9nkwJRb//75PPIS2wSnh4I9YLImyFxdHs1FEyGVRl0GV5A+q3cTk24cffq8p?= =?utf-8?q?Hw1/AeSjQ0lrDfCykVIxXd1o3Wvdl6ragjRz/ZAF3131YFut+bsNIjSRWruEt9NN/?= =?utf-8?q?kf1aebR57sL7aLWBhRcT8e1lN8EMcScrkPRwfAYtVPUe1l2+bgXLEvLXV8QiMxLRb?= =?utf-8?q?3izXl1PMpU6CN9xqXliDc1lweDbIHepj2dDyNZXEajlvfRAcT0YVWbqsP6DmVMUfh?= =?utf-8?q?GSW0JbfSuZ0bCgcQyrv6Bf71gNfpd5duxjHr8+0rPDbVYYziD3g6j/tjs229+1js8?= =?utf-8?q?t84Z6SxJe++KMPY/aeQTz8cWJ0wv0LGKIsjSTO+IYyBht6Y1gQeguGkB4A2FKnvQk?= =?utf-8?q?EMdD+x3JwZrYH+bDqvaUr1iN1EscZFVZzIBrUaEHYihoLdx+BUiXtZcWraxg0rOo/?= =?utf-8?q?7yDkvBzmAVmQ4NQOhD4AnaaVg+WJEAMsqPLBZHZQNu6iZIPazURFzFyU9rVMceUoU?= =?utf-8?q?g3uB2MaNFHGkSjg/6l4qfN/g8fr4QlliS5oR3uNFM0btU/hQOOjqJNSrwS36/hN0j?= =?utf-8?q?ExNY7thXLIyL?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: e2e4a9b8-274d-4bb3-026a-08db82bb16da X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jul 2023 09:33:45.8510 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: n21UeX8ZKWQJQBCkAU2QP8S0ikswoNqlMDzYayv6x82ywOLMe57LLUwgadrb/joAhiMoU8pkePJDFByE/ce/Ow== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SEYPR06MB5985 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1771207122442292498 X-GMAIL-MSGID: 1771207122442292498 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Cc: Uwe Kleine-König Signed-off-by: Yangtao Li Reviewed-by: Sudeep Holla --- drivers/cpufreq/scpi-cpufreq.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/cpufreq/scpi-cpufreq.c b/drivers/cpufreq/scpi-cpufreq.c index fd2c16821d54..28f1e0490af1 100644 --- a/drivers/cpufreq/scpi-cpufreq.c +++ b/drivers/cpufreq/scpi-cpufreq.c @@ -208,11 +208,10 @@ static int scpi_cpufreq_probe(struct platform_device *pdev) return ret; } -static int scpi_cpufreq_remove(struct platform_device *pdev) +static void scpi_cpufreq_remove(struct platform_device *pdev) { cpufreq_unregister_driver(&scpi_cpufreq_driver); scpi_ops = NULL; - return 0; } static struct platform_driver scpi_cpufreq_platdrv = { @@ -220,7 +219,7 @@ static struct platform_driver scpi_cpufreq_platdrv = { .name = "scpi-cpufreq", }, .probe = scpi_cpufreq_probe, - .remove = scpi_cpufreq_remove, + .remove_new = scpi_cpufreq_remove, }; module_platform_driver(scpi_cpufreq_platdrv);