From patchwork Wed Jul 12 08:12:57 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?5p2O5oms6Z+s?= X-Patchwork-Id: 118935 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:a6b2:0:b0:3e4:2afc:c1 with SMTP id c18csp996104vqm; Wed, 12 Jul 2023 01:28:55 -0700 (PDT) X-Google-Smtp-Source: APBJJlGkAPMTdqDRMKp2O3BCyzH7w1c3ZwJCd7XsQU2G0uWRFMMuSWegPfZt/AMsryZLepcCewi/ X-Received: by 2002:a17:906:3f4e:b0:98e:2334:af12 with SMTP id f14-20020a1709063f4e00b0098e2334af12mr18411671ejj.45.1689150535462; Wed, 12 Jul 2023 01:28:55 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1689150535; cv=pass; d=google.com; s=arc-20160816; b=F2RHobgzSf5CH8LfVEy40HzJyzF8PMw7OzHTRIYqYeS+j8pU0RpqOv77ajiyctKO70 h61S+uEi7CGq+SnT8yVFLvwx0pjGrnBy9wvjQ0ULJraPuEPTrro0CEf1E+tolmd5uk/m fcYtjPyzlGf9pWt1OtkhwNLq2OtuAVmOfYudcfeGTpOX9uqOQIBuXJtyR7Wn2Kx/ev2s xShN5UPHH/scw8TXqcFL/6JnA8c6FHyvXLnuIqyPPBT5owzEeyY0xh3zJPIYWt1aoecp KPXHc7ElFqU99aXT3E+JHf/zk0UjvpfXH0QarZOK/XQ3orI+4Wdnt65BSKUyM+MvWUwb DnCw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:content-transfer-encoding :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=vkE8UIAMl81x4IEXLUNUoD00xlsLnumBQtjcFmK62/A=; fh=gF2itGWmtUVqnmzOcHFVFNxYnJ9SOivG91RfrScPkYQ=; b=QMu68pQ6Uc5maZh/eypkhHR8S78BXeNnAM1npOfj3RRj5s71VzQ32B5U2Z1ZJ4JOxj 3HCG9lWUHg+yPYOSpeIFbGiaiWbukZPEVVtRBfsWSsrCD1NU+TH4MBYdHmJmJNzdM/F7 fzmG23BH9Y3jImLbb8wFZTXe7mSmG9VI1hmlntoE/pcFNViI6L2pW02YZwiUNv3pveGk T2FWQGYQIZFrPt25qxMwAIwOqMnzeqtVsvZoZ0x3WACjm2mOp5fNG/U9aOWy2wLDGRnq 3C/QwhtxZjsK8xvshDUn8aoIfBWVtbbos2TMg6bsNFs6TI99C2AAGkwqPcB3Fg+795+s BflQ== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@vivo.com header.s=selector2 header.b=duSF143y; arc=pass (i=1 spf=pass spfdomain=vivo.com dkim=pass dkdomain=vivo.com dmarc=pass fromdomain=vivo.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=vivo.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ca25-20020a170906a3d900b00991dfb5dfb7si4003117ejb.573.2023.07.12.01.28.32; Wed, 12 Jul 2023 01:28:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@vivo.com header.s=selector2 header.b=duSF143y; arc=pass (i=1 spf=pass spfdomain=vivo.com dkim=pass dkdomain=vivo.com dmarc=pass fromdomain=vivo.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=vivo.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232375AbjGLIRk (ORCPT + 99 others); Wed, 12 Jul 2023 04:17:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46610 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232364AbjGLIQ4 (ORCPT ); Wed, 12 Jul 2023 04:16:56 -0400 Received: from APC01-SG2-obe.outbound.protection.outlook.com (mail-sgaapc01on2136.outbound.protection.outlook.com [40.107.215.136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5AD721FD7; Wed, 12 Jul 2023 01:15:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MyC1QjD0hcqSk+v2ervN8vezHNPx+DU0rKNj7S/K/tCs8OqxwfzeP9YXZQ/bwFn+ZwW2+Ketwesf8GUqm4rMcimXo4O4j2W3VMJVRaJn/Wy8yiRMVNr5qo1cts6iXm7XkyWjhIiIvmGyAedEi1Ywx9LtStPXiAPttBepbN/6ERYec4xElvR2v1C2Nb4GvviBtneku6KkHpmKd1Huf0jn5s8iIKkZ+FmU4eKo6QebdEaC8ua9h0y0tI3K7koS/3syObbkTy8Nd0D1s6bmB5OA1i+xFxrvQ/RPzz4RtlY2z+24HVxSXnBFa+KUywNVYOKq9k65QGa1G1bQDRl9xHjOYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vkE8UIAMl81x4IEXLUNUoD00xlsLnumBQtjcFmK62/A=; b=FtxARiCNw7GgPdba1Tc7LCxr9o0gSsgcHUMQN9uCXS8vdq7FzZis6gMAu3smg8TaBlsGFakvPvhm3FbR43UPbJ6wylinpEGJT12FxuM0PBm7c1YbJTxPZjcJZVxXhR20vO2xkdqe2bCYqSkQC2NM+aOZGqLQsoBNJ/yrAJtmIh5rEKH5xmZY4B84xAcae0gcUY5MgQXdz9ukuJikqYsP+196UpIvCYKJIjOtyrVmbCqGvOBqY1l3O5aYH6sqfysu488bp1ouBgSnt9gCc0il7v1iP+JDxgNQm9M+F+U0wg/khUqCpHV5NInAns+/TcSYqDsIYslJN6QkjGTLrr8NUQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vkE8UIAMl81x4IEXLUNUoD00xlsLnumBQtjcFmK62/A=; b=duSF143yZnR2YoqVBwPV3YDEaag7BWm9aB2TjwVHfhlCXiFIt2VymumHAhj7H/JGXV+oLeD1vN4KDjqV/rn8BULX/yinz/+vTTLNWDJCUgHEiMcRTEH3P91/oIFPo2qB6zQnwtO7/mAE4u5RBltVm/YTCwcPBebhyN8n1rtfEKocY3QIvTnkFavIC3JyAUCxfdv7YbZcMkOCDZ4DZDer/t/X+FXYp8neyRkSb9ge1UAmBtCSrWv5EwFpygzU9D2pA+T52kggRfg8XFFM8bhQMJWoYVmdqy+eygLQJYOD7Ub6+cxYo7tCsT7P1yGKweiKNoAhi+cKYl+xF3r2rN0iTg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) by TYZPR06MB5027.apcprd06.prod.outlook.com (2603:1096:400:1c9::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6588.20; Wed, 12 Jul 2023 08:14:40 +0000 Received: from SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::fa0e:6c06:7474:285c]) by SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::fa0e:6c06:7474:285c%5]) with mapi id 15.20.6565.028; Wed, 12 Jul 2023 08:14:40 +0000 From: Yangtao Li To: "Rafael J. Wysocki" , Daniel Lezcano , Amit Kucheria , Zhang Rui Cc: Yangtao Li , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 26/27] thermal/drivers/kirkwood: Convert to platform remove callback returning void Date: Wed, 12 Jul 2023 16:12:57 +0800 Message-Id: <20230712081258.29254-26-frank.li@vivo.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230712081258.29254-1-frank.li@vivo.com> References: <20230712081258.29254-1-frank.li@vivo.com> X-ClientProxiedBy: SG2PR04CA0208.apcprd04.prod.outlook.com (2603:1096:4:187::10) To SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5269:EE_|TYZPR06MB5027:EE_ X-MS-Office365-Filtering-Correlation-Id: 54a29f5c-bc1e-4786-8fbf-08db82b00a79 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: EG7FypUVyLIRFKds2RAt3uwkrGAMkIM4d9QQ6Wo+/wutVWOCU1wDHhumCmuyZ4z05dU68J2Fl243DZgtIGjjBKzywh7QgchAtDx5VsFg4QGKVFK+ZHf9xFmdkrBhQWr9tunN9x2oK+M3ILVE7pB0uYC0B1M3r0KTbBjIELQ53eCBGCJks+Req2UZtMnCdvMLEqBnVTyr/e/kOWt0LrtFSC1me6Fp5z+PmP/NAUKr7ZD9xuB4jDgqcrhjrExFZJJCAnvCaqwoc4j31iIccyvJ+rsIVutE3gOUWN06yyUjyc4bycy63muutPCH5YdQuy/Nm6HxW+tHIapqsfxj7TUEQ+PMK72k0HyshxrzkllO93aYrbG9nu7fHd2RfbSORlExdKev0+KEQFDv0JP/xe2Fq1czYOyJ2+Xm3L4DfygMGzZj52jZZ7WeO15VTC1NKmhXYKL3yrPML2DJDoSHo2q6wyffidseqkX2fm5U/lzD09oPzuacaOpxaCyE7sFZlr8stimCS9fJ7vwxxM2AegCbLiLJ4EMc4p2sX07r0bus5sN1WYPlGgxickzR0CtLkPYF8pjlCvG/sl9Mf7NNmQGghhvMNf8TL6tNSvQpk97BVggjVvi14S+JFB0jBTlazkaD X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SEZPR06MB5269.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(396003)(39850400004)(366004)(376002)(136003)(346002)(451199021)(66556008)(66946007)(66476007)(4326008)(478600001)(36756003)(110136005)(54906003)(86362001)(26005)(186003)(1076003)(6506007)(6666004)(6512007)(6486002)(52116002)(83380400001)(38350700002)(38100700002)(2616005)(41300700001)(8676002)(8936002)(5660300002)(316002)(2906002);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?abvB67cfGfYkUo6/ENS+NkUlZgJH?= =?utf-8?q?tNz4IWxrr+bEFkw94hMeDfHZU9jZ5+0X9hgh4LdDvAu3xfBnOFPnIP8HmOxeqrl+a?= =?utf-8?q?xk/30kjoygnGYSsCQqKCpm+EhylF49aNCwB+vSEEuzlDuVprS4VAr342ESmWqkbrB?= =?utf-8?q?RouEFX1f9d/owrvruONgg/AV70xaHrBaPI5iRT15CgDZLZLoSnXTgyTZlivGH3+HJ?= =?utf-8?q?KN+46Vur5f98eHPs71SgBHpJXT2JaRVfC8u5PPixaomVCDHnIzD61ikRz1U4HJWDf?= =?utf-8?q?1lvsOFHdCGcS4HflK2/qUEddsK9RtITltwYYjnIDcDwMBgaQWum0Ff5x84jD32pIQ?= =?utf-8?q?HyKo9IllCaZALnpLBFyMhp0xtNjbTN9Zzg2pSPW25a7S5u6W7l7wgW4W10tWUBTV2?= =?utf-8?q?SPJEINtiaUvP9vzyJLGxaaYUBCjzJ6U5in2w5TgBrEcyhKVatVocjT6QZJJZ22BIZ?= =?utf-8?q?LkSo+dPmjTVonZmr9q7I3EFoJYV6b6wChohCqxBIQexLHpa0tRwsJboEGEFtiqiAw?= =?utf-8?q?52a4VYSbdyOK32BVENQlMCjdcpurSVpf7o/rLqfG0e04D308prpjcxIB5GSmRXEBy?= =?utf-8?q?r615rF17NnAwpV8ZFFj03XkyImFcu1J4um2l4+ZRTyhaoAyhPazQDpaMkgdpyv31i?= =?utf-8?q?/pNiaSOcI3M24wTZdUNVZ/mCCYQ5nABby71gjQXZtpI5ROsJ0mgc3mwmuxSOzRYVH?= =?utf-8?q?TQPEChV4xBiOsgTuWlyQdbw6YUu6igHZjUq0goRoW49P1oPmBwYtCBY4FgH7fz1iJ?= =?utf-8?q?oCkeHvPEfirj/+19Tcq44nCGrLLCrSwQSXb3Fin5zB2XWNAOE6p7PSuOug8/R8nLQ?= =?utf-8?q?NSifT3QIw4b/lYYQLdaUraP3gZ/Z9f1pQOwSZNfzvB+pArmXVqW6JuoYEV9WNUEOf?= =?utf-8?q?Z/4inLrYtKsTi6kyZQ69uKNjOigIocHpjAU9AlUyx5ZHwyyHdAtJGgPGGsNBa7TbL?= =?utf-8?q?eANMi1+96jOe44uYbUrdnhsnPZMzqcKjkmD4yJZ776eYSEYVItx95zv3VnOMoh81j?= =?utf-8?q?r5dXN5TH5YoOZ0T8taR4PolUbf8R3ZZFc8TLs82T6Ca+BmhXgxNKUffkd8UAMNOyb?= =?utf-8?q?aNRXY/jMs0s0l6TtXEkDSUFFlKk+tMxvD13Zv0AWE8gLKNdC6fr5PwrA0oLnHkMgi?= =?utf-8?q?xAq/hTbpUdr44TEnYX0mLwpLuwsfbfj/klndnkrNulwm84hhPIC4quYMZ+G8Ybduh?= =?utf-8?q?He+ymNlUUPVA4uid4kBFq4I97ZzDvjkv6IcnFLsEon9CyzyDHl4hVDCO4NdvIrbmG?= =?utf-8?q?CebAKfgeZJZVMXtK1+RacWpJIQ6Ghva7qtL2ppn29YdDxY7NDWpgtpoVfXCIedJBT?= =?utf-8?q?ZjF47n89m/YsHHWyi9lQdgkA4eP5d44sSaFMkh101mZAwkOVx+zj82F6JlN3nr+/k?= =?utf-8?q?FDUyk6YOxSAzv+IIIoCe352jRfxX+PdU109bO+0E35r942vC40TLt3XfC0xLpDoV+?= =?utf-8?q?VPGEsuQEwLgUIe+Ol2m6jWuZdTx0vENxjTur8uaExMkO8oxY72j8qr9lFgIDs5y3j?= =?utf-8?q?WmVpw+Oni6N/?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 54a29f5c-bc1e-4786-8fbf-08db82b00a79 X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jul 2023 08:14:40.6021 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: veqoWnYkAB38GEB8w33CGmsJ1CwnHLpBKYyczsxkysyx8Lzm526fUo6e9zOovYGwD4YZV0Yrr2SF/vyumc1dfA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYZPR06MB5027 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1771202711623670580 X-GMAIL-MSGID: 1771202711623670580 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Cc: Uwe Kleine-König Signed-off-by: Yangtao Li --- drivers/thermal/kirkwood_thermal.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/thermal/kirkwood_thermal.c b/drivers/thermal/kirkwood_thermal.c index 668747bd86ef..94c95870f277 100644 --- a/drivers/thermal/kirkwood_thermal.c +++ b/drivers/thermal/kirkwood_thermal.c @@ -90,21 +90,19 @@ static int kirkwood_thermal_probe(struct platform_device *pdev) return 0; } -static int kirkwood_thermal_exit(struct platform_device *pdev) +static void kirkwood_thermal_exit(struct platform_device *pdev) { struct thermal_zone_device *kirkwood_thermal = platform_get_drvdata(pdev); thermal_zone_device_unregister(kirkwood_thermal); - - return 0; } MODULE_DEVICE_TABLE(of, kirkwood_thermal_id_table); static struct platform_driver kirkwood_thermal_driver = { .probe = kirkwood_thermal_probe, - .remove = kirkwood_thermal_exit, + .remove_new = kirkwood_thermal_exit, .driver = { .name = "kirkwood_thermal", .of_match_table = kirkwood_thermal_id_table,