From patchwork Wed Jul 12 08:12:53 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?5p2O5oms6Z+s?= X-Patchwork-Id: 118929 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:a6b2:0:b0:3e4:2afc:c1 with SMTP id c18csp995083vqm; Wed, 12 Jul 2023 01:26:24 -0700 (PDT) X-Google-Smtp-Source: APBJJlGPAZHJGyvFFZ7hXak5p2yM/B4rcIfEgiz+oQwjV5tL5xEdVAhjGxfhROSJrS0nVVgok9MH X-Received: by 2002:a05:6402:1b0b:b0:51d:a6e3:81f4 with SMTP id by11-20020a0564021b0b00b0051da6e381f4mr16222052edb.10.1689150383873; Wed, 12 Jul 2023 01:26:23 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1689150383; cv=pass; d=google.com; s=arc-20160816; b=ZzhTK6Hldaew2gkTXz7F2M2cwEDfC4IqBiS9IcnGIqLziGVvVz0ZcsykGwz8Bdm+nE aF8fFo84UKslpK76nczM7mMm02WRe927X/C4LySgDWZc3pLB9veaiLxJNQOp8d689GIR 8iRBbeO5SCMLM+H1hkYB/REcwb2Ao2kF7d3+1V+2iDryZVCjNObZ9j/a5Q8/zwksuTT3 DK3CSCn+t08ZE8utgiaMxJ6vaDpBK/5+k+mE9R5rgsWWYWOC7c9hCF3fOM4lT1Llyp6+ quz+HAySpyLLtJp+QARJCwB2qNhYZa05ezUmMVQ2JMrixkPvbzLhJV8BWxBzleQHvA93 QTXw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:content-transfer-encoding :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=fhP46AB2RhUS6oqayVfe/eF0wD+5UJFy3MIxYFrPY9U=; fh=q7JVi1xs7j0f7NcmZgJvA4ABs/GXnqbkDUJRSTFfDBI=; b=O5GP0dEXjHva2+SGiHW8XXrCDuOibdUuMoClc6lDF/Pf1mrDXxRUZswQQeQjE/tZQT nyDfrCLrl24y4NO25sbb/PKAFDjIvWbE/I//3FHhyNopJmzlECy2vyKEZlyjyQj2UX7O Tg7RNGF1GSv1HA6LKUDD5169VvwT63k+GMe4hHr/gRx0EfoxFsmIbquounM1TCCbdOEg 3jeWU4imwOJUMseVRAVcfBJZ8zKcuW7w/KblMAy6pWNxnWUFynByCp+WYgh684823UfQ FntSKEBn/3YyM9ibzYljWdkoR3CAlULXSZZFIRcZXPOCMxeL18+EycEDbm0v1BCUUP33 e14g== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@vivo.com header.s=selector2 header.b=LRGitOod; arc=pass (i=1 spf=pass spfdomain=vivo.com dkim=pass dkdomain=vivo.com dmarc=pass fromdomain=vivo.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=vivo.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i4-20020aa7c704000000b0051e186a6fadsi4110149edq.227.2023.07.12.01.26.01; Wed, 12 Jul 2023 01:26:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@vivo.com header.s=selector2 header.b=LRGitOod; arc=pass (i=1 spf=pass spfdomain=vivo.com dkim=pass dkdomain=vivo.com dmarc=pass fromdomain=vivo.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=vivo.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231765AbjGLITX (ORCPT + 99 others); Wed, 12 Jul 2023 04:19:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46252 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231678AbjGLISb (ORCPT ); Wed, 12 Jul 2023 04:18:31 -0400 Received: from APC01-SG2-obe.outbound.protection.outlook.com (mail-sgaapc01on2137.outbound.protection.outlook.com [40.107.215.137]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D2C522D7E; Wed, 12 Jul 2023 01:16:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ScbyEyyZkmp53JTPqryXo2DgaI2X0Cqwv5No2+q1MZ2lDWSk2Kagu2ktFt/AcCskW3ipbHh37zthEiC3aP9aXkrwu44DdE4ZwwU5QfTxCtWITllY62R5fAGFBIxw+2RZJiU92Xgs6BOfLZkYVjsJZLZycTWaj7syBib72mwex6t7r0e3wUdOKg2ZlEQH4nkud+FP7P7XpK4Lxwc7TniTxRLdokRsO9Q/OdV6zYCC1cx6BZO7/7B0rOQNehIsdjTm2jSsX1w0KZDmtjos9sl3l2mVI1SC/6WJ7teJbUxjxZfNASDqSpznqUmjZMqAj8XKtCZyI3IcXrj4d7RueXvd0Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fhP46AB2RhUS6oqayVfe/eF0wD+5UJFy3MIxYFrPY9U=; b=FRdSIu1EjWAJZVERld1UXVVhPfBCyDG89Cq6Xds2I3n/zf7miK/tSfrfha2Qb+9Qz5UdYdR/gKoxfkDmzpBzacDFihTm7SXR1Pm/hQ/qmBm3Gx1CqQ4Di9T/yKCk9aW2Ib2aAmf9olVQJUBF5BxWP/USiaxOHoxm15XV3y5j0PcCMWFzr11y+guG/ZNCHwqtByQANI+irJdCL+U3Mo0WqBO4HPL2FXUaNZN4GmYFABABbcV7cLrAxtPBUCQ2/nhJ5DpuQNYy0iKuF/sdUJG84yye8u/R2l/1CUt27VmvCPzSFnVLzByuagPpiF2FlBLzP900xfgYTQk+rt3Xl43KgA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fhP46AB2RhUS6oqayVfe/eF0wD+5UJFy3MIxYFrPY9U=; b=LRGitOodRjNR3NiZ+0usCFk7tB5x4aLA31VYtRdW/yTh5ICrdjBQJw4SpjyT8e0Hr2TBxYN4OGqMq9dBpiySlK8DpInCZUMuYEr4fPGOh+DLk0+fYhAnVdsTbGT8p5DM0m0Vbl+v9urmQd7z33Dg9/GuzIsbv+Hz7O0Mu2de2CCEjJdeHo9XVpNw7SFxGiTWxDRqs2FQnRA7svA4o6JMMiQU1cVlz8PD3FdZ+fMH08s98Pmy0CP/7WXXsN9+cFDAek2G59n8zku8bIr5teV6xgeAaNI6dMtnAE7q/kpCqkUHuJGozz0w1qpmWHeVuSvaKgqg2CzlRaBLc+5lmKqY+w== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) by SEYPR06MB6524.apcprd06.prod.outlook.com (2603:1096:101:171::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6565.32; Wed, 12 Jul 2023 08:14:31 +0000 Received: from SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::fa0e:6c06:7474:285c]) by SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::fa0e:6c06:7474:285c%5]) with mapi id 15.20.6565.028; Wed, 12 Jul 2023 08:14:31 +0000 From: Yangtao Li To: Eduardo Valentin , Keerthy , "Rafael J. Wysocki" , Daniel Lezcano , Amit Kucheria , Zhang Rui Cc: Yangtao Li , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , linux-pm@vger.kernel.org, linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 22/27] thermal/ti-soc-thermal: Convert to platform remove callback returning void Date: Wed, 12 Jul 2023 16:12:53 +0800 Message-Id: <20230712081258.29254-22-frank.li@vivo.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230712081258.29254-1-frank.li@vivo.com> References: <20230712081258.29254-1-frank.li@vivo.com> X-ClientProxiedBy: SG2PR04CA0208.apcprd04.prod.outlook.com (2603:1096:4:187::10) To SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5269:EE_|SEYPR06MB6524:EE_ X-MS-Office365-Filtering-Correlation-Id: 937f8d88-d09c-401a-fc12-08db82b00531 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: GMxUaieA4cUpoatiAQ+KBaUqiS3RKnwvbpkAHuLPqin/lI0g3hNDulvFWQMOENZXpgSy80dD9hI7Xsfa9HLsIQ8WG4uLOUC4Lb3jC0l0X2p3clBZ/ls3ZXvslIB2a0Z/Fs2c2qBcr9cXOBgFW+0TPIMySRYNUFbdxR5LFNjSe7/BuiX/BxksErU3amak1bfWj1VQ8rDr1McFTGDZiPVmURNVdLbb8EpZS9jDCBE3Lh8zjCjEsCFVKD/ajSuT4r7EDFeWnmT+R/GKjXpoPJyTLQXMxMYmNcV3l5mBKwGb4H5k6P7Hd4xWa0vHEplSJIe/6HY+hhwBwg+OAFmppiDSXyNq44E5t9cvegC9Nr0lsnmT6HYj2v/xlsbXI+J3q3FTi7tiQO+uIcXFpWi567AP/2wZRLiyfPeAHpKkKGtB5vH1regwTb/ZRuKEMDd7/WCVSYycaRXtNzFJs1UAt+w/nplQZp3uAl05bg7uRc/L4HRPgbdZgQon2L0/JTgd139/Sc9tLCeRPYqSrWfdj7mYJnPa0i38fDwvTtVrQqDzE0DdjZHXLbgrjVzIcD1laxf+R6dEx6z3rakA9HefCpgZ7fTgzYOO+yPjA0WODdVKIcsCoZcEeUVcKchFDXkOI+sp X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SEZPR06MB5269.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(376002)(346002)(366004)(136003)(39860400002)(396003)(451199021)(8676002)(8936002)(5660300002)(186003)(2616005)(83380400001)(7416002)(6506007)(26005)(86362001)(41300700001)(1076003)(6666004)(6486002)(52116002)(316002)(6512007)(66476007)(36756003)(2906002)(66946007)(66556008)(54906003)(478600001)(110136005)(4326008)(38100700002)(38350700002);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?eL8RNie9iicM+ZNI6WCiIAgBkpnW?= =?utf-8?q?S2Mn1yFtCVr/L9rmH1p/rViij4WegXmHaGr/rOIpIVD3qO4D63eE30pK7X9zT8wFi?= =?utf-8?q?WgIyX4RG19nAAlT9A3MmJiiI/ydTBFiFrHqe8QZsrzza4Zt7HRUEmzag8dhEfDD0a?= =?utf-8?q?Q7tNBTGmc1+LSld7HNeo/Z8bNrsus1qhB1je9mTU5iGECP0t1RMhKJQBRmIpVpN7K?= =?utf-8?q?iVpgr1A8LxIqz20zJ00YoDWe0Lzt7Y0dLy8Zrn6vF9fwlDDVdVsSf0N6ToYZbNlg5?= =?utf-8?q?gnNl10USb7a7D8ZqosBm8JyW840z4SbTk5RT8sn7SpNQjzMR7LV13AvY3A6XYHGCR?= =?utf-8?q?JetVwoQNUl3KDtqDsQLUDt/bMOg1k9GKMj3hz2YtxW0KJ0Or32M0baLPcIiGMPzZC?= =?utf-8?q?2E+wcqIcGAsIeta1GscqE2n/v4IYcSuCr40nEbLSVNF5b6gCowsgy5X+TVn1o2aTl?= =?utf-8?q?U+x+EPBkNG/ugdV8Xb7jrRZTtdid42n9IBBZNOyL+OcmEO4dbUFBgzTxjkuF3/NAF?= =?utf-8?q?VVeU2tHA4luzthspP44pi3rGLUN7KsQeUGsprq1VtR6OiFs42CLWoXvIzXZhp5g1o?= =?utf-8?q?4ayEzcwKyeyu4AR5l09riYyY0YFD5dQSU6uzc9JV8Zm5QbOg1VTxJOajDwe64VwcM?= =?utf-8?q?UtfO8x2UaEn7CMz953WdAfLsefrhJc0d4p3yJPtLQlT+MjK3lt2NHe7OSIwHO3VAQ?= =?utf-8?q?ApGvpn4M6ck/tTUEB7WFmrZN7qtM0trKkYtbp/TuTbC2cDV7QJVxlXu4vPl+G07B6?= =?utf-8?q?8Gh0PqTXqpsOaCTHSGlUhKYc4k0c6GgkteliGZdz73g7YQNLOzBTv2SgEVTGZXK8j?= =?utf-8?q?cLBBI6AQxLQ5AQKaCFdsjbcs1T+5G0rL1kyc5UNFz672bEs99PEZLkHhJnGAr2GfO?= =?utf-8?q?DMeN3Dg8+oP3zPOsJFxGTVbp00ZPipcP+hkcaY4DT7DHPfj9dWdP3+kdiJ9c6TsmF?= =?utf-8?q?VqCUb7L32vw9Mc4wGOfMQ+TGw86jqh3OxYqtR9nuuskWhAVqFKU1uulR2vW71uKiQ?= =?utf-8?q?8v5zmeVk+voMWoTtmvT3t/Prmd0MDoE72XBN6Qqndb3yhVwBMvcx1ZIvMIW3PPkut?= =?utf-8?q?7pAiHSt/VUv6gxTu92/IIWe1n25/t08Zc/Li4JToLe5iw/FBP1GLsuAE7jKr4Ilw7?= =?utf-8?q?kS+vGXZ74UDIeBlnkilz3LuzjktdFYmBxaXsSlNo0cmro7zrRwnM/na7JwS40m/Qw?= =?utf-8?q?qge5JIort5iy1/L5k6VdQuUOIF9roZ6V60+9VFmzF1BdcGkC7CiEhr+Xq4evYb/03?= =?utf-8?q?mSgd8G0UGFsYubKZqQo/DM6HNuFrNMxJy3ClF89R5YoIkzyzwRE3D1OhqRty5X7ag?= =?utf-8?q?qMN3q/0lAE+5q0nhQw6vG1oTR0WvkNQF2jwqrKrsB1XoCITVxWAXc7uVO0p6xhs+n?= =?utf-8?q?Z+EHd88HOf9NgKs93jvs5dZ0llVZNDeoYm5jawhX11KHn+MP9ulOLek1HKctWjvHc?= =?utf-8?q?pJS+bKLq9egz0gpyvSZ9822yqJilOY/eNGTr1BnQ6yDATtPZ/ML3plkOETWkbQMuU?= =?utf-8?q?LNV1jSoRSFSb?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 937f8d88-d09c-401a-fc12-08db82b00531 X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jul 2023 08:14:31.7375 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: CMeNwE2kCysWQOZhE3LCqRKZa5xD56D35ySjMaHtITFe+mylfRtY5/lOmURyh7ByD2lRTp7fC1E5BStszwggrg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SEYPR06MB6524 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1771202552957480413 X-GMAIL-MSGID: 1771202552957480413 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Cc: Uwe Kleine-König Signed-off-by: Yangtao Li --- drivers/thermal/ti-soc-thermal/ti-bandgap.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/thermal/ti-soc-thermal/ti-bandgap.c b/drivers/thermal/ti-soc-thermal/ti-bandgap.c index a1c9a1530183..6c23f2095631 100644 --- a/drivers/thermal/ti-soc-thermal/ti-bandgap.c +++ b/drivers/thermal/ti-soc-thermal/ti-bandgap.c @@ -1068,8 +1068,7 @@ int ti_bandgap_probe(struct platform_device *pdev) return ret; } -static -int ti_bandgap_remove(struct platform_device *pdev) +static void ti_bandgap_remove(struct platform_device *pdev) { struct ti_bandgap *bgp = platform_get_drvdata(pdev); int i; @@ -1098,8 +1097,6 @@ int ti_bandgap_remove(struct platform_device *pdev) if (TI_BANDGAP_HAS(bgp, TSHUT)) free_irq(gpiod_to_irq(bgp->tshut_gpiod), NULL); - - return 0; } #ifdef CONFIG_PM_SLEEP @@ -1283,7 +1280,7 @@ MODULE_DEVICE_TABLE(of, of_ti_bandgap_match); static struct platform_driver ti_bandgap_sensor_driver = { .probe = ti_bandgap_probe, - .remove = ti_bandgap_remove, + .remove_new = ti_bandgap_remove, .driver = { .name = "ti-soc-thermal", .pm = DEV_PM_OPS,