From patchwork Wed Jul 12 08:12:52 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?5p2O5oms6Z+s?= X-Patchwork-Id: 118926 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:a6b2:0:b0:3e4:2afc:c1 with SMTP id c18csp994435vqm; Wed, 12 Jul 2023 01:24:39 -0700 (PDT) X-Google-Smtp-Source: APBJJlHO81VEota93rT5h5KWaSgf4JGv11g3jrNTuK+F2gUfY/Qon4+vnGii8HuEyeQ2Ak2j8RZ+ X-Received: by 2002:a17:906:5356:b0:993:f497:adbe with SMTP id j22-20020a170906535600b00993f497adbemr14752175ejo.19.1689150279202; Wed, 12 Jul 2023 01:24:39 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1689150279; cv=pass; d=google.com; s=arc-20160816; b=0mMauNyhflbEnfSVwcsG5zJKPq2baYGuBSXsu2kysUSFNItjhmCm1MaWwB828YWacs Hs6gamg5Jc+UED+07Ishg1FkuVmdFw8kib9ntAnCVoTxO9RaJ3kvtpE9PTqTc8MGV+k1 dkM1ZdazPUJKQNPD3v7/4InStxLiWBwm0edYFe0nWUALpmYTPcIdcDLSaexGdD8//QWI dSe9rX6G45olDbP35VR5CQKre5IOFxs957yXqiPkvc0qKHSLKnzOt3NiG0e9THA46lid JPozBoIw1nx3LVvrtLvPxTrsilt5jbVEiNSjrbYOXckH4Vk1euJtaITfF/QXWbdzEB5w DMeA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:content-transfer-encoding :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=BmlYxUlZMLn3gJYLM84Y8qIS0SHt06c0F82wrEX1jIo=; fh=Cmjlp7r1sVwzkDkoKftLyginZOx26MWtlgTL6TCUiUI=; b=MZV4hvL/eRjOVoU1hMZtI0IHNgUutub2QoHe7gYeLlqLzxvj9WiPUcV3CGrvQA8cxw 0CQ7XsdpH4VoKt+izlFFOx7s0Jz+uCHFzMCy15WToQTMWo3U2d/Nv0u9Uy6XjEfOioFJ AgtbX7hAqAN54+2HbRUD7dw7nqcw7AVI/jSCHcxZfZmszaNtdrGT1Se0FWt6V9a3/qgV 280XEmtuE9s0hqDXUqcqzXwDYz1KIB/n40L7Ji7/ZKZQbc2eeRcZSSwP7oegIDE3wU3z WblKMZao46SuM9Mw6GYpVNd57THIgFrDKC/vaYJDEkrqQkpbYQTG1pxbcpLBFbJsICdj maCA== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@vivo.com header.s=selector2 header.b=d4dzxt+A; arc=pass (i=1 spf=pass spfdomain=vivo.com dkim=pass dkdomain=vivo.com dmarc=pass fromdomain=vivo.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=vivo.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id w24-20020a1709064a1800b00993320628absi4002900eju.675.2023.07.12.01.24.15; Wed, 12 Jul 2023 01:24:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@vivo.com header.s=selector2 header.b=d4dzxt+A; arc=pass (i=1 spf=pass spfdomain=vivo.com dkim=pass dkdomain=vivo.com dmarc=pass fromdomain=vivo.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=vivo.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232329AbjGLISt (ORCPT + 99 others); Wed, 12 Jul 2023 04:18:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46770 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232422AbjGLIRz (ORCPT ); Wed, 12 Jul 2023 04:17:55 -0400 Received: from APC01-SG2-obe.outbound.protection.outlook.com (mail-sgaapc01on2090.outbound.protection.outlook.com [40.107.215.90]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 46842212D; Wed, 12 Jul 2023 01:15:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iyhx9hgZCVgEeOfNtFDRqoECWF0VGaPFwx0+suf6g9n/j6Fkgf4nGOOpvOWf1B9pkXCEawsDEVh6yrdw3Bgmfw1Ljqk11Rl0yoUDb6slaKnN6d43sM0czTK24U8AP36Xa2JnxoWNi9tM3bCBCeELXiF05xh/78vwu1jUsI++FVWn4ghf7LS5Gm513Omfl9R9jg1eosU5D8kYBtnsM1wsBrO709mLnUSckivOfID92rqFvPHso041JgVDBSIyCGfrqZifhJ3mR/anedIruZLl/s9AGokiQqW2JEMNm5xxxqyZVv2q1TnoyHTVjbRoA9UoW4yGxkopVRVopR2vue5C+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BmlYxUlZMLn3gJYLM84Y8qIS0SHt06c0F82wrEX1jIo=; b=Ww9kBS/6dp7n0yRxFkYj+KcE4Q7z7G6mEgXweg6neT+1hkF/xbgnbHx4uBeCIeSwkwpnoTbMuhvCZwsVl588cQr+8zWnilz9+8v7/aU836wmfw0alKZN5UKKv2FU5YF3SvsmL8FHoPWTwxcyTEafaKJ7M8o3+RyNY1JZOIqtSCG/eJ6BB4ilfzm74mifMOVrfXZnvbwVzQ1/fQCBtasRyRSr/BkV48l+pacbgiaEPIMNWIMAzyvez83hiL8kTqjmR+Ceyozj349N2pON4fgcMgNvmRaavyPXHqgHEHxbRsj4UbMYldPZqpYV9/FJscnU9zEhEcnGaaiJZdyYu9bCnw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BmlYxUlZMLn3gJYLM84Y8qIS0SHt06c0F82wrEX1jIo=; b=d4dzxt+ASED5iSMqaBLFBG72lD8vHeemBAzz91JEMBbWIt9W68UGiJ9O6K2Np+HOsgQAuplWfSZkjL6AsHf5+vn1u/E1pFpLZ4ILDRA3EJ5g089IBS6x3u3YaAIzof0bxGyJG99BaqYuWD0CHq0j0P1VjqPzWr4GCM7IgPIccLCg/BoB7LJxjm/yP7GY41yRDhHYCMyqnZf4GwOHYbep8YpqpwE21LxD97lNyY7nFj+Uu+dUzW2ojxMXQM1PU4JgdEcYS7ioH7MjaMMevYj7w1SOFaWRGuIu854G4pPbwxp56E28gPlZWpYNdV7cJYxmsTehEaFkj7QGNa4tf6qbbQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) by SEYPR06MB6524.apcprd06.prod.outlook.com (2603:1096:101:171::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6565.32; Wed, 12 Jul 2023 08:14:29 +0000 Received: from SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::fa0e:6c06:7474:285c]) by SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::fa0e:6c06:7474:285c%5]) with mapi id 15.20.6565.028; Wed, 12 Jul 2023 08:14:29 +0000 From: Yangtao Li To: =?utf-8?q?Niklas_S=C3=B6derlund?= , "Rafael J. Wysocki" , Daniel Lezcano , Amit Kucheria , Zhang Rui Cc: Yangtao Li , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , linux-renesas-soc@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 21/27] thermal/drivers/rcar_thermal: Convert to platform remove callback returning void Date: Wed, 12 Jul 2023 16:12:52 +0800 Message-Id: <20230712081258.29254-21-frank.li@vivo.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230712081258.29254-1-frank.li@vivo.com> References: <20230712081258.29254-1-frank.li@vivo.com> X-ClientProxiedBy: SG2PR04CA0208.apcprd04.prod.outlook.com (2603:1096:4:187::10) To SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5269:EE_|SEYPR06MB6524:EE_ X-MS-Office365-Filtering-Correlation-Id: 9d0b128f-b9df-4228-7e7b-08db82b003df X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: NHDupBP443ajH+MN7hcS0xHZ8IKO0yRmOQLE+/gbBYlJ7VIewc4gZ4Fo4XSz+jnSFLc0wGb0w1eIYkLMuFWoQ4Igj3YJonBYnmya5wZ666QWA4ZxkSk5qCvMTrL2Hwg6pAuzEIoBk9njn2HpCS6jqjkVt06b5O3AT2zzJfsYwXJk+sFRBgyIzoOZ+8ZifsBInb2MinSkgAla8h0j+R82u1nQzm6iHAmKE7vOomC8ZpqI6sQXAZdcxrrcBBnhblDeRv8zhkUwuCxXtP0kuiVrjuQkjYIO/2CuqXXSa1g5G7AfZCf/ZbjuNdn1njrmPuINHs+8UQP/WaK6IRp1Pw0keMyRsubd1BnYD/F539lCOcsV8/ezzlhLmL8NkoFnF6Cx1SxehoX2oCHSw8QbpS/eyk0ZGym9F9g3pOyVQ5q1L61r5NG+NZk0d8xvJ7zV/kQeMXLe5x9r1fuGKrFCVL9gzLSghGa/MKsMHyzL7Abvk0eJqlN/Wzk0qCBiWcYRyEVdKdJnDB6Vdw0+hsUPIuFj8G8jTeWPDQsf9bPC9haX9aGv5EM5NTtQC4MSk56XfPvXRW3qmtHCBA9JgBiZQXzcPo5lZ7i9A7Y1YL3IKcALnHwdujP2rbocyZVP9YQ3u/MM X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SEZPR06MB5269.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(376002)(346002)(366004)(136003)(39860400002)(396003)(451199021)(8676002)(8936002)(5660300002)(186003)(2616005)(83380400001)(6506007)(26005)(86362001)(41300700001)(1076003)(6666004)(6486002)(52116002)(316002)(6512007)(66476007)(36756003)(2906002)(66946007)(66556008)(54906003)(478600001)(110136005)(4326008)(38100700002)(38350700002);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?owm8pqKS1Vgfts3QteiDAaDT5+GD?= =?utf-8?q?inpjgEmgYB9frqkGhLBPa2rfKna8cphQJ9eoEsgVUWf9YaPmBY9K3toryZKhRfiV3?= =?utf-8?q?QRZeJf/6+638TpyTFEQb5miglAJ4ftGaitY7A0dujuKPnqDRN1RbHX3cDMuR9KXYv?= =?utf-8?q?QmGSA9RxknmUw1OEIdVjlUY+hASC+x4wy8Gkf3pbv7uh0+C1u9jqd9hT1gJB79w7v?= =?utf-8?q?Sjwtq42qrqD/vYIWPtSx0CbNmLQqB6Ynv6O7yfToS6KJC6KbQCuY4s3ln9m7AlYu3?= =?utf-8?q?ygo/dOKZv1EpgkL4f7KAL3qWdyMKgDYj1N7Y6hd9yac0rgoNLbsw6F2yIJSHFxq+F?= =?utf-8?q?k4n/W6jjXYOWZ6TRuirHZTyZpx69Ehy2Wj4HyNu6c1SZJqKcdllszhpYJ4Syma/i9?= =?utf-8?q?nliOu/Oyo0oNf96CDP20wGNtlxdXuGARzqwl0z18dP6IIfhmOkjbBaduCd/vwLvab?= =?utf-8?q?il9lTqdb8k5cg4WmzxkaUKY+O8C4QTE1nmmRE/czGpkAu/x+SJcj39vGIVaJAqgFO?= =?utf-8?q?pKLJj1GQg7552weDZQVKN0RzNdjC2J1bavMyxy5ByUnhnDXK5qDAZm3lO4BWwVbHo?= =?utf-8?q?B2CUQnBLpvU1djaGrJxOuKmYoVpN9sA3ZN2O2FTQe5Q2+dFMKg4ZXqFVoDjKt/6h6?= =?utf-8?q?qUJKPuiq3ilTNYjLtUJaQ9qN55tl8mEwje5SOP/NqR/ZVmA2jCfHE5THJ9ejWNL0L?= =?utf-8?q?Ozj+SUkvaiKVJu2q9SVSKAnHQ2M5He6G70XsAsVmOWj7RCvzK7LW+UQAjzhyg0WuZ?= =?utf-8?q?YmJeJiQQ7AAA0ONcwq4A1+a/aAWlFyMcG3p2mPRmRYlSHw0K3YqtfLzkb9XiV3aHZ?= =?utf-8?q?9+35SaIDz+MnNn/OLR6NVfgmh//gQd4sXiH6Qs1f2E7FCmusnM/95bwAGQr7swV/6?= =?utf-8?q?mLd34pdB9f3omk2G+uz9ZzgRuIOBgPUT36WWLhbLwv3LP6AwrPj3RKNmRct+sQ6Oy?= =?utf-8?q?yDU7h6Z7FxqZJS73tMb47qr1XeULs8nTLimcXY85LyrCIoVkyJ2taEn1iwClaHZ0D?= =?utf-8?q?PQWNAlZrUsnFCKqh//UPMjuuYnBwi2qs1iMfn3MBH7IlBxAj2oW/nrfloVBBFtN0A?= =?utf-8?q?YTpwLbZ95jeYihV7Lge0dX/DrTt7+biAlG7jnH25bYvtvoB/mZUNk54wWFVq370Lo?= =?utf-8?q?F+/VJx+oT1M/ObL72YJHWQGA112Z12JtdzmmcbNYnlHYY2Y9bxgyc0BgxU4vHRrEa?= =?utf-8?q?TDqwZC+dlmSQ0QrUBY2yu1sxw1dy0J6qhypfPbB1kbQeWVVOYCmZRXPBfUvhG5K63?= =?utf-8?q?zo64DySiLk5N9o8AyViJSCWn8vkhBcWIOhl2aXslsz8w0uCDZ++eGagxNdNgeHwj9?= =?utf-8?q?wwB1CPkNgzjGKrDJMjR4N2QkwAjSQvJUz+as0jVX/yyJ7oO6zKgRwEqyBdeC7SXIP?= =?utf-8?q?wEKTFE+lwpyrVbYw/vmCmMKnubczOoSnPV0fMsVQ5GbxbT/7NvsKiBW2qEIFeCbww?= =?utf-8?q?HZoDLQzk8KPfLNh15w0ptfBFIUgKwCrmEdgTAsnYyGCRtises6j74tHyo9noa1bTR?= =?utf-8?q?FYfA6/aZGj0r?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9d0b128f-b9df-4228-7e7b-08db82b003df X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jul 2023 08:14:29.5389 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Lq26VdSOYwJAvEAVYEkKk6nAvmL0S4NXogRzAZsVnBYcDB826147ACMpPaYelsLNIljjySmNRAhyFJVQ5ex6Rg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SEYPR06MB6524 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1771202443622739553 X-GMAIL-MSGID: 1771202443622739553 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Cc: Uwe Kleine-König Signed-off-by: Yangtao Li Reviewed-by: Geert Uytterhoeven Reviewed-by: Uwe Kleine-König Reviewed-by: Niklas Söderlund --- drivers/thermal/rcar_thermal.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/thermal/rcar_thermal.c b/drivers/thermal/rcar_thermal.c index b8571f7090aa..b4c58c5f6f6d 100644 --- a/drivers/thermal/rcar_thermal.c +++ b/drivers/thermal/rcar_thermal.c @@ -371,7 +371,7 @@ static irqreturn_t rcar_thermal_irq(int irq, void *data) /* * platform functions */ -static int rcar_thermal_remove(struct platform_device *pdev) +static void rcar_thermal_remove(struct platform_device *pdev) { struct rcar_thermal_common *common = platform_get_drvdata(pdev); struct device *dev = &pdev->dev; @@ -388,8 +388,6 @@ static int rcar_thermal_remove(struct platform_device *pdev) pm_runtime_put(dev); pm_runtime_disable(dev); - - return 0; } static int rcar_thermal_probe(struct platform_device *pdev) @@ -581,7 +579,7 @@ static struct platform_driver rcar_thermal_driver = { .of_match_table = rcar_thermal_dt_ids, }, .probe = rcar_thermal_probe, - .remove = rcar_thermal_remove, + .remove_new = rcar_thermal_remove, }; module_platform_driver(rcar_thermal_driver);