From patchwork Wed Jul 12 08:12:51 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?5p2O5oms6Z+s?= X-Patchwork-Id: 118939 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:a6b2:0:b0:3e4:2afc:c1 with SMTP id c18csp996744vqm; Wed, 12 Jul 2023 01:30:19 -0700 (PDT) X-Google-Smtp-Source: APBJJlHytiOQsj30+7fpky7/e+8lZg6CWgC4wZAUGOgLFHM7/izSmbq6Tr0CPvwDnPKwyZVSG8a8 X-Received: by 2002:a17:907:cca0:b0:98e:a451:fac3 with SMTP id up32-20020a170907cca000b0098ea451fac3mr17254128ejc.42.1689150619439; Wed, 12 Jul 2023 01:30:19 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1689150619; cv=pass; d=google.com; s=arc-20160816; b=hhiUK0tuQz2sWDNwfmhJlX6UKZdDtY3Ei7QfXm5pazHhoQ9Aej4zrCH/HKIEMbtAFZ 6MP9lBKMD77pSJUKMcf0KVK1JKniZK1qtMpNKBPf8MYBtn/ADMdMgke1lVT+PKwaN0Xv hynbmDk9ruQvFGf/azpbuulODQl2Sm6nuKFsS3R4IV26CCitdLll0wkU9s0Le02NdPkL fKFMXkfsiDLnl0CbrmWDtfPpMRNXRis0oDblWeN6QvFpIsvT28Tu0EX0pg3wuJ6fsT7b dMHslm15IBPnDyaGM/hZljx3z6xsetN+ZAQnP6q+9DJGKKHSazQ+8bEKsj01kgPBK8Xw DbHw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:content-transfer-encoding :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=k7FwGtw4e9f+mAIMZLaLeQAhQ+nQdAGktLRvdZX51Kc=; fh=Y1lSEII/uTD63dAvhSXdvuyJQ0CmkMAalQ5E6tB0tdQ=; b=SZmSiqbWcNSVqQBSKkvWrRYdr8XnrzpC1Z5iAa8tRQYtkamool0hesXgfJ/pF1ecC+ LXBlPSwdCenpdiWSlkkd1ue7OVMYw8LOvAtuEeiDfx8gdtQoBABEXe1UBV3X5K9Y+ejE GiZku0hC1oN2RXM9LeSBTXwIKH6OGX1NhqqyKjSI3TpCyUBAQDayLatFOnNBr17GE2i8 VJ7RTT9nP+SY40blThtdzOpwvEJpRSWzkqgHkF+n/xGxfFttBpbRUl2FIFFtfMSTpUQp vRvdW3Uft+SubIruPBCz+rmxQNHtAm564vbmybxxSfs9xFFUf0M67vbzgEDVixDSYsE3 LXKQ== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@vivo.com header.s=selector2 header.b=lgdT5b5y; arc=pass (i=1 spf=pass spfdomain=vivo.com dkim=pass dkdomain=vivo.com dmarc=pass fromdomain=vivo.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=vivo.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id re7-20020a170906d8c700b00992f8116abdsi4023015ejb.480.2023.07.12.01.29.55; Wed, 12 Jul 2023 01:30:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@vivo.com header.s=selector2 header.b=lgdT5b5y; arc=pass (i=1 spf=pass spfdomain=vivo.com dkim=pass dkdomain=vivo.com dmarc=pass fromdomain=vivo.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=vivo.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231183AbjGLISQ (ORCPT + 99 others); Wed, 12 Jul 2023 04:18:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47068 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231213AbjGLIRd (ORCPT ); Wed, 12 Jul 2023 04:17:33 -0400 Received: from APC01-SG2-obe.outbound.protection.outlook.com (mail-sgaapc01on2137.outbound.protection.outlook.com [40.107.215.137]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 34FF12D5B; Wed, 12 Jul 2023 01:15:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RtovODxjYznE7RzaQvNq3KyfOYcddjpvaqupXdMvCXWG29mXnS19CHiknzymrXzqzqWv5a9C6IgrSvNsAwMqWU+e0fgax27o3msD1mstH+Ew5gzwiICnfeayyJ3lCQ5QncpevcTa+svmUoHQGpBIGY2+hgBCv5+AQlH5AKiyatJ/vhOHmCAFUiDEyHhZ2brpc7Em6ralkNS+4Ol1NRhPfsGT213hOvFwNHHuw/3EHOQsu/0t1wTxQ3V/UuSmxXqEn0Qy217vp4xugYiVn68PF7Y6elvpu+FC0alBiHXjZKSX/8SrNogyNiEL7/tNyg+4w2icgA62V4eVg/t3RztXlQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=k7FwGtw4e9f+mAIMZLaLeQAhQ+nQdAGktLRvdZX51Kc=; b=k3PSOHVl0elr8NsBQiOb6IbGnnNcoyr1fqYYqdw9tLNIQITb8seYrv4XQNqVrUjUb0gkgO2qBkH0sirNUaWITCeaXxlaHg/ueyYqr3ezp6eG1LrQuj53XmoDBzLZUmQVYbXSlrIq7orqlckd6BJPrS7LZXTzOOlFflQwUTqkKSPkhmREUtaroShWdMJYaVwDo3qRNrf6OWrFyj8c3vwR8HQNCNy0t5UXvW0K1nnJFBpSdyjWKfUeqW9tY4RHs3tHH0hgID3pYioCTghn1SecYzxsGvc8e1JrmbQL4Cl870Z/T/hvJ6WQ0BIo1enT1T6IcVaRoQB+qP4qVkMkKJU36w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=k7FwGtw4e9f+mAIMZLaLeQAhQ+nQdAGktLRvdZX51Kc=; b=lgdT5b5yuyOI6q448rckzQuXbRVzu/iutg+DVgEbNusdDo7CkMWtuykMRzBr8JcbLCvKi6XbmGIxT/mln/TGK2YV88CJshTOF30umdRRm80DfbG2HHJdtQQqOkIa88uIBhErUWurW2d6Ij5SHPxXow3/UTWfI/KPXsm3tVTdN7W1xYIhDnC+ZxDhmZ7A2CUbFjUxI7WYl1q3TrJkNqpb+axlTvjPA5VvXTAZg++qz6bMQxVce26oAkaYK29J7J2EaU4aCOgPIIzKdq9/Q6+1MwhrfXjGF+ZdrOC7blKd38ZL+WAC4EdKUql1DYMRM7Pymt8yfnVYTuekBEwU0uAlNw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) by SEYPR06MB6524.apcprd06.prod.outlook.com (2603:1096:101:171::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6565.32; Wed, 12 Jul 2023 08:14:27 +0000 Received: from SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::fa0e:6c06:7474:285c]) by SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::fa0e:6c06:7474:285c%5]) with mapi id 15.20.6565.028; Wed, 12 Jul 2023 08:14:27 +0000 From: Yangtao Li To: "Rafael J. Wysocki" , Daniel Lezcano , Amit Kucheria , Zhang Rui , Orson Zhai , Baolin Wang , Chunyan Zhang Cc: Yangtao Li , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 20/27] thermal/drivers/sprd: Convert to platform remove callback returning void Date: Wed, 12 Jul 2023 16:12:51 +0800 Message-Id: <20230712081258.29254-20-frank.li@vivo.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230712081258.29254-1-frank.li@vivo.com> References: <20230712081258.29254-1-frank.li@vivo.com> X-ClientProxiedBy: SG2PR04CA0208.apcprd04.prod.outlook.com (2603:1096:4:187::10) To SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5269:EE_|SEYPR06MB6524:EE_ X-MS-Office365-Filtering-Correlation-Id: 2b73e176-a3c9-41eb-010a-08db82b0028d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: KAS7ZB4mmu7igjU77C8Y/OweqIpRdBvKupMxEH7gfWCbAZMMVPjx3HemdqdexYEG0fKDvYNiWxkJuM++lTZrNbma5tPfYCkJ6gCdHuojCfrMje9sZu/N8O8oeXhb+jKeLYdQUM423+VzOYDY87d3QF1sbi6DAIpB1jfrofhUOwrEXMSdswXwnSNOIpPTXZ39Yyr0mjFlxh75n+mIYD1QylS+P2uYuqYisfj/QNEOQ4W1iZuk+YQM/8agGtnT92I9kB2Kyw5VKuJFKia9NpcyyB6VQ18pUPlR2JvyxeTVsf8QGDD++98+7vAup559NThCqTeuQfH6wCad1vuxQAu+q4s8d20xPRBelm6hM2GMVQG+16xyoSyqkpRlKn4MvW26iwlPUgLH+ASMtQMvQ9cKuwt99rReneqDjqXGQl0tXRRhzpxW5gQdRVId3Kwfa+FfAOHMeM3pIJ/scOAqS3bPeE/NNo+2L2XzDdBNk68aZiB36MsXxEVsmThtmGLZLNu5+qn7xVGgoO/S9IblK3x5dV9b1oNwj9dHrNtiUUmWKqHi7SBqCesvlscZcveySO4PkNFUEM8mvSHEFMRKTj2CvjBJ8EQawDWxFfRbg7LaHc7bJfddes/jQ00u4O9x3mTy X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SEZPR06MB5269.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(376002)(346002)(366004)(136003)(39860400002)(396003)(451199021)(8676002)(8936002)(5660300002)(186003)(2616005)(83380400001)(7416002)(6506007)(26005)(86362001)(41300700001)(1076003)(6666004)(6486002)(52116002)(316002)(6512007)(66476007)(36756003)(2906002)(66946007)(66556008)(54906003)(478600001)(110136005)(4326008)(38100700002)(38350700002);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?lulaAJVp40LNCqOIOXoCNTPFb5be?= =?utf-8?q?JqMGKT0wrTzbuEhNxmDL17Gr1rrWukd0uBBQN6ZJ0QReG+3gDbLA+AfTllByjGNEg?= =?utf-8?q?bM2iODbmwhV4lMp27do87uIfm6RLPDvVR3cv2bexm0kinyxUB0q47GTthWd/Ph3Ka?= =?utf-8?q?XN2HEYfcqKDcts+a/tEqa/koHqkR1xVZf+erPfOZBy4i/jTjuFnn59kwtQPGnQ0Ar?= =?utf-8?q?TAVBOP7phwfZczv61RrdErLPU3Y6MYMtLFI2V3sbmjSVxXElFzz6UX8s9qUWIlyE7?= =?utf-8?q?qZ92cng9+6tmaHSEzLtZPsbFwtVKIrXdXabgjJVbuRHNDDhbckKuW9DmPkekg2ASj?= =?utf-8?q?n/Ps5wPODFYPYp3oZK59a9ZyqkyNpvG/7Cp0Z7330Z5JfyXz20XJnk4UbumNdPxpr?= =?utf-8?q?2XckSiePK0h2T/3CF/0ohXtCUy++L/XTL3280+W75WSRJEldWSYjzxet0wzqIRlSs?= =?utf-8?q?+xZckrADgYIogLj/nqo0a+tLbCc89A8B6BvVhbjO2M8pmJYP1SU6wvM7MF5F5Icay?= =?utf-8?q?myUXvkDhjWcz0Thql9quNbFB3wca5mKwSWT35U5Ux3VB21pwP78GfIH1aKKT8PUMt?= =?utf-8?q?ltaIC6Rxe8agzhqUSeK4M+oraC5GeaPVWVVjzlmr241FRihONuPEdVak4zxMo9J6i?= =?utf-8?q?SZADEoZnxdkys3dV5EaHF3lVYgGrvgusq54ufAfWJf9BQKTE2x32g+YMo1LnwAKYr?= =?utf-8?q?BuOmLpPZ7SAq9qmHPMi9BVo4HD7lNZzTcis4rWGwi+8uC/fsB+BGrAqVv7R1PbEFk?= =?utf-8?q?8lQDOhFXXgcB4gXXALzAcWwPwteHjYatxqToNEWTOnSzKsW67VzRXW/Uc2KzNsXAN?= =?utf-8?q?WLMIWtnXsYcJ4UmU8sC2OIv8AxIEolfG5dBo+UPSHJROKdzMsvumc/y7252SwwbNh?= =?utf-8?q?421eU3YGPFvBV5ZSCBKrZ3zN80sO7RS3DFQRbCmtukCJv++dF0FZOnc/Haa20/f1F?= =?utf-8?q?woZGT+Fesdc3RZ+mb71yz8fMuqFjx+OjESrHN58JrkK0+8rkLYIBzn8toiZdIqIql?= =?utf-8?q?VDH/PhPuARs5h4ko8DGocRv1fKcyffS4PJdlsoDGI7dRDMD7INYSPjOJpN2/wxPBN?= =?utf-8?q?3sQi2h9CXcP38FnUpCzrVfUWP4lwkD2Qx81vjh89hB9mz6NbbOPv1X6SyYz7GS/TK?= =?utf-8?q?lwzbqe5zoUDItfzMku1hfO2Yy0dUgWpuomU0SlDaFppddCw5K2IdxTLld53aP7KUF?= =?utf-8?q?jPNaWZDfAsaJuMGRShgirdChGelxRiW2EAMFrDtAb7AW3QOVzpu30OyUsxJ8w67PY?= =?utf-8?q?+KgXmEx6qMFysScBUu1PjwrEj2fHAf/KOCkGYc4JTb2nadSAPE+HV76I0LfGvOKN+?= =?utf-8?q?trqfJkong2yG8bCJQ6jfmx+cTrYgPuo2IHRBOwYz4OEQXxWJoMF48FNMXGjAxn4Ts?= =?utf-8?q?gtrfEWeS50Q5TdAP6GUQP7/PgwGtYcfe0hd+7vjfV4EueS+uox8BiV9jCzXidsIbF?= =?utf-8?q?iIjPqXA7MxBC3Npyn586N++mgJ1JTYGYorhXurYv2b30Xg9QRjrO0HXaR0JlTdEIq?= =?utf-8?q?kPwwE+waN4HO?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2b73e176-a3c9-41eb-010a-08db82b0028d X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jul 2023 08:14:27.3056 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: yqHXXueky8Zuyn3BWR7H9mDtgAvtZk4/LD+FLkbgt04ZnkdyYyNikPC5tcD2IvaOXJsyRwtwy6YTabl1icwmCA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SEYPR06MB6524 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1771202799911720427 X-GMAIL-MSGID: 1771202799911720427 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Cc: Uwe Kleine-König Signed-off-by: Yangtao Li --- drivers/thermal/sprd_thermal.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/thermal/sprd_thermal.c b/drivers/thermal/sprd_thermal.c index 2fb90fdad76e..0546096f7e2d 100644 --- a/drivers/thermal/sprd_thermal.c +++ b/drivers/thermal/sprd_thermal.c @@ -516,7 +516,7 @@ static int sprd_thm_resume(struct device *dev) } #endif -static int sprd_thm_remove(struct platform_device *pdev) +static void sprd_thm_remove(struct platform_device *pdev) { struct sprd_thermal_data *thm = platform_get_drvdata(pdev); int i; @@ -528,7 +528,6 @@ static int sprd_thm_remove(struct platform_device *pdev) } clk_disable_unprepare(thm->clk); - return 0; } static const struct of_device_id sprd_thermal_of_match[] = { @@ -543,7 +542,7 @@ static const struct dev_pm_ops sprd_thermal_pm_ops = { static struct platform_driver sprd_thermal_driver = { .probe = sprd_thm_probe, - .remove = sprd_thm_remove, + .remove_new = sprd_thm_remove, .driver = { .name = "sprd-thermal", .pm = &sprd_thermal_pm_ops,