From patchwork Wed Jul 12 08:12:46 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?5p2O5oms6Z+s?= X-Patchwork-Id: 118919 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:a6b2:0:b0:3e4:2afc:c1 with SMTP id c18csp993572vqm; Wed, 12 Jul 2023 01:22:49 -0700 (PDT) X-Google-Smtp-Source: APBJJlH1zetdF3AtVqf9n2kk7B+fQFo4rT3rWaGXVzrMUh8HFNU+3ySMgGzJsXujbIGNrJ1kN8GJ X-Received: by 2002:a19:2d4e:0:b0:4f9:556b:93c4 with SMTP id t14-20020a192d4e000000b004f9556b93c4mr13423409lft.31.1689150169451; Wed, 12 Jul 2023 01:22:49 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1689150169; cv=pass; d=google.com; s=arc-20160816; b=1JUgczruyx+WMr9haVLqpqAYUqd02S3jgId71iZut6l11hcNHiKGcjxq9lGQGqfZR2 q2iy8MekzAX+LBXUSL2J9joh/q5wKoFeI0nXuxy5b32ghbPDOhaaAG9HD1121L2Xk1r1 lmfOawYSC3+3DjnooqOrTYa4EQKar69trjZ72yTSNAUKQKZ2sRvDPNlQhiKe/WFIYar8 D9y6QizXZ6hKaaGQ+6bF3or7w9notuEJsX3ulinsAV2kR9vUQ/0m+F7q62bkOK+eqrSa LnteK7UsgHg0ai/+TAsZ4Yn7fFkZu9gZ31BvL0UXwC0DBZorX7P1/zBirXJV/QFKBzx2 Jldg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:content-transfer-encoding :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=5AmRGHLwszoXzj02IaQufMXzkfE0fzmNaTRUxzGYq9w=; fh=IiWTCAiotD2hu6GhmOQoVrQujLqRY2CNTHWh9Km1TgY=; b=b1D3eoXicLrciK43UrW6V6t0PvZkeqTaN+69Jv/zXkp9XTAxWmwwByQbm5/wXdl+CK L0uZe4WHferPxbUuoLOvVVJX336QYmSmLk8103t+GZhYJtdY5Woqwqa/mjDJapqmat5K ekPVNwlMn6hlwyCAepBg41i87EYHzYcwlTVZ+sSWYDa6MLazKC5OHT81SDjooolStR6J r2YCKizSBj/nLuhnTIEoqUGzF7mqJtO1n6px8U570VrNxNu9bMm4xt8YSsZtzmrHn0B6 kY05rSdiXJi8H/7+N+qzqyOp39iXoYf9vH1HlaEbXYfqiN4MYN3MspfEkkKjepitu6S4 5Tpg== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@vivo.com header.s=selector2 header.b=TrrVdMZC; arc=pass (i=1 spf=pass spfdomain=vivo.com dkim=pass dkdomain=vivo.com dmarc=pass fromdomain=vivo.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=vivo.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i15-20020aa7c70f000000b0051e43fce3ccsi4001196edq.393.2023.07.12.01.22.25; Wed, 12 Jul 2023 01:22:49 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@vivo.com header.s=selector2 header.b=TrrVdMZC; arc=pass (i=1 spf=pass spfdomain=vivo.com dkim=pass dkdomain=vivo.com dmarc=pass fromdomain=vivo.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=vivo.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231571AbjGLIQG (ORCPT + 99 others); Wed, 12 Jul 2023 04:16:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46946 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231811AbjGLIPY (ORCPT ); Wed, 12 Jul 2023 04:15:24 -0400 Received: from APC01-SG2-obe.outbound.protection.outlook.com (mail-sgaapc01on2090.outbound.protection.outlook.com [40.107.215.90]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BA0E62688; Wed, 12 Jul 2023 01:14:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oO54yIO1nm2asbrVHbiPYt7GIJGit7/McdLjvMW9xBUPB3gPr8suBCE+zrtFI6QW5XBsIYuhasUpku+wNkx4HkFiR2MYEQ94rC9VNadHMgMxalTUjd9riUCDzTKHk4KTMwfYRrS2CqEYFS4sXfLoQdSWF0e1HYHcT9mQELxM5VkzJ+7f0gJMmQUX0C1e4sKRJveczQiWpLmDAoGMYqkWBQTvsDZYWYoqUQDeMSOAu3Dm2v3J3ZD8g6RA2F7LkmNmWYjKqVE1b4Es60G5Y83eEPBXxM5DeC33bzHxaVfRLnZ2RZ4HENIJaAEzwdLS0oNIqM76YwfLyUTPHXLosmQd2A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5AmRGHLwszoXzj02IaQufMXzkfE0fzmNaTRUxzGYq9w=; b=bJjuLJrhd0Ynlynvm8iult0KFMufkEKNC1VqgH8R4N9TOx9xZrQVv2qQiTP315Gc14Fv76Whan0KiQvnnJV0tQGAFA2rTtJMdWlevwe5mgsXjDQ2IBmoABMk4bZf1jsXoQjjWyDuFMMYItf8PEUFiV/w3+JS1PdJ591s9QUfBO4qH4K9cCDc9xcbm6RgHYpsdrKIL2X984xXnKXcGVwhWdVumuLzXoVxJu7rZm7nZJV5D32u2yL/dsA1+VXb+pxJeCJkl1Iqk1vmsvJxKAgU1VNr602gJnGZxF+K3aWSHQhJzDxJN4CwU01TCr7bIMzU6ibo+eRpxOzkyK/HQ9/w6A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5AmRGHLwszoXzj02IaQufMXzkfE0fzmNaTRUxzGYq9w=; b=TrrVdMZCr781RbBSrdOc03V6YXleWAftYuv+/arDO+h3WPD8tcEfNBdo89ZBzzbqeu4D7kfDel4HbPD9MhRk1M9Gnk/fWFcGv2Y9OIJCTaiED5MoD3YKDD/qxiE0W3Y5Vyk3TOECQe6doV80bewdtIeMeoXSpCtYpll8vqt4vBK687mA1g4Zkg73Gw74PQPfK4TSpMESmAbKBp5qV3zP0Q4i6RY26bdZi47U+TF3nlweEtF/LLnU4oRouWofAvr3bDm5nB7D1U6mul3vnN+4X2cuq29pyH/Uw2XuvVwHRroAwOdT/yi3vvbNlTLIMmXS0QP6nM2IH/himvpapgZPhw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) by SEYPR06MB6524.apcprd06.prod.outlook.com (2603:1096:101:171::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6565.32; Wed, 12 Jul 2023 08:14:18 +0000 Received: from SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::fa0e:6c06:7474:285c]) by SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::fa0e:6c06:7474:285c%5]) with mapi id 15.20.6565.028; Wed, 12 Jul 2023 08:14:18 +0000 From: Yangtao Li To: "Rafael J. Wysocki" , Daniel Lezcano , Amit Kucheria , Zhang Rui , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team Cc: Yangtao Li , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 15/27] thermal/drivers/imx: Convert to platform remove callback returning void Date: Wed, 12 Jul 2023 16:12:46 +0800 Message-Id: <20230712081258.29254-15-frank.li@vivo.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230712081258.29254-1-frank.li@vivo.com> References: <20230712081258.29254-1-frank.li@vivo.com> X-ClientProxiedBy: SG2PR04CA0208.apcprd04.prod.outlook.com (2603:1096:4:187::10) To SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5269:EE_|SEYPR06MB6524:EE_ X-MS-Office365-Filtering-Correlation-Id: 18734dab-774f-4604-5895-08db82affd51 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 2A6nk+I9VOI8TS0aD5s6HqtttCUVl2Xe0WR/3VWOC3BcnDjCrWae25Ht1m0pxv2GDkTagp/srCrh9SDD39D+3RoGMiAcJDK/0zFWAv2pCkJSXVPczxL5nRIY0oKh6Is54kyfrliU0pknEup0Em/KzNQq/nQU4Iu9mD10OW2y1+4swuXsEKDlY0h3bppn9uDpgWR0M2lm/KDAww8kpoiUyOaNlFgd/G1ZIXr80tUKd4ttfbs+Bq9BTt2Mm7cNBA2AZuUvxQJRe92mOSqpFanFlY4Tn79T6PTVi5zXhknPK6i1TrDYRo3aFX03D/8ENQ4uS6QT9BVAaJpH+EMLPG+3EgMf9wL2WrlsaTdhfcJjMP/BZXruzpm2Ukxk+2+EC6ooidHHD2evX7BG59mS3tQsjonslDkgSkiM/FdGgaAXbpGvvS/wTjIQqE68vMZTVxccvrm8m+N72zMtfpDOFmbbFicKDebuF1mQXaiooUIORxC1VU+rszoketTiYITBxKdnXXWAWi4UAolaSZM5E1CPr1yZLDuK2VYSsR3NmhNbb21TblHiocTVrr5lgDDjmPT7oY9TiM3s9D11HSDxR5f1Dr9bPbjPlbHJb9vozYyQGWwi1s5kk+EHwAyJsFcVR1AZ X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SEZPR06MB5269.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(376002)(346002)(366004)(136003)(39860400002)(396003)(451199021)(8676002)(8936002)(5660300002)(186003)(2616005)(66574015)(83380400001)(7416002)(6506007)(26005)(86362001)(41300700001)(1076003)(6666004)(6486002)(52116002)(316002)(6512007)(66476007)(36756003)(2906002)(66946007)(66556008)(54906003)(478600001)(110136005)(4326008)(38100700002)(38350700002);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?MQAq0KvVyHJhZ3xzIRK5h3bxuUFy?= =?utf-8?q?EaAZw9jpUEUHINegUwn7zCzH2mcDzW8EMSpBZ/eTGTf7Ca/tQv1rECIMG98DsJ9tq?= =?utf-8?q?LHxNABUAR11Ralv4Xui5K7g6jIgYDRoCvtRLe9OTTm5Zlc+EvxNKQeskzdxhwnpTw?= =?utf-8?q?0h0ETYFazw/f8aqAlxcL7UVqNpMyqAwHewShS0HqQvKSJ52PUDea99+tkrHjc6s/W?= =?utf-8?q?UguZgKWpYnxmxgu4GTNnP2Geq21pxoyhCSOv0vLcQYWILN6jtWZZfRUy+I4GrBy9g?= =?utf-8?q?hk627zDrv0rbXmJ24tWCnAbrjXTHpuO1EpEc+9/PNoGGPkxp2eXawqcdGlIose75p?= =?utf-8?q?ttiD7q/BZfrluHyFF7km+jK16WRcAUJT9ROe80qp9LYs+y1rvoKOs3IR/B8ahYKsg?= =?utf-8?q?cHkbpbE++Ey0liyJcrLgO4XDra0c4brhM5e8m3hjAiiBVYtLow9khvkyftK/PS4jX?= =?utf-8?q?2V2t75W9KoyXvZKNe3T6Nou9QRBUA5LrEXfOsN2v/1fWidhxkZdbkCE37Q4tQaai/?= =?utf-8?q?trLGIBrrsXniF8jCZjOT4F45sTsyEM7HapSk1RdeuMZ8KGzJShQr77+TAofCkahhh?= =?utf-8?q?7HH8rfXLz5YEhodhow+3lE6XGfTErzOpli3L7xLypePxOfKB3iVyCHxxTq8gYUk0i?= =?utf-8?q?sYxKU7t7G+2BJ6r92XxQoudJW40lKhFzvrbLFjxNWzCzK0Gfzj0EGQ6es/YDJxRXx?= =?utf-8?q?ttXGc7I7iEUFlo+4qtndgOiKs3l0D5xxvPMZINWiwVKfgqP61a0jOFBI/UbeHUnVW?= =?utf-8?q?4ms9BtUEB3kwucPYnmaWtVQ9WceZtES/KEWgiR+YVN7tnZZ4uUu4lrQCjIdJ6GLPJ?= =?utf-8?q?0/TUsF+8wFzTIrAKvmFPQFCIHG8nBYselnqdJoGkLwgDRgGQS8ZQ19Hu5Ju2UX7vx?= =?utf-8?q?yR2KVkq41SQKklpjdlGjANRcWAnDBDw+W1A+ItitxM6t7H5VU2GC810hRg2bDdnwC?= =?utf-8?q?VeaeYqC0ry77pK9dA3j3jeb8B63aW9tFa2mTUCCCfeStcacLIfG5Y6Xja1Eg0B3ZB?= =?utf-8?q?Pu2vCPkEV4wUzVmkWUlStUlAXxnCifwDKlgXiEfCf6gVhtObYh+bwHblD9ZS2sFF7?= =?utf-8?q?raoF+WHCKCRjEr4gd1QhJlAhoAputoyTxnR1K5SWdwHkDn5Vf7SYLf4iziGgUaovM?= =?utf-8?q?fmDLd0k6JujDjS9mXODfzmTHGm02EA2ddzbgqigjwufzI6kuFNHruA03b4XuICV0Q?= =?utf-8?q?d2xju+QvSEKaon1/rilenVp8eOYojxXZqmzyaLg2SAde8QYTOTXARlu1DtUin8IYx?= =?utf-8?q?SaWXl8k4rMT9K1Y9gSOuhlA28/fWHZ1l3kS5Y3yoBgNGerQ/iSV3LMfkh9OK/+w22?= =?utf-8?q?5b7+TqFEaKhpS3ABBt519NPGYG+ouMrIpQ1JNDjDp/NM8pDrykMltpAhOpdtJGFRu?= =?utf-8?q?8rpG5YRDCirlCfl9JxdIIh0NwcjK7TEEGDEvomiY9QpYfEllkYrjevNj//naAYej/?= =?utf-8?q?dgiF42iu81jGTeHI53MPUjKOes78+fJoigW+9txlVDi/JX19oN0VHk4JV5qFr5abj?= =?utf-8?q?feSzErq4HRrR?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 18734dab-774f-4604-5895-08db82affd51 X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jul 2023 08:14:18.5257 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: U9V6DQjNNXiAVYQQkvSbmL7NFodWXdxZRaYiyeS0SzpgCsL6xQb0KFZxLYtqZC8lLlcFxCQY4T93hvfwtHnqwA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SEYPR06MB6524 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1771202327961832889 X-GMAIL-MSGID: 1771202327961832889 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Cc: Uwe Kleine-König Signed-off-by: Yangtao Li --- drivers/thermal/imx_thermal.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/thermal/imx_thermal.c b/drivers/thermal/imx_thermal.c index a94ec0a0c9dd..0f033c2ca0ad 100644 --- a/drivers/thermal/imx_thermal.c +++ b/drivers/thermal/imx_thermal.c @@ -771,7 +771,7 @@ static int imx_thermal_probe(struct platform_device *pdev) return ret; } -static int imx_thermal_remove(struct platform_device *pdev) +static void imx_thermal_remove(struct platform_device *pdev) { struct imx_thermal_data *data = platform_get_drvdata(pdev); @@ -780,8 +780,6 @@ static int imx_thermal_remove(struct platform_device *pdev) thermal_zone_device_unregister(data->tz); imx_thermal_unregister_legacy_cooling(data); - - return 0; } static int __maybe_unused imx_thermal_suspend(struct device *dev) @@ -880,7 +878,7 @@ static struct platform_driver imx_thermal = { .of_match_table = of_imx_thermal_match, }, .probe = imx_thermal_probe, - .remove = imx_thermal_remove, + .remove_new = imx_thermal_remove, }; module_platform_driver(imx_thermal);