diff mbox series

mfd: wcd934x: Update to use maple tree register cache

Message ID 20230712-mfd-wcd934x-maple-v1-1-0d7aba4b0077@kernel.org
State New
Headers
Series mfd: wcd934x: Update to use maple tree register cache |

Commit Message

Mark Brown July 12, 2023, 4:40 p.m. UTC 
  The maple tree register cache is based on a much more modern data structure
than the rbtree cache and makes optimisation choices which are probably
more appropriate for modern systems than those made by the rbtree cache. In
v6.5 it has also acquired the ability to generate multi-register writes in
sync operations, bringing performance up to parity with the rbtree cache
there.

Update the wcd934x to use the more modern data structure.

Signed-off-by: Mark Brown <broonie@kernel.org>
---


Signed-off-by: Mark
---
 drivers/mfd/wcd934x.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


---
base-commit: 06c2afb862f9da8dc5efa4b6076a0e48c3fbaaa5
change-id: 20230623-mfd-wcd934x-maple-852535e3b2c6

Best regards,

Comments

Lee Jones July 13, 2023, 3:43 p.m. UTC | #1 
On Wed, 12 Jul 2023, Mark Brown wrote:

> The maple tree register cache is based on a much more modern data structure
> than the rbtree cache and makes optimisation choices which are probably
> more appropriate for modern systems than those made by the rbtree cache. In
> v6.5 it has also acquired the ability to generate multi-register writes in
> sync operations, bringing performance up to parity with the rbtree cache
> there.
> 
> Update the wcd934x to use the more modern data structure.
> 
> Signed-off-by: Mark Brown <broonie@kernel.org>
> ---
> 
> 
> Signed-off-by: Mark

Something going on with your helpers?

> ---
>  drivers/mfd/wcd934x.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks
Mark Brown July 13, 2023, 3:56 p.m. UTC | #2 
On Thu, Jul 13, 2023 at 04:43:46PM +0100, Lee Jones wrote:
> On Wed, 12 Jul 2023, Mark Brown wrote:

> > ---
> > 
> > 
> > Signed-off-by: Mark

> Something going on with your helpers?

That's a b4 thing.
diff mbox series

Patch

diff --git a/drivers/mfd/wcd934x.c b/drivers/mfd/wcd934x.c
index 6b942d5270c1..7b9873b72c37 100644
--- a/drivers/mfd/wcd934x.c
+++ b/drivers/mfd/wcd934x.c
@@ -112,7 +112,7 @@  static const struct regmap_range_cfg wcd934x_ranges[] = {
 static struct regmap_config wcd934x_regmap_config = {
 	.reg_bits = 16,
 	.val_bits = 8,
-	.cache_type = REGCACHE_RBTREE,
+	.cache_type = REGCACHE_MAPLE,
 	.max_register = 0xffff,
 	.can_multi_write = true,
 	.ranges = wcd934x_ranges,